[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-25 Thread GitBox
sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284617 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelixJob

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-25 Thread GitBox
sv2000 commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339284718 ## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/StateStoreBased

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com…

2019-10-26 Thread GitBox
jhsenjaliya commented on a change in pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com… URL: https://github.com/apache/incubator-gobblin/pull/2782#discussion_r339321774 ## File path: conf/standalone/log4j.xml ## @@ -3,7 +3,7 @@

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com…

2019-10-26 Thread GitBox
jhsenjaliya commented on issue #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com… URL: https://github.com/apache/incubator-gobblin/pull/2782#issuecomment-546653477 LGTM, other than a file name comment.

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-26 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339321805 ## File path: bin/gobblin.sh ## @@ -105,7 +107,7 @@ function print_gobblin_cli_us

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-26 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339321965 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_servic

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-26 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339321995 ## File path: gobblin-docker/gobblin-service/alpine-gaas-latest/entrypoint.sh ##

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-27 Thread GitBox
autumnust commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339371421 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinHelix

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-27 Thread GitBox
autumnust commented on a change in pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#discussion_r339371471 ## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/StateStoreBa

[GitHub] [incubator-gobblin] codecov-io commented on issue #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-27 Thread GitBox
codecov-io commented on issue #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784#issuecomment-546750094 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2784?src=pr&el=h1) Report > Merging [#

[GitHub] [incubator-gobblin] asfgit closed pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version

2019-10-27 Thread GitBox
asfgit closed pull request #2784: [GOBBLIN-928]Craftsmanship cleaning and bumping up ORC version URL: https://github.com/apache/incubator-gobblin/pull/2784 This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-gobblin] autumnust commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration

2019-10-28 Thread GitBox
autumnust commented on issue #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780#issuecomment-547024231 > @autumnust I use a pull command which seems introduce all the changes which have been commit

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com…

2019-10-28 Thread GitBox
Will-Lo commented on a change in pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com… URL: https://github.com/apache/incubator-gobblin/pull/2782#discussion_r339700268 ## File path: conf/standalone/log4j.xml ## @@ -3,7 +3,7 @@ -

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339729627 ## File path: bin/gobblin.sh ## @@ -105,7 +107,7 @@ function print_gobblin_cli_usage(

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339764542 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_service_us

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339765341 ## File path: gobblin-docker/gobblin-service/alpine-gaas-latest/entrypoint.sh ## @@ -

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r339765341 ## File path: gobblin-docker/gobblin-service/alpine-gaas-latest/entrypoint.sh ## @@ -

[GitHub] [incubator-gobblin] codecov-io commented on issue #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com…

2019-10-28 Thread GitBox
codecov-io commented on issue #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com… URL: https://github.com/apache/incubator-gobblin/pull/2782#issuecomment-547126016 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2782?src=pr&el=h1) Report > Mer

[GitHub] [incubator-gobblin] asfgit closed pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com…

2019-10-28 Thread GitBox
asfgit closed pull request #2782: [GOBBLIN-925] Create option to log outputs to console, fix docker-com… URL: https://github.com/apache/incubator-gobblin/pull/2782 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#issuecomment-545699470 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2781?src=pr&el=h1) Report > Merging [#27

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-28 Thread GitBox
codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#issuecomment-545699470 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2781?src=pr&el=h1) Report > Merging [#27

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md: Typos

2019-10-28 Thread GitBox
jhsenjaliya commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md: Typos URL: https://github.com/apache/incubator-gobblin/pull/2783#issuecomment-547231948 LGTM, @bstaudacher do you want to just run the spell check on all docs and fix it ? Also pls create JIRA ticket and me

[GitHub] [incubator-gobblin] bstaudacher commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md: Typos

2019-10-29 Thread GitBox
bstaudacher commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md: Typos URL: https://github.com/apache/incubator-gobblin/pull/2783#issuecomment-547637326 I don't believe I can make a JIRA ticket, I went and poked around but it appears I don't have the option to do so. -

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2759: [GOBBLIN-905] Fixes issue where newly added jobs would crash in gobbl…

2019-10-30 Thread GitBox
jhsenjaliya commented on issue #2759: [GOBBLIN-905] Fixes issue where newly added jobs would crash in gobbl… URL: https://github.com/apache/incubator-gobblin/pull/2759#issuecomment-547999820 Thanks William for fixing this, I just encountered this yesterday (GOBBLIN-935) and fixed it but a

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340768889 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340762257 ## File path: gobblin-docker/gobblin-service/alpine-gaas-latest/entrypoint.sh ## @@ -

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340766549 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340762532 ## File path: bin/gobblin.sh ## @@ -400,7 +401,7 @@ function start() { f

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2755: [GOBBLIN-897] adds local FS spec executor to write jobs to a local dir

2019-10-30 Thread GitBox
codecov-io edited a comment on issue #2755: [GOBBLIN-897] adds local FS spec executor to write jobs to a local dir URL: https://github.com/apache/incubator-gobblin/pull/2755#issuecomment-539170866 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2755?src=pr&el=h1) Report

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340791157 ## File path: bin/gobblin.sh ## @@ -400,7 +401,7 @@ function start() { f

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340791157 ## File path: bin/gobblin.sh ## @@ -400,7 +401,7 @@ function start() { f

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340794003 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340794003 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340796164 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340796164 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/application.yaml ## @@ -

[GitHub] [incubator-gobblin] jhsenjaliya opened a new pull request #2785: [GOBBLIN-934] bug fix and refactor for handling new job scheduling

2019-10-30 Thread GitBox
jhsenjaliya opened a new pull request #2785: [GOBBLIN-934] bug fix and refactor for handling new job scheduling URL: https://github.com/apache/incubator-gobblin/pull/2785 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked

[GitHub] [incubator-gobblin] bstaudacher commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md for typos

2019-10-30 Thread GitBox
bstaudacher commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md for typos URL: https://github.com/apache/incubator-gobblin/pull/2783#issuecomment-548110947 I would say LGTM and then I can take a look at programatically fixing the rest of the typos that may exist in the docs? Or

[GitHub] [incubator-gobblin] codecov-io commented on issue #2785: [GOBBLIN-934] bug fix and refactor for handling new job scheduling

2019-10-30 Thread GitBox
codecov-io commented on issue #2785: [GOBBLIN-934] bug fix and refactor for handling new job scheduling URL: https://github.com/apache/incubator-gobblin/pull/2785#issuecomment-548118180 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2785?src=pr&el=h1) Report > Mergin

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340883278 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_service_us

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
Will-Lo commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340892290 ## File path: gobblin-docker/gobblin-service/alpine-gaas-latest/entrypoint.sh ## @@ -

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340896160 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_servic

[GitHub] [incubator-gobblin] jhsenjaliya opened a new pull request #2786: fix help text and align it with variable names

2019-10-30 Thread GitBox
jhsenjaliya opened a new pull request #2786: fix help text and align it with variable names URL: https://github.com/apache/incubator-gobblin/pull/2786 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps be

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340896160 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_servic

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2786: [GOBBLIN-937] fix help text and align it with variable names

2019-10-30 Thread GitBox
jhsenjaliya commented on issue #2786: [GOBBLIN-937] fix help text and align it with variable names URL: https://github.com/apache/incubator-gobblin/pull/2786#issuecomment-548150191 @Will-Lo , @sv2000 , can u pls review and merge this? Thanks ---

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#issuecomment-545699470 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2781?src=pr&el=h1) Report > Merging [#27

[GitHub] [incubator-gobblin] codecov-io commented on issue #2786: [GOBBLIN-937] fix help text and align it with variable names

2019-10-30 Thread GitBox
codecov-io commented on issue #2786: [GOBBLIN-937] fix help text and align it with variable names URL: https://github.com/apache/incubator-gobblin/pull/2786#issuecomment-548156882 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2786?src=pr&el=h1) Report > Merging [#27

[GitHub] [incubator-gobblin] autumnust opened a new pull request #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers

2019-10-30 Thread GitBox
autumnust opened a new pull request #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers URL: https://github.com/apache/incubator-gobblin/pull/2787 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have chec

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-10-30 Thread GitBox
jhsenjaliya commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r340896160 ## File path: bin/gobblin.sh ## @@ -135,6 +137,7 @@ function print_gobblin_servic

[GitHub] [incubator-gobblin] codecov-io commented on issue #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers

2019-10-30 Thread GitBox
codecov-io commented on issue #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers URL: https://github.com/apache/incubator-gobblin/pull/2787#issuecomment-548224920 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2787?src=pr&el=h1) Report > M

[GitHub] [incubator-gobblin] asfgit closed pull request #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers

2019-10-31 Thread GitBox
asfgit closed pull request #2787: [GOBBLIN-938] Make job-template resolution available in all JobLaunchers URL: https://github.com/apache/incubator-gobblin/pull/2787 This is an automated message from the Apache Git Service.

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate

2019-10-31 Thread GitBox
jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548469068 @Will-Lo , I am trying to see how can we make this consistent, I think with add

[GitHub] [incubator-gobblin] jhsenjaliya opened a new pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
jhsenjaliya opened a new pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I ha

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate

2019-10-31 Thread GitBox
jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548489825 not it looks much better with #2788, pls check it out.

[GitHub] [incubator-gobblin] autumnust commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md for typos

2019-10-31 Thread GitBox
autumnust commented on issue #2783: Update Hive-Avro-To-ORC-Converter.md for typos URL: https://github.com/apache/incubator-gobblin/pull/2783#issuecomment-548491406 @bstaudacher Just out of curiosity: Which tool are you planning to address typos given the scale of this code base? I am mo

[GitHub] [incubator-gobblin] Will-Lo commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate

2019-10-31 Thread GitBox
Will-Lo commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548491660 @jhsenjaliya sure we can go with that, I think the main thing is that the documenta

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341287822 ## File path: bin/gobblin-env.sh ## @@ -17,4 +17,6 @@ # limi

[GitHub] [incubator-gobblin] Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
Will-Lo commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341290769 ## File path: bin/gobblin.sh ## @@ -283,18 +291,18 @@ elif [[

[GitHub] [incubator-gobblin] Will-Lo commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
Will-Lo commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548500401 I was wondering, would it be better if we were to utilise javaopts, so `-D` flags for these env

[GitHub] [incubator-gobblin] autumnust commented on issue #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching

2019-10-31 Thread GitBox
autumnust commented on issue #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching URL: https://github.com/apache/incubator-gobblin/pull/2789#issuecomment-548508801 @htran1 Can you take a look ? thanks -

[GitHub] [incubator-gobblin] autumnust opened a new pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching

2019-10-31 Thread GitBox
autumnust opened a new pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching URL: https://github.com/apache/incubator-gobblin/pull/2789 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed unt

[GitHub] [incubator-gobblin] codecov-io commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
codecov-io commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1) Report

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1) R

[GitHub] [incubator-gobblin] codecov-io commented on issue #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching

2019-10-31 Thread GitBox
codecov-io commented on issue #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching URL: https://github.com/apache/incubator-gobblin/pull/2789#issuecomment-548527186 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2789?src=pr&el=h1) Re

[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 opened a new pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until

[GitHub] [incubator-gobblin] asfgit closed pull request #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration

2019-10-31 Thread GitBox
asfgit closed pull request #2780: [GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration URL: https://github.com/apache/incubator-gobblin/pull/2780 This is an automated message from the Apache Git Servi

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate

2019-10-31 Thread GitBox
jhsenjaliya commented on issue #2751: [GOBBLIN-895] Fixes Gobblin Standalone configs and scripts so that user guide is accurate URL: https://github.com/apache/incubator-gobblin/pull/2751#issuecomment-548558371 Sure, let me updates the docs accordingly.

[GitHub] [incubator-gobblin] ZihanLi58 closed pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 closed pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790 This is an automated message from the Apach

[GitHub] [incubator-gobblin] ZihanLi58 opened a new pull request #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 opened a new pull request #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until

[GitHub] [incubator-gobblin] codecov-io commented on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
codecov-io commented on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#issuecomment-548564313 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr&el=h1) R

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
codecov-io edited a comment on issue #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#issuecomment-548564313 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2790?src=pr&el

[GitHub] [incubator-gobblin] jhsenjaliya commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
jhsenjaliya commented on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548566219 > I was wondering, would it be better if we were to utilise javaopts, so `-D` flags for the

[GitHub] [incubator-gobblin] jhsenjaliya commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
jhsenjaliya commented on a change in pull request #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#discussion_r341362631 ## File path: bin/gobblin.sh ## @@ -283,18 +291,18 @@ eli

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341357961 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341358264 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341363858 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341356298 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341361806 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341357486 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341358581 ## File path: gobblin-hive-registration/src/main/java/org/apa

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341366268 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341366880 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341370332 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341369711 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] codecov-io commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
codecov-io commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548577059 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr&el=h1) R

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1) R

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
codecov-io edited a comment on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548577059 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2791?src=pr&el

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs

2019-10-31 Thread GitBox
codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=pr&el=h1) R

[GitHub] [incubator-gobblin] ZihanLi58 commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on issue #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791#issuecomment-548599519 @autumnust Here is the new PR, Thx. ^^ ---

[GitHub] [incubator-gobblin] asfgit closed pull request #2786: [GOBBLIN-937] fix help text and align it with variable names

2019-10-31 Thread GitBox
asfgit closed pull request #2786: [GOBBLIN-937] fix help text and align it with variable names URL: https://github.com/apache/incubator-gobblin/pull/2786 This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341414676 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341414676 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341415129 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
autumnust commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341415701 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-10-31 Thread GitBox
ZihanLi58 commented on a change in pull request #2790: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341419272 ## File path: gobblin-data-management/src/main/java/org/apach

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-11-01 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r341681213 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/mysql-deployment.yaml ##

[GitHub] [incubator-gobblin] zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-11-01 Thread GitBox
zxcware commented on a change in pull request #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#discussion_r341678716 ## File path: gobblin-kubernetes/gobblin-service/dev-cluster/gaas-application.conf ##

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster

2019-11-01 Thread GitBox
codecov-io edited a comment on issue #2781: [GOBBLIN-913] Add MySQL and configurations to cluster URL: https://github.com/apache/incubator-gobblin/pull/2781#issuecomment-545699470 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2781?src=pr&el=h1) Report > Merging [#27

[GitHub] [incubator-gobblin] htran1 commented on a change in pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching

2019-11-01 Thread GitBox
htran1 commented on a change in pull request #2789: [GOBBLIN-940]Add synchronization on workunit persistency before Helix job launching URL: https://github.com/apache/incubator-gobblin/pull/2789#discussion_r341686549 ## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cl

[GitHub] [incubator-gobblin] codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and standardize configs

2019-11-01 Thread GitBox
codecov-io edited a comment on issue #2788: [GOBBLIN-939] Integrate usage of env variables in gobblin scripts and standardize configs URL: https://github.com/apache/incubator-gobblin/pull/2788#issuecomment-548517189 # [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2788?src=

[GitHub] [incubator-gobblin] asfgit closed pull request #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema

2019-11-01 Thread GitBox
asfgit closed pull request #2791: [GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving schema URL: https://github.com/apache/incubator-gobblin/pull/2791 This is an automated message from the Apache G

  1   2   3   4   5   6   7   8   9   10   >