I should clarify that I'm only thinking about a particular set of unchecked
exceptions from java.lang: NullPointerException, IllegalArgumentException,
IllegalStateException, NoSuchElementException and IndexOutOfBoundsException.
Being consistent on checked exceptions like IOException is still
My point is that we should not break existing common rules and drop
test bases not even understanding motivation. Sorry, saving
engineering time to run simple tests and fix the code does not
convince me because it takes human years to create the tests and keep
our implementation compatible.
I
On 17/Nov/2009 03:50, Nathan Beyer wrote:
2009/11/16 Alexei Fedotov alexei.fedo...@gmail.com:
Funny. We don't have a requirement that a committer have to test the
code before committing it here [1].
I suppose some things are just assumed.
[1] http://wiki.apache.org/harmony/NewCommitter
I would rather call this misunderstanding.
Jesse run one set of tests, Tim expected another set. One way to
correct the problem is to agree that committers run a specific minimal
set of tests, for example, on one platform. I thought we had such
agreements documented, but failed to find a proper
On 13/Nov/2009 20:24, Jesse Wilson wrote:
Harmony team,
In the process of fixing a bug, I just checked in
SneakyThrowhttp://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/org/apache/harmony/luni/util/SneakyThrow.java?revision=835972view=markup.
This is a
On Tue, Nov 17, 2009 at 7:56 AM, Tim Ellison t.p.elli...@gmail.com wrote:
The difference I see, by just staring at the code and without running
it, is that if the 'thrown' Throwable that was caught earlier is not one
of the tested types (IOException | RuntimeException | Error) then the
On 17/Nov/2009 16:33, Jesse Wilson wrote:
On Tue, Nov 17, 2009 at 7:56 AM, Tim Ellison t.p.elli...@gmail.com wrote:
The difference I see, by just staring at the code and without running
it, is that if the 'thrown' Throwable that was caught earlier is not one
of the tested types (IOException
For better or for worse, Dalvik was changed long ago to ignore exception
priorities. We get exception messages for NPEs and save branches. The full
set of deltas are here:
http://www.google.com/codesearch?q=multiple+errors+lang:java+package:git://android.git.kernel.org/platform/dalvik.git
On Tue, Nov 17, 2009 at 8:53 AM, Tim Ellison t.p.elli...@gmail.com wrote:
Now I've gone back and looked, they were never the real last 10 lines of
the close() method. More a case of, rather than code it like this ... I
did it like this ..., right?
Yes, I named the wrong file. But for a few
I would argue that we are doing a better job of ensuring compatibility with
the RI by *not* mandating the same exception priority on these exceptions.
In the RI, they can (and do) change even in minor releases. Our tests are
mandating compatibility with a random snapshot of the RI on an
Hi, dear all
I'm wondering if there is use case in Harmony for several scalable
components in Amino library. You can see its scalability curve in following
posts:
http://aminoprj.blogspot.com/2009/08/performance-of-amino-stack.html
On Tue, Nov 17, 2009 at 10:33 AM, Jesse Wilson jessewil...@google.com wrote:
On Tue, Nov 17, 2009 at 7:56 AM, Tim Ellison t.p.elli...@gmail.com wrote:
The difference I see, by just staring at the code and without running
it, is that if the 'thrown' Throwable that was caught earlier is not one
On Tue, Nov 17, 2009 at 12:13 PM, Joshua Bloch j...@google.com wrote:
I would argue that we are doing a better job of ensuring compatibility with
the RI by *not* mandating the same exception priority on these exceptions.
In the RI, they can (and do) change even in minor releases. Our tests
James,
If these can be adapted to implement the JSR-166 APIs (completely), you'd
probably be best off working with Doug Lea (the JSR-166 benevolent dictator
for life) to integrate them into the JSR-166 codebase. This way, all users
of the j.u.c APIs (not just Harmony users) would benefit from
Ok, done.
On Wed, Nov 18, 2009 at 6:11 AM, Nathan Beyer nbe...@gmail.com wrote:
2009/11/17 Alexei Fedotov alexei.fedo...@gmail.com:
I would rather call this misunderstanding.
Jesse run one set of tests, Tim expected another set. One way to
If you think it should be documented on the wiki,
15 matches
Mail list logo
