Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 17:19 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 17:04 +0200, Michael Osipov wrote: Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... I actually did: https://mail-archives.apache.org/mod_mbox/hc-dev/201

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 17:19 schrieb Gary Gregory: On Mon, May 15, 2017 at 8:04 AM, Michael Osipov wrote: Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: What benefit do you ha

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Oleg Kalnichevski
On Mon, 2017-05-15 at 17:04 +0200, Michael Osipov wrote: > Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: > > On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: > > > > > > > > ... > I actually did:  > https://mail-archives.apache.org/mod_mbox/hc-dev/201705.mbox/%3C01066 > 1f8-4e15-01

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Gary Gregory
On Mon, May 15, 2017 at 8:04 AM, Michael Osipov wrote: > Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: > >> On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: >> >>> >> ... >> >> >> Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: >>> What benefit do you have if it is hard to foll

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 16:36 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: What benefit do you have if it is hard to follow the code paths? How much is "good" code worth if you don't have proper documenta

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Oleg Kalnichevski
On Mon, 2017-05-15 at 16:18 +0200, Michael Osipov wrote: > > ... > Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: > What benefit do you have if it is hard to follow the code paths? How  > much is "good" code worth if you don't have proper documentation? > Even  > if you have to constantly cl

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 16:00 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 15:18 +0200, Michael Osipov wrote: ... Am 2017-05-15 um 15:05 schrieb Oleg Kalnichevski: I have _no_ intention of policing other committers. It is emotionally cheaper for me to take time to clean things up and than to

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Oleg Kalnichevski
On Mon, 2017-05-15 at 15:18 +0200, Michael Osipov wrote: > > ... > Am 2017-05-15 um 15:05 schrieb Oleg Kalnichevski: > > I have _no_ intention of policing other committers. It is > > emotionally > > cheaper for me to take time to clean things up and than to hold all > > those conversations abou

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 15:05 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 14:58 +0200, Michael Osipov wrote: Am 2017-05-15 um 13:13 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: Force pushing is considered a bad practice in Git for good reasons, thus rewriti

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Oleg Kalnichevski
On Mon, 2017-05-15 at 14:58 +0200, Michael Osipov wrote: > Am 2017-05-15 um 13:13 schrieb Oleg Kalnichevski: > > On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: > > > Force pushing is considered a bad practice in Git for good > > > reasons, > > > thus rewriting history of published branche

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 13:13 schrieb Oleg Kalnichevski: On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: Force pushing is considered a bad practice in Git for good reasons, thus rewriting history of published branches is IMHO a no-go. It makes everybody's life harder (and developers less exper

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Oleg Kalnichevski
On Mon, 2017-05-15 at 11:54 +0200, Julian Sedding wrote: > Force pushing is considered a bad practice in Git for good reasons, > thus rewriting history of published branches is IMHO a no-go. It > makes > everybody's life harder (and developers less experienced with Git may > not be able to integrat

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Michael Osipov
Am 2017-05-15 um 11:54 schrieb Julian Sedding: Force pushing is considered a bad practice in Git for good reasons, thus rewriting history of published branches is IMHO a no-go. It makes everybody's life harder (and developers less experienced with Git may not be able to integrate the rewritten hi

Re: Do not commit to HttpCore SVN!

2017-05-15 Thread Julian Sedding
Force pushing is considered a bad practice in Git for good reasons, thus rewriting history of published branches is IMHO a no-go. It makes everybody's life harder (and developers less experienced with Git may not be able to integrate the rewritten history at all). Don't get me wrong. I do a lot of

Re: Do not commit to HttpCore SVN!

2017-05-11 Thread Oleg Kalnichevski
On Thu, 2017-05-11 at 00:00 +0200, Michael Osipov wrote: > Am 2017-05-10 um 23:48 schrieb Oleg Kalnichevski: > > On Wed, 2017-05-10 at 23:25 +0200, Michael Osipov wrote: > > > > ... > > I am not sure I understand what you mean by git apply. > > > > Can we go back to what appears to be the only

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 23:48 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 23:25 +0200, Michael Osipov wrote: ... But your answer is contrary to your previous statement -- cherry- picking shouldn't be a fuzz with two different repos. Can you explain why? My understanding is that cherry picking

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 23:25 +0200, Michael Osipov wrote: ... > > > But your answer is contrary to your previous statement -- cherry- > > > picking > > > shouldn't be a fuzz with two different repos. Can you explain > > > why? > > > > > > > My understanding is that cherry picking is not possible

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 23:19 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 22:00 +0200, Michael Osipov wrote: Am 2017-05-10 um 21:54 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: This will a problem anyway because all paths change (package names, etc.). Hope

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 22:00 +0200, Michael Osipov wrote: > Am 2017-05-10 um 21:54 schrieb Oleg Kalnichevski: > > On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: > > > > > > This will a problem anyway because all paths change (package > > > names, > > > etc.). Hopefully Git's similarity al

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:54 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: This will a problem anyway because all paths change (package names, etc.). Hopefully Git's similarity algorithm can detect this. No, it is not. Git is that great. It always amazes me ho

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 21:45 +0200, Michael Osipov wrote: > > This will a problem anyway because all paths change (package names,  > etc.). Hopefully Git's similarity algorithm can detect this. > No, it is not. Git is that great. It always amazes me how intelligent Git when it comes to merging st

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:42 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:27 +0200, Michael Osipov wrote: Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15 -

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 21:27 +0200, Michael Osipov wrote: > Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: > > On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: > > > Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: > > > > On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: > > > > >

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Gary Gregory
On Wed, May 10, 2017 at 12:27 PM, Michael Osipov wrote: > Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: > >> On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: >> >>> Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: >>> On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: >

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 21:16 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski wrote: ... One person

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread sebb
If the committer squashes their commits *before* pushing then history is maintained. On 10 May 2017 at 20:16, Oleg Kalnichevski wrote: > On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: >> Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: >> > On Wed, 2017-05-10 at 11:15 -0700, Gary Grego

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 21:07 +0200, Michael Osipov wrote: > Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: > > On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: > > > On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski > > .org > > > > > > > > > > wrote: > > > > > > > ... > > > > > > >

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 20:52 schrieb Oleg Kalnichevski: On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski wrote: ... One personal request. Do you think you could try to make your commits less granular and combine logically related change

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 11:15 -0700, Gary Gregory wrote: > On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski > > wrote: > > > ... > > > > > > > > One personal request. Do you think you could try to make your > > > > commits > > > > less granular and combine logically related changes into larger

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 09:51 -0700, Gary Gregory wrote: > Can you rename trunk to master and then give the green light? > Done. SVN trunk pushed to remote as master and remote trunk deleted. Oleg > Gary > > On Wed, May 10, 2017 at 12:59 AM, Oleg Kalnichevski > > wrote: > > > Folks > > > > P

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Gary Gregory
I've blow away my local SVN copy, checked out git trunk and it builds :-) Gary On Wed, May 10, 2017 at 12:59 AM, Oleg Kalnichevski wrote: > Folks > > Please switch your local HttpCore repositories from SVN to the new Git > repo: > > https://git-wip-us.apache.org/repos/asf/httpcomponents-core.gi

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Gary Gregory
On Wed, May 10, 2017 at 10:13 AM, Oleg Kalnichevski wrote: > ... > > > > > One personal request. Do you think you could try to make your > > > commits > > > less granular and combine logically related changes into larger > > > change > > > sets? > > > > > > > Old habits die hard. Git might indeed

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
... > > One personal request. Do you think you could try to make your > > commits > > less granular and combine logically related changes into larger > > change > > sets? > > > > Old habits die hard. Git might indeed make this better. If you want > to add > this to the style guideline on the si

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Gary Gregory
Can you rename trunk to master and then give the green light? Gary On Wed, May 10, 2017 at 12:59 AM, Oleg Kalnichevski wrote: > Folks > > Please switch your local HttpCore repositories from SVN to the new Git > repo: > > https://git-wip-us.apache.org/repos/asf/httpcomponents-core.git > > Please

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Gary Gregory
On Wed, May 10, 2017 at 12:59 AM, Oleg Kalnichevski wrote: > Folks > > Please switch your local HttpCore repositories from SVN to the new Git > repo: > > https://git-wip-us.apache.org/repos/asf/httpcomponents-core.git > > Please try to not commit to SVN while it is being set to read-only > mode.

Git policies and practices; Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Oleg Kalnichevski
On Wed, 2017-05-10 at 16:18 +0200, Michael Osipov wrote: > Am 2017-05-10 um 09:59 schrieb Oleg Kalnichevski: > > > > I collected all your latest SVN commits and pushed them to the Git > > repo. Nothing should have been lost. > > > > One personal request. Do you think you could try to make your >

Re: Do not commit to HttpCore SVN!

2017-05-10 Thread Michael Osipov
Am 2017-05-10 um 09:59 schrieb Oleg Kalnichevski: I collected all your latest SVN commits and pushed them to the Git repo. Nothing should have been lost. One personal request. Do you think you could try to make your commits less granular and combine logically related changes into larger change