Re: Review Request 65304: HIVE-18513 Query results caching

2018-01-24 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/ --- (Updated Jan. 25, 2018, 7:34 a.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-18537) Queries with a nested distinct clause and a windowing function seem to fail with calcite Assertion error

2018-01-24 Thread Amruth S (JIRA)
Amruth S created HIVE-18537: --- Summary: Queries with a nested distinct clause and a windowing function seem to fail with calcite Assertion error Key: HIVE-18537 URL: https://issues.apache.org/jira/browse/HIVE-18537

[jira] [Created] (HIVE-18536) IOW + DP is broken

2018-01-24 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18536: --- Summary: IOW + DP is broken Key: HIVE-18536 URL: https://issues.apache.org/jira/browse/HIVE-18536 Project: Hive Issue Type: Sub-task

Re: Review Request 65047: Fix for HIVE-18393

2018-01-24 Thread Janaki Lahorani via Review Board
> On Jan. 22, 2018, 8:43 p.m., Sahil Takiar wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/parquet/serde/primitive/ParquetStringInspector.java > > Lines 64 (patched) > > > > > > do we need to handle all the

[jira] [Created] (HIVE-18535) Can not start LLAP

2018-01-24 Thread songqi (JIRA)
songqi created HIVE-18535: - Summary: Can not start LLAP Key: HIVE-18535 URL: https://issues.apache.org/jira/browse/HIVE-18535 Project: Hive Issue Type: Bug Components: Diagnosability

Review Request 65331: HIVE-17751 Separate HMS Client and HMS server into separate sub-modules

2018-01-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65331/ --- Review request for hive, Alan Gates, Sergey Shelukhin, and Vihang Karajgaonkar.

[jira] [Created] (HIVE-18534) null partition values may be output as the magic string in query results

2018-01-24 Thread Sergey Shelukhin (JIRA)
Sergey Shelukhin created HIVE-18534: --- Summary: null partition values may be output as the magic string in query results Key: HIVE-18534 URL: https://issues.apache.org/jira/browse/HIVE-18534

Review Request 65330: HIVE-18526 Backport HIVE-16886 to Hive 2

2018-01-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65330/ --- Review request for hive, anishek, Andrew Sherman, Janaki Lahorani, Sergio Pena,

Re: Review Request 65276: HIVE-18516

2018-01-24 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196192 --- ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines

[jira] [Created] (HIVE-18533) Add option to use InProcessLauncher to submit spark jobs

2018-01-24 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18533: --- Summary: Add option to use InProcessLauncher to submit spark jobs Key: HIVE-18533 URL: https://issues.apache.org/jira/browse/HIVE-18533 Project: Hive Issue

[jira] [Created] (HIVE-18532) Hive Connection can't be closed if there is an error while creating session

2018-01-24 Thread Purshotam Shah (JIRA)
Purshotam Shah created HIVE-18532: - Summary: Hive Connection can't be closed if there is an error while creating session Key: HIVE-18532 URL: https://issues.apache.org/jira/browse/HIVE-18532 Project:

[jira] [Created] (HIVE-18531) Vectorization: Vectorized PTF operator should not set the initial type infos

2018-01-24 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18531: --- Summary: Vectorization: Vectorized PTF operator should not set the initial type infos Key: HIVE-18531 URL: https://issues.apache.org/jira/browse/HIVE-18531 Project:

Re: Hive packaging and the standalone metastore

2018-01-24 Thread Mithun RK
#1 is preferable, IMHO. On Wed, Jan 24, 2018 at 12:16 PM Alan Gates wrote: > In HIVE-17983 I have been working on packaing and start/stop scripts for > the standalone metastore. One question this brings up is how Hive will be > released now, with or without the metastore.

[jira] [Created] (HIVE-18530) Replication should skip MM table (for now)

2018-01-24 Thread Daniel Dai (JIRA)
Daniel Dai created HIVE-18530: - Summary: Replication should skip MM table (for now) Key: HIVE-18530 URL: https://issues.apache.org/jira/browse/HIVE-18530 Project: Hive Issue Type: Bug

[jira] [Created] (HIVE-18529) Vectorization: Add a debug config option to disable scratch column reuse

2018-01-24 Thread Gopal V (JIRA)
Gopal V created HIVE-18529: -- Summary: Vectorization: Add a debug config option to disable scratch column reuse Key: HIVE-18529 URL: https://issues.apache.org/jira/browse/HIVE-18529 Project: Hive

[jira] [Created] (HIVE-18528) Stats: In the bitvector codepath, when extrapolating column stats for String type columnStringColumnStatsAggregator uses the min value instead of max

2018-01-24 Thread Vaibhav Gumashta (JIRA)
Vaibhav Gumashta created HIVE-18528: --- Summary: Stats: In the bitvector codepath, when extrapolating column stats for String type columnStringColumnStatsAggregator uses the min value instead of max Key: HIVE-18528

Re: Review Request 65304: HIVE-18513 Query results caching

2018-01-24 Thread Jason Dere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65304/ --- (Updated Jan. 24, 2018, 9:51 p.m.) Review request for hive, Ashutosh Chauhan,

[jira] [Created] (HIVE-18527) DESCRIBE and DESCRIBE FORMATTED show partitions differently

2018-01-24 Thread Anirudh (JIRA)
Anirudh created HIVE-18527: -- Summary: DESCRIBE and DESCRIBE FORMATTED show partitions differently Key: HIVE-18527 URL: https://issues.apache.org/jira/browse/HIVE-18527 Project: Hive Issue Type:

Hive packaging and the standalone metastore

2018-01-24 Thread Alan Gates
In HIVE-17983 I have been working on packaing and start/stop scripts for the standalone metastore. One question this brings up is how Hive will be released now, with or without the metastore. I can see two options: 1) We continue to ship the metastore with Hive. Not only does this mean the

[jira] [Created] (HIVE-18526) Backport HIVE-16886 to Hive 2

2018-01-24 Thread Alexander Kolbasov (JIRA)
Alexander Kolbasov created HIVE-18526: - Summary: Backport HIVE-16886 to Hive 2 Key: HIVE-18526 URL: https://issues.apache.org/jira/browse/HIVE-18526 Project: Hive Issue Type: Sub-task

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-24 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65075/ --- (Updated Jan. 24, 2018, 7:28 p.m.) Review request for hive, Aihua Xu, Andrew

Re: Review Request 64632: HIVE-18247: Use DB auto-increment for indexes

2018-01-24 Thread Alexander Kolbasov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64632/#review196157 --- ping for reviewers. - Alexander Kolbasov On Dec. 15, 2017,

[jira] [Created] (HIVE-18525) Add explain plan to Hive on Spark Web UI

2018-01-24 Thread Sahil Takiar (JIRA)
Sahil Takiar created HIVE-18525: --- Summary: Add explain plan to Hive on Spark Web UI Key: HIVE-18525 URL: https://issues.apache.org/jira/browse/HIVE-18525 Project: Hive Issue Type: Sub-task

[GitHub] hive pull request #296: Use valueOf method instead of constructor since valu...

2018-01-24 Thread reudismam
GitHub user reudismam opened a pull request: https://github.com/apache/hive/pull/296 Use valueOf method instead of constructor since valueOf is likely to … …yield significantly better space and time performance by caching frequently requested values. You can merge this pull

Re: Review Request 65264: HIVE-18481: Create tests for table related methods (get, list, exists)

2018-01-24 Thread Sahil Takiar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196144 ---

Re: Review Request 65075: HIVE-18426: Memory leak in RoutingAppender for every hive operation

2018-01-24 Thread kalyan kumar kalvagadda via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65075/ --- (Updated Jan. 24, 2018, 5:44 p.m.) Review request for hive, Aihua Xu, Andrew

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-24 Thread Sahil Takiar
> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestFunctions.java > > Lines 236 (patched) > > > > > > Should we be filing JIRAs for

[jira] [Created] (HIVE-18524) Vectorization: Execution failure related to non-standard embedding of IfExprConditionalFilter inside VectorUDFAdaptor (HIVE-17139)

2018-01-24 Thread Matt McCline (JIRA)
Matt McCline created HIVE-18524: --- Summary: Vectorization: Execution failure related to non-standard embedding of IfExprConditionalFilter inside VectorUDFAdaptor (HIVE-17139) Key: HIVE-18524 URL:

Re: Review Request 65213: HIVE-18479: Create tests to cover methods for dropping Partitions

2018-01-24 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65213/ --- (Updated Jan. 24, 2018, 4:37 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-24 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/ --- (Updated Jan. 24, 2018, 4:06 p.m.) Review request for hive, Peter Vary and

Re: Review Request 65241: HIVE-18496: Create tests to cover add/alter/drop index methods

2018-01-24 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65241/ --- (Updated Jan. 24, 2018, 3:41 p.m.) Review request for hive, Peter Vary and

[jira] [Created] (HIVE-18523) Fix summary row in case there are no inputs

2018-01-24 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18523: --- Summary: Fix summary row in case there are no inputs Key: HIVE-18523 URL: https://issues.apache.org/jira/browse/HIVE-18523 Project: Hive Issue Type:

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/ --- (Updated Jan. 24, 2018, 2:02 p.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65285: Create tests to cover getPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 200 (patched) > > > > > > Maybe test for case

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-24 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 1:48 p.m., Peter Vary wrote: > > Nice job, looks good to me, one minor question Thanks a lot Peter for the review. > On Jan. 22, 2018, 1:48 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetListIndexes.java > >

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-24 Thread Marta Kuczora via Review Board
> On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote: > > This change looks good! I only spotted some small code-duplications that we > > may want to clean up. Thanks a lot Adam for the review. > On Jan. 22, 2018, 12:35 p.m., Adam Szita wrote: > >

Re: Review Request 65240: HIVE-18498: Create tests to cover get and list index methods

2018-01-24 Thread Marta Kuczora via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65240/ --- (Updated Jan. 24, 2018, 1:46 p.m.) Review request for hive, Peter Vary and

[jira] [Created] (HIVE-18522) Running all negative qtests seems to leave some threads behind

2018-01-24 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created HIVE-18522: --- Summary: Running all negative qtests seems to leave some threads behind Key: HIVE-18522 URL: https://issues.apache.org/jira/browse/HIVE-18522 Project: Hive

Re: Review Request 65284: Create tests to cover listPartition(s) methods

2018-01-24 Thread Adam Szita via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65284/ --- (Updated Jan. 24, 2018, 11:22 a.m.) Review request for hive, Marta Kuczora and

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-24 Thread Peter Vary via Review Board
> On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > > A few comments, in general the tests look very thorough. Nice work! Thanks for the review Sahil! > On Jan. 23, 2018, 7:50 p.m., Sahil Takiar wrote: > >

Re: Review Request 65210: HIVE-18480 Create tests for function related methods

2018-01-24 Thread Peter Vary via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65210/ --- (Updated Jan. 24, 2018, 10:52 a.m.) Review request for hive, Alan Gates, Marta