Cool! Can't wait the first DI specific commit and the review :)
On 2023. Apr 19., Wed at 14:24, Stamatis Zampetakis
wrote:
> I think we all agree that DI can be beneficial in general.
>
> However, it's hard to say yes or no on something before having a
> concrete case to discuss; it doesn't
I think we all agree that DI can be beneficial in general.
However, it's hard to say yes or no on something before having a
concrete case to discuss; it doesn't have to be a PR but we need to
work on a specific Hive use-case and list advantages/disadvantages of
the proposal.
Best,
Stamatis
On
Hi all,
Sorry for not answering for so far, for some reason I did not receive your
answers in my gmail account. I’m happy to see that there’s a conversation
around the topic, so let me add my opinion on your points.
First of all, introducing a DI framework does not mean a large scale
Thanks Sungwoo. Regarding the correctness issue, can you post it to the
proper thread? I guess it was not intentional to post here.
Regards,
Laszlo Bodor
Sungwoo Park ezt írta (időpont: 2023. ápr. 13., Cs,
12:39):
> I would like to add another question to the list of Laszlo.
>
> 4) When a
I would like to add another question to the list of Laszlo.
4) When a specific DI framework is chosen, what kinds of new dependencies
will be introduced? (Are they conflicting with existing dependencies of
Hive?)
Regards,
--- Sungwoo Park
On Thu, Apr 13, 2023 at 4:43 PM László Bodor
wrote:
Hi Stamatis,
For the correctness issue, we wanted to solve the problem ourselves and
have made a few pull requests in [1] so far. (We would like to kindly
request Hive committers to review the pull requests.) For HIVE-27226, we
are working on a solution and will create a pull request when a
Thanks, guys for putting DI into scope, sounds very interesting, just a
couple of questions to help me understand and move this forward (and maybe
involve more folks with DI experience):
1) Can we have some examples, even with dummy code snippet-level, about
what we want to achieve? I mean,
Just to be clear, I am in favor of introducing DI frameworks in Hive
where it makes sense. As Attila said, we don't want to get stuck with
legacy code forever. When a concrete proposal comes up we can discuss
benefits vs drawbacks.
Regarding stability I agree it is a pressing issue but Hive is an
Hi Stamatis and Sungwoo,
Agree with several points. Hive has millions of LOC which is here and will
be with us in the same way, it is not a question. But we need to think
about the future of the project. There are no engineers in the world who
want to use old and legacy technologies, every
Hello,
I am not a committer, but I would like to add my opinion. At this stage of
development, I think it is quite risky to switch to a DI framework for a
couple of reasons.
1. A DI framework would have been a powerful tool if it had been
incorporated into the project from the early stage. Now,
Hey Laszlo,
Dependency injection is a very powerful and useful tool/design pattern.
I don't think there is a particular reason for which Hive does not use
DI framework apart maybe from the fact that we have lots of legacy
code that existed before DI became that popular.
I am open to ideas and
11 matches
Mail list logo
