Re: Review Request 63319: HIVE-17908: LLAP External client not correctly handling killTask for pending requests

nt would be helpful on the field about the lifecycle for acquire/release - Sergey Shelukhin On Oct. 26, 2017, 2:42 a.m., Jason Dere wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 63490: HIVE-17907 enable and apply resource plan commands in HS2

://reviews.apache.org/r/63490/diff/3/ Changes: https://reviews.apache.org/r/63490/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63490: HIVE-17907 enable and apply resource plan commands in HS2

://reviews.apache.org/r/63490/diff/3-4/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63490: HIVE-17907 enable and apply resource plan commands in HS2

60531457b7 Diff: https://reviews.apache.org/r/63490/diff/4/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63490: HIVE-17907 enable and apply resource plan commands in HS2

60531457b7 Diff: https://reviews.apache.org/r/63490/diff/5/ Changes: https://reviews.apache.org/r/63490/diff/4-5/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63490: HIVE-17907 enable and apply resource plan commands in HS2

60531457b7 Diff: https://reviews.apache.org/r/63490/diff/6/ Changes: https://reviews.apache.org/r/63490/diff/5-6/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

://reviews.apache.org/r/63346/diff/8/ Changes: https://reviews.apache.org/r/63346/diff/7-8/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

standalone-metastore/src/main/resources/package.jdo 296e273ec8 standalone-metastore/src/main/thrift/hive_metastore.thrift 60531457b7 Diff: https://reviews.apache.org/r/63346/diff/9/ Changes: https://reviews.apache.org/r/63346/diff/8-9/ Testing --- Thanks, Sergey Shelukhin

Review Request 63600: HIVE-17904 handle internal Tez AM restart in registry and WM

ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestGuaranteedTaskAllocator.java 5d1a3b6d72 Diff: https://reviews.apache.org/r/63600/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

/ Changes: https://reviews.apache.org/r/63346/diff/9-10/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

--------- On Nov. 7, 2017, 3:09 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63346/ >

Re: Review Request 63346: HIVE-17902 add a notions of default pool and unmanaged mapping

/11/ Changes: https://reviews.apache.org/r/63346/diff/10-11/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

/WorkloadManager.java 169991c639 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc Diff: https://reviews.apache.org/r/63533/diff/2/ Changes: https://reviews.apache.org/r/63533/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

/WorkloadManager.java Lines 459 (patched) <https://reviews.apache.org/r/63533/#comment267744> needs to continue - Sergey Shelukhin On Nov. 8, 2017, 2:29 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

/WorkloadManager.java 169991c639 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 0347e914bc Diff: https://reviews.apache.org/r/63533/diff/3/ Changes: https://reviews.apache.org/r/63533/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63533/#review190530 ------- On Nov. 8, 2017, 9:12 p.m., Sergey Shelukhin wrote: > > --- > This is

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

/WorkloadManager.java 16f5dce10a ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 84a35cc78c Diff: https://reviews.apache.org/r/63533/diff/4/ Changes: https://reviews.apache.org/r/63533/diff/3-4/ Testing --- Thanks, Sergey Shelukhin

adding a label that would trigger HiveQA?

Resubmitting the same patch for HiveQA as patches are constantly getting dropped is getting old. I wonder if we should have a label that would trigger HiveQA and only be removed at the end, when posting results to the JIRA? We could either add it in addition to the current filter or trigger mechani

Re: Review Request 63533: HIVE-17906 use kill query mechanics to kill queries in WM

/WorkloadManager.java bdbcce5666 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java a73a24aef3 Diff: https://reviews.apache.org/r/63533/diff/5/ Changes: https://reviews.apache.org/r/63533/diff/4-5/ Testing --- Thanks, Sergey Shelukhin

Review Request 63782: HIVE-18002 add group support for pool mappings

://reviews.apache.org/r/63782/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2

://reviews.apache.org/r/63864/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2

always be logged - Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63864/#review191232 --- On Nov. 16, 2017, 3:36 a.m., Ser

Re: Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2

/exec/tez/WorkloadManager.java 1fe5859490 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 5ba6639e0c Diff: https://reviews.apache.org/r/63864/diff/2/ Changes: https://reviews.apache.org/r/63864/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2

/TestWorkloadManager.java 5ba6639e0c Diff: https://reviews.apache.org/r/63864/diff/3/ Changes: https://reviews.apache.org/r/63864/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63864: HIVE-18072 WM - fix various bugs based on cluster testing - part 2

/TestWorkloadManager.java 5ba6639e0c Diff: https://reviews.apache.org/r/63864/diff/4/ Changes: https://reviews.apache.org/r/63864/diff/3-4/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63890: HIVE-18025: Push resource plan changes to tez/unmanaged sessions

nerated code without a thrift change. The null check (or isSet check?) should be in the caller - Sergey Shelukhin On Nov. 17, 2017, 2:20 a.m., Prasanth_J wrote: > > --- > This is an automatically gener

Review Request 63927: HIVE-17631 upgrade orc to 1.4.0

/63927/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63927: HIVE-17631 upgrade orc to 1.4.0

----- On Nov. 17, 2017, 10:42 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63927/ >

Re: Review Request 63927: HIVE-17631 upgrade orc to 1.4.0

a20328cb69 Diff: https://reviews.apache.org/r/63927/diff/2/ Changes: https://reviews.apache.org/r/63927/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63927: HIVE-17631 upgrade orc to 1.4.0

a20328cb69 Diff: https://reviews.apache.org/r/63927/diff/3/ Changes: https://reviews.apache.org/r/63927/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

ned elsewhere in the patch and doesn't seem to follow the convention (e.g. component name is LLAP without DAEMON). Just checking; it used to have a fancy name like site.global. ... - Sergey Shelukhin On Nov. 21, 2017, 1:37 a.m., Gour Saha wrote: > > --

Review Request 64021: HIVE-18073 AM may assert when duck count for it is reduced

--- see jira Diffs - llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java 66f3d2ea4a Diff: https://reviews.apache.org/r/64021/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 64099: HIVE-18076 killquery doesn't actually work for non-trigger WM kills

/java/org/apache/hadoop/hive/ql/exec/tez/WmTezSession.java 96d70c98fe ql/src/java/org/apache/hadoop/hive/ql/exec/tez/WorkloadManager.java a8360bd628 Diff: https://reviews.apache.org/r/64099/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64115: HIVE-18160: Jar localization during session initialization is slow

the time when actually computing it? ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java Lines 773 (patched) <https://reviews.apache.org/r/64115/#comment270069> hmm.. why is this necessary? it should still be possible to use the streaming version - Sergey Shelukhin

Re: Review Request 64099: HIVE-18076 killquery doesn't actually work for non-trigger WM kills

/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java > > Lines 176 (patched) > > <https://reviews.apache.org/r/63972/diff/1/?file=1897953#file1897953line210> > > > > is

Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/cli/LlapSliderUtils.java > > Line 47 (original), 46 (patched) > > <https://reviews.apache.org/r/63972/diff/1/?file=1897953#file1897953line54> > > > &

Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote: > > llap-server/src/main/resources/templates.py > > Lines 43 (patched) > > <https://reviews.apache.org/r/63972/diff/1/?file=1897959#file1897959line133> > > > > how does it know what LLAP_DAEMON_OPTS

Re: Review Request 63972: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

> On Nov. 21, 2017, 4:09 a.m., Sergey Shelukhin wrote: > > llap-server/src/main/resources/templates.py > > Lines 43 (patched) > > <https://reviews.apache.org/r/63972/diff/1/?file=1897959#file1897959line133> > > > > how does it know what LLAP_DAEMON_OPTS

Re: Review Request 64229: [HIVE-18037] Migrate Slider LLAP package to YARN Service framework for Hadoop 3.x

t; need jira to restore this code (or equivalent) based on YARN services... without it, LLAP status cannot succeed and e.g. Ambari cannot start LLAP - Sergey Shelukhin On Nov. 30, 2017, 10:27 p.m., Gour Saha wrote: > > --

Re: Review Request 64222: HIVE-18088: Add WM event traces at query level for debugging

hadoop/hive/ql/wm/WMContext.java Lines 2 (patched) <https://reviews.apache.org/r/64222/#comment270788> is this just a move+json? ql/src/java/org/apache/hadoop/hive/ql/wm/WMContext.java Lines 166 (patched) <https://reviews.apache.org/r/64222/

Re: Review Request 64222: HIVE-18088: Add WM event traces at query level for debugging

anyway? - Sergey Shelukhin On Dec. 3, 2017, 10:40 p.m., Prasanth_J wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

/TestWorkloadManager.java 78df962a3a Diff: https://reviews.apache.org/r/64324/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java 78df962a3a Diff: https://reviews.apache.org/r/64324/diff/2/ Changes: https://reviews.apache.org/r/64324/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64222: HIVE-18088: Add WM event traces at query level for debugging

Lines 259 (patched) <https://reviews.apache.org/r/64222/#comment271294> nit: since this can be assigned multiple times as the session is used repeatedly, set to null here? - Sergey Shelukhin On Dec. 5, 2017, 4:38 a.m., Prasanth_J

Review Request 64356: HIVE-18078 WM getSession needs some retry logic

/64356/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 64358: HIVE-18003 add explicit jdbc connection string args for mappings

/cli/thrift/ThriftCLIService.java fc9e6b2a91 Diff: https://reviews.apache.org/r/64358/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64358: HIVE-18003 add explicit jdbc connection string args for mappings

78df962a3a Diff: https://reviews.apache.org/r/64358/diff/2/ Changes: https://reviews.apache.org/r/64358/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64358: HIVE-18003 add explicit jdbc connection string args for mappings

c58e4507f2 Diff: https://reviews.apache.org/r/64358/diff/3/ Changes: https://reviews.apache.org/r/64358/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2 Diff: https://reviews.apache.org/r/64324/diff/3/ Changes: https://reviews.apache.org/r/64324/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Review Request 64402: HIVE-18240 support getClientInfo/setClientInfo in JDBC

a1f293bdc2 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 7fbcd13b63 service/src/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java fc9e6b2a91 Diff: https://reviews.apache.org/r/64402/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64402: HIVE-18240 support getClientInfo/setClientInfo in JDBC

/HiveSessionImpl.java Lines 305 (patched) <https://reviews.apache.org/r/64402/#comment271586> this should be removed - Sergey Shelukhin On Dec. 7, 2017, 3:24 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically gener

Re: checkstyle changes

I think the 140-character change will make the code hard to use on a laptop without a monitor. On 17/12/7, 02:43, "Peter Vary" wrote: >Disclaimer: I did not have time to test it out, but according to >http://checkstyle.sourceforge.net/config_misc.html#Indentation >

Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

--- Thanks, Sergey Shelukhin

Re: Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2 Diff: https://reviews.apache.org/r/64324/diff/4/ Changes: https://reviews.apache.org/r/64324/diff/3-4/ Testing --- Thanks, Sergey Shelukhin

Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

24c59f2f1b0b017cff3b26f86c3f903b498d2553 standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 1e4fe5d973542d6b0e3ae0760ca5c06ea9888089 Diff: https://reviews.apache.org/r/64555/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

o expectation of consistency if local files change during process lifetime, behavior is undefined (reopen is also not a defined away). Exec jar uses sha because it's shared between multiple users. - Sergey --- This is an automatically g

Review Request 64592: HIVE-18095 add a unmanaged flag to triggers (applies to container based sessions)

/main/resources/package.jdo 57e75f890dbbd2d5105614aaeac04ef37131e8cd standalone-metastore/src/main/thrift/hive_metastore.thrift 1085ce566a5fba632ae2acb074ce538143bac6ed Diff: https://reviews.apache.org/r/64592/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64324: HIVE-18153 refactor reopen and file management in TezTask

47aa936845 ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestWorkloadManager.java c58e4507f2 Diff: https://reviews.apache.org/r/64324/diff/5/ Changes: https://reviews.apache.org/r/64324/diff/4-5/ Testing --- Thanks, Sergey Shelukhin

Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

c58e4507f2 ql/src/test/queries/clientpositive/resourceplan.q fc924a2f95 ql/src/test/results/clientpositive/llap/resourceplan.q.out 7f3e784457 Diff: https://reviews.apache.org/r/64595/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 64631: HIVE-18273 add LLAP-level counters for WM

/LlapWmSummary.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java 9726af1506 Diff: https://reviews.apache.org/r/64631/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: [DISCUSS] IMetaStoreClient and HMS Thrift API exception handling

If we break the APIs, can we also do the API cleanup where we remove duplicate ones and change everything to use req/resp pattern? On 17/12/14, 13:50, "Thejas Nair" wrote: >This direction looks good to me. >If the new exceptions are inheriting from TException the applications >would >still work.

Re: Review Request 64631: HIVE-18273 add LLAP-level counters for WM

, Sergey Shelukhin

Re: Review Request 64356: HIVE-18078 WM getSession needs some retry logic

/ Changes: https://reviews.apache.org/r/64356/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

-------- On Dec. 8, 2017, 1:11 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64433/ > --

Re: Review Request 64433: HIVE-18203 change the way WM is enabled and allow dropping the last resource plan

://reviews.apache.org/r/64433/diff/2/ Changes: https://reviews.apache.org/r/64433/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

74 ------- On Dec. 12, 2017, 9:46 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/645

Re: Review Request 64555: HIVE-18230 create plan like plan, and replace plan commands for easy modification

://reviews.apache.org/r/64555/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

1085ce566a testutils/ptest2/src/main/java/org/apache/hive/ptest/execution/context/CloudExecutionContextProvider.java e80656385e Diff: https://reviews.apache.org/r/64595/diff/2/ Changes: https://reviews.apache.org/r/64595/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64595: HIVE-18257 implement scheduling policy configuration instead of hardcoding fair scheduling

://reviews.apache.org/r/64595/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

, Sergey Shelukhin

Re: Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

/r/64787/diff/2/ Changes: https://reviews.apache.org/r/64787/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64631: HIVE-18273 add LLAP-level counters for WM

, Sergey Shelukhin

Review Request 64903: HIVE-18269 LLAP: Fast llap io with slow processing pipeline can lead to OOM

4b0a1ceca4 ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Consumer.java 43c56472f3 ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 29cef30d5f Diff: https://reviews.apache.org/r/64903/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 64942: HIVE-18274 add AM level metrics for WM

/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64942: HIVE-18274 add AM level metrics for WM

: https://reviews.apache.org/r/64942/diff/2/ Changes: https://reviews.apache.org/r/64942/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Review Request 64965: HIVE-18275 add HS2-level WM metrics

/hadoop/hive/ql/exec/tez/monitoring/QueryExecutionBreakdownSummary.java 271e3c6eeb Diff: https://reviews.apache.org/r/64965/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64903: HIVE-18269 LLAP: Fast llap io with slow processing pipeline can lead to OOM

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64903/#review194816 --- On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote: > >

Re: Review Request 64903: HIVE-18269 LLAP: Fast llap io with slow processing pipeline can lead to OOM

. To reply, visit: https://reviews.apache.org/r/64903/#review194821 ------- On Jan. 3, 2018, 2:32 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically generated

Re: Review Request 64787: HIVE-18326 LLAP Tez scheduler - only preempt tasks if there's a dependency between them

/64787/diff/3/ Changes: https://reviews.apache.org/r/64787/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 64903: HIVE-18269 LLAP: Fast llap io with slow processing pipeline can lead to OOM

://reviews.apache.org/r/64903/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Review Request 64999: HIVE-18004 investigate deriving app name from JDBC connection for pool mapping

/ThriftCLIServiceClient.java d43f1254c5 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/model/MWMMapping.java ec0ac3f148 standalone-metastore/src/main/resources/package.jdo e3ae67d58e Diff: https://reviews.apache.org/r/64999/diff/1/ Testing --- Thanks, Sergey

Re: Review Request 64999: HIVE-18004 investigate deriving app name from JDBC connection for pool mapping

/UserPoolMapping.java Lines 37 (patched) <https://reviews.apache.org/r/64999/#comment274000> the comment needs to be removed - Sergey Shelukhin On Jan. 5, 2018, 11:51 p.m., Sergey Shelukhin wrote: > > --- > This is an automatically gener

Review Request 65002: HIVE-18229 add the unmanaged mapping command

/clientpositive/resourceplan.q ce684ed51b ql/src/test/results/clientpositive/llap/resourceplan.q.out 29c01a8b43 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java 5bfa62485b Diff: https://reviews.apache.org/r/65002/diff/1/ Testing --- Thanks, Sergey

Re: Review Request 65002: HIVE-18229 add the unmanaged mapping command

4057 (original), 4062 (patched) <https://reviews.apache.org/r/65002/#comment274010> hm, will take a look at this next week - Sergey Shelukhin On Jan. 6, 2018, 3:25 a.m., Sergey Shelukhin wrote: > > --- > This is a

Re: Review Request 65002: HIVE-18229 add the unmanaged mapping command

/2/ Changes: https://reviews.apache.org/r/65002/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Review Request 65052: HIVE-18417 better error handling in TezSessionState cleanup

/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63382: HIVE-17833: Publish split generation counters

ize > 1Gb, not for any one vertex. - Sergey Shelukhin On Jan. 11, 2018, 10:17 p.m., Prasanth_J wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Review Request 65148: HIVE-18452 work around HADOOP-15171

/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6 Diff: https://reviews.apache.org/r/65148/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

/EncodedReaderImpl.java 627e617d91 ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java df536ead1c ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/ReaderImpl.java 203ef69cf6 Diff: https://reviews.apache.org/r/65148/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

/diff/2-3/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

/EncodedReaderImpl.java Lines 1919 (patched) <https://reviews.apache.org/r/65148/#comment274694> this should be removed - Sergey Shelukhin On Jan. 13, 2018, 3:19 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically g

Re: Review Request 65148: HIVE-18452 work around HADOOP-15171

;s good to have an option to disable it - Sergey --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65148/#review195504 ------- O

Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

://reviews.apache.org/r/65185/diff/1/ Testing --- Thanks, Sergey Shelukhin

Re: Review Request 63382: HIVE-17833: Publish split generation counters

/HiveSplitGenerator.java Lines 226 (patched) <https://reviews.apache.org/r/63382/#comment274904> nit: given that this keeps the files in the set anyway, it can increment the counter once with the size of the set, in the end - Sergey Shelukhin On Jan. 17, 2018, 7:38 p.m., Prasanth_J

Re: Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

ply, visit: https://reviews.apache.org/r/65185/#review195530 ------- On Jan. 17, 2018, 2:15 a.m., Sergey Shelukhin wrote: > > --- > This is an automatically ge

Re: Review Request 65185: HIVE-18457 improve show plan output (triggers, mappings)

/clientpositive/resourceplan.q b46c1ee2d6 ql/src/test/results/clientpositive/llap/resourceplan.q.out 72a78b1b4a Diff: https://reviews.apache.org/r/65185/diff/2/ Changes: https://reviews.apache.org/r/65185/diff/1-2/ Testing --- Thanks, Sergey Shelukhin

Review Request 65206: HIVE-18438 WM RP: it's impossible to unset things

standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 6aa5d95a8a Diff: https://reviews.apache.org/r/65206/diff/1/ Testing --- Thanks, Sergey Shelukhin

Review Request 65356: HIVE-18536 IOW + DP is broken for insert-only ACID

/ Testing --- Thanks, Sergey Shelukhin

<    1   2   3   4   5   6   7   8   9   10   >