Re: S_L_U_A for worker MPM?

2002-01-21 Thread Ryan Bloom
The easiest way to remove the S_L_U_A from the worker MPM is to remove all signals from the MPM. Basically, we have a single thread that currently sits in sigwait, which is just waiting for a signal. We then have every other thread sitting in accept waiting for something to wake them up, either

Re: Tagging 1.3.23

2002-01-21 Thread Victor J. Orlikowski
Hrm.Gave things a second look. Thomas, I think your fix is fine. I will commit it shortly. I think, however, that a more reliable option with the various Linux distributions may be to use the DBM_LIB variable a little more in src/Configure. If we can determine the linux distribution being us

[PATCH] ap_rgetline rewrite

2002-01-21 Thread Justin Erenkrantz
As discussed before, here is an implementation rewrite of ap_rgetline. I'd appreciate it if people could review before I consider committing it. =) It passes all of the httpd-tests (this is why I've been adding AP_MODE_SPECULATIVE). The rationale behind this rewrite is to remove the req_cfg-

Re: APR_BRIGADE_NORMALIZE

2002-01-21 Thread Justin Erenkrantz
On Sun, Jan 20, 2002 at 10:36:47PM -0500, Cliff Woolley wrote: > > Can someone please remind me why APR_BRIGADE_NORMALIZE is absolutely > necessary? It's only being used in one place AFAICT (in core.c), and as > far as I know, that just means there's a bug we're patching around rather > than fix

Re: PHP Apache2Filter crashes on Win32

2002-01-21 Thread Justin Erenkrantz
On Mon, Jan 21, 2002 at 01:23:42PM +0100, Sebastian Bergmann wrote: > Here's a backtrace: > > ap_save_brigade(ap_filter_t * 0x10d57628, apr_bucket_brigade * * > 0x10d56004, apr_bucket_brigade * * 0x10a6fe74, apr_pool_t * 0x10d55b30) > line 418 + 49 bytes > php_output_filter(ap_filter_t * 0x10d5

Re: Tagging 1.3.23

2002-01-21 Thread Greg Stein
On Mon, Jan 21, 2002 at 07:58:57PM -0500, Jim Jagielski wrote: > I'm also thinking of the # of patches OtherBill is folding in > as well... By "bumping" the tag, do you mean having the tag > say something like APACHE_1_3_23_R2 or something? Not APACHE_1_3_24 > right? :) :) > > Bill Stoddard wrot

Re: APR_BRIGADE_NORMALIZE

2002-01-21 Thread Greg Stein
On Sun, Jan 20, 2002 at 10:36:47PM -0500, Cliff Woolley wrote: > > Can someone please remind me why APR_BRIGADE_NORMALIZE is absolutely > necessary? It's only being used in one place AFAICT (in core.c), and as > far as I know, that just means there's a bug we're patching around rather > than fix

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Thomas Eibner wrote: > > Like this? I had to put the gdbm test after db1 since debian only has > the gdbm-ndbm.h (but it has the db1/ndbm.h) Yep, that does it -- at least on the RH 7.1 system; haven't tried it on others. -Wall -Wmissing-prototypes generates a bunch o' messages for ndbm.h, but t

Re: Tagging 1.3.23

2002-01-21 Thread Jim Jagielski
I'm also thinking of the # of patches OtherBill is folding in as well... By "bumping" the tag, do you mean having the tag say something like APACHE_1_3_23_R2 or something? Not APACHE_1_3_24 right? :) :) Bill Stoddard wrote: > > The tarball hasn't been rolled, so if the change is simple, why not

Re: modules/aaa/mod_auth_digest.c

2002-01-21 Thread William A. Rowe, Jr.
Madhu, Without looking at the code - that looks dead on, for the parent process only (probably best done in the pre_mpm hook). We need to -attach- for children, rather that init (best in the child_init hook.) From: "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <[EMAIL PROTECTED]> Sent: Monday

Re: Tagging 1.3.23

2002-01-21 Thread Cliff Woolley
On Mon, 21 Jan 2002, Bill Stoddard wrote: > in about 15 minutes... FWIW, it builds and runs fine on slackware-current (8.x). --Cliff -- Cliff Woolley [EMAIL PROTECTED] Charlottesville, VA

modules/aaa/mod_auth_digest.c

2002-01-21 Thread MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)
Hi, I'm trying to understand the use of shm/rmm and I was wondering if it makes sense to have something like this in mod_auth_digest.c. Thanks -Madhu Index: mod_auth_digest.c === RCS file: /home/cvspublic/httpd-2.0/modules/a

Re: Tagging 1.3.23

2002-01-21 Thread Victor J. Orlikowski
I still think that there has to be a better way, rather than patching find-dbm-lib right and left based on wherever a vendor decided to put their ndbm.h. If no-one beats me to it, I'll prolly muck with this tonight. Victor -- Victor J. Orlikowski | The Wall is Down, But the Threat Remains! ==

Re: WIN32 build

2002-01-21 Thread Christian Gross
I will put all the various emails together regarding the WIN32 build issues that I am having. >> >> 1) AWK is necessary and my AWK from Cygwin crashes everytime it is >> used. My Cygwin installation is up to date with the latest edition. >Sorry, then patch cyg-awk, or use another (see win_co

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 05:04:01PM -0500, Rodent of Unusual Size wrote: > Thomas Eibner wrote: > > > > Moving around on the way that find-dbm-lib looks for the libs works for > > me on my Debian box. Is this going to break something else? > > Without testing this patch (my 7.1 system just hung a

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 05:04:01PM -0500, Rodent of Unusual Size wrote: > Thomas Eibner wrote: > > > > Moving around on the way that find-dbm-lib looks for the libs works for > > me on my Debian box. Is this going to break something else? > > Without testing this patch (my 7.1 system just hung a

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Thomas Eibner wrote: > > Moving around on the way that find-dbm-lib looks for the libs works for > me on my Debian box. Is this going to break something else? Without testing this patch (my 7.1 system just hung again), wouldn't we have to fix the CFLAGS to include "-I/usr/include/gdbm", though?

Re: Tagging 1.3.23

2002-01-21 Thread Bill Stoddard
The tarball hasn't been rolled, so if the change is simple, why not make the change and bump the tag? This method has worked pretty good for 2.0 if we impose a reasonable time limit between the tag and the roll (say 24 hours). Bill (who really doesn't mind if we go to 1.3.24) > I have a feelin

Re: S_L_U_A for worker MPM?

2002-01-21 Thread Greg Ames
Brian Pane wrote: > I'm willing to spend some time this week on this issue, but first, can > somebody clarify how prefork is handling the pipe-of-death? > > It looks like prefork children only check the pod upon completion of > a request. Is that all there is to it, or am I missing something?

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 04:10:49PM -0500, Victor J. Orlikowski wrote: > Problem found, but not resolved. > > Turns out that find-dbm-lib in helpers looks for ndbm.h in > /usr/include/db1 on RH 7. This is provided in the db1-devel package. > However, gdbm-devel also provides a ndbm.h, in /usr/inc

Re: Tagging 1.3.23

2002-01-21 Thread Bill Stoddard
Interesting... Here are the first few lines from the tag... C:\home\apache\apache-1.3\apache-1.3>cvs tag APACHE_1_3_23 cvs tag APACHE_1_3_23 ? .cvsignore cvs server: Tagging . T ABOUT_APACHE T Announcement .cvsignore was, um, ignored it seems. It exists on my system... Now it gets more interes

Re: Tag 1.3.23?

2002-01-21 Thread Greg Marr
At 04:13 PM 01/21/2002, William Rowe wrote: >The following (decorated, default) exported symbol names, and the >attached >asm output from footest and footest2 illustrate that _stdcall is >ignored >for vararg prototypes :) looking up __stdcall in the MSVC help gives this: The __stdcall calling c

Re: Tag 1.3.23?

2002-01-21 Thread William A. Rowe, Jr.
From: "Bill Stoddard" <[EMAIL PROTECTED]> Sent: Monday, January 21, 2002 9:44 AM > Upon closer inspection, ap_rprintf() has been NON_STD for ages, so it's fine as is. >Not > sure why it showed up on Rowe-san's list :-o It went to _NONSTD in 1.302, and back to std in 1.309. The tricky bit - i

Re: Tagging 1.3.23

2002-01-21 Thread Jim Jagielski
+1 Rodent of Unusual Size wrote: > > Thomas Eibner wrote: > > > > On Mon, Jan 21, 2002 at 04:15:25PM -0500, Rodent of Unusual Size wrote: > > > > > > A /usr/include/gdbm/ndbm.h file exists. Adding symbolic > > > links all over the /usr/include tree is *not* an option if > > > other packages do

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Thomas Eibner wrote: > > On Mon, Jan 21, 2002 at 04:15:25PM -0500, Rodent of Unusual Size wrote: > > > > A /usr/include/gdbm/ndbm.h file exists. Adding symbolic > > links all over the /usr/include tree is *not* an option if > > other packages don't have a problem with finding it. > > But you're

Re: Tagging 1.3.23

2002-01-21 Thread Jim Jagielski
Victor J. Orlikowski wrote: > > 2 solutions: > 1) Doc it up. Does the job, but not what I want. > 2) Fix find-dbm-lib properly, so that it does "The Right Thing" and > uses whatever dbm it finds. > > I prefer 2, but is it the right thing for 1.3.23 (I would hope that > thsi would not scrap it)?

Re: Tagging 1.3.23

2002-01-21 Thread Cliff Woolley
On Mon, 21 Jan 2002, Bill Stoddard wrote: > in about 15 minutes... Any idea why apache-1.3/.cvsignore didn't get tagged? I did a spot check of other files (including other .cvsignore's), and they seem okay. --Cliff -- Cliff Woolle

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Joe Orton wrote: > > This will happen if you don't have the db1-devel package installed > (unsurprisingly: if the header isn't there, it isn't detected). If you > do have db1-devel installed, you should find -I/usr/include/db1 in your > CFLAGS... So what's the /usr/include/gdbm/ndbm.h file all a

Re: Tagging 1.3.23

2002-01-21 Thread Victor J. Orlikowski
Problem found, but not resolved. Turns out that find-dbm-lib in helpers looks for ndbm.h in /usr/include/db1 on RH 7. This is provided in the db1-devel package. However, gdbm-devel also provides a ndbm.h, in /usr/include/gdbm. The problem at hand: We are going to have users who want to use mod

Re: Tagging 1.3.23

2002-01-21 Thread Jim Jagielski
I have a feeling that this implies a 1.3.24... The real fix is to include the correct header, or determine if it's even needed. Thomas Eibner wrote: > > On Mon, Jan 21, 2002 at 03:53:31PM -0500, Rodent of Unusual Size wrote: > > "Victor J. Orlikowski" wrote: > > > > > > Argh > > > Not this

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 04:15:25PM -0500, Rodent of Unusual Size wrote: > Thomas Eibner wrote: > > > > ln -s /usr/include/gdbm-ndbm.h /usr/include/ndbm.h in case > > you're running debian and have installed libgdbmg1-dev. > > (If that is the case: debian breakage by default, not apache's fault) >

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Thomas Eibner wrote: > > ln -s /usr/include/gdbm-ndbm.h /usr/include/ndbm.h in case > you're running debian and have installed libgdbmg1-dev. > (If that is the case: debian breakage by default, not apache's fault) A /usr/include/gdbm/ndbm.h file exists. Adding symbolic links all over the /usr/i

S_L_U_A for worker MPM?

2002-01-21 Thread Brian Pane
One of the open items in the STATUS file is: * Performance: Get the SINGLE_LISTEN_UNSERIALIZED_ACCEPT optimization working in worker. prefork's new design for how to notice data on the pod should be sufficient. I'm willing to spend some time this week on this issue, but first, c

Re: Tagging 1.3.23

2002-01-21 Thread Joe Orton
On Mon, Jan 21, 2002 at 03:10:36PM -0500, Ken Coar wrote: > : > gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP >-DUSE_HSREGEX -DUSE_EXPAT -I../../lib/expat-lite -g > -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow `../../apaci` -fpic >-DSHARED_MODULE

Re: WIN32 build

2002-01-21 Thread sterling
On Mon, 21 Jan 2002, Christian Gross wrote: > I think it is great that all of the modules are dynamically loaded in the > latest builds of Apache. But there is a problem, in that the dependencies > of libhttp.dll have not been altered. Hence when building Apache not > everything is built and th

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 03:53:31PM -0500, Rodent of Unusual Size wrote: > "Victor J. Orlikowski" wrote: > > > > Argh > > Not this *again*. > > *Sigh*. > > Which linux distribution? > > RH 7.1. This was building for 1.3.22, so I'm pretty sure > this is something new. I just tried it on my d

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
"Victor J. Orlikowski" wrote: > > Argh > Not this *again*. > *Sigh*. > Which linux distribution? RH 7.1. This was building for 1.3.22, so I'm pretty sure this is something new. -- #kenP-)} Ken Coar, Sanagendamgagwedweinini http://Golux.Com/coar/ Author, developer, opinionist htt

Re: Tagging 1.3.23

2002-01-21 Thread Thomas Eibner
On Mon, Jan 21, 2002 at 03:10:36PM -0500, Rodent of Unusual Size wrote: > Bill Stoddard wrote: > > > > Tagged. > > Breakage: > > CC="gcc" \ > CFLAGS="-g -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow " \ > ./configure --enable-shared=max --enable-module=most > : > make >

Re: cvs commit: apache-1.3/src/include http_protocol.h

2002-01-21 Thread William A. Rowe, Jr.
> wrowe 02/01/21 12:29:12 > > Modified:src/include http_protocol.h > Log: > ap_rprintf is implemented as API_EXPORT() in http_protocol.c. > Therefore, make the prototype and implementation consistant. > > The question remains, why no compiler warning/emit? Because MS

Re: Tagging 1.3.23

2002-01-21 Thread Victor J. Orlikowski
Argh Not this *again*. *Sigh*. Which linux distribution? Victor -- Victor J. Orlikowski | The Wall is Down, But the Threat Remains! == [EMAIL PROTECTED] | [EMAIL PROTECTED] | [EMAIL PROTECTED]

Re: Tagging 1.3.23

2002-01-21 Thread Rodent of Unusual Size
Bill Stoddard wrote: > > Tagged. Breakage: CC="gcc" \ CFLAGS="-g -O2 -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow " \ ./configure --enable-shared=max --enable-module=most : make : gcc -c -I../../os/unix -I../../include -DLINUX=22 -DNO_DBM_REWRITEMAP -DUSE_HSREGEX

Re: Tagging 1.3.23

2002-01-21 Thread Bill Stoddard
Tagged. Jim, Did you want to be RM? If so, take it away. If not, I'll try to roll the tarball tomorrow morning. Bill - Original Message - From: "Bill Stoddard" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, January 21, 2002 2:18 PM Subject: Tagging 1.3.23 > in about 15 min

Tagging 1.3.23

2002-01-21 Thread Bill Stoddard
in about 15 minutes... Bill

Re: WIN32 build

2002-01-21 Thread William A. Rowe, Jr.
Christian, libhttpd.dll runs without any modules. Therefore it's isn't dependent on them. There is a top-level InstallBin project that builds -all- modules. This came up once before. Does the list believe we need an 'intermediate' no-op BuildBin target that will build all the files, wit

WIN32 build

2002-01-21 Thread Christian Gross
I think it is great that all of the modules are dynamically loaded in the latest builds of Apache. But there is a problem, in that the dependencies of libhttp.dll have not been altered. Hence when building Apache not everything is built and then there are version conflicts, etc, etc. While

AddLanguage

2002-01-21 Thread Zvi Har'El
Hi Apache Developers, Comparing the AddLanguage directives in the default configuration for Apache 1.3.22 and the most recent CVS version of Apache 2.0, I noticed some differences. One, which is perhaps OK, is that the extension for Estonian files has been changed from .ee to .et, so now the exte

Re: Tag 1.3.23?

2002-01-21 Thread Bill Stoddard
Upon closer inspection, ap_rprintf() has been NON_STD for ages, so it's fine as is. Not sure why it showed up on Rowe-san's list :-o Bill - Original Message - From: "Bill Stoddard" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, January 21, 2002 10:37 AM Subject: Re: Tag 1.3.23

Re: Tag 1.3.23?

2002-01-21 Thread Bill Stoddard
Looks like ap_rprintf is still broken (or fixed in a way that is binary incompatable :-) I'll fix this now... Bill > No, the original code was, simply, broken. We must find a way to break > compatibility for modules using _those_few_functions_, alone. They are; > > ap_snprintf ap.h - Ok > ap

PHP Apache2Filter crashes on Win32

2002-01-21 Thread Sebastian Bergmann
Here's a backtrace: ap_save_brigade(ap_filter_t * 0x10d57628, apr_bucket_brigade * * 0x10d56004, apr_bucket_brigade * * 0x10a6fe74, apr_pool_t * 0x10d55b30) line 418 + 49 bytes php_output_filter(ap_filter_t * 0x10d57628, apr_bucket_brigade * 0x10d57790) line 350 + 32 bytes ap_pass_brigade(ap_fi

Re: [PATCH] 1.3: changing accept mutex for Cygwin

2002-01-21 Thread Robert Collins
=== - Original Message - From: "Stipe Tolj" <[EMAIL PROTECTED]> To: "Jeff Trawick" <[EMAIL PROTECTED]> Cc: "Robert Collins" <[EMAIL PROTECTED]>; <[EMAIL PROTECTED]> > Ok, I'm going to send a new patch in for that. > > BTW, Robert, what about the pthread-win32 (native) library that has >