Re: URI lossage with ProxyPass

2004-06-26 Thread Dirk-Willem van Gulik
On Sat, 26 Jun 2004, Nick Kew wrote: > On Thu, 17 Jun 2004, Francois-Rene Rideau wrote: > > I've reviewed this in the context of httpd-2.1, and it looks good to me > with essentially the same patch. It works on your testcase, and I'm > 99% satisfied that it doesn't break anything. Ready to com

Flood?

2004-06-26 Thread Lex Yakker
Hi, I notice that the last release of the "flood" utility was in 2002. I had to make some trivial changes to get it to compile with my installation of apache 2.0.49 (include apr_poll.h, add an argument to the call to apr_poll). Now, it compiles but segfaults immediately, even with the example s

Re: PATCH: various mod_proxy issues

2004-06-26 Thread Graham Leggett
Nick Kew wrote: (2) Bug #29554 - URL munging I've ported Francois-Rene Rideau's patch to 2.1, subject to the question over proxy_fixup discussed in my last post. Looking at this issue, I think the real solution is to a) canonicalise all URLS (reverse and forward) for internal Apache use. b) use the

Re: URI lossage with ProxyPass

2004-06-26 Thread Graham Leggett
Nick Kew wrote: Can anyone see why proxy_fixup should not be removed altogether? Proxy fixup seems to do the job of making sure the URL "/%41%42%43" matches "ProxyPass /ABC http://xxx/ABC";, so I don't think it should be removed altogether. The URL that is sent to the backend server however has

Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c util_ldap_cache.c util_ldap_cache.h

2004-06-26 Thread Graham Leggett
[EMAIL PROTECTED] wrote: +#if APR_HAS_SHARED_MEMORY +/* If the cache file already exists then delete it. Otherwise we are + * going to run into problems creating the shared memory. */ +apr_file_remove(st->cache_file, ptemp); +if (st->cache_file) { +

Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c util_ldap_cache.c util_ldap_cache.h

2004-06-26 Thread Brad Nicholes
No, I didn't change anything that would allow for anonymous shared memory. This should probably check for a NULL before calling apr_file_remove(). Brad Brad Nicholes Senior Software Engineer Novell, Inc., the leading provider of Net business solutions http://www.novell.com >>> [EMAIL PROTECT

Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c util_ldap_cache.c util_ldap_cache.h

2004-06-26 Thread Graham Leggett
Brad Nicholes wrote: No, I didn't change anything that would allow for anonymous shared memory. This should probably check for a NULL before calling apr_file_remove(). +apr_file_remove(st->cache_file, ptemp); Will this line segfault if ptempt is NULL? If not, then it should be fine. I

Re: URI lossage with ProxyPass

2004-06-26 Thread Nick Kew
On Sat, 26 Jun 2004, Graham Leggett wrote: > Nick Kew wrote: > > > Can anyone see why proxy_fixup should not be removed altogether? > > Proxy fixup seems to do the job of making sure the URL "/%41%42%43" > matches "ProxyPass /ABC http://xxx/ABC";, so I don't think it should be > removed altogether

Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c util_ldap_cache.c util_ldap_cache.h

2004-06-26 Thread Brad Nicholes
ptemp shouldn't ever be NULL on a post_config, right? I just fixed the code so that it checks for a NULL file name before calling apr_file_remove(). Brad Brad Nicholes Senior Software Engineer Novell, Inc., the leading provider of Net business solutions http://www.novell.com >>> [EMAIL PROT

Re: cvs commit: httpd-2.0/modules/experimental util_ldap.c util_ldap_cache.c util_ldap_cache.h

2004-06-26 Thread Brad Nicholes
This patch should fix the shared memory issues on Linux and Solaris. But this code could use some more review and testing. I would like to get mod_auth_ldap and mod_ldap out of experimental if this proves to stabilize the module. On a related issue, I would also like to backport these patches

Re: Proxy Cookie Support (Bug #10722)

2004-06-26 Thread Dirk-Willem van Gulik
On Fri, 25 Jun 2004, Nick Kew wrote: > OK, that's what I needed to know. I'll still have to modify my patch > slightly to work with yours, but at least it's now clear what's going on. DO make sure that it is still possible for, say, mod_perl or mod_jk to remove/kill a coppy with an expired Set

Re: URI lossage with ProxyPass

2004-06-26 Thread Nick Kew
On Sat, 26 Jun 2004, Graham Leggett wrote: > Nick Kew wrote: > > > Can anyone see why proxy_fixup should not be removed altogether? > > Proxy fixup seems to do the job of making sure the URL "/%41%42%43" > matches "ProxyPass /ABC http://xxx/ABC";, so I don't think it should be > removed altogether