modify request_rec->args

Hello, I have a simple module, with just a quick_hander, it's sole function is to check if there is a specific key=value on the query string, and modify the value, so it gets picked up by a separate module. For example: if "foo=1" is in r->args, then replace it with "foo=0", decline the request

Re: svn commit: r1725307 - /httpd/httpd/trunk/modules/proxy/mod_proxy_hcheck.c

Le 18/01/2016 17:54, j...@apache.org a écrit : Author: jim Date: Mon Jan 18 16:54:12 2016 New Revision: 1725307 URL: http://svn.apache.org/viewvc?rev=1725307=rev Log: simplify and start on concept framework of OPTIONS Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_hcheck.c Modified:

Re: [PATCH] Add "FreeListen" to support IP_FREEBIND

On Fri, Mar 18, 2016 at 9:36 AM, Jan Kaluža wrote: > > I've implemented the way described in that question above ^. Please see the > attached patch and share your opinions. > > The syntax to enable IP_FREEBIND currently is: > > Listen 192.168.0.1:80 http freebind I think we

Re: 2.4.20 Change dsp: Win32-specific build files.

On 03/24/2016 06:05 AM, William A Rowe Jr wrote: > I observed the note below in 2010 when that comment was first made (I > cribbed that comment from 2.2.x checkin). So I now wonder if that note > was based on an Express edition perhaps? Or on an early release - and > MS later added or fixed the

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

On Thu, Mar 24, 2016 at 11:40 AM, Jan Ehrhardt wrote: > William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 09:16:17 > -0500): > >> > http://windows.php.net/downloads/snaps/master/r454ae8a/logs/make-ts-windows-vc14-x64-r454ae8a.html > > > >It's been a *long* time,

Re: mod_status Total Accesses with 2.4.20

Fix in 2.4.x: r1736465 *) mod_http2: fix for missing score board updates on request count, fix for memory leak on slave connection reuse. Happy Easter, Stefan > Am 24.03.2016 um 17:17 schrieb Stefan Eissing : > > Yes, that is how it worked and

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 09:16:17 -0500): >> http://windows.php.net/downloads/snaps/master/r454ae8a/logs/make-ts-windows-vc14-x64-r454ae8a.html > >It's been a *long* time, and I know it hadn't been that well maintained >for non-Linux (non-BSD) target

Re: mod_status Total Accesses with 2.4.20

Yes, that is how it worked and should soon work again. > Am 24.03.2016 um 16:57 schrieb William A Rowe Jr : > > The inner http2 response to the outer h1 upgrade request remains a > single request IMHO. Within that h2 collection of streams, each of > the subsequent h2

Re: mod_status Total Accesses with 2.4.20

Should the scoreboard really account for both h2 and inner h1 connections in the same counter? It seems to me that they should be distinguish-ed/able. On Thu, Mar 24, 2016 at 3:56 PM, Stefan Eissing wrote: > Found it. Slave connections cleared their scoreboard

Re: mod_status Total Accesses with 2.4.20

The inner http2 response to the outer h1 upgrade request remains a single request IMHO. Within that h2 collection of streams, each of the subsequent h2 requests should then be counted individually. On Thu, Mar 24, 2016 at 10:54 AM, Yann Ylavic wrote: > Should the

Re: mod_status Total Accesses with 2.4.20

Like to see it in 2.4.20, because my reporting is broken. -Original Message- From: Stefan Eissing Sent: Thursday, March 24, 2016 3:56 PM To: dev@httpd.apache.org Subject: ** Re: mod_status Total Accesses with 2.4.20 Found it. Slave connections cleared their scoreboard handle too

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

On Thu, Mar 24, 2016 at 3:40 PM, William A Rowe Jr wrote: > On Thu, Mar 24, 2016 at 9:31 AM, Yann Ylavic wrote: >> >> Not to talk about they very personal conception of sizeof(long) on >> 64bit systems... > > You might be too young to remember when

Re: mod_status Total Accesses with 2.4.20

Found it. Slave connections cleared their scoreboard handle too early (and unneccessary) so that the update simply did not happen. Fix will be in trunk/2.4.x soonish.. > Am 24.03.2016 um 14:05 schrieb Stefan Eissing : > > Quick test: http/2 connections are not

Re: [VOTE] access control for dynamic hosts

Hello Yann, I guess this question is for me, not the doc :) Yep! [...] So, finally, mentioning that *any* ip/host-based authz should be combined with other authz/authn (SSL certificates, credentials schemes, ...) for stronger requirements may be the way to go. I agree that combining

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

On Thu, Mar 24, 2016 at 9:31 AM, Yann Ylavic wrote: > >> nghttp2_session.c(160) : warning C4996: 'vsnprintf': This function or > >> variable may be unsafe. Consider using vsnprintf_s instead. To disable > >> deprecation, use _CRT_SECURE_NO_WARNINGS. > > [sarcasm] >

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

>> nghttp2_session.c(160) : warning C4996: 'vsnprintf': This function or >> variable may be unsafe. Consider using vsnprintf_s instead. To disable >> deprecation, use _CRT_SECURE_NO_WARNINGS. [sarcasm] Microsoft being unable to provide a safe vsnprintf() in the first place and now warning every

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

On Thu, Mar 24, 2016 at 8:49 AM, Jan Ehrhardt wrote: > William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 07:58:45 > -0500): > >Precisely, Jan. We don't know where these truncation errors lead - do > they > >portentially open security holes? They cetainly

Re: mod_http2 on Windows (was: Re: Status for 2.4.20)

William A Rowe Jr in gmane.comp.apache.devel (Thu, 24 Mar 2016 07:58:45 -0500): >Precisely, Jan. We don't know where these truncation errors lead - do they >portentially open security holes? They cetainly interefere with serving >huge resources such as .iso images. > >When I first tripped over

Re: [VOTE] access control for dynamic hosts

Hi Fabien, On Wed, Mar 23, 2016 at 6:12 PM, wrote: > > How about adding something like: > > From a security perspective, getting access to a protected page is somehow > easier with "forward-dns" because the attacker needs only to control the DNS > for the domain, while they

Re: apr_global_mutex_create vs apr_proc_mutex_create

proc_mutex can only be used to block on a cross process event. It can be used in a threaded server, but cannot be held in multiple threads, you might use it to block in a single thread queue per-process. Thread_mutex will not block between processes, this is used for the mutex-per-process logic

Re: apr_global_mutex_create vs apr_proc_mutex_create

proc_mutex can only be used to block on a cross process event. It can be used in a threaded server, but cannot be held in multiple threads, you might use it to block in a single thread queue per-process. Thread_mutex will not block between processes, this is used for the mutex-per-process logic

Re: mod_status Total Accesses with 2.4.20

Quick test: http/2 connections are not counted here. checking... > Am 24.03.2016 um 14:02 schrieb Steffen : > > Using server-status?auto. > > Now since running with 2.4.20-dev my statistics graphs shows less Total > Accesses. > > Is it not counting http/1.1 or http/2

Re: 2.4.20 Change dsp: Win32-specific build files.

Steffan, I was plesantly surprised when I tested this on an early VS2015 preview and the conversion was still supported. I observed the note below in 2010 when that comment was first made (I cribbed that comment from 2.2.x checkin). So I now wonder if that note was based on an Express edition

mod_status Total Accesses with 2.4.20

Using server-status?auto. Now since running with 2.4.20-dev my statistics graphs shows less Total Accesses. Is it not counting http/1.1 or http/2 in Total Accesses ? Steffen

mod_http2 on Windows (was: Re: Status for 2.4.20)

On Mar 23, 2016 22:19, "Jan Ehrhardt" wrote: > > William A Rowe Jr in gmane.comp.apache.devel (Wed, 23 Mar 2016 08:00:19 > -0500): > >On Wed, Mar 23, 2016 at 7:42 AM, William A Rowe Jr > >wrote: > > > >> Again, a C89 regression breaking the candidate, but

Re: svn commit: r1736217 - in /httpd/httpd/trunk/include: ap_hooks.h ap_mmn.h

On 03/24/2016 12:59 PM, Jeff Trawick wrote: > On Thu, Mar 24, 2016 at 5:56 AM, Ruediger Pluem > wrote: > > > > On 03/22/2016 06:38 PM, yla...@apache.org > wrote: > > Author: ylavic > > Date: Tue Mar 22

Re: svn commit: r1736217 - in /httpd/httpd/trunk/include: ap_hooks.h ap_mmn.h

On Thu, Mar 24, 2016 at 5:56 AM, Ruediger Pluem wrote: > > > On 03/22/2016 06:38 PM, yla...@apache.org wrote: > > Author: ylavic > > Date: Tue Mar 22 17:38:20 2016 > > New Revision: 1736217 > > > > URL: http://svn.apache.org/viewvc?rev=1736217=rev > > Log: > > core: Add

Re: svn commit: r1736217 - in /httpd/httpd/trunk/include: ap_hooks.h ap_mmn.h

On Thu, Mar 24, 2016 at 10:56 AM, Ruediger Pluem wrote: > > You forgot the real bump :-) Thanks :) fixed in r1736428.

Re: Status for 2.4.20

Tell you what. Let's delay for 1 week and I'll take up a T on Monday April 4th.

Re: 2.4.20 Change dsp: Win32-specific build files.

Good now. Little note: Visual Studio 2010 users cannot convert our .dsp files. That's not true, I convert them. Steffen From: William A Rowe Jr Sent: Wednesday, March 23, 2016 9:23 PM To: httpd Subject: * Re: 2.4.20 Change dsp: Win32-specific build files. On Wed, Mar 23, 2016 at

Re: svn commit: r1736217 - in /httpd/httpd/trunk/include: ap_hooks.h ap_mmn.h

On 03/22/2016 06:38 PM, yla...@apache.org wrote: > Author: ylavic > Date: Tue Mar 22 17:38:20 2016 > New Revision: 1736217 > > URL: http://svn.apache.org/viewvc?rev=1736217=rev > Log: > core: Add missing AP_IMPLEMENT_OPTIONAL_HOOK_RUN_FIRST. > > Modified: >

Re: Questions on writing logging stmts in httpd

Hi! Don't have a lot of context but I found some answers in the httpd code (see inline comments): 2016-03-24 2:07 GMT+01:00 Tianyin Xu : > I find a previous post, > http://marc.info/?t=14057931881=1=2 > > which helped answer the 2nd question, basically, "anything more

Re: apr_global_mutex_create vs apr_proc_mutex_create

+httpd-dev@ Hello! 2016-03-23 21:49 GMT+01:00 Ali Shah : > Hi Module maintainers, > > I'm writing a simple apache module and I'd like to aggregate some > statistics. > I saw an example module that does this ( > https://wiki.apache.org/httpd/ModuleLife) using shared memory. >