Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread William A Rowe Jr
CR LF are 0D 37 in EBCDIC. Those have protocol specific meanings. NL in EBCDIC or ASCII has no specific meaning, it is opaque text. It's not an HTTP CTRL char. However, wouldn't we need to escape it in a shell cmd? We might want to consider escaping many C1 ctrls in the shell. On Jul 30, 2016 8:

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-07-30 Thread William A Rowe Jr
On Jul 30, 2016 4:36 PM, "Yann Ylavic" wrote: > > On Sat, Jul 30, 2016 at 11:22 PM, Yann Ylavic wrote: > > On Fri, Jul 29, 2016 at 6:24 PM, wrote: > >> Author: wrowe > >> Date: Fri Jul 29 16:24:14 2016 > >> New Revision: 1754548 > >> > >> URL: http://svn.apache.org/viewvc?rev=1754548&view=rev >

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 11:22 PM, Yann Ylavic wrote: > On Fri, Jul 29, 2016 at 6:24 PM, wrote: >> Author: wrowe >> Date: Fri Jul 29 16:24:14 2016 >> New Revision: 1754548 >> >> URL: http://svn.apache.org/viewvc?rev=1754548&view=rev >> Log: >> Strictly observe spec on obs-fold >> >> Modified: >>

Re: svn commit: r1754548 - /httpd/httpd/trunk/server/protocol.c

2016-07-30 Thread Yann Ylavic
On Fri, Jul 29, 2016 at 6:24 PM, wrote: > Author: wrowe > Date: Fri Jul 29 16:24:14 2016 > New Revision: 1754548 > > URL: http://svn.apache.org/viewvc?rev=1754548&view=rev > Log: > Strictly observe spec on obs-fold > > Modified: > httpd/httpd/trunk/server/protocol.c [] > > me

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 7:28 PM, Eric Covener wrote: > On Sat, Jul 30, 2016 at 1:11 PM, Yann Ylavic wrote: >> But I mean we pre-suppose in gen_test_char that for T_HTTP_TOKEN_STOP >> and T_HTTP_CTRLS, TEST_CHAR (in util.c) will be called with ascii >> bytes (because they come from the network in

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread William A Rowe Jr
On Jul 30, 2016 10:15 AM, "Yann Ylavic" wrote: > > On Sat, Jul 30, 2016 at 12:00 AM, wrote: > > > > Looking for someone with an EBCDIC environment to post the output of > > the test_char.h generated file for verification. > > > [] > > > > +#if APR_CHARSET_EBCDIC > > +/* See util.c for complete e

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Eric Covener
On Sat, Jul 30, 2016 at 1:11 PM, Yann Ylavic wrote: > But I mean we pre-suppose in gen_test_char that for T_HTTP_TOKEN_STOP > and T_HTTP_CTRLS, TEST_CHAR (in util.c) will be called with ascii > bytes (because they come from the network in ap_getline_core(), not > from ap_getline() where a2e actual

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 6:35 PM, Eric Covener wrote: > On Sat, Jul 30, 2016 at 12:28 PM, Yann Ylavic wrote: >> On Sat, Jul 30, 2016 at 5:37 PM, Yann Ylavic wrote: >>> >>> (I'm a bit lost on where are/aren't EBCDIC octets here). >> >> Mostly, I understand that T_HTTP_TOKEN_STOP and T_HTTP_CTRLS s

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Eric Covener
On Sat, Jul 30, 2016 at 12:28 PM, Yann Ylavic wrote: > On Sat, Jul 30, 2016 at 5:37 PM, Yann Ylavic wrote: >> >> (I'm a bit lost on where are/aren't EBCDIC octets here). > > Mostly, I understand that T_HTTP_TOKEN_STOP and T_HTTP_CTRLS should be > used with ascii chars because they come from test_

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 5:37 PM, Yann Ylavic wrote: > > (I'm a bit lost on where are/aren't EBCDIC octets here). Mostly, I understand that T_HTTP_TOKEN_STOP and T_HTTP_CTRLS should be used with ascii chars because they come from test_isascii_equiv() (and due to the fact they are called from ap_ge

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Eric Covener
On Sat, Jul 30, 2016 at 11:37 AM, Yann Ylavic wrote: > Or, if that's needed (for all "ctype" functions), why don't we: > ap_xlate_proto_from_ascii(&c, 1); > at the very beginning of each loop and be done with it? > > Is it because we are mixing quoted string literals (natively EBCDIC) > an

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread William A Rowe Jr
On Jul 30, 2016 9:41 AM, "Jim Jagielski" wrote: > > If we use this table more than once and we depend on consistency > between them then we should make it a shared extern. Therein lies the rub... For this particular case, requiring crossplat compilation and execution, gen_test_char.c is standalon

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 5:15 PM, Yann Ylavic wrote: > On Sat, Jul 30, 2016 at 12:00 AM, wrote: >> >> Looking for someone with an EBCDIC environment to post the output of >> the test_char.h generated file for verification. >> > [] >> >> +#if APR_CHARSET_EBCDIC >> +/* See util.c for complete expla

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Yann Ylavic
On Sat, Jul 30, 2016 at 12:00 AM, wrote: > > Looking for someone with an EBCDIC environment to post the output of > the test_char.h generated file for verification. > [] > > +#if APR_CHARSET_EBCDIC > +/* See util.c for complete explanation of this table */ > +static const short ucharmap[] = { We

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Jim Jagielski
If we use this table more than once and we depend on consistency between them then we should make it a shared extern. > On Jul 29, 2016, at 6:00 PM, wr...@apache.org wrote: > > Author: wrowe > Date: Fri Jul 29 22:00:52 2016 > New Revision: 1754579 > > URL: http://svn.apache.org/viewvc?rev=175457

Re: svn commit: r1754579 - /httpd/httpd/trunk/server/gen_test_char.c

2016-07-30 Thread Eric Covener
What's going on with 0x15 (newline in ebcdic)? It is a control char that we map to 0x85 but it doesn't look right int he generated table. On Fri, Jul 29, 2016 at 9:37 PM, Eric Covener wrote: > from rev below: > http://people.apache.org/~covener/test_char.h > > > > On Fri, Jul 29, 2016 at 6:00 PM