= path; *pc; pc++) {
> > -if (apr_iscntrl(*pc)) {
> > +from_handler = apr_table_get(r->notes, "proxy-sethandler") != NULL;
>
> Why do we need the from_handler variable?
Axed in r1921237.
Thanks;
Yann.
irectory_walk(r);
> > - }
> > +if (rconf && rconf->need_dirwalk) {
> > +char *saved_filename = r->filename;
> > +r->filename = r->uri;
>
> Why not using the result of the below Strip proxy: prefixes for r->filename?
> In case of a Rewriterule I guess r->uri and
> r->filename could be fundamentally different path wise.
Did this in r1921238, as well as setting up the expected request
fields for ap_directory_walk().
Regards;
Yann.
On Wed, Sep 11, 2024 at 5:59 PM Yann Ylavic wrote:
>
> On Mon, Sep 9, 2024 at 12:20 PM Ruediger Pluem wrote:
> >
> > Looks like there is no further feedback on the below.
> > @Yann: Care to commit
> > https://bz.apache.org/bugzilla/attachment.cgi?id=39832 ?
&g
On Mon, Sep 9, 2024 at 12:20 PM Ruediger Pluem wrote:
>
> Looks like there is no further feedback on the below.
> @Yann: Care to commit https://bz.apache.org/bugzilla/attachment.cgi?id=39832 ?
> I would then commit my stuff below.
Done (r1920570).
I suppose we need a single backp
not on the fast path here and I don't think one
more strcspn() on an empty string is going to hurt compared to the
expansion work. We could break out earlier in other places in this
loop too, not worth complicating the code imho.
Thanks for reviewing!
Regards;
Yann.
On Fri, Aug 2, 2024 at 3:26 PM Eric Covener wrote:
>
> On Fri, Aug 2, 2024 at 9:10 AM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> > >
> > > > Yeah, if not under DocumentRoot I don't see how ProxyPass could wo
On Fri, Aug 2, 2024 at 3:10 PM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
> >
> > > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > > but SetHandler should since it's following the whole request
>
On Fri, Aug 2, 2024 at 1:06 PM Eric Covener wrote:
>
> > Yeah, if not under DocumentRoot I don't see how ProxyPass could work,
> > but SetHandler should since it's following the whole request
> > processing to resolve the filesystem r->filename?
>
> In the examples I am seeing spot-checking google
On Fri, Aug 2, 2024 at 11:33 AM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 6:02 AM Eric Covener wrote:
> >
> > On Thu, Aug 1, 2024 at 9:22 PM Yann Ylavic wrote:
> > > >
> > > > For this how about this attached patch?
> > > > With it I
On Fri, Aug 2, 2024 at 6:02 AM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 9:22 PM Yann Ylavic wrote:
> > >
> > > For this how about this attached patch?
> > > With it I can get the correct env vars (I think), and since we'd not
> > > send a &quo
On Fri, Aug 2, 2024 at 5:22 AM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 9:12 PM Yann Ylavic wrote:
> >
> > On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> > >
> > > So we probably should keep encoding r->filename with ProxyPass, and
> > &
On Fri, Aug 2, 2024 at 3:12 AM Yann Ylavic wrote:
>
> On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
> >
> > So we probably should keep encoding r->filename with ProxyPass, and
> > come back to my previous patch which skipped it only for SetHandler?
> > Po
On Fri, Aug 2, 2024 at 12:18 AM Yann Ylavic wrote:
>
> So we probably should keep encoding r->filename with ProxyPass, and
> come back to my previous patch which skipped it only for SetHandler?
> Possibly FCGI_MAY_BE_FPM() only too because for "ProxyFCGIBackendType
> GEN
On Thu, Aug 1, 2024 at 9:53 PM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 2:47 PM Yann Ylavic wrote:
> >
> > On Thu, Aug 1, 2024 at 7:57 PM Eric Covener wrote:
> > >
> > > On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
> > > >
> >
On Thu, Aug 1, 2024 at 7:57 PM Eric Covener wrote:
>
> On Thu, Aug 1, 2024 at 1:37 PM Yann Ylavic wrote:
> >
> > On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
> > >
> > > But does it leave the splitting problem with decoded %3F?
> >
> >
On Thu, Aug 1, 2024 at 5:51 PM Eric Covener wrote:
>
> But does it leave the splitting problem with decoded %3F?
Yeah but I'm not sure that it's _our_ problem, a "proxy:" r->filename
does never contain the query-string in the first place, so any '?' in
there (hence in SCRIPT_FILENAME) is part of
On Wed, Jul 31, 2024 at 7:34 PM Eric Covener wrote:
>
> On Tue, Jul 23, 2024 at 5:35 AM Yann Ylavic wrote:
> >
> > On Wed, Jul 17, 2024 at 6:22 PM wrote:
> > >
> > > https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
> > >
> > > --- Com
On Wed, Jul 31, 2024 at 6:57 PM wrote:
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=69235
>
> --- Comment #2 from Yann Ylavic ---
> Created attachment 39832
> --> https://bz.apache.org/bugzilla/attachment.cgi?id=39832&action=edit
> mod_proxy fixup after mod_
On Fri, Jul 26, 2024 at 6:10 PM Joe Orton wrote:
>
> On Fri, Jul 26, 2024 at 03:52:40PM -, yla...@apache.org wrote:
> > Author: ylavic
> > Date: Fri Jul 26 15:52:40 2024
> > New Revision: 1919534
> >
> > URL: http://svn.apache.org/viewvc?rev=1919534&view=rev
> > Log:
> > Is that what's wrong i
On Wed, Jul 17, 2024 at 6:22 PM wrote:
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=69203
>
> --- Comment #6 from Yann Ylavic ---
> Created attachment 39817
> --> https://bz.apache.org/bugzilla/attachment.cgi?id=39817&action=edit
> Proxy FCGI nocanon from Set
On Mon, Jul 15, 2024 at 2:14 PM Eric Covener wrote:
>
> I would like to call a VOTE over the next few days to release
> this candidate tarball httpd-2.4.62-rc1 as 2.4.62:
[X] +1: It's not just good, it's good enough!
Tested on Debian stable and testing/sid, all passes.
Sigs/checksums OK.
Thanks
On Thu, Jul 11, 2024 at 4:19 PM wrote:
> --- httpd/httpd/branches/2.4.x/STATUS (original)
> +++ httpd/httpd/branches/2.4.x/STATUS Thu Jul 11 14:19:08 2024
> @@ -166,6 +166,34 @@ PATCHES ACCEPTED TO BACKPORT FROM TRUNK:
> +
> + *) mod_http2: sync with github module. Add async handling
> + on n
> https://patch-diff.githubusercontent.com/raw/apache/httpd/pull/460.diff
> -PR: https://github.com/apache/httpd/pull/460
> -+1: rpluem, covener, ylavic
> -covener: needs manual MMN bump after backport
The added functions are in "proxy_util.h" which is a private header,
do we need a MMN bump?
Regards;
Yann.
On Fri, Jul 5, 2024 at 5:59 PM Yann Ylavic wrote:
>
> On Fri, Jul 5, 2024 at 5:08 PM Ruediger Pluem wrote:
> >
> > On 7/5/24 4:09 PM, Stefan Eissing via dev wrote:
> > >
> > > The patches look good to me. I have not tested them as I have no old
> > &
On Fri, Jul 5, 2024 at 5:08 PM Ruediger Pluem wrote:
>
> On 7/5/24 4:09 PM, Stefan Eissing via dev wrote:
> >
> >
> >> Am 05.07.2024 um 15:44 schrieb Ruediger Pluem :
> >>
> >>
> >>
> >> On 7/5/24 3:40 PM, Yann Ylavic
On Fri, Jul 5, 2024 at 3:35 PM Yann Ylavic wrote:
>
> On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote:
> >
> > >>>> md_crypt.c: In function 'md_cert_get_ct_scts':
> > >>>> md_crypt.c:2071:5: error: unknown type name 'SCT'
On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote:
>
> md_crypt.c: In function 'md_cert_get_ct_scts':
> md_crypt.c:2071:5: error: unknown type name 'SCT'
> SCT *sct_handle;
>
> This one is caused by r1918195 in >= 2.4.60. Before r1918195 OPENSSL_NO_CT
> was defined when opens
On Fri, Jul 5, 2024 at 3:16 PM Yann Ylavic wrote:
>
> On Fri, Jul 5, 2024 at 3:05 PM Ruediger Pluem wrote:
> >
> >
> >
> > On 7/5/24 2:14 PM, Ruediger Pluem wrote:
> > >
> > >
> > > On 7/5/24 2:11 PM, Ruediger Pluem wrote:
> > &
ssl 1.0.2.
This probably comes from r1913912 (2.4.x) which backported r1913616
(trunk) which changed EVP_PKEY_get1_RSA() => EVP_PKEY_get0_RSA(), the
former being probably available in < 1.1.1.
So the check for using EVP_PKEY_get{0,1}_RSA() or the new openssl >= 3
API should probably be something like:
#if OPENSSL_VERSION_NUMBER < 0x10101000L
RSA *rsa = EVP_PKEY_get1_RSA(pkey->pkey);
if (rsa) {
const char *ret;
const BIGNUM *e;
RSA_get0_key(rsa, NULL, &e, NULL);
ret = bn64(e, p);
RSA_free(rsa);
return ret;
}
#elif OPENSSL_VERSION_NUMBER < 0x3000L
...
#else
...
#endif
?
Regards;
Yann.
On Wed, Jul 3, 2024 at 4:40 PM Ruediger Pluem wrote:
>
> On 7/3/24 3:23 PM, Yann Ylavic wrote:
> > On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
> >>
> >> Thanks for the intense review. I hope I captured all stuff in the below.
> >
> > Thanks for
On Wed, Jul 3, 2024 at 4:40 PM Ruediger Pluem wrote:
>
> On 7/3/24 3:23 PM, Yann Ylavic wrote:
> > On Wed, Jul 3, 2024 at 2:34 PM Ruediger Pluem wrote:
> >>
> >> Thanks for the intense review. I hope I captured all stuff in the below.
> >
> > Thanks for
l_len >= MODSSL_IO_DUMP_MAX
> + ? MODSSL_IO_DUMP_MAX
> + : actual_len);
So "int dump_len" here should be (more than) enough?
> +ssl_io_data_dump(c, s, argp, dump_len);
> +}
> }
> else {
> ap_log_cserror(APLOG_MARK, APLOG_TRACE4, 0, c, s,
> -"%s: I/O error, %d bytes expected to %s on BIO#%pp [mem:
> %pp]",
> -MODSSL_LIBRARY_NAME, argi,
> +"%s: I/O error, %" APR_SIZE_T_FMT
> +" bytes expected to %s on BIO#%pp [mem: %pp]",
> +MODSSL_LIBRARY_NAME, requested_len,
> (cmd == (BIO_CB_WRITE|BIO_CB_RETURN) ? "write" : "read"),
> bio, argp);
> }
Regards;
Yann.
On Wed, Jul 3, 2024 at 11:01 AM Yann Ylavic wrote:
>
> On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
> >
> > On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
> > >
> > > On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > > > On Tue, Jul 2,
On Wed, Jul 3, 2024 at 10:57 AM Yann Ylavic wrote:
>
> On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
> >
> > On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
> > >>
> > >> Updat
On Wed, Jul 3, 2024 at 8:58 AM Ruediger Pluem wrote:
>
> On 7/3/24 2:59 AM, Yann Ylavic wrote:
> > On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
> >>
> >> Updated patch.
[]
> >> const char *dump = "";
> >
On Tue, Jul 2, 2024 at 10:57 AM Ruediger Pluem wrote:
>
> On 7/1/24 3:01 PM, Ruediger Pluem wrote:
> >
> >
> > On 6/27/24 3:48 PM, Ruediger Pluem wrote:
> >>
> >>
> >> On 6/27/24 12:47 PM, Yann Ylavic wrote:
> >>> On Thu, Jun 27, 20
On Tue, Jul 2, 2024 at 3:45 PM Eric Covener wrote:
>
> Hi all,
>
> Please find below the proposed release tarball and signatures:
>
> https://dist.apache.org/repos/dist/dev/httpd/
>
> === Different from template ===
> I would like to call an expedited VOTE (due to regression in 2.4.60)
> over the
On Thu, Jun 27, 2024 at 12:38 PM Yann Ylavic wrote:
>
> On Thu, Jun 27, 2024 at 12:07 PM Ruediger Pluem wrote:
> >
> > How about the below? I am yet undecided if I should follow the below
> > approach to have
> > two completely separate callbacks depending
uch shared code as possible. Thoughts?
Hm, I wouldn't duplicate the whole thing depending on openssl version.
Something like the attached maybe? modssl_io_cb() will just consider
up to APR_INT32_MAX bytes, more shouldn't happen anyway and it's more
than enough for debug logs..
On Wed, Jun 26, 2024 at 7:10 PM Eric Covener wrote:
>
> I would like to call a VOTE over the next few days to release
> this candidate tarball httpd-2.4.60-rc4 as 2.4.60:
[X] +1: It's not just good, it's good enough!
Tested on Debian stable and testing/sid, all passes.
Sigs/checksums OK too.
Gr
; else if (!(p->flags & (RULEFLAG_PROXY | RULEFLAG_FORCEREDIRECT))) {
> /* Not an absolute URI-path and the scheme (if any) is unknown,
Maybe the test for !AP_IS_SLASH() could be moved up (i.e.
!AP_IS_SLASH() && !is_absolute_path()) if we don't want to add a '/'
before anything Windows considers a slash too?
Regards;
Yann.
x27; && argp != NULL)
> > ssl_io_data_dump(c, s, argp, rc);
>
> Similar to above. I think we need to use len here in case of OpenSSL 3.
> If my findings are seen as correct I could work on a patch :-).
I think you are right from the man page of BIO_set_callback{,_ex}(),
please go ahead ;)
Regards;
Yann.
r (line 1427).
I simplified ap_proxy_fixup_uds_filename() in r1918647, it takes only
the request now and those who want the new url can use r->filename + 6
(like ap_proxy_pre_request() does).
>
> > +rc = ap_proxy_fixup_uds_filename(r, &uri);
> > +if (rc <= OK) {
> > rc = proxy_fixup(r);
> > }
> > if (rc != OK) {
> > -return rc;
> > +r->filename = old_filename;
> > +r->proxyreq = 0;
> > }
> > -}
Regards;
Yann.
On Wed, Jun 26, 2024 at 12:02 AM Helmut K. C. Tessarek
wrote:
>
> I tried with rc2, since rc3 is not available yet.
>
> Same issue.
Should be fixed by
https://github.com/apache/httpd/commit/6937b985ae112de0ad60f12a3cb522b608a4d501.diff
Regards;
Yann.
On Wed, Jun 26, 2024 at 2:02 AM Yann Ylavic wrote:
>
> On Tue, Jun 25, 2024 at 7:29 PM wrote:
> >
> > Author: covener
> > Date: Tue Jun 25 17:29:06 2024
> > New Revision: 1918606
> >
> > URL: http://svn.apache.org/viewvc?rev=1918606&view=rev
>
On Tue, Jun 25, 2024 at 7:29 PM wrote:
>
> Author: covener
> Date: Tue Jun 25 17:29:06 2024
> New Revision: 1918606
>
> URL: http://svn.apache.org/viewvc?rev=1918606&view=rev
> Log:
> validate hostname
Seems this broke something in the http2 tests. Will have a look tomorrow.
On Wed, Jun 26, 2024 at 1:17 AM Eric Covener wrote:
>
> On Tue, Jun 25, 2024 at 7:03 PM Yann Ylavic wrote:
> >
> > On Wed, Jun 26, 2024 at 12:37 AM Eric Covener wrote:
> > >
> > > > The attached might work, currently testing but sending early if you
>
On Wed, Jun 26, 2024 at 12:37 AM Eric Covener wrote:
>
> > The attached might work, currently testing but sending early if you
> > want to try too.
>
> looks like proxy: is stripped off after the new call and needs to be
> added back in?
Yeah, the new call to ap_proxy_fixup_uds_filename() should
On Tue, Jun 25, 2024 at 11:35 PM Eric Covener wrote:
>
> On Tue, Jun 25, 2024 at 5:22 PM Eric Covener wrote:
> >
> > On Tue, Jun 25, 2024 at 5:06 PM Eric Covener wrote:
> > >
> > > On Tue, Jun 25, 2024 at 4:35 PM Helmut K. C. Tessarek
> > > wrote:
> > > >
> > > > On 2024-06-25 02:53, Ruediger P
On Tue, Jun 25, 2024 at 2:50 PM Eric Covener wrote:
>
> - whether backing out
> https://github.com/apache/httpd/commit/9494aa8d52e3c263bc0413b77ac8a73b0d524388.diff
> from the candidate helps?
I'm not sure r1918553 made it to rc1, did it?
On Wed, Jun 5, 2024 at 5:24 PM Eric Covener wrote:
>
> Please make sure your backport proposals/votes are in.
Fix for addressTTL (PR 454) is missing one vote, would be nice to fix
it in 2.4.60.
Thanks!
On Wed, Jun 19, 2024 at 4:34 PM Yann Ylavic wrote:
>
> On Wed, Jun 19, 2024 at 4:23 PM Joe Orton wrote:
> >
> > On Wed, Jun 19, 2024 at 03:41:06PM +0200, Yann Ylavic wrote:
> > > Done in PR 454, will update STATUS too.
> >
> > In the path where keep_addr_a
On Wed, Jun 19, 2024 at 4:23 PM Joe Orton wrote:
>
> On Wed, Jun 19, 2024 at 03:41:06PM +0200, Yann Ylavic wrote:
> > Done in PR 454, will update STATUS too.
>
> In the path where keep_addr_alive and keep_conn_alive are both false,
> conn_cleanup(conn) is run, which sets conn
On Wed, Jun 19, 2024 at 2:52 PM Joe Orton wrote:
>
> On Wed, Jun 19, 2024 at 02:04:20PM +0200, Yann Ylavic wrote:
> > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote:
> > > As far as I read the code it does not.
> > >
> >
On Wed, Jun 19, 2024 at 2:49 PM Ruediger Pluem wrote:
>
> On 6/19/24 2:04 PM, Yann Ylavic wrote:
>
> > On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote:
> >>
> >> As far as I read the code it does not.
> >>
> >> https://github.com/apach
On Wed, Jun 19, 2024 at 1:00 PM Ruediger Pluem wrote:
>
> On 6/19/24 12:00 PM, Yann Ylavic wrote:
> > On Wed, Jun 19, 2024 at 9:07 AM Ruediger Pluem wrote:
> >>
> >> On 6/18/24 4:20 PM, yla...@apache.org wrote:
> >>>
> >>> +/*
not
simply release the old conn->address without leaving a dangling
pointer in sock->remote_addr. That's why conn->[address->]addr is
reattached to conn->scpool to be cleaned up only when the socket is
closed.
[2] Well, not really the same because we'll walk all the
conn->addr[->next] to find one that works, so the conn->addr ==
remote_addr test should actually be a loop to find one of the
conn->addr[->next]. Will fix this!
[3] From worker_address_resolve() it's actually a subpool of
worker->cp->dns_pool since worker->s->is_address_reusable here.
Regards;
Yann.
On Tue, May 28, 2024 at 4:06 PM Stefan Eissing via dev
wrote:
>
>
>
> > Am 28.05.2024 um 15:45 schrieb Yann Ylavic :
> >
> > On Tue, May 28, 2024 at 12:47 PM Stefan Eissing via dev
> > wrote:
> >>
> >>> Am 27.05.2024 um 14:08 schrieb Yann Yla
On Tue, May 28, 2024 at 12:47 PM Stefan Eissing via dev
wrote:
>
> > Am 27.05.2024 um 14:08 schrieb Yann Ylavic :
> >
> > Per our discussion the other day, if you want to avoid c1 connections
> > to be killed by mpm_event on high load in this case, I think you can
>
H2_SESSION_ST_CLEANUP:
--
c->clogging_input_filters = 1 will tell the MPM to always call
process_connection() hooks after the WRITE_COMPLETION state did the
poll(), rather than entering the (killable) keepalive state.
Looks like the correct workaround with current mpm_event..
Regards;
Yann.
h2 workers would still be there but be prepared to be
SUSPENDED too (i.e. when the MPM calls back mod_proxy_http after
poll()ing it will be from a MPM worker thread, not an h2 worker)?
Well, enough (whishful?) thoughts for tonight (-_-)
Cheers;
Yann.
On Mon, May 13, 2024 at 9:02 PM Yann Ylavic wrote:
>
> On Mon, May 13, 2024 at 6:31 PM Stefan Eissing wrote:
> >
> > > Am 13.05.2024 um 17:41 schrieb Yann Ylavic :
> > >
> > > On Mon, May 13, 2024 at 1:32 PM Stefan Eissing
> > >>
> > >
On Mon, May 13, 2024 at 6:31 PM Stefan Eissing wrote:
>
> > Am 13.05.2024 um 17:41 schrieb Yann Ylavic :
> >
> > On Mon, May 13, 2024 at 1:32 PM Stefan Eissing
> >>
> >> With the change in PR 280, we return on being flow blocked. The
> >> response
sh before close) and CONN_STATE_POLL_READ/POLL_WRITE/POLL_RW which
would be how a process_connection hook would return to the MPM just
for poll()ing.
Regards;
Yann.
are about
> picking/configuring among many LDAP libraries.
FWIW I tried some time ago to avoid the very same kind of complexity
with apr_crypto vs TLS/SSL library but it was -1'd.
I would prefer direct linking of those libraries too, databases are a
special case which we shouldn't generalize for every library used by
APR (IMHO).
Regards;
Yann.
; > +rv = apr_pollset_create_ex(&event_pollset, pollset_size + 1,
> > pruntime,
>
> You explained this in the commit message above (thanks), but I think it would
> be good to add a comment
> here in the code why +1 is added to the pollset_size to have the rational at
> hand when reading the code.
Good point, done in r1916929 for both event and worker.
Regards;
Yann.
On Sat, Apr 6, 2024 at 10:46 AM jean-frederic clere wrote:
>
> It seems pthread_kill(t, 0) returns 0 even the thread t has exited...
> older version of fedora will return 3 (I have tried fc28)
>
> The small example (taken from the internet) seems to behave like httpd
> reporting running threads th
we would apply Yann's patch for the worker mpm.
Thanks for testing, now in r1916926.
Finally I did not use the "good methods" (APR_POLLSET_NODEFAULT) to
create the pollset (like in mpm_event) but left the pollset
implementation to be selected as before. It's now using
APR_POLLSET_WAKEABLE though to help wakeup_listener().
Regards;
Yann.
nitely
apr_pollset_poll() at this point, and since there is no pollset wakeup
in mpm_worker I don't think that wakeup_listener() can help here.
So maybe we need to add an apr_pollset_wakeup() in wakeup_listener()
too, like in mpm_event t
quot; somewhere in the -I[nclude] path?
Because DAV_WALKTYPE_TOLERANT is well defined in the new "mod_dav.h"
(of 2.4.59) which is also correctly #include'd in
"modules\dav\fs\repos.c"..
Regards;
Yann.
On Wed, Apr 3, 2024 at 2:26 PM Eric Covener wrote:
>
> I would like to call a SHORTENED VOTE to release
> this candidate tarball httpd-2.4.59-rc1 as 2.4.59:
[X] +1: It's not just good, it's good enough!
All good from my testing on debian(s).
Thanks Eric!
On Tue, Mar 12, 2024 at 4:08 PM Eric Covener wrote:
>
> below + POD wakeup
>
> Did not force the path yet where the listener is started (or fold in
> the scoreboard change )
+1, maybe ap_queue_term() rather than ap_queue_interrupt_all().
On Tue, Mar 12, 2024 at 3:30 PM Eric Covener wrote:
>
> On Tue, Mar 12, 2024 at 10:19 AM Yann Ylavic wrote:
> >
> > On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote:
> > >
> > > On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote:
> > >
On Tue, Mar 12, 2024 at 3:03 PM Eric Covener wrote:
>
> On Tue, Mar 12, 2024 at 8:48 AM Yann Ylavic wrote:
> >
> > Maybe it could be:
> > if (threads_created) {
>
> not listener_started?
>
> threads_started>0 could just mean we had no scoreboar
On Tue, Mar 12, 2024 at 1:46 PM Yann Ylavic wrote:
>
> Maybe it could be:
We should probably prevent the listener from starting too, like:
> if (threads_created) {
> resource_shortage = 1;
> signal_threads(ST_GRACEFUL);
listener_started = 1; /* do
e this option is silly, if we are going to nearly immediately
> clear pchild and call exit().
Maybe it could be:
if (threads_created) {
resource_shortage = 1;
signal_threads(ST_GRACEFUL);
break;
}
clean_child_exit(APEXIT_CHILDSICK);
?
Regards;
Yann.
On Fri, Mar 1, 2024 at 2:12 PM Joe Orton wrote:
>
> On Fri, Mar 01, 2024 at 01:52:15PM +0100, Yann Ylavic wrote:
> > On Fri, Mar 1, 2024 at 1:42 PM Yann Ylavic wrote:
> > >
> > > On Fri, Mar 1, 2024 at 1:24 PM Joe Orton wrote:
> > > >
> > > &
On Fri, Mar 1, 2024 at 1:42 PM Yann Ylavic wrote:
>
> On Fri, Mar 1, 2024 at 1:24 PM Joe Orton wrote:
> >
> > Also - I guess the note about *not* accepting PKCS#8 format keys in
> > https://httpd.apache.org/docs/2.4/mod/mod_ssl.html#sslproxymachinecertificatefi
On Fri, Mar 1, 2024 at 1:42 PM Yann Ylavic wrote:
>
> On Fri, Mar 1, 2024 at 1:24 PM Joe Orton wrote:
> >
> > Do you still want that
> > TestSSLCA.pm change merged?
>
> I think it can be useful for those who test httpd with openssl1 still
> (not mainta
On Fri, Mar 1, 2024 at 1:24 PM Joe Orton wrote:
>
> On Fri, Mar 01, 2024 at 12:59:10PM +0100, Yann Ylavic wrote:
> > On Fri, Mar 1, 2024 at 11:15 AM wrote:
> > >
> > > Author: jorton
> > > Date: Fri Mar 1 10:15:13 2024
> > > New Revision: 19160
On Fri, Mar 1, 2024 at 12:59 PM Yann Ylavic wrote:
>
> On Fri, Mar 1, 2024 at 11:15 AM wrote:
> >
> > Author: jorton
> > Date: Fri Mar 1 10:15:13 2024
> > New Revision: 1916068
> >
> > URL: http://svn.apache.org/viewvc?rev=1916068&view=rev
>
7.
I had to modify Apache-Test too when running the perl test framework
with openssl >= 3.0 and proposed a patch here [1] (not enough karma to
commit on perl.a.o).
It was an issue with mod_proxy's client certs IIRC, which r1916067 is
possibly fixing too, but just in case you are still fi
t; mc->szCryptoDevice = NULL;
> in ssl_cmd_SSLCryptoDevice().
Thanks, I suppose this happens with the latest OpenSSL versions where
they removed the ENGINE API completely?
Fixed in r1915889 hopefully (should probably be backported to 2.4.x
since r1913815 made it there already).
Regards;
Yann.
ose patches
after the last release (if needed, possibly in a patches/ directory or
so), but I'm not willing to engage more than that by myself.
Regards;
Yann.
On Thu, Feb 15, 2024 at 5:12 AM Joe Schaefer wrote:
>
> I gave you beta males an entire year
His Alpha Most Serene Highness is too kind to us..
> to find an excuse for completely boning the modperl user community for no
> good reason,
_You_ did that (boning the modperl user community), by spitt
+1
On Thu, Jan 25, 2024 at 3:45 PM Eric Covener wrote:
>
> I wouldn't mind move/rename to README.md
>
> On Thu, Jan 25, 2024, 10:40 AM Joe Orton wrote:
>>
>> On Thu, Jan 25, 2024 at 08:12:24AM +0100, Ruediger Pluem wrote:
>> > Tried it in r1915391 and it seems to work. Not sure if there are
>> >
On Wed, Jan 24, 2024 at 5:07 PM wrote:
>
> On Wed, 2024-01-24 at 17:01 +0100, Yann Ylavic wrote:
> > On Wed, Jan 24, 2024 at 4:56 PM Mads Toftum wrote:
> > >
> > > On Wed, Jan 24, 2024 at 10:06:43AM -0500, rbo...@rcbowen.com wrote:
> > > > I've
x27;d ask first.
>
> I don't have strong opinions on this, but we'll end up with a READNE
> that's less readable for those not viewing it through github.
Maybe we could keep the line breaks as before for the text to keep it
as readable as before w/o a markdown viewer?
Regards;
Yann.
On Mon, Jan 8, 2024 at 5:54 PM Ruediger Pluem wrote:
>
> On 1/8/24 1:37 PM, Yann Ylavic wrote:
> >
> > As noted in v2 we have an issue here by "losing" the beginning of the
> > value on recursion:
> > /* XXX: recursing by us
On Mon, Jan 8, 2024 at 10:49 AM Ruediger Pluem wrote:
>
> On 1/5/24 3:08 PM, Yann Ylavic wrote:
> >
> > process_regexp.diff
> >
> > Index: modules/metadata/mod_headers.c
> > ===
> > --- m
et-Cookie ^(.*)$
> > $1;HttpOnly;secure
>
> edit* just makes no sense at all here when you are capturing/replacing
> the entire string and will loop by definition.
Maybe we should avoid infinite recursion in any case, like in the
atta
On Wed, Dec 20, 2023 at 5:50 PM Joe Orton wrote:
>
> On Wed, 20 Dec 2023, 16:30 Yann Ylavic, wrote:
>>
>> For the last-chunk, I think we need
>
> I think that's not necessary because in the special case eos=flush, in the
> normal case flush is NULL. Actually t
On Wed, Dec 20, 2023 at 5:20 PM Yann Ylavic wrote:
>
> On Wed, Dec 20, 2023 at 4:56 PM wrote:
> >
> > Author: jorton
> > Date: Wed Dec 20 15:56:15 2023
> > New Revision: 1914804
> >
> > URL: http://svn.apache.org/viewvc?rev=1914804&view=
> -else if (flush != NULL) {
> +if (flush != NULL) {
> APR_BUCKET_INSERT_BEFORE(flush, e);
> }
> + else if (eos != NULL) {
> +APR_BUCKET_INSERT_BEFORE(eos, e);
> +}
> else {
> APR_BRIGADE_INSERT_TAIL(b, e);
> }
Regards;
Yann.
On Wed, Dec 20, 2023 at 4:57 PM Joe Orton wrote:
>
> On Wed, Dec 20, 2023 at 04:24:32PM +0100, Ruediger Pluem wrote:
> > On 12/20/23 4:08 PM, Yann Ylavic wrote:
> > > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote:
> > >> https://github.com/apache/httpd/pull/4
On Wed, Dec 20, 2023 at 4:45 PM Yann Ylavic wrote:
>
> On Wed, Dec 20, 2023 at 4:18 PM Eric Norris wrote:
> >
> > On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote:
> > >
> > > So I think what the POC or mod_php should be doing is [FLUSH EOS] or
> &g
On Wed, Dec 20, 2023 at 4:18 PM Eric Norris wrote:
>
> On Wed, Dec 20, 2023 at 10:09 AM Yann Ylavic wrote:
> >
> > So I think what the POC or mod_php should be doing is [FLUSH EOS] or
> > something might not work in the chain sooner or later?
>
> I believe that
ast in ap_http_chunk_filter() this won't work since, as Joe said,
everything after EOS being dropped breaks c) and the filter not
removing itself after EOS breaks d).
So I think what the POC or mod_php should be doing is [FLUSH EOS] or
something might not work in the chain sooner or later?
Regards;
Yann.
On Wed, Dec 6, 2023 at 11:05 AM Yann Ylavic wrote:
>
> On Tue, Dec 5, 2023 at 4:26 PM wrote:
> >
> > Author: jorton
> > Date: Tue Dec 5 15:26:22 2023
> > New Revision: 1914365
> >
> > URL: http://svn.apache.org/viewvc?rev=1914365&view=rev
> >
pubkey, privkey);
#endif
#if MODSSL_HAVE_ENGINE_API
if (rv == APR_ENOTIMPL)
rv = modssl_load_keypair_engine(s, p, vhostid, certid, keyid,
pubkey, privkey);
#endif
return rv;
and somehow make modssl_load_keypair_store() return APR_ENOTIMPL when
there is no store to get the cert/key from?
Regards;
Yann.
1 - 100 of 1086 matches
Mail list logo
