Bill Stoddard wrote:
It's obvious we are not using the return either way.
But without the cast, someone not conversant with the details
won't know it normally returns a value; they might think it's
a void function.
Less is better so dump the cast :-)
I think the cast improves
[moving this back on-list]
On Wed, 19 Sep 2001, Aaron Bannert wrote:
On Wed, Sep 19, 2001 at 11:45:57AM -0400, Cliff Woolley wrote:
Anyway, I'm of mixed feelings about the (void) thing, since sometimes we
do in fact get bugs from having thrown away a return value that we
shouldn't have
On Wed, Sep 19, 2001 at 06:47:31PM -, [EMAIL PROTECTED] wrote:
trawick 01/09/19 11:47:31
Modified:server/mpm/worker worker.c
Log:
if we're gonna trash the connection due to a queue overflow, at the
very least we should close the socket and write a log message (mostly
On Wednesday 19 September 2001 12:11 pm, Aaron Bannert wrote:
On Wed, Sep 19, 2001 at 06:47:31PM -, [EMAIL PROTECTED] wrote:
trawick 01/09/19 11:47:31
Modified:server/mpm/worker worker.c
Log:
if we're gonna trash the connection due to a queue overflow, at the
very
Aaron Bannert [EMAIL PROTECTED] writes:
On Wed, Sep 19, 2001 at 06:47:31PM -, [EMAIL PROTECTED] wrote:
trawick 01/09/19 11:47:31
Modified:server/mpm/worker worker.c
Log:
if we're gonna trash the connection due to a queue overflow, at the
very least we should
[EMAIL PROTECTED] writes:
+++ worker.c2001/09/19 18:47:31 1.26
@@ -659,7 +659,16 @@
signal_workers();
}
if (csd != NULL) {
-ap_queue_push(worker_queue, csd, ptrans);
+rv =
Aaron Bannert wrote:
2) How long should the queue be? Should we just set some arbitrary constant,
defined in mpm_default.h, or should we come up with some heuristic?
Ideally, you would have 0 connections on the queue most of the time.
Then, just before some worker gets done with its last
On Wed, Sep 19, 2001 at 12:18:31PM -0700, Ryan Bloom wrote:
On Wednesday 19 September 2001 12:11 pm, Aaron Bannert wrote:
So I have two questions:
1) How do we send back that error?
You can't. There is no way to determine how busy the other processes are.
I'm not sure if simply
Ryan Bloom [EMAIL PROTECTED] writes:
On Wednesday 19 September 2001 01:21 pm, Greg Ames wrote:
For now, ThreadsPerChild might be fine. I'd feel a little better about
some small constant, like 5 or 10. But the code does need to learn to
deal with queue full more gracefully.
Guys,
Aaron Bannert [EMAIL PROTECTED] writes:
On Wed, Sep 19, 2001 at 12:18:31PM -0700, Ryan Bloom wrote:
On Wednesday 19 September 2001 12:11 pm, Aaron Bannert wrote:
So I have two questions:
1) How do we send back that error?
You can't. There is no way to determine how busy the
On Wednesday 19 September 2001 01:59 pm, Jeff Trawick wrote:
Ryan Bloom [EMAIL PROTECTED] writes:
On Wednesday 19 September 2001 01:21 pm, Greg Ames wrote:
For now, ThreadsPerChild might be fine. I'd feel a little better about
some small constant, like 5 or 10. But the code does need
On Wednesday 19 September 2001 02:05 pm, Ryan Bloom wrote:
On Wednesday 19 September 2001 01:59 pm, Jeff Trawick wrote:
Ryan Bloom [EMAIL PROTECTED] writes:
On Wednesday 19 September 2001 01:21 pm, Greg Ames wrote:
For now, ThreadsPerChild might be fine. I'd feel a little better
On Wed, Sep 19, 2001 at 02:03:13PM -0700, Ryan Bloom wrote:
On Wednesday 19 September 2001 01:49 pm, Aaron Bannert wrote:
I'm not sure if simply closing the socket is the right answer either.
Is there a more appropriate error code? Server Temporarily Unavailable
or whatnot?
I'd agree
I probably should have mentioned in the comment that the reason I made
the comment was that it broke when I changed it to 0. :)
And I assume the first question in my comment is true? That is:
ap_threads_per_child includes the listener thread
-aaron
On Sat, Aug 25, 2001 at 06:29:49PM -0700,
This will break things. We will no longer be keeping track of the listener, which
is a bad thing. I will fix this later this weekend, but the worker MPM is broken
now.
Ryan
On Saturday 25 August 2001 18:17, [EMAIL PROTECTED] wrote:
dougm 01/08/25 18:17:32
Modified:
On Saturday 25 August 2001 18:40, [EMAIL PROTECTED] wrote:
On Sat, 25 Aug 2001, Ryan Bloom wrote:
This will break things. We will no longer be keeping track of the
listener, which is a bad thing. I will fix this later this weekend, but
the worker MPM is broken now.
its working for me.
101 - 116 of 116 matches
Mail list logo
