Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 10:40 AM, Graham Leggett via dev wrote: > Hi all, > > The attached patch is a current work in progress patch for httpd-trunk to use > the new apr_ldap API that just landing in APR. > > The highlights: > > - Complete replacement of the previous API. > - Will work against apr-2

Re: [WIP] mod_authnz_ldap / mod_ldap support for APR v2 LDAP API

2024-04-19 Thread Ruediger Pluem
On 4/18/24 3:21 PM, Joe Orton wrote: > On Thu, Apr 18, 2024 at 09:40:21AM +0100, Graham Leggett via dev wrote: >> Hi all, >> >> The attached patch is a current work in progress patch for httpd-trunk to >> use the new apr_ldap API that just landing in APR. >> >> The highlights: >> >> - Complete

Re: svn commit: r1916926 - in /httpd/httpd/trunk: changes-entries/worker_exit.txt server/mpm/worker/worker.c

2024-04-12 Thread Ruediger Pluem
On 4/12/24 1:02 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 12 11:02:31 2024 > New Revision: 1916926 > > URL: http://svn.apache.org/viewvc?rev=1916926=rev > Log: > mpm_worker: Fix AH00045 about children processes not terminating timely. > > *

Re: svn commit: r1916925 - /httpd/httpd/trunk/server/mpm/event/event.c

2024-04-12 Thread Ruediger Pluem
On 4/12/24 12:35 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Apr 12 10:35:10 2024 > New Revision: 1916925 > > URL: http://svn.apache.org/viewvc?rev=1916925=rev > Log: > mpm_event: Simplify pollset "good methods" vs APR_POLLSET_WAKEABLE. > > *

Re: Fwd: [Bug 68872] New: xmlhttprequest.onprogress behavior changed after updated to 2.4.59

2024-04-08 Thread Ruediger Pluem
On 4/8/24 1:47 PM, Eric Covener wrote: > Any concerns with documenting the ap_trust_cgilike_cl variable in e.g. > https://httpd.apache.org/docs/2.4/env.html ? Not from my side. Regards Rüdiger

Re: pytest results for 2.4.59

2024-04-04 Thread Ruediger Pluem
On 4/5/24 12:59 AM, Rainer Jung wrote: > I think I fixed all test failures, hopefully in the correct way. More eyes > welcome. > > I have a few additional sporadic ERRORS: > > A] ERROR during teardown check for log file errors or warnings (twice): > > 04.04.2024 21:14:42.205465

Re: [VOTE] Release httpd-2.4.59-rc1 as httpd-2.4.59

2024-04-04 Thread Ruediger Pluem
Are you sure that you did not use outdated headers somehow? DAV_WALKTYPE_TOLERANT is defined in modules/dav/main/mod_dav.h Regards Rüdiger On 4/4/24 12:49 PM, Steffen Land wrote: > -1 > Get an error: > > Error C2065 'DAV_WALKTYPE_TOLERANT': undeclared identifier mod_dav_fs >

Re: mod_systemd: refactor to get rid of libsystemd dependency?

2024-04-04 Thread Ruediger Pluem
On 4/3/24 4:32 PM, Joe Orton wrote: > On Tue, Apr 02, 2024 at 12:25:40PM +0200, Rainer Jung wrote: >> Hi there, >> >> in the light of the recent xz attack I was wondering, whether we should also >> reduce our library dependencies by no longer using sd_notify() in >> mod_systemd (thus loading

Re: libapreq subproject roll call

2024-02-16 Thread Ruediger Pluem
On 2/16/24 2:10 PM, Eric Covener wrote: >> Will apreq 2.18 still be released? > > I think we should, but we need someone to do the release work and 3 > active PMC members to approve it. Prior to the recent activity, the > subproject was essentially unchanged and unreleased for 10 years (with

Re: reset in proxy_balancer_method

2024-02-15 Thread Ruediger Pluem
On 2/15/24 9:28 AM, jean-frederic clere wrote: > On 2/14/24 20:54, Ruediger Pluem wrote: >> >> >> On 2/14/24 3:45 PM, jean-frederic clere wrote: >>> On 2/14/24 08:19, Ruediger Pluem wrote: >>>> >>>> >>>> On 2/9/24 11:59

Re: reset in proxy_balancer_method

2024-02-14 Thread Ruediger Pluem
On 2/14/24 3:45 PM, jean-frederic clere wrote: > On 2/14/24 08:19, Ruediger Pluem wrote: >> >> >> On 2/9/24 11:59 AM, jean-frederic clere wrote: >>> Hi, >>> >>> I have noted to the reset() clean up too much in the balancers

Re: using changes-entries or write in CHANGES directly

2024-02-14 Thread Ruediger Pluem
On 2/14/24 10:53 AM, jean-frederic clere wrote: > Hi, > > Are there any rules to use changes-entries or write directly in CHANGES? > IMHO change-entries is preferred. See http://svn.apache.org/viewvc/httpd/httpd/trunk/README.CHANGES?view=markup I just noticed that we probably need a

Re: reset in proxy_balancer_method

2024-02-13 Thread Ruediger Pluem
On 2/9/24 11:59 AM, jean-frederic clere wrote: > Hi, > > I have noted to the reset() clean up too much in the balancers: > mod_lbmethod_bybusyness.c for example does: > +++ >     for (i = 0; i < balancer->workers->nelts; i++, worker++) { >     (*worker)->s->lbstatus = 0; >    

Re: svn commit: r1915534 - in /httpd/httpd/branches/2.4.x: ./ modules/cache/mod_socache_shmcb.c modules/proxy/balancers/mod_lbmethod_heartbeat.c os/unix/unixd.c server/buildmark.c server/scoreboard.c

2024-02-02 Thread Ruediger Pluem
On 2/2/24 12:50 PM, jor...@apache.org wrote: > Author: jorton > Date: Fri Feb 2 11:50:07 2024 > New Revision: 1915534 > > URL: http://svn.apache.org/viewvc?rev=1915534=rev > Log: > Merge r1909450 from trunk: > > Make sources build with latest clang version > > Submitted by: icing > Reviewed

Re: svn commit: r1915516 - in /httpd/httpd/branches/2.4.x: ./ CHANGES configure.in docs/man/htpasswd.1 support/htpasswd.c support/passwd_common.c support/passwd_common.h

2024-02-01 Thread Ruediger Pluem
On 2/1/24 5:54 PM, jor...@apache.org wrote: > Author: jorton > Date: Thu Feb 1 16:54:40 2024 > New Revision: 1915516 > > URL: http://svn.apache.org/viewvc?rev=1915516=rev > Log: > Merge r1861793, r1862612, r1862724, r1877251, r1907672 from trunk: > > Add support for SHA-2 crypt() algorithm

Re: svn commit: r1915411 - /httpd/httpd/trunk/CMakeLists.txt

2024-01-26 Thread Ruediger Pluem
On 1/26/24 4:07 PM, jean-frederic clere wrote: > On 1/26/24 15:57, Ruediger Pluem wrote: >> There seem to be unrelated changes to mod_proxy_hcheck in the below. Is this >> intended? > > Well mod_proxy_hchech was missing... I was planning another commit. > > Sh

Re: svn commit: r1915411 - /httpd/httpd/trunk/CMakeLists.txt

2024-01-26 Thread Ruediger Pluem
There seem to be unrelated changes to mod_proxy_hcheck in the below. Is this intended? Regards Rüdiger On 1/26/24 3:25 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Fri Jan 26 14:25:15 2024 > New Revision: 1915411 > > URL: http://svn.apache.org/viewvc?rev=1915411=rev > Log: > ab

Re: PR #363

2024-01-24 Thread Ruediger Pluem
On 1/25/24 8:04 AM, Ruediger Pluem wrote: > > > On 1/24/24 11:31 PM, Rich Bowen wrote: >> Well, it turns out that in order for this to actually work, we would need to >> rename README to README.md, so I'm inclined to revert >> this change unless someone thinks

Re: PR #363

2024-01-24 Thread Ruediger Pluem
On 1/24/24 11:31 PM, Rich Bowen wrote: > Well, it turns out that in order for this to actually work, we would need to > rename README to README.md, so I'm inclined to revert > this change unless someone thinks differently. How about using a symlink? Keep README and create a README.md symlink

Re: New type of spam bugzilla entries

2024-01-15 Thread Ruediger Pluem
On 1/12/24 1:22 PM, Eric Covener wrote: > On Fri, Jan 12, 2024 at 3:22 AM Ruediger Pluem wrote: >> >> Recently we seem to have new types of SPAM entries in Bugzilla. Instead of >> adding the SPAM message directly they look >> more like real bug reports / comments w

New type of spam bugzilla entries

2024-01-12 Thread Ruediger Pluem
Recently we seem to have new types of SPAM entries in Bugzilla. Instead of adding the SPAM message directly they look more like real bug reports / comments with some context / relation to httpd or even the specific bug (maybe AI generated) but then contain SPAM links. Examples:

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2024-01-11 Thread Ruediger Pluem
On 11/28/23 10:29 PM, Yann Ylavic wrote: > > Tried something in https://github.com/apache/httpd/pull/396 > WDYT? Looks good. Thanks. Regards Rüdiger

Re: process_regexp bug, infinite recursion

2024-01-08 Thread Ruediger Pluem
On 1/8/24 1:37 PM, Yann Ylavic wrote: > On Mon, Jan 8, 2024 at 10:49 AM Ruediger Pluem wrote: >> >> On 1/5/24 3:08 PM, Yann Ylavic wrote: >>> >>> process_regexp.diff >>>

Re: Module file access problem

2024-01-08 Thread Ruediger Pluem
On 12/25/23 9:55 AM, MIIM via dev wrote: > > I apologize in advance for posting this question to the development > forum, but unfortunately the modules-development list is dead > according to the list server. > > > I have a module attempting to write a log file -- > not one of the Apache log

Re: process_regexp bug, infinite recursion

2024-01-08 Thread Ruediger Pluem
On 1/5/24 3:08 PM, Yann Ylavic wrote: > On Fri, Jan 5, 2024 at 3:11 AM Eric Covener wrote: >> On Thu, Jan 4, 2024 at 9:04 PM Jason Pyeron wrote: >>> I am having some issue searching Bugzilla for any issue involving >>> process_regexp in mod_headers.c . >>> >>> It finds nothing, so I am

Re: [PATCH] mod_deflate: remove filter after seeing EOS

2023-12-20 Thread Ruediger Pluem
On 12/20/23 4:08 PM, Yann Ylavic wrote: > On Wed, Dec 20, 2023 at 2:40 PM Joe Orton wrote: >> >> I was surprised this made a difference to the behaviour on the wire. It >> seems like the chunk filter has suboptimal behaviour here. If you take >> an output brigade like either: >> >> a) [HEAP

Re: svn commit: r1914045 - in /httpd/httpd/trunk: changes-entries/ab-source-address.txt docs/man/ab.1 support/ab.c

2023-12-19 Thread Ruediger Pluem
On 12/19/23 4:44 PM, Joe Orton wrote: > On Wed, Nov 22, 2023 at 05:19:50PM -, minf...@apache.org wrote: >> Author: minfrin >> Date: Wed Nov 22 17:19:49 2023 >> New Revision: 1914045 >> >> URL: http://svn.apache.org/viewvc?rev=1914045=rev >> Log: >> Add an option to specify a source address.

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Ruediger Pluem
On 11/24/23 5:41 PM, Graham Leggett via dev wrote: > On 24 Nov 2023, at 14:25, Ruediger Pluem wrote: > >>> +            req->dn = dn; >> >> Don't we need to save the vals as well? > > We do - and we also need to apr_pstrdup() the dn to be consistent w

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-24 Thread Ruediger Pluem
On 11/24/23 10:59 AM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 5:47 PM Ruediger Pluem wrote: >> >> On 11/23/23 5:05 PM, Yann Ylavic wrote: >>> On Thu, Nov 23, 2023 at 4:46 PM Yann Ylavic wrote: >>>> >>>> On Thu, Nov 23, 2023 at 4:17 PM Rue

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-24 Thread Ruediger Pluem
On 11/24/23 10:45 AM, Graham Leggett via dev wrote: > >   > >          /* Make sure that the filtered search returned a single dn */ > >          if (result == LDAP_SUCCESS && dn) { > > +            req->dn = dn; Don't we need to save the vals as well? Index:

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 11/23/23 5:05 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 4:46 PM Yann Ylavic wrote: >> >> On Thu, Nov 23, 2023 at 4:17 PM Ruediger Pluem wrote: >>> >>> On 11/23/23 3:53 PM, Yann Ylavic wrote: >>> I am asking because I guess

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 11/23/23 3:53 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 12:11 PM Ruediger Pluem wrote: >> >> On 9/11/23 3:50 PM, jfcl...@apache.org wrote: >>> Author: jfclere >>> Date: Mon Sep 11 13:50:21 2023 >>> New Revision: 1912245 >>> &g

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 2:28 PM, Yann Ylavic wrote: > On Thu, Nov 23, 2023 at 1:33 PM Ruediger Pluem wrote: >> >> >> >> On 11/23/23 12:52 PM, Graham Leggett via dev wrote: >>> On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: >>> >>>>> -if (

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 12:52 PM, Graham Leggett via dev wrote: > On 23 Nov 2023, at 11:25, Ruediger Pluem wrote: > >>> -    if (req->dn == NULL || !*req->dn) { >>> -    ap_log_rerror(APLOG_MARK, APLOG_DEBUG, 0, r, APLOGNO(02636) >>> -  &q

Re: svn commit: r1914067 - in /httpd/httpd/trunk: changes-entries/ldap-optimise.txt modules/aaa/mod_authnz_ldap.c

2023-11-23 Thread Ruediger Pluem
On 11/23/23 11:22 AM, minf...@apache.org wrote: > Author: minfrin > Date: Thu Nov 23 10:22:58 2023 > New Revision: 1914067 > > URL: http://svn.apache.org/viewvc?rev=1914067=rev > Log: > Optimise handling LDAP authorization where LDAP was not used > previously for LDAP authentication. > >

Re: svn commit: r1912245 - in /httpd/httpd/trunk/modules/proxy: balancers/mod_lbmethod_bybusyness.c mod_proxy_balancer.c proxy_util.c proxy_util.h

2023-11-23 Thread Ruediger Pluem
On 9/11/23 3:50 PM, jfcl...@apache.org wrote: > Author: jfclere > Date: Mon Sep 11 13:50:21 2023 > New Revision: 1912245 > > URL: http://svn.apache.org/viewvc?rev=1912245=rev > Log: > Arrange the bybusyness logic and prevent bad busy values > this closes #383 > > Modified: >

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 4:19 PM, Graham Leggett via dev wrote: > On 20 Nov 2023, at 15:10, Ruediger Pluem wrote: > >> Revisiting this again. I guess the below patch should fix it. >> I assume that only the checking on req != NULL is relevant. >> r->user and req->dn do not

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 4:05 PM, Yann Ylavic wrote: > On Mon, Nov 20, 2023 at 3:46 PM Yann Ylavic wrote: >> >> On Mon, Nov 20, 2023 at 2:33 PM Yann Ylavic wrote: >>> >>> On Mon, Nov 20, 2023 at 1:57 PM Graham Leggett via dev >>> wrote: >>>>

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 3:46 PM, Yann Ylavic wrote: > On Mon, Nov 20, 2023 at 2:33 PM Yann Ylavic wrote: >> >> On Mon, Nov 20, 2023 at 1:57 PM Graham Leggett via dev >> wrote: >>> >>> On 20 Nov 2023, at 12:26, Ruediger Pluem wrote: >>> >>> Or we

Re: svn commit: r1913977 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/20/23 1:07 PM, yla...@apache.org wrote: > Author: ylavic > Date: Mon Nov 20 12:07:11 2023 > New Revision: 1913977 > > URL: http://svn.apache.org/viewvc?rev=1913977=rev > Log: > mod_authnz_ldap: Follow up to r1913962: r->user not used in > ldapsearch_check_authorization(). > > >

Re: svn commit: r1913962 - /httpd/httpd/trunk/modules/aaa/mod_authnz_ldap.c

2023-11-20 Thread Ruediger Pluem
On 11/19/23 11:45 AM, minf...@apache.org wrote: > Author: minfrin > Date: Sun Nov 19 10:45:05 2023 > New Revision: 1913962 > > URL: http://svn.apache.org/viewvc?rev=1913962=rev > Log: > Apply earlier fix to the ldapsearch case: > > Arrange for backend LDAP connections to be returned > to the

Re: svn commit: r1912459 - in /httpd/httpd/trunk: include/ modules/proxy/

2023-11-02 Thread Ruediger Pluem
On 11/2/23 1:47 PM, Yann Ylavic wrote: > On Sat, Sep 30, 2023 at 7:19 PM Ruediger Pluem wrote: >> >> On 9/21/23 3:15 PM, yla...@apache.org wrote: >> >>> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) >>> +++ httpd/httpd/trunk/modules/prox

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x:./modules/http2/h2.h

2023-10-17 Thread Ruediger Pluem
If you revert r1913027, r1913024, r1913006, hence --- modules/http2/h2.h (revision 1913024) +++ modules/http2/h2.h (revision 1913006) @@ -20,8 +20,6 @@ #include #include -#include - struct h2_session; struct h2_stream; @@ -41,9 +39,7 @@ #define H2_USE_POLLFD_FROM_CONN 0 #endif +#if

Re: svn commit: r1913028 - /httpd/httpd/tags/2.4.58-rc2-candidate/

2023-10-16 Thread Ruediger Pluem
Windows 64 bit is fine? Regards Rüdiger On 10/16/23 3:52 PM, SteffenAL wrote: > No go. All other modules fine, only mod_http2 error. > > Recap: > > On windows 32: > > Generating Code... > h2_ws.h > C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax > error: missing ';'

Re: svn commit: r1913006 - in /httpd/httpd/branches/2.4.x: ./modules/http2/h2.h

2023-10-16 Thread Ruediger Pluem
On 10/16/23 3:18 PM, Stefan Eissing via dev wrote: > >> Am 16.10.2023 um 15:12 schrieb SteffenAL : >> >> checkout. >> >> Looks like h2_ws.h : >> >> Generating Code... >> h2_ws.h >> C:\VS17\Win32\httpd-2.4\modules\http2\h2.h(173,17): error C2143: syntax >> error: missing ';' before '*' >>

Re: [VOTE] Release httpd-2.4.58-rc2 as httpd-2.4.58

2023-10-16 Thread Ruediger Pluem
I am sorry, but #include "apr_encode.h" is still unconditional in h2_ws.c in 2.4.x. Fixed in r1913027. Regards Rüdiger On 10/16/23 3:31 PM, Stefan Eissing via dev wrote: > Hi all, > > after some hickups with getting the new WebSockets support to > compile on Joe's old computers, we try

Re: svn commit: r1913019 - in /httpd/httpd/trunk/modules/http2: h2_session.c h2_ws.c

2023-10-16 Thread Ruediger Pluem
On 10/16/23 2:38 PM, Stefan Eissing via dev wrote: > > >> Am 16.10.2023 um 14:28 schrieb jor...@apache.org: >> >> Author: jorton >> Date: Mon Oct 16 12:28:13 2023 >> New Revision: 1913019 >> >> URL: http://svn.apache.org/viewvc?rev=1913019=rev >> Log: >> Further h2 compile fixes: >> >> *

Re: [PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Ruediger Pluem
On 10/16/23 2:38 PM, Joe Orton wrote: > BTW is modules/http2 really CTR for 2.4.x? STATUS says only > mod_proxy_http2 is. > > Anyway: I am +1 for r1913005 and r1913019 for 2.4.x, latter was > sufficient to get 2.4 building on RHEL8 again (if only we had a CI to do > this, oh...). I am also

Re: [PATCH] fix mod_h2 with older nghttp2

2023-10-16 Thread Ruediger Pluem
I will do. Regards Rüdiger On 10/16/23 1:13 PM, Stefan Eissing via dev wrote: > I added that patch to trunk and merged it into 2.4.x. > > I'll make another release candidate soonish. Someone wants to merge the back > ports idling in STATUS? > > Cheers, > Stefan > >> Am 16.10.2023 um 12:55

Re: [VOTE] Release httpd-2.4.58-rc1 as httpd-2.4.58

2023-10-16 Thread Ruediger Pluem
First of all thanks for RM. It looks to me that we have 2 accepted backports in the STATUS that have not been merged. This seems unfortunate. Regards Rüdiger On 10/16/23 12:07 PM, Stefan Eissing via dev wrote: > Hi all, > > Please find below the proposed release tarball and signatures: > >

Re: svn commit: r1912459 - in /httpd/httpd/trunk: include/ modules/proxy/

2023-09-30 Thread Ruediger Pluem
On 9/21/23 3:15 PM, yla...@apache.org wrote: > Author: ylavic > Date: Thu Sep 21 13:15:35 2023 > New Revision: 1912459 > > URL: http://svn.apache.org/viewvc?rev=1912459=rev > Log: > mod_proxy: Handle backend address renewal with address_ttl= parameter. > > Define a new proxy_address struct

Re: svn commit: r1912181 - /httpd/httpd/branches/2.4.x/STATUS

2023-09-08 Thread Ruediger Pluem
On 9/8/23 9:43 AM, ic...@apache.org wrote: > Author: icing > Date: Fri Sep 8 07:43:17 2023 > New Revision: 1912181 > > URL: http://svn.apache.org/viewvc?rev=1912181=rev > Log: > back port proposal > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified:

Re: svn commit: r1911908 - /httpd/httpd/branches/2.4.x/STATUS

2023-08-25 Thread Ruediger Pluem
On 8/25/23 9:52 AM, jor...@apache.org wrote: > Author: jorton > Date: Fri Aug 25 07:52:31 2023 > New Revision: 1911908 > > URL: http://svn.apache.org/viewvc?rev=1911908=rev > Log: > Update and reset. > > Modified: > httpd/httpd/branches/2.4.x/STATUS > > Modified:

Re: release?

2023-08-23 Thread Ruediger Pluem
On 8/17/23 1:42 PM, Stefan Eissing via dev wrote: > How are people feeling about another release? > > Since I have tons of bugfixes in 2.4.x and some pending features to port > back, I offer to RM this. > > We have 5 items in 2.4.x/STATUS which lack votes. Would be nice if people > could

Re: 2.4.x fails to compile

2023-08-22 Thread Ruediger Pluem
On 8/22/23 1:48 PM, Stefan Eissing via dev wrote: > I believe we can add that to the backport proposal without resetting the > votes. Add what to which backport proposal? Regards Rüdiger

2.4.x fails to compile

2023-08-22 Thread Ruediger Pluem
Currently 2.4.x fails to compile for me with the following error: In file included from h2_c1_io.c:24: h2_c1_io.c: In function ‘pass_output’: /usr/src/apache/httpd-2.4.x/include/http_log.h:495:14: warning: ‘rv’ may be used uninitialized in this function [-Wmaybe-uninitialized]

Re: svn commit: r1911068 - /httpd/httpd/patches/2.4.x/alias-preserve-path.diff

2023-08-22 Thread Ruediger Pluem
On 7/17/23 5:52 PM, minf...@apache.org wrote: > Author: minfrin > Date: Mon Jul 17 15:52:33 2023 > New Revision: 1911068 > > URL: http://svn.apache.org/viewvc?rev=1911068=rev > Log: > Add patch proposal. > > Added: > httpd/httpd/patches/2.4.x/alias-preserve-path.diff > > Added:

Re: new HTTPProtocolOption for C-L+chunked?

2023-08-16 Thread Ruediger Pluem
On 8/16/23 1:32 PM, Eric Covener wrote: >>> So a few questions: >>> >>> - Is it reasonable as a standalone additional HTTPProtocolOption to >>> decide the behavior? >>> - Thoughts on behavior change in 2.4.x? >>> - 400 as a status code? >>> >>>

Re: new HTTPProtocolOption for C-L+chunked?

2023-08-16 Thread Ruediger Pluem
On 8/2/23 1:29 PM, Eric Covener wrote: > Hi, at $bigco I am seeing more and more scanners reporting HTTP > request smuggling but the byte stream is really just two pipelined > requests. They are costly to debunk. I guess I just miss the point, but how is the above related to the lower? > >

Re: svn commit: r1909401 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-07-10 Thread Ruediger Pluem
On 7/5/23 2:31 PM, Yann Ylavic wrote: > On Fri, Jun 30, 2023 at 4:08 PM Yann Ylavic wrote: >> >> On Fri, Jun 30, 2023 at 2:35 PM Ruediger Pluem wrote: >>> >>> On 6/29/23 5:08 PM, Yann Ylavic wrote: >>>> On Tue, Apr 25, 2023 at 1:57 PM wrote: &g

Re: svn commit: r1910861 - /httpd/httpd/trunk/support/ab.c

2023-07-10 Thread Ruediger Pluem
On 7/10/23 10:11 AM, Joe Orton wrote: > On Fri, Jul 07, 2023 at 03:52:46PM -, yla...@apache.org wrote: >> Author: ylavic >> Date: Fri Jul 7 15:52:45 2023 >> New Revision: 1910861 >> >> URL: http://svn.apache.org/viewvc?rev=1910861=rev >> Log: >> ab: Fix accounting of started connections.

Re: svn commit: r1910846 - /httpd/httpd/trunk/server/util_filter.c

2023-07-10 Thread Ruediger Pluem
On 7/7/23 1:00 PM, yla...@apache.org wrote: > Author: ylavic > Date: Fri Jul 7 11:00:34 2023 > New Revision: 1910846 > > URL: http://svn.apache.org/viewvc?rev=1910846=rev > Log: > util_filter: More useful logging for brigade setaside/reinstate/adopt. > > > Modified: >

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-07-03 Thread Ruediger Pluem
On 7/3/23 10:17 AM, Stefan Eissing via dev wrote: > > >> Am 30.06.2023 um 17:22 schrieb Stefan Eissing via dev : >> >> >> >>> Am 30.06.2023 um 16:45 schrieb Ruediger Pluem : >>> >>> >>> >>> On 6/30/23 4:15 PM, Stefan

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/30/23 4:15 PM, Stefan Eissing via dev wrote: > > >> Am 30.06.2023 um 15:56 schrieb Yann Ylavic : >> >> On Fri, Jun 30, 2023 at 2:44 PM Ruediger Pluem wrote: >>> >>> On 6/30/23 11:08 AM, ic...@apache.org wrote: >>>> Author: icing

Re: svn commit: r1910704 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/30/23 11:08 AM, ic...@apache.org wrote: > Author: icing > Date: Fri Jun 30 09:08:23 2023 > New Revision: 1910704 > > URL: http://svn.apache.org/viewvc?rev=1910704=rev > Log: > proxy: in proxy tunnels, use the smaller timeout value of >client and origin as timeout for polling the

Re: svn commit: r1909401 - /httpd/httpd/trunk/modules/proxy/proxy_util.c

2023-06-30 Thread Ruediger Pluem
On 6/29/23 5:08 PM, Yann Ylavic wrote: > On Tue, Apr 25, 2023 at 1:57 PM wrote: >> >> --- httpd/httpd/trunk/modules/proxy/proxy_util.c (original) >> +++ httpd/httpd/trunk/modules/proxy/proxy_util.c Tue Apr 25 11:57:22 2023 >> @@ -2790,7 +2790,11 @@ ap_proxy_determine_connection(apr_pool_t >>

Re: svn commit: r1910662 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 3:55 PM, Eric Covener wrote: > On Wed, Jun 28, 2023 at 9:08 AM Ruediger Pluem wrote: >> >> >> >> On 6/28/23 2:37 PM, cove...@apache.org wrote: >>> Author: covener >>> Date: Wed Jun 28 12:37:50 2023 >>> New Revision: 1910662 >

Re: svn commit: r1910662 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 2:37 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 28 12:37:50 2023 > New Revision: 1910662 > > URL: http://svn.apache.org/viewvc?rev=1910662=rev > Log: > back to original patch in PR66672 > > Since QSNONE will skip splitoutqueryargs, it's where we should fixup

Re: svn commit: r1910650 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2023-06-28 Thread Ruediger Pluem
On 6/28/23 12:38 PM, cove...@apache.org wrote: > Author: covener > Date: Wed Jun 28 10:38:27 2023 > New Revision: 1910650 > > URL: http://svn.apache.org/viewvc?rev=1910650=rev > Log: > act more like pre-r1908097 with rewrite > > - be more conservative with setting QSNONE > - allow the query

Re: svn commit: r1910327 - /httpd/httpd/branches/2.4.x/STATUS

2023-06-09 Thread Ruediger Pluem
On 6/9/23 6:28 PM, jean-frederic clere wrote: > On 6/9/23 14:58, rpl...@apache.org wrote: >> Author: rpluem >> Date: Fri Jun  9 12:58:55 2023 >> New Revision: 1910327 >> >> URL: http://svn.apache.org/viewvc?rev=1910327=rev >> Log: >> * Vote and comment [skip ci] >> >> Modified: >>

Re: svn commit: r1909411 - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/aaa/

2023-06-09 Thread Ruediger Pluem
Any feedback on my comments below? Regards Rüdiger On 5/5/23 7:37 PM, Ruediger Pluem wrote: > > > On 4/25/23 7:52 PM, minf...@apache.org wrote: >> Author: minfrin >> Date: Tue Apr 25 17:52:18 2023 >> New Revision: 1909411 >> >> URL: http://svn.a

Re: svn commit: r1909409 - in /httpd/httpd/trunk: CHANGES docs/manual/developer/new_api_2_6.xml include/ap_mmn.h include/http_request.h include/mod_auth.h server/request.c

2023-06-09 Thread Ruediger Pluem
On 5/5/23 12:28 PM, Ruediger Pluem wrote: > > > On 4/25/23 7:35 PM, minf...@apache.org wrote: >> Author: minfrin >> Date: Tue Apr 25 17:35:08 2023 >> New Revision: 1909409 >> >> URL: http://svn.apache.org/viewvc?rev=1909409=rev >> Log: >

Re: svn commit: r1910267 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/filters/mod_ext_filter.c

2023-06-07 Thread Ruediger Pluem
On 6/7/23 1:56 PM, Yann Ylavic wrote: > Hi Giovanni; > > On Wed, Jun 7, 2023 at 12:02 AM wrote: >> >> Author: gbechis >> Date: Tue Jun 6 22:02:37 2023 >> New Revision: 1910267 >> >> URL: http://svn.apache.org/viewvc?rev=1910267=rev >> Log: >> mod_ext_filter: check exit status of filter

Re: svn commit: r1910161 - in /httpd/httpd/trunk: changes-entries/ include/ modules/http/ test/modules/http2/

2023-06-01 Thread Ruediger Pluem
On 6/1/23 3:30 PM, Stefan Eissing via dev wrote: >>> Modified: httpd/httpd/trunk/modules/http/http_request.c >>> URL: >>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/http/http_request.c?rev=1910161=1910160=1910161=diff >>>

Re: svn commit: r1910161 - in /httpd/httpd/trunk: changes-entries/ include/ modules/http/ test/modules/http2/

2023-06-01 Thread Ruediger Pluem
On 6/1/23 2:21 PM, ic...@apache.org wrote: > Author: icing > Date: Thu Jun 1 12:21:03 2023 > New Revision: 1910161 > > URL: http://svn.apache.org/viewvc?rev=1910161=rev > Log: > *) core: add `final_resp_passed` flag to request_rec to allow > ap_die() to judge if it can send out a

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-18 Thread Ruediger Pluem
On 5/18/23 1:55 PM, Eric Covener wrote: > On Thu, May 18, 2023 at 6:40 AM Ruediger Pluem wrote: >> >> >> >> On 5/18/23 3:17 AM, Eric Covener wrote: >>> bump? Just was reminded by a thread on reddit (config unclear but >>> probably not non-cfgi

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-18 Thread Ruediger Pluem
fix, can we let spaces > through mod_rewrite? Any reason why we should not encode the spaces as proposed below? > > On Tue, May 9, 2023 at 6:18 PM Eric Covener wrote: >> >> On Tue, May 9, 2023 at 3:14 PM Ruediger Pluem wrote: >>> >>> >>> >>>

Re: Apache2 chroot problem: towards a solution

2023-05-18 Thread Ruediger Pluem
On 5/18/23 6:45 AM, Benjamin Godfrey wrote: > Hi, I'm working on the problem of Apache2 ignoring requests to any command in > the chroot environment.  I have seen complaints > about this posted on a couple of websites, and I have not seen any solution.  >  I seem to have narrowed the problem

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/11/23 5:40 PM, Daniel Gruno wrote: > On 2023-05-11 10:33, Ruediger Pluem wrote: >> >> >> On 5/11/23 12:27 PM, Ruediger Pluem wrote: >>> >>> >>> On 5/4/23 10:34 AM, Ruediger Pluem wrote: >>>> This is a formal vote on whether we

Re: [VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/11/23 12:27 PM, Ruediger Pluem wrote: > > > On 5/4/23 10:34 AM, Ruediger Pluem wrote: >> This is a formal vote on whether we should move our read/write repository >> from Subversion to Git. >> This means that our latest read/write repository will be

[VOTE CLOSED] Switch read/write repository from Subversion to Git

2023-05-11 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 8:01 PM, Eric Covener wrote: > On Tue, May 9, 2023 at 11:51 AM Ruediger Pluem wrote: >> >> >> >> On 5/9/23 4:33 PM, Yann Ylavic wrote: >>> On Tue, May 9, 2023 at 2:10 PM Yann Ylavic wrote: >>>> >>>> On Tue, May 9, 2023 at

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 4:33 PM, Yann Ylavic wrote: > On Tue, May 9, 2023 at 2:10 PM Yann Ylavic wrote: >> >> On Tue, May 9, 2023 at 12:55 PM Ruediger Pluem wrote: >>> >>> On 5/9/23 12:16 PM, Eric Covener wrote: >>>> Still getting feedback in the PR about break

Re: Fwd: [apache/httpd] don't forward invalid query strings (d78a166)

2023-05-09 Thread Ruediger Pluem
On 5/9/23 12:16 PM, Eric Covener wrote: > Still getting feedback in the PR about breakage. Any thoughts on options > here, like allowing spaces or encoding rather than failing? Allowing spaces is out of question for me as it creates an invalid request and opens the door to response

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-09 Thread Ruediger Pluem
On 5/8/23 9:16 AM, Greg Stein wrote: > I might suggest another day or two because of the weekend and because it is > so high-impact. Maybe an extra post to private@ in > case some PMC members aren't tracking dev@ very closely. > > I intend to close this vote in about 48 hours. It has been

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-09 Thread Ruediger Pluem
On 5/9/23 12:00 AM, Daniel Gruno wrote: > > VHS vs BetaMax anyone? :) Video 2000 (https://en.wikipedia.org/wiki/Video_2000) rules :-) Regards Rüdiger

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-08 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: svn commit: r1909411 - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/aaa/

2023-05-05 Thread Ruediger Pluem
On 4/25/23 7:52 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 25 17:52:18 2023 > New Revision: 1909411 > > URL: http://svn.apache.org/viewvc?rev=1909411=rev > Log: > *) mod_autht_jwt: New module to handle RFC 7519 JWT tokens within > bearer tokens, both as part of the

Re: svn commit: r1909409 - in /httpd/httpd/trunk: CHANGES docs/manual/developer/new_api_2_6.xml include/ap_mmn.h include/http_request.h include/mod_auth.h server/request.c

2023-05-05 Thread Ruediger Pluem
On 4/25/23 7:35 PM, minf...@apache.org wrote: > Author: minfrin > Date: Tue Apr 25 17:35:08 2023 > New Revision: 1909409 > > URL: http://svn.apache.org/viewvc?rev=1909409=rev > Log: > core: Add the token_checker hook, that allows authentication to take > place using mechanisms other than

Re: [VOTE] Switch read/write repository from Subversion to Git

2023-05-05 Thread Ruediger Pluem
On 5/4/23 10:34 AM, Ruediger Pluem wrote: > This is a formal vote on whether we should move our read/write repository > from Subversion to Git. > This means that our latest read/write repository will be no longer available > via svn.apache.org. It > will be available via

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-05-05 Thread Ruediger Pluem
On 5/5/23 2:37 AM, Greg Stein wrote: > Down-thread, Giovanni asks about security patch handling. We can continue to > use repos/private/pmc/httpd/ for that. That area will > not go away. If people want to go "all git", then Infra can provide projects > with a single, private repository that

[VOTE] Switch read/write repository from Subversion to Git

2023-05-04 Thread Ruediger Pluem
This is a formal vote on whether we should move our read/write repository from Subversion to Git. This means that our latest read/write repository will be no longer available via svn.apache.org. It will be available via Git at https://gitbox.apache.org/repos/asf/httpd-site.git and

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-25 Thread Ruediger Pluem
On 4/12/23 2:02 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 1:31 PM Eric Covener wrote: >> >> On Wed, Apr 12, 2023 at 6:36 AM Yann Ylavic wrote: >>> >>> On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: > > @ylavic

Re: build trunk in windows

2023-04-24 Thread Ruediger Pluem
I am not a Windows guy, but I guess the best way to build trunk on Windows is to use cmake which is integrated in later versions of Visual studio. Regards Rüdiger On 4/24/23 1:05 PM, jean-frederic clere wrote: > Hi, > > I am trying to build httpd on windoze... > > "The .dsp project files are

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-18 Thread Ruediger Pluem
On 4/17/23 1:07 PM, Yann Ylavic wrote: > On Mon, Apr 17, 2023 at 9:08 AM Ruediger Pluem wrote: >> >> On 4/16/23 12:20 PM, Graham Leggett via dev wrote: >>> On 14 Apr 2023, at 17:18, Ruediger Pluem >> <mailto:rpl...@apache.org>> wrote:

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-17 Thread Ruediger Pluem
On 4/16/23 12:20 PM, Graham Leggett via dev wrote: > On 14 Apr 2023, at 17:18, Ruediger Pluem <mailto:rpl...@apache.org>> wrote: > >> Would that break configs like >> >> >> >> Alias /filesystemprefix/%{HTTP:X-example-header} >> &

Re: svn commit: r1909137 - in /httpd/httpd/trunk: CHANGES modules/mappers/mod_alias.c

2023-04-14 Thread Ruediger Pluem
On 4/14/23 4:07 PM, minf...@apache.org wrote: > Author: minfrin > Date: Fri Apr 14 14:07:49 2023 > New Revision: 1909137 > > URL: http://svn.apache.org/viewvc?rev=1909137=rev > Log: > mod_alias: When an alias is declared inside a Location, make sure > the balance of the URL is preserved to

Re: ci vs PR approvals? (was: [apache/httpd] Fix a possible NULL pointer dereference in hook_uri2file (PR #355))

2023-04-12 Thread Ruediger Pluem
On 4/12/23 12:35 PM, Yann Ylavic wrote: > On Wed, Apr 12, 2023 at 12:26 PM Yann Ylavic wrote: >> >> On Wed, Apr 12, 2023 at 12:18 PM ylavic wrote: >>> >>> @ylavic approved this pull request. >>> >>> Three approvals to get ci started? >> >> Nope.. It seems that gh actions don't run for PRs

Re: svn commit: r1909073 - in /httpd/httpd/trunk/docs/manual: mod/mod_rewrite.xml rewrite/flags.xml

2023-04-12 Thread Ruediger Pluem
On 4/11/23 11:36 PM, cove...@apache.org wrote: > Author: covener > Date: Tue Apr 11 21:36:55 2023 > New Revision: 1909073 > > URL: http://svn.apache.org/viewvc?rev=1909073=rev > Log: > PR66563: escaping of url releated server vars > > Modified: >

Re: [VOTE] Release httpd-2.4.57-rc1 as httpd-2.4.57

2023-04-11 Thread Ruediger Pluem
On 4/10/23 11:37 PM, BUSH Steve wrote: > I just downloaded the apache 2.4.57 source code and attempting to compile on > Windows, mod_rewrite.c fails with this error: > > > I fixed it for my local build by editing modules/mapper/mod_rewrite.mak and > updating the CPP_PROJ= lines to include

  1   2   3   4   5   6   7   8   9   10   >