rbb 02/03/04 21:21:13
Modified:server util_filterc
Log:
Stop the loop when we have found the correct filter, or when the
filter
list is over Do not stop if the next filter is NULL
This fixes the infinite loop and the seg fault Sorry it took so long,
the code was a
My list insertion code was wrong, which was causing this bug Also,
this patch is required even without the rest of the
mod_dir/mod_negotiation patch We have a bug, it allows a connection
filter to be added and never called Try this:
Crete a request
Add connection filters
On Sun, Mar 03, 2002 at 08:47:17AM -0800, Ryan Bloom wrote:
My list insertion code was wrong, which was causing this bug Also,
this patch is required even without the rest of the
mod_dir/mod_negotiation patch We have a bug, it allows a connection
filter to be added and never called Try
Hooks are not the solution to every problem We already have people
complaining that there are so many hooks that they don't really know
what is possible with the server, nor do they know what they have to
do
to make their modules work Why would we add more hooks at this
point
when
On Sun, Mar 03, 2002 at 10:20:52AM -0800, Ryan Bloom wrote:
Was that the one about returning a 302 to the client? No way If every
time we do a multiviews or a mod_dir request we have to send a 302 to
the client, we will cut our throughput horribly You are actually
talking about making most
At 11:54 AM 3/3/2002, you wrote:
I think you may have missed my message yesterday It's not adding a
hook - it's allowing a hook to be able to abort processing of a
request That's all internal_redirect will take care of
everything fast_redirect is bogus because it skips hooks in the
new
On Sun, Mar 03, 2002 at 06:04:08AM -, [EMAIL PROTECTED] wrote:
rbb 02/03/02 22:04:08
Modified:.STATUS
include util_filter.h
server util_filter.c
Log:
This finishes the mod_dir/mod_negotiation bug. This final part of the
From: Roy T. Fielding [EMAIL PROTECTED]
Sent: Thursday, September 20, 2001 5:30 AM
That is complete BS. We have a long standing tradition of NOT making
commits just to follow the code style. There is no need for a vote, because
this has been discussed to death and formatting only
That is complete BS. We have a long standing tradition of NOT making
commits just to follow the code style. There is no need for a vote, because
this has been discussed to death and formatting only commits have been
vetoed in the past in every thread that they come up in. Review the
On Monday 03 September 2001 23:57, [EMAIL PROTECTED] wrote:
jerenkrantz01/09/03 23:57:58
Modified:server util_filter.c
Log:
**NO CODE CHANGES**
This is a reformat commit *ONLY*
Please drive on through.
(One spelling tpyo fixed...)
Didn't we decide a LONG time ago
[EMAIL PROTECTED] writes:
jerenkrantz01/09/03 23:50:52
Modified:server util_filter.c
Log:
The ap_add_input_filter/ap_add_output_filter functions do an O(n) scan
through the list of registered filters. This patch replaces the linear
list with a hash table for better
On Tue, Sep 04, 2001 at 06:40:03AM -0700, Ryan Bloom wrote:
Didn't we decide a LONG time ago not to do this unless it was absolutely
necessary? Format changes just add cruft to the CVS logs. I have noticed
a lot of changes to the format in this patch that were more opinion than code
style.
On Tue, Sep 04, 2001 at 04:28:45PM -, [EMAIL PROTECTED] wrote:
jerenkrantz01/09/04 09:28:45
Modified:server util_filter.c
Log:
Jeff pointed out that the character array must be constant.
Well, it's not, so make it allocated from the correct pool rather than
the
On Tuesday 04 September 2001 09:16, Justin Erenkrantz wrote:
On Tue, Sep 04, 2001 at 06:40:03AM -0700, Ryan Bloom wrote:
Didn't we decide a LONG time ago not to do this unless it was absolutely
necessary? Format changes just add cruft to the CVS logs. I have
noticed a lot of changes to
On Tue, 4 Sep 2001, Ryan Bloom wrote:
On Tuesday 04 September 2001 09:16, Justin Erenkrantz wrote:
Ryan, you may veto this commit. However, if you wish to repeal or
modify our style guide, I suggest you call a vote. -- justin
That is complete BS. We have a long standing tradition of
[EMAIL PROTECTED] wrote:
rbb 01/08/26 23:00:51
Modified:.CHANGES
include util_filter.h
modules/ssl mod_ssl.c ssl_engine_io.c
server util_filter.c
util_filter.c
httpd-2.0\server\util_filter.c(205) :
warning C4098:
16 matches
Mail list logo
