Re: [VOTE] Table v3 spec: Add unknown and new type promotion

2024-09-30 Thread Amogh Jahagirdar
+1 (binding) Thanks, Amogh Jahagirdar On Mon, Sep 30, 2024 at 1:39 PM rdb...@gmail.com wrote: > +1 (binding) > > On Mon, Sep 30, 2024 at 12:32 PM Daniel Weeks wrote: > >> +1 (binding) >> >> On Fri, Sep 27, 2024 at 2:41 PM Russell Spitzer < >> russ

Re: [VOTE] Merge REST Spec Change To Add New Scan Planning APIs

2024-09-10 Thread Amogh Jahagirdar
Thanks Rahil for driving this and everyone for reviewing! Merged the PR. Thanks, Amogh Jahagirdar On Tue, Sep 10, 2024 at 8:24 AM Chertara, Rahil wrote: > Thanks all for reviewing the pr. With 4 binding and 1 non-binding votes, > the vote has passed. Can a maintainer please merge the p

Re: [VOTE] Merge REST Spec Change To Add New Scan Planning APIs

2024-09-05 Thread Amogh Jahagirdar
Thanks Rahil for driving this and providing the summary of changes since these APIs were originally proposed. I'm +1 (binding) on the spec change. Thanks, Amogh Jahagirdar On Wed, Sep 4, 2024 at 10:55 AM Chertara, Rahil wrote: > Thanks Jack and Ryan, I will give an overview of the

Re: [VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-30 Thread Amogh Jahagirdar
Thanks all, with 5 binding and 3 non-binding votes the vote passed. The PR has been merged. Thanks, Amogh Jahagirdar On Thu, Aug 29, 2024 at 10:03 AM Daniel Weeks wrote: > +1 (binding) > > On Wed, Aug 28, 2024 at 8:33 AM Jack Ye wrote: > >> +1 (binding) >> >> O

Re: [VOTE] Merge guidelines for committing PRs

2024-08-28 Thread Amogh Jahagirdar
+1 (binding) On Wed, Aug 28, 2024 at 6:45 PM Yufei Gu wrote: > +1 (binding) > Yufei > > > On Wed, Aug 28, 2024 at 4:56 PM Anton Okolnychyi > wrote: > >> +1 (binding) >> >> Thanks, Micah! >> >> ср, 28 серп. 2024 р. о 16:36 Dmitri Bourlatchkov >> пише: >> >>> +1 (nb) >>> >>> Cheers, >>> Dmitri.

Re: [VOTE] Release Apache Iceberg 1.6.1 RC2

2024-08-26 Thread Amogh Jahagirdar
+1 (binding) Verified signatures, checksums, RAT checks. Ran build and tests with JDK11. Thanks, Amogh Jahagirdar On Mon, Aug 26, 2024 at 6:21 AM Renjie Liu wrote: > +1 (binding) > > - Verified signatures, checksums > - Ran `./gradlew build` and all tests passed, jdk 17 > &

Re: Type promotion in v3

2024-08-26 Thread Amogh Jahagirdar
us on how to handle the precision. Thanks, Amogh Jahagirdar On Thu, Aug 22, 2024 at 3:14 PM Ryan Blue wrote: > Thanks for the discussion, everyone. I think the back and forth between > Fokko and Micah helped me understand Micah's position more clear. I can see > how some of the

[VOTE] Merge REST Spec change to add RemovePartitionSpecsUpdate update type

2024-08-26 Thread Amogh Jahagirdar
[] +1 [] +0 [] -1, do not merge because ... [1] https://github.com/apache/iceberg/pull/10846 [2] https://lists.apache.org/thread/2lo59wkhn8cm29wmokfmg2f18934qnln Thanks, Amogh Jahagirdar

Re: [DISCUSS] Adding RemovePartitionSpecsUpdate update type to REST

2024-08-26 Thread Amogh Jahagirdar
te: >>> >>>  >>> >>> +1, the new spec looks good to me. It seems like the client-side >>> handling the heavy lifting of figuring out which spec to remove is a >>> reasonable approach. >>> >>> Yufei >>> >>> >

Re: [VOTE] REST Endpoint discovery

2024-08-20 Thread Amogh Jahagirdar
+1 Thanks for driving this Eduard! On Tue, Aug 20, 2024 at 3:08 PM Ryan Blue wrote: > +1 > > On Tue, Aug 20, 2024 at 1:46 PM Christian Thiel > wrote: > >> + 1 (non-binding) >> >> > > -- > Ryan Blue > Databricks >

Re: [VOTE] Spec changes in preparation for v3

2024-08-19 Thread Amogh Jahagirdar
+1 (binding) On Mon, Aug 19, 2024 at 5:22 PM Daniel Weeks wrote: > +1 (binding) > > On Mon, Aug 19, 2024, 4:11 PM Steven Wu wrote: > >> +1 (binding) >> >> On Mon, Aug 19, 2024 at 4:06 PM Anton Okolnychyi >> wrote: >> >>> +1 (binding) >>> >>> - Anton >>> >>> пн, 19 серп. 2024 р. о 13:49 John Zh

[DISCUSS] Adding RemovePartitionSpecsUpdate update type to REST

2024-08-19 Thread Amogh Jahagirdar
/pull/10755 <https://github.com/apache/iceberg/pull/10755> [2] https://github.com/apache/iceberg/pull/10846/ [3] https://lists.apache.org/thread/99lo7stnprchjzosjcq9k3mns1mq8fwc Thanks, Amogh Jahagirdar

Re: Type promotion in v3

2024-08-19 Thread Amogh Jahagirdar
ay of evolving the spec sounds plausible specifically for int/long -> string, although I'd need to double check/think through implications. Thanks, Amogh Jahagirdar On Mon, Aug 19, 2024 at 8:43 AM Xianjin YE wrote: > Hey Fokko, > > > Distribute all the schemas to the execut

Re: [VOTE] Release Apache Iceberg Rust 0.3.0 RC1

2024-08-18 Thread Amogh Jahagirdar
users have to explicitly run tests via make. Should we update the verify script to run tests by default since I'd imagine most users want to run tests by default as part of release verification? Do let me know if I'm missing something. Thanks, Amogh Jahagirdar On Sat, Aug 17, 2024 at 7:

Re: [VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

2024-08-16 Thread Amogh Jahagirdar
The vote passes 7 +1 binding votes and 1 +1 non-binding vote and I will merge the spec change. Thanks everyone for providing feedback and voting! Thanks, Amogh Jahagirdar On Wed, Aug 14, 2024 at 9:23 PM Renjie Liu wrote: > +1 > > On Thu, Aug 15, 2024 at 10:10 AM Jack Ye wrote

Re: Welcome Péter, Amogh and Eduard to the Apache Iceberg PMC

2024-08-14 Thread Amogh Jahagirdar
Iceberg PMC has voted to >> have several talented individuals join us. >> >> So without further ado, please welcome Péter Váry, Amogh Jahagirdar and >> Eduard Tudenhoefner to the Apache Iceberg PMC. >> >> As usual I am excited about the future of this community

[VOTE] Merge REST spec clarification on how servers should handle unknown updates/requirements

2024-08-13 Thread Amogh Jahagirdar
[] +0 [] -1, do not merge because ... [1] https://github.com/apache/iceberg/pull/10848 Thanks, Amogh Jahagirdar

Re: [DISCUSS] Clarify in REST spec expected implementation behavior for unknown updates or requirements

2024-08-13 Thread Amogh Jahagirdar
Thanks all for your feedback! Since it seems like there's general consensus and this discussion thread has been open for quite some time at this point, I will start a vote thread on this. Thank you, Amogh Jahagirdar On Wed, Aug 7, 2024 at 7:17 PM Yufei Gu wrote: > Thanks Amogh for

Re: [RESULT][VOTE] Merge specification clarifications on reading/writing partition values

2024-08-05 Thread Amogh Jahagirdar
Thanks Micah and all who voted! I merged the change. Thanks, Amogh Jahagirdar On Mon, Aug 5, 2024 at 6:49 PM Micah Kornfield wrote: > The vote passes with: > > 3 +1 binding votes (Yufei, Daniel, Ryan) > 2 +1 non-binding votes (Micah, Prashant). > > Action items: merge th

Re: [DISCUSS] Clarify in REST spec expected implementation behavior for unknown updates or requirements

2024-08-05 Thread Amogh Jahagirdar
the clearest option is to have a defined failure mode. Thanks, Amogh Jahagirdar On Mon, Aug 5, 2024 at 9:22 AM Daniel Weeks wrote: > I feel like this is a little bit of a gray area in terms of 400 vs 422. > While I agree that 422 reads like the right answer just based on the > defin

[DISCUSS] Clarify in REST spec expected implementation behavior for unknown updates or requirements

2024-08-02 Thread Amogh Jahagirdar
cUpdate and does not recognize it, must fail with a 400. Note: I will propose the specific example of RemovePartitionSpecUpdate spec change in a different thread. Thanks, Amogh Jahagirdar

Re: [VOTE] Clarify "File System Tables" in the table spec

2024-08-01 Thread Amogh Jahagirdar
+1 (non-binding) On Thu, Aug 1, 2024 at 10:22 AM Steven Wu wrote: > +1 (binding) > > On Thu, Aug 1, 2024 at 10:16 AM Ryan Blue > wrote: > >> Adding my own +1 >> >> On Thu, Aug 1, 2024 at 9:52 AM Robert Stupp wrote: >> >>> +1 (nb) >>> On 01.08.24 18:17, Yufei Gu wrote: >>> >>> +1 (binding) >>>

Re: [VOTE] Drop Java 8 support in Iceberg 1.7.0

2024-07-26 Thread Amogh Jahagirdar
+1 (non-binding) Thanks, Amogh Jahagirdar On Fri, Jul 26, 2024 at 9:57 AM Szehon Ho wrote: > +1 (binding) > > Thanks > Szehon > > On Fri, Jul 26, 2024 at 8:55 AM Steven Wu wrote: > >> +1 (binding) >> >> I would also suggest keeping the vote open for 7

Re: [Early Feedback] Variant and Subcolumnarization Support

2024-07-25 Thread Amogh Jahagirdar
Any chance this meeting was recorded? I couldn't make it but would be interested in catching up on the discussion. Thanks, Amogh Jahagirdar On Tue, Jul 23, 2024 at 11:30 AM Aihua Xu wrote: > Thanks folks for additional discussion. > > There are some questions related to sub

Re: [ANNOUNCE] Welcoming new committers and PMC members

2024-07-23 Thread Amogh Jahagirdar
Congrats all, and thank you for your contributions! Thanks, Amogh Jahagirdar On Tue, Jul 23, 2024 at 9:59 AM Walaa Eldin Moustafa wrote: > Congratulations everyone! Great to see the community growing. > > Thanks, > Walaa. > > On Tue, Jul 23, 2024 at 8:51 AM A

Re: [Early Feedback] Variant and Subcolumnarization Support

2024-07-23 Thread Amogh Jahagirdar
port having the spec, and reference implementation in Iceberg; as others have said, it centralizes improvements in a single, agnostic dependency for engines, rather than engines having to take dependencies on other engine modules. Thanks, Amogh Jahagirdar On Tue, Jul 23, 2024 at 12:15 AM Péter Vá

Re: [VOTE] Release Apache Iceberg 1.6.0 RC1

2024-07-21 Thread Amogh Jahagirdar
+1 (non-binding) Verified signature/checksum/RAT/build/test on JDK 17. Thanks JB for managing this release! Thanks, Amogh Jahagirdar On Fri, Jul 19, 2024 at 1:20 PM Daniel Weeks wrote: > +1 (binding) > > Verified sigs/sums/license/build/test (Java 17) > > -Dan > > On F

Re: [VOTE] Merge table spec clarifications on time travel and equality deletes

2024-07-18 Thread Amogh Jahagirdar
+1 (non-binding) on these spec clarifications Thanks, Amogh Jahagirdar On Thu, Jul 18, 2024 at 5:08 PM Steven Wu wrote: > I am +1 for the spec clarifications. > > I have left some comments for the time travel PR. we can discuss the > details in the PR itself before merging. In part

Re: [CANCEL][VOTE] Release Apache Iceberg 1.6.0 RC0

2024-07-17 Thread Amogh Jahagirdar
Thanks for the reviews, I just realized we'd just cut a new RC from main with the change (there's no 1.6.x branch). Thanks, Amogh jahagiradr On Wed, Jul 17, 2024 at 2:22 PM Jean-Baptiste Onofré wrote: > Hi everyone, > > Due to the TableMetadata.Builder constructor visibility change, I > cancel

Re: [VOTE] Release Apache Iceberg 1.6.0 RC0

2024-07-17 Thread Amogh Jahagirdar
re in agreement with that, I'd recommend another candidate. If not (which I can understand since maybe it's a bit overkill), we could just go through a deprecation cycle. Thanks, Amogh Jahagirdar On Wed, Jul 17, 2024 at 1:39 PM Jean-Baptiste Onofré wrote: > Hi Amogh > > Are

Re: [VOTE] Release Apache Iceberg 1.6.0 RC0

2024-07-17 Thread Amogh Jahagirdar
nstructor that I added in #10369. That should not be public. Thanks and sorry for the confusion there, Amogh Jahagirdar On Wed, Jul 17, 2024 at 9:48 AM Amogh Jahagirdar <2am...@gmail.com> wrote: > I'm -1 (non-binding). > > Aside from running through the standard checks, I wa

Re: [VOTE] Release Apache Iceberg 1.6.0 RC0

2024-07-17 Thread Amogh Jahagirdar
com/apache/iceberg/pull/10369/files#diff-c540a31e66b157a8f080433c82a29a070096d0e08c6578a0099153f1229bdb7aR913 is marked public, which I think I'd prefer to change to private upfront rather than have to go through a deprecation cycle/revAPI changes. Thanks, Amogh Jahagirdar On Wed, Jul 17, 2024 at 2:29 AM Honah J. wrote: > +1 (non-b

Re: Core:support redis and http lock-manager

2024-07-12 Thread Amogh Jahagirdar
oach to isolate that complexity. Thanks, Amogh Jahagirdar On Fri, Jul 12, 2024 at 12:08 PM Ryan Blue wrote: > I think one of the main questions is whether we want to support locking > strategies moving forward. These were needed in early catalogs that didn't > have support for ato

Re: [VOTE] spec: remove the JSON spec for content file and file scan task sections

2024-07-11 Thread Amogh Jahagirdar
+ 1 (non-binding). Thanks, Amogh Jahagirdar On Thu, Jul 11, 2024 at 10:25 AM Péter Váry wrote: > +1 (non-binding) > > On Thu, Jul 11, 2024, 17:31 Jack Ye wrote: > >> +1 (binding) >> >> On Thu, Jul 11, 2024 at 3:37 AM Piotr Findeisen < >> piotr.findei...

Re: [VOTE] Fix property names in REST spec for statistics / partition statistics

2024-07-10 Thread Amogh Jahagirdar
+1 (non-binding) On Wed, Jul 10, 2024 at 7:16 AM Piotr Findeisen wrote: > +1 (non binding) > > On Wed, 10 Jul 2024 at 10:11, Jean-Baptiste Onofré > wrote: > >> +1 (non binding) >> >> Regards >> JB >> >> On Wed, Jul 10, 2024 at 5:35 AM Eduard Tudenhöfner >> wrote: >> > >> > Hey everyone, >> > >

Re: Spark: Copy Table Action

2024-07-09 Thread Amogh Jahagirdar
table and subsequently relying on orphan file removal on the copied table to remove the actual files? Is it around listing? Overall this is great to see. Thanks, Amogh Jahagirdar On Tue, Jul 9, 2024 at 10:59 AM Anurag Mantripragada wrote: > Agreed with Peter. I will bring relative paths

Re: Making the NDV property required for theta sketch blobs in Puffin

2024-07-05 Thread Amogh Jahagirdar
, Amogh Jahagirdar On 2024/07/05 17:18:56 Ryan Blue wrote: > For the compatibility and version bump question, shouldn't this be a new > revision of the theta sketch rather than a new version of Puffin? I think > we want to avoid making changes to the file format itself if we can

Re: Making the NDV property required for theta sketch blobs in Puffin

2024-07-05 Thread Amogh Jahagirdar
://github.com/apache/iceberg/pull/10288 and other engine integrations with Puffin, they'd have to follow the spec as it is today which means doing a best effort read of the property, and if it does not exist, derive the NDV from the sketch. Please let me know your thoughts! Thanks, Amo

Re: [Proposal] REST Spec: Server-side Metadata Tables

2024-07-04 Thread Amogh Jahagirdar
al direction of this. Thanks, Amogh Jahagirdar On Thu, Jul 4, 2024 at 4:10 AM Robert Stupp wrote: > Hi Yufei, > > I think the proposal is very interesting! The direction this and other > proposals are going is IMO the right one. > > Since many proposals need access to at least ma

Re: [INFO] Preparing the Apache Iceberg 1.6.0 release

2024-07-01 Thread Amogh Jahagirdar
which proves there's incorrect behavior in the `Tasks.run` API for the singleThreaded case. I'll take a look at the other issues/PRs as well. Thanks, Amogh Jahagirdar On Mon, Jul 1, 2024 at 9:07 AM Robert Stupp wrote: > Should these be added to the milestone as well? > >

Re: Iceberg-arrow vectorized read bug

2024-06-26 Thread Amogh Jahagirdar
onfirm if that's expected or not. Thanks, Amogh Jahagirdar On Wed, Jun 26, 2024 at 6:05 PM Lessard, Steve wrote: > I have found unexpected behavior in iceberg-arrow’s vectorized read > support. After quite a bit of digging and collaboration with Eduard > Tudenhoefner we have de

Re: [DISCUSS] Describing REST Server capabilities

2024-06-26 Thread Amogh Jahagirdar
I'm in favor of grouping by tags. The way I look at this, there are 2 primary considerations: 1.) The client/server protocol complexity tradeoffs. On the first consideration, unless I'm missing something the client side becomes significantly more complex; if this has been sketched out earlier i

Making the NDV property required for theta sketch blobs in Puffin

2024-06-21 Thread Amogh Jahagirdar
behind an API) but this loses the advantage of guaranteeing that engines don't have to read the sketch. The spec change to make the property required seems to be the consensus on the PR thread but I wanted to bring it up here in case others had different ideas or if I'm missing any problems with this approach! Thank you, Amogh Jahagirdar

Re: Addressing security questions in the Iceberg REST specification

2024-05-28 Thread Amogh Jahagirdar
think the intention is Oauth2 is the only way, but I think the capabilities PR will make that even more clear. On point 4, isn't that possible today, Can't that be achieved with the current token exchange approach, and the internal implementation of the endpoint? Sorry if I missed that

Re: [Discuss] Heap pressure with RewriteFiles APIs

2024-05-22 Thread Amogh Jahagirdar
these files and use instrumentation to see the memory consumption. Thanks, Amogh Jahagirdar On Wed, May 22, 2024 at 1:15 AM Naveen Kumar wrote: > Hi Szehon, > > Thanks for your email. > > I agree configuring metadata metrics per column will create a smaller > manifest

Re: [Early Feedback] Variant and Subcolumnarization Support

2024-05-11 Thread Amogh Jahagirdar
llenges in integration (if there's any), so we can make progress in those areas and get adoption for these new data types! Overall this is very exciting! Thanks, Amogh Jahagirdar On Fri, May 10, 2024 at 11:28 PM Gang Wu wrote: > Hi, > > This sounds very interesting! > > IIUC,

[ANNOUNCE] Apache Iceberg release 1.5.2

2024-05-09 Thread Amogh Jahagirdar
Hi everyone, I'm pleased to announce the release of Apache Iceberg 1.5.2! Apache Iceberg is an open table format for huge analytic datasets. Iceberg delivers high query performance for tables with tens of petabytes of data, along with atomic commits, concurrent writes, and SQL-compatible table ev

[RESULT][VOTE] Release Apache Iceberg 1.5.2 RC0

2024-05-08 Thread Amogh Jahagirdar
s out correctly on the original thread, this is a duplicate). Thanks, Amogh Jahagirdar On Mon, May 6, 2024 at 9:44 PM Daniel Weeks wrote: > +1 (binding) > > Verified sigs/sums/license/build/test (Java 17) > > -Dan > > On Mon, May 6, 2024 at 11:00 AM Russell Spitzer

[RESULT][VOTE] Release Apache Iceberg 1.5.2 RC0

2024-05-08 Thread Amogh Jahagirdar
Thanks everyone who participated in the vote for Release Apache Iceberg 1.5.2 RC0. The vote result is: +1: 3 (binding), 5 (non-binding) +0: 0 (binding), 0 (non-binding) -1: 0 (binding), 0 (non-binding) Therefore, the release candidate is passed. Thanks, Amogh Jahagirdar

Re: [VOTE] Release Apache Iceberg 1.5.2 RC0

2024-05-01 Thread Amogh Jahagirdar
apache.org/dyn/closer.lua/spark/spark-3.3.4/spark-3.3.4-bin-hadoop3-scala2.13.tgz> . I encourage folks to try out the staged Spark artifacts in their own test environments or CI if possible when voting, that would also give us some more confidence. Thanks, Amogh Jahagirdar

[VOTE] Release Apache Iceberg 1.5.2 RC0

2024-05-01 Thread Amogh Jahagirdar
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.5.2 release. The commit ID is cbb853073e681b4075d7c8707610dceecbee3a82 * This corresponds to the tag: apache-iceberg-1.5.2-rc0 * https://github.com/apache/iceberg/commits/apache-iceberg-1.5.2-rc0 * https://gi

Re: [DISCUSS] Apache Iceberg 1.5.2 Release

2024-04-30 Thread Amogh Jahagirdar
Sorry to clarify: When I say "an issue with some of the released Spark artifacts" I specifically mean the Spark artifacts that were released as part of the recent 1.5.1 release. Thanks, Amogh Jahagirdar On Tue, Apr 30, 2024 at 10:34 AM Amogh Jahagirdar wrote: > Hi all, >

[DISCUSS] Apache Iceberg 1.5.2 Release

2024-04-30 Thread Amogh Jahagirdar
iss anything while we're doing this. Thanks, Amogh Jahagirdar

Re: [ANNOUNCE] Apache Iceberg release 1.5.1

2024-04-30 Thread Amogh Jahagirdar
chanism to verify the staged release jars since at the end of the day those are what's going out when the release passes. Thanks, Amogh Jahagirdar

[ANNOUNCE] Apache Iceberg release 1.5.1

2024-04-25 Thread Amogh Jahagirdar
I'm pleased to announce the release of Apache Iceberg 1.5.1! Apache Iceberg is an open table format for huge analytic datasets. Iceberg delivers high query performance for tables with tens of petabytes of data, along with atomic commits, concurrent writes, and SQL-compatible table evolution. This

Subject: [RESULT][VOTE] Release Apache Iceberg 1.5.1 RC0

2024-04-23 Thread Amogh Jahagirdar
verifying this release! - Amogh Jahagirdar On Tue, Apr 23, 2024 at 3:37 PM Fokko Driesprong wrote: > Sorry for being late to the party! > > +1 (binding) > > - Checked checksum, signature and licenses > <https://gist.github.com/Fokko/62677bb2e897574dcdb8b49b1b6760de> > - Ran

Re: [VOTE] Release Apache PyIceberg 0.6.1rc3

2024-04-20 Thread Amogh Jahagirdar
+1 (non-binding) Verified signatures/checksums/license. Ran unit and integration tests. Thanks, Amogh Jahagirdar On Sat, Apr 20, 2024 at 5:14 PM Hussein Awala wrote: > +1 (non-binding) > > - checked signatures, checksums and licences > - tested writing and querying a table with G

[VOTE] Release Apache Iceberg 1.5.1 RC0

2024-04-18 Thread Amogh Jahagirdar
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.5.1 release. The commit ID is cbb853073e681b4075d7c8707610dceecbee3a82 * This corresponds to the tag: apache-iceberg-1.5.1-rc0 * https://github.com/apache/iceberg/commits/apache-iceberg-1.5.1-rc0 * https://gi

Re: [DISCUSS] Apache Iceberg 1.5.1 Release

2024-04-06 Thread Amogh Jahagirdar
Thanks for surfacing these, I think a patch release makes sense at this point now that there's a few issues. I'm happy to help manage the release! Thanks, Amogh Jahagidar On Sat, Apr 6, 2024 at 4:03 PM Daniel Weeks wrote: > Hey everyone, > > I wanted to open the discussion around releasing a 1

Re: truncate transform over binary columns

2024-04-03 Thread Amogh Jahagirdar
the history of this, it's been supported since the very beginning of the reference implementation and I think it was a miss on the original spec definition. However, if people are concerned about directly updating the spec as is, then I think this is another option. Thanks, Amogh Jahagirdar On

Re: truncate transform over binary columns

2024-04-03 Thread Amogh Jahagirdar
ake [0, width) bytes (essentially the same as the string case). Right now, I'm favoring 2 but I think it's worth leaving this open for a bit in case others see an issue with supporting this behavior. Thanks, Amogh Jahagirdar On Wed, Apr 3, 2024 at 6:45 PM Brian Hulette wrote: > Hello,

Re: New committer: Renjie Liu

2024-03-10 Thread Amogh Jahagirdar
Congrats Renjie! Very well deserved, excited to see Rust support grow further! Thanks, Amogh Jahagirdar On Sun, Mar 10, 2024 at 5:57 PM Brian Olsen wrote: > Renjie, > > I’ve already enjoyed all of our interactions, All I’ve heard in my first > year heavily interacting with the da

Re: [VOTE] Release Apache Iceberg 1.5.0 RC6

2024-03-08 Thread Amogh Jahagirdar
+1 non-binding Verified signatures,checksums,RAT checks, build, and tests with JDK11. I also ran ad-hoc tests for views in Trino with the rest catalog. Thanks, Amogh Jahagirdar On Fri, Mar 8, 2024 at 5:04 PM Ryan Blue wrote: > +1 (binding) > > - Normal tarball verification > -

Re: New committer: Bryan Keller

2024-03-05 Thread Amogh Jahagirdar
Congratulations Bryan! Very well deserved, thank you for all your contributions! On Tue, Mar 5, 2024 at 7:29 AM Steven Wu wrote: > Bryan, congratulations and thank you for your many contributions. > > On Tue, Mar 5, 2024 at 5:54 AM Bryan Keller wrote: > >> Thanks everyone! I really appreciate i

Re: Inconsistency between REST spec and table/view spec

2024-02-29 Thread Amogh Jahagirdar
I want to echo Dan's point that just because there is a separate spec for a REST Catalog does not mean that implementations can deviate from the spec's definition of the commit protocol or metadata layout, and still be considered "spec compliant". > Secondly, once we do that, we should declare RES

Re: [VOTE] Release Apache Iceberg 1.5.0 RC3

2024-02-22 Thread Amogh Jahagirdar
+1 non-binding. Ran signature, checksum, license checks and build/test with JDK11 Ran tests with views in Spark3.5/Spark3.4 and Trino with REST/JDBC catalog. Thanks, Amogh Jahagirdar On Thu, Feb 22, 2024 at 9:10 PM Jack Ye wrote: > +1 (binding) > > Checked license, signature, checks

Re: [VOTE] Release Apache PyIceberg 0.6.0rc6

2024-02-18 Thread Amogh Jahagirdar
+1 non-binding Verified signatures, checksum, and license Ran unit/integ tests on Python 3.10.4 Ran ad-hoc tests w/ Rest Catalog Thanks all, Amogh Jahagirdar On Sun, Feb 18, 2024 at 4:32 PM Hussein Awala wrote: > +1 (non-binding) > > - Tested the new writing feature with a non-pa

Re: [VOTE] Release Apache Iceberg Rust 0.2.0 RC1

2024-02-16 Thread Amogh Jahagirdar
+1 non-binding, Verified checksum/signatures, license/notice files, ASF headers and ran build and tests. Thanks, Amogh Jahagirdar On Fri, Feb 16, 2024 at 10:52 AM Chojan Shang wrote: > +1 non-binding > > [x] Download links are valid. > [x] Checksums and signatures. > [x] LICEN

Re: Partition column order in rewrite manifests

2024-01-30 Thread Amogh Jahagirdar
Yeah I think being able to specify the order of the columns to sort by when rewriting the manifests makes a lot of sense. On Tue, Jan 30, 2024 at 5:47 PM Renjie Liu wrote: > Sounds reasonable to me. > > On Wed, Jan 31, 2024 at 7:56 AM wrote: > >> Sounds like a reasonable thing to add? Maybe we

Re: [ANNOUNCE] New committer: Honah J.

2024-01-12 Thread Amogh Jahagirdar
Congrats Honah, thank you for all of your contributions! On Fri, Jan 12, 2024 at 1:24 PM Hussein Awala wrote: > Congrats Honah! > > On Fri 12 Jan 2024 at 22:23, Micah Kornfield > wrote: > >> Congrats! >> >> On Friday, January 12, 2024, Jack Ye wrote: >> >>> Congratulations! Thanks for all the

Re: [PROPOSAL] Improvement on our PR flows

2024-01-03 Thread Amogh Jahagirdar
+1, I think this is a step in the right direction. One other consideration I wanted to bring up was dependabot and if there's any unique handling we want to do there because I've noticed that PRs from dependabot tend to pile up. I think with the proposal we won't really need to do anything unique a

Re: [VOTE] Release Apache Iceberg 1.4.3 RC0

2023-12-21 Thread Amogh Jahagirdar
+1 non-binding. Verified signature, checksum, RAT checks and ran the build and tests with JDK11. I also ran some ad-hoc tests with Spark and REST Catalog. Thanks, Amogh Jahagirdar On Thu, Dec 21, 2023 at 3:50 PM Daniel Weeks wrote: > +1 (binding) > > Verified sigs/sums/license/bu

Re: [VOTE] Release Apache Iceberg 1.4.2 RC0

2023-11-02 Thread Amogh Jahagirdar
wrote: > +1 - Checked all the normal things (Checksum, Tests, Rat) > > On Nov 2, 2023, at 12:38 PM, Ryan Blue wrote: > > +1 > > Thanks for getting this fix out, Amogh! > > On Thu, Nov 2, 2023 at 9:19 AM Amogh Jahagirdar wrote: > >> Thanks Ajantha, I've re

[ANNOUNCE] Apache Iceberg release 1.4.2

2023-11-02 Thread Amogh Jahagirdar
I'm pleased to announce the release of Apache Iceberg 1.4.2! Apache Iceberg is an open table format for huge analytic datasets. Iceberg delivers high query performance for tables with tens of petabytes of data, along with atomic commits, concurrent writes, and SQL-compatible table evolution. This

Re: [VOTE] Release Apache Iceberg 1.4.2 RC0

2023-11-02 Thread Amogh Jahagirdar
Thanks Ajantha, I've reached out to a few more PMCs to see about getting some more votes casted. A few folks are voting on it, really appreciate everyone's help on this release. Thanks, Amogh Jahagirdar On Wed, Nov 1, 2023 at 9:47 PM Ajantha Bhat wrote: > Friendly reminder: We

Re: [VOTE] Release Apache Iceberg 1.4.2 RC0

2023-10-30 Thread Amogh Jahagirdar
+1 non-binding 1.) Validated checksum and signature 2.) RAT/license checks 3.) Build/tests with JDK8 4.) Performed an ad-hoc Spark test which would read a table with corrupted offsets and verified it succeeded to verify that the new patch works end to end. Thanks, Amogh Jahagirdar On Mon, Oct

[VOTE] Release Apache Iceberg 1.4.2 RC0

2023-10-28 Thread Amogh Jahagirdar
Hi Everyone, I propose that we release the following RC as the official Apache Iceberg 1.4.2 release. The commit ID is f6bb9173b13424d77e7ad8439b5ef9627e530cb2 * This corresponds to the tag: apache-iceberg-1.4.2-rc0 * https://github.com/apache/iceberg/commits/apache-iceberg-1.4.2-rc0 * https://gi

[DISCUSS] Apache Iceberg 1.4.2

2023-10-28 Thread Amogh Jahagirdar
s://github.com/apache/iceberg/pull/8925> . Starting this thread to see if folks have any other bug fixes that should be included in a 1.4.2 patch release? I've created a milestone here <https://github.com/apache/iceberg/milestone/40> . Thanks, Amogh Jahagirdar

Re: [VOTE] Release Apache PyIceberg 0.5.1 (RC1)

2023-10-19 Thread Amogh Jahagirdar
+1 non-binding Verified signature and checksum, RAT checks, and ran all unit/integration tests. Thanks, Amogh On Thu, Oct 19, 2023 at 2:23 AM Fokko Driesprong wrote: > +1 (binding) from me as well. > > I ran the example notebooks against the REST catalog >