Re: [VOTE] Release pyignite 0.5.0-rc1

2021-06-17 Thread Surkov
+ 1 for me. Checked for Mac OS -- Sent from: http://apache-ignite-developers.2346864.n4.nabble.com/

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Andrey, here we discuss serialization format, as far as I understand. Current implementation of ignite binary object serialization can be rewritten. If we do not care about fast (O(1)) field lookup, about schema validation and so on, msgpack is a really good option. It is also good for client binar

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Andrey Mashenkov
Ivan, thankd for clarification. Binarilizable interface forces user to write serialization code. We can support this or similar interface. But I'd like Ignite has some default serializer in addition. It can be also useful e.g. in compute for param and result serialization. BinaryObjectBuider requ

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
>> Double checked -- there is not any links to PR either in IEP or in jira issue Sorry, there is a link in IEP, but not in jira ticket. чт, 17 июн. 2021 г. в 21:39, Ivan Daschinsky : > Andrey, > >> arbitrary object graph > Also, that is not true, msgpack format doesn't handle circular graphs. > T

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Andrey, >> arbitrary object graph Also, that is not true, msgpack format doesn't handle circular graphs. Think about msgpack as binary json. You couldn't understand full structure of message if you didn't deserialize it fully before, maps and arrays are serialized just as contiguos chunks of value

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Andrey Mashenkov
Ivan, Ok, I've just thought if "fields are not included" then we need to bother about them by ourselves. чт, 17 июн. 2021 г., 20:10 Ivan Daschinsky : > Andrey, i'm sorry but what do you mean as additional code harness? Usually, > POJO is serialized simply as map. > > чт, 17 июн. 2021 г., 19:55 A

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Andrey, i'm sorry but what do you mean as additional code harness? Usually, POJO is serialized simply as map. чт, 17 июн. 2021 г., 19:55 Andrey Mashenkov : > Hi Pavel, > > What you suggest looks promising: arbitrary object graph and platform > independence aspects in particular. > > In IEP-54 we

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Andrey Mashenkov
Hi Pavel, What you suggest looks promising: arbitrary object graph and platform independence aspects in particular. In IEP-54 we support only flat objects and only some standard types and assume inner objects of custom types will be serialized to byte[] somehow and their schema will not be manage

Re: [DISCUSSION] Add cache statistics switch to control script

2021-06-17 Thread Shishkov Ilya
Hi, Andrey Thanks for your comments, I have updated the ticket. Initially, I assumed the 'VisorCacheToggleStatisticsTask' should be used. But, as I see, VisorCacheToggleStatisticsTask doesn't perform any checks of cache existence [1], and this work is done by the IgniteVisorCmd [2]. Moreover, it

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Also, it's well known use case of msgpack in the world of memory grids -- tarantool.io uses msgpack for clients binary protocol [1] So writing connectors to tarantool is quite easy task. [1] -- https://www.tarantool.io/en/doc/latest/dev_guide/internals/box_protocol/ чт, 17 июн. 2021 г. в 16:15, P

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Pavel Tupitsyn
Ivan, > Have you considered format with schema? 1. We should be able to serialize arbitrary user data on the client side. I think we don't want to require extra steps from the user. 2. MsgPack can be also used in a schemaful way, when user objects are written as arrays, not as maps - so that

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Could you please share your code for benchmarks? чт, 17 июн. 2021 г. в 15:56, Ivan Daschinsky : > Hi, Pavel. Have you considered format with schema? Or schemaless of a > candidate format was a prerequisite? > As for me, msgpack is great, but I suppose that we should benchmark > formats thoroughl

Re: IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Ivan Daschinsky
Hi, Pavel. Have you considered format with schema? Or schemaless of a candidate format was a prerequisite? As for me, msgpack is great, but I suppose that we should benchmark formats thoroughly. And not only for Java. чт, 17 июн. 2021 г. в 15:29, Pavel Tupitsyn : > Igniters, > > I have drafted a

IEP-75 Thin Client MsgPack Serialization for 3.0

2021-06-17 Thread Pavel Tupitsyn
Igniters, I have drafted an IEP on thin client serialization format [1], please review and let me know what you think. [1] https://cwiki.apache.org/confluence/display/IGNITE/IEP-75+Thin+Client+Serialization

Re: [VOTE] Release pyignite 0.5.0-rc1

2021-06-17 Thread Pavel Tupitsyn
+1 Checked pip install from tar.gz on Python 3.8 on Ubuntu 20.04, ran some of the examples. On Thu, Jun 17, 2021 at 2:32 PM Igor Sapego wrote: > +1 from me > > Best Regards, > Igor > > > On Thu, Jun 17, 2021 at 12:10 PM Ivan Daschinsky > wrote: > > > +1 From me > > Checked on Ubuntu 20.04 and

Re: [VOTE] Release pyignite 0.5.0-rc1

2021-06-17 Thread Igor Sapego
+1 from me Best Regards, Igor On Thu, Jun 17, 2021 at 12:10 PM Ivan Daschinsky wrote: > +1 From me > Checked on Ubuntu 20.04 and windows 10 > 1. Installation from wheels for pythons 3.6 3.7 3.8 3.9 > 2. Native module work > 3. Examples > > Checked on Ubuntu 20.04 building from source package a

Re: Exceeding the DataStorageConfiguration#getMaxWalArchiveSize due to historical rebalance

2021-06-17 Thread ткаленко кирилл
Created the first task by this discussion IGNITE-14923. 13.05.2021, 18:37, "Stanislav Lukyanov" : > What I mean by degradation when archive size < min is that, for example, > historical rebalance is available for a smaller timespan than expected by the > system design. > It may not be an issue o

Re: [VOTE] Release pyignite 0.5.0-rc1

2021-06-17 Thread Ivan Daschinsky
+1 From me Checked on Ubuntu 20.04 and windows 10 1. Installation from wheels for pythons 3.6 3.7 3.8 3.9 2. Native module work 3. Examples Checked on Ubuntu 20.04 building from source package and correct work of result package. Checked all sha256 checksums and gpg signatures. Let's extend votin

Re: [DISCUSSION] Javadoc style requirements and checks in Ignite-3.

2021-06-17 Thread Andrey Gura
Hi, Unfortunately, such things as the "many private APIs" rule can't be formalized for any validation tool. So we have to choose between rules like "everything should be documented" and "private API documentation is not mandatory". The community prefers the second approach. I don't want to argue

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-17 Thread Nikolay Izhikov
> No validation in the world prevent me from typing manually "mess" instead of > "msg"/«message" Code review will do. > btw "svc" is more common imo Agree. I think you can start a discussion and change some abbrevs if you wish. > 17 июня 2021 г., в 10:23, Ivan Daschinsky написал(а): > > I'm

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-17 Thread Ivan Daschinsky
I'm sorry, but the rule is not strict and, moreover, not clear enough for constans. See here [1] ``` Type and method names are usually not abbreviated (except for the well-accepted abbreviations such as EOF, Impl, Fifo, etc.). Abbreviation applies to local variables, method parameters, class field

Re: [DISCUSSION] Code style. Variable abbrevations

2021-06-17 Thread Konstantin Orlov
Enforced validation doesn't guarantee code consistency. No validation in the world prevent me from typing manually "mess" instead of "msg"/"message" or "svc" instead of "srvc"/"service" (btw "svc" is more common imo). And the fact that someone name a variable "count" instead of "cnt" doesn't mak