Re: Internal API: Introduction

2018-01-27 Thread Andreas Huber
Excellent! I think, making this clear distinction between what's public and what's not, gives us more flexibility. E.g. we can experiment with ideas not having to worry about removing anything later, in case an idea has flaws. By the way, at first I thought removing guava entirely from applib

Re: Internal API: Introduction

2018-01-27 Thread Dan Haywood
OK, thanks Andi. Well, for myself I'm happy to leave these classes in isis-core-applib, ie where you've moved them. In any case, suspect folk will be moving to Java 9 in the next year, and so we're gonna have to figure out a way to bundle Isis for both Java 8 and Java 9 (ie with module-info.java)

Re: Internal API: Introduction

2018-01-25 Thread Andi Huber
Thx Dan! Giving just quick answers inline ... Cheers, Andi! On 25.01.2018 23:05, Dan Haywood wrote: > Hi Andreas, > > thanks for doing this work, very happy to see the codebase being tidied up > and you bringing in some useful utility classes. > > One question though ... > > Obviously in the fut

Re: Internal API: Introduction

2018-01-25 Thread Dan Haywood
Hi Andreas, thanks for doing this work, very happy to see the codebase being tidied up and you bringing in some useful utility classes. One question though ... Obviously in the future when we're on Java 9, this package can be made truly private and hidden from other consumers. But in the meanti