stefan-egli commented on PR #1326:
URL: https://github.com/apache/jackrabbit-oak/pull/1326#issuecomment-1966567441
thx for merging @mbaedke !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504280658
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new Checkpoi
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504283327
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -82,6 +97,7 @@ public class RevisionsCommand implements Command {
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504288687
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504290603
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1053,6 +1053,28 @@ private void collectUn
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504293588
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504304416
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -460,6 +494,97 @@ private void sweep(RevisionsOptions options, Closer clo
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504309300
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleanerTest.java:
##
@@ -0,0 +1,549 @@
+package org.apache
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504314717
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504315202
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504318420
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the
stefan-egli commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1966670655
It's generally speaking a bit difficult to review as the code doesn't
compile at this point (therefore eg you can't debug through it, to understand
it better). As I understand
fabriziofortino merged PR #1327:
URL: https://github.com/apache/jackrabbit-oak/pull/1327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...
rishabhdaim merged PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
stefan-egli commented on PR #1315:
URL: https://github.com/apache/jackrabbit-oak/pull/1315#issuecomment-1966884398
ah, you right away merged it, ok :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504533722
##
oak-run/src/main/groovy/org/apache/jackrabbit/oak/console/GroovyConsole.groovy:
##
@@ -124,6 +124,7 @@ class GroovyConsole {
new CheckpointC
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1504557325
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Ap
fabriziofortino commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r150551
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505586923
##
oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/ManyChildrenIT.java:
##
@@ -82,7 +80,7 @@ public void addRemoveNodes() throws Exception {
}
@T
nfsantos commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r1505604037
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,70 @@ s
nfsantos commented on code in PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#discussion_r1505604811
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -184,65 +181,70 @@ s
rishabhdaim opened a new pull request, #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Joscorbe commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505968214
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,7 +360,27 @@ private void applyToDocumentStore(RevisionVe
smiroslav commented on code in PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#discussion_r1505962367
##
oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/cli/container/SegmentAzureServicePrincipalNodeStoreContainer.java:
##
@@ -0,0 +1,100 @@
+package
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1505997636
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(Revisio
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506010020
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(RevisionVec
Joscorbe commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506008713
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(RevisionVe
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506016539
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506046428
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(Revisio
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506050953
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable Str
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506056762
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506057283
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class DocumentNod
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506058504
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -181,6 +181,8 @@ public class DocumentNod
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506059960
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable String
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506060798
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##
@@ -127,6 +127,7 @@ public class DocumentNodeSto
rishabhdaim merged PR #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jac
rishabhdaim commented on PR #1332:
URL: https://github.com/apache/jackrabbit-oak/pull/1332#issuecomment-1969118364
thanks for review @stefan-egli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506066095
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(Revisio
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506066452
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
rishabhdaim commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506077322
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable Str
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506094311
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
stefan-egli commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506097290
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(Revisio
mbaedke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506099419
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -571,6 +571,8 @@ public Long apply(@Nullable String
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506101202
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##
@@ -869,6 +872,11 @@ public int getMemory() {
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506104757
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##
@@ -181,6 +181,8 @@ public class DocumentNodeSto
reschke commented on code in PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317#discussion_r1506112813
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/Commit.java:
##
@@ -354,6 +358,39 @@ private void applyToDocumentStore(RevisionVec
reschke opened a new pull request, #1333:
URL: https://github.com/apache/jackrabbit-oak/pull/1333
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke merged PR #1333:
URL: https://github.com/apache/jackrabbit-oak/pull/1333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
mbaedke merged PR #1317:
URL: https://github.com/apache/jackrabbit-oak/pull/1317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
steffenvan commented on PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331#issuecomment-1969463801
Don't have anything to add LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
smiroslav commented on PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#issuecomment-1970690588
@t-rana for new files please add license headers
```
[INFO] BUILD FAILURE
[INFO]
[
reschke opened a new pull request, #1334:
URL: https://github.com/apache/jackrabbit-oak/pull/1334
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke merged PR #1334:
URL: https://github.com/apache/jackrabbit-oak/pull/1334
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
nfsantos merged PR #1331:
URL: https://github.com/apache/jackrabbit-oak/pull/1331
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackra
t-rana commented on code in PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329#discussion_r1508497917
##
oak-upgrade/src/test/java/org/apache/jackrabbit/oak/upgrade/cli/container/SegmentAzureServicePrincipalNodeStoreContainer.java:
##
@@ -0,0 +1,100 @@
+package or
reschke opened a new pull request, #1335:
URL: https://github.com/apache/jackrabbit-oak/pull/1335
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mbaedke opened a new pull request, #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke opened a new pull request, #1337:
URL: https://github.com/apache/jackrabbit-oak/pull/1337
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke merged PR #1335:
URL: https://github.com/apache/jackrabbit-oak/pull/1335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
kwin merged PR #1311:
URL: https://github.com/apache/jackrabbit-oak/pull/1311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrabbit
reschke opened a new pull request, #1338:
URL: https://github.com/apache/jackrabbit-oak/pull/1338
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke commented on PR #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336#issuecomment-1973433681
Oh, wow.
I'm somewhat concerned by the amount of changes over on the elastic search
side. Either these need to be double-checked by the right people
(@fabriziofortino ???),
reschke merged PR #1337:
URL: https://github.com/apache/jackrabbit-oak/pull/1337
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
github-actions[bot] commented on PR #509:
URL: https://github.com/apache/jackrabbit-oak/pull/509#issuecomment-1974177235
This PR is stale because it has been open 24 months with no activity. Remove
stale label or comment or this will be closed in 30 days.
--
This is an automated message f
github-actions[bot] closed pull request #478: fix links to javadoc
URL: https://github.com/apache/jackrabbit-oak/pull/478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
mbaedke commented on PR #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336#issuecomment-1976026683
@reschke,
> we really do not want to introduce shaded Guava into 1.22
Yes, obviously. That one sneaked in with the cherry-pick. I'll remove it.
--
This is an automat
reschke merged PR #1338:
URL: https://github.com/apache/jackrabbit-oak/pull/1338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
reschke opened a new pull request, #1339:
URL: https://github.com/apache/jackrabbit-oak/pull/1339
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
smiroslav merged PR #1329:
URL: https://github.com/apache/jackrabbit-oak/pull/1329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackr
nfsantos opened a new pull request, #1340:
URL: https://github.com/apache/jackrabbit-oak/pull/1340
Add property to specify list of paths to be excluded from Mongo download:
`oak.indexer.pipelined.mongoCustomExcludedPaths`.
Custom path filtering will only be applied if the index includ
reschke commented on PR #1318:
URL: https://github.com/apache/jackrabbit-oak/pull/1318#issuecomment-1976399507
I *believe* these are created by the ancient Felix SCR plugin (see
[OAK-6741](https://issues.apache.org/jira/browse/OAK-6741))
--
This is an automated message from the Apache Git
mbaedke commented on PR #1213:
URL: https://github.com/apache/jackrabbit-oak/pull/1213#issuecomment-1976441288
@reschke that is very likely
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
reschke commented on PR #1213:
URL: https://github.com/apache/jackrabbit-oak/pull/1213#issuecomment-1976495050
I agree these are wrong, but they *are* used as names in the generated OSGi
metadata. We need to fix them, butI'm not sure we can simply remove (thus
rename) them.
--
This is an
reschke merged PR #1339:
URL: https://github.com/apache/jackrabbit-oak/pull/1339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
Joscorbe closed pull request #1191: OAK-10535: Clean up old revisions in a
document
URL: https://github.com/apache/jackrabbit-oak/pull/1191
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
fabriziofortino commented on code in PR #1340:
URL: https://github.com/apache/jackrabbit-oak/pull/1340#discussion_r1511168284
##
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##
@@ -126,6 +126,1
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511258728
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -82,6 +97,7 @@ public class RevisionsCommand implements Command {
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511333001
##
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##
Review Comment:
I haven't done any change
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511343112
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Ap
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511343772
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -460,6 +494,97 @@ private void sweep(RevisionsOptions options, Closer closer
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511344989
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Ap
rishabhdaim commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511357714
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -32,6 +37,7 @@
import java.util.concurrent.TimeUnit;
import java.util.c
Joscorbe commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1976895834
I have squashed the WIP commits, sorry for the forced-PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
rishabhdaim commented on PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#issuecomment-1976901217
Could you please revert `VersionGarbageCollectorIT` from your PR, it looks
like you haven't made any changes in this file.
--
This is an automated message from the Apache Git
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511389602
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/NodeDocumentRevisionCleaner.java:
##
@@ -0,0 +1,270 @@
+/*
+ * Licensed to the Ap
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1511417455
##
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##
@@ -23,6 +23,11 @@
import java.io.IOException;
import java.util.List;
import
stefan-egli commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1512625559
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1238,12 +1240,11 @@ private void removeUn
mbaedke merged PR #1336:
URL: https://github.com/apache/jackrabbit-oak/pull/1336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
reschke opened a new pull request, #1342:
URL: https://github.com/apache/jackrabbit-oak/pull/1342
This is a proof-of-concept for the removal of an easy-to-replace use of
Guava.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
mbaedke opened a new pull request, #1343:
URL: https://github.com/apache/jackrabbit-oak/pull/1343
Moving to slf4j-2.0.12 and logback-1.5.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
mbaedke merged PR #1213:
URL: https://github.com/apache/jackrabbit-oak/pull/1213
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
mbaedke merged PR #1214:
URL: https://github.com/apache/jackrabbit-oak/pull/1214
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
nfsantos merged PR #1340:
URL: https://github.com/apache/jackrabbit-oak/pull/1340
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackra
reschke opened a new pull request, #1344:
URL: https://github.com/apache/jackrabbit-oak/pull/1344
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
reschke opened a new pull request, #1345:
URL: https://github.com/apache/jackrabbit-oak/pull/1345
(temporary playground for testing)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
reschke merged PR #1344:
URL: https://github.com/apache/jackrabbit-oak/pull/1344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
reschke commented on PR #1344:
URL: https://github.com/apache/jackrabbit-oak/pull/1344#issuecomment-1980412843
trunk:
[b1b7c5a472|https://github.com/apache/jackrabbit-oak/commit/b1b7c5a472d41116b7d5b85330b0740a44c4e1f7]
--
This is an automated message from the Apache Git Service.
To respo
mbaedke opened a new pull request, #1346:
URL: https://github.com/apache/jackrabbit-oak/pull/1346
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
mbaedke merged PR #1346:
URL: https://github.com/apache/jackrabbit-oak/pull/1346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jackrab
Joscorbe commented on code in PR #1328:
URL: https://github.com/apache/jackrabbit-oak/pull/1328#discussion_r1514423969
##
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##
@@ -1398,6 +1399,24 @@ private void delayOnModif
601 - 700 of 3730 matches
Mail list logo
