Ah-- I missed the difference between "build" and "deploy", thanks Claude!
ajs6f
Claude Warren wrote on 6/5/17 10:31 AM:
I made the same change to jena development deploy so we should get a deploy
this evening.
On Mon, Jun 5, 2017 at 2:43 PM, <aj...@apache.org &
Hm, looks like Claude's latest build failed on the same problem-- did you make
you fix after that?
ajs6f
Andy Seaborne wrote on 6/4/17 11:43 AM:
See the thread
http://mail-archives.apache.org/mod_mbox/www-builds/201706.mbox/%3Cpony-84a3f5a42c31170b6f0cfe9682940d3779cc1a0d
I'll take it up with INFRA tomorrow unless someone beats me to it.
ajs6f
Claude Warren wrote on 6/4/17 8:54 AM:
Looks like the last number of Dev builds have faild for this reason.
On Fri, Jun 2, 2017 at 11:48 AM, Andy Seaborne <a...@apache.org> wrote:
Jena built with maven 3.5.0 l
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/237
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Urg, we're getting:
ERROR: Maven Home /home/jenkins/tools/maven/latest3 doesnt exist
out of that. That doesn't look right. Is that an INFRA ticket or just wait a
bit and see if it comes back?
ajs6f
Apache Jenkins Server wrote on 6/1/17 7:34 AM:
See
<https://builds.apache.org/
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/257
Yeah, I was going to look at that at some point-- transitive dependency
management, yes, please!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/257#discussion_r119154650
--- Diff: jena-parent/pom.xml ---
@@ -59,10 +59,10 @@
2.5
3.4
-1.3
-0.6
+1.4
+0.7
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/257
Upgrade some dependencies to next minor versions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1353
Alternatively you can review
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/255#discussion_r118848106
--- Diff:
jena-fuseki2/jena-fuseki-embedded/src/test/java/org/apache/jena/fuseki/embedded/FusekiTestAuth.java
---
@@ -0,0 +1,182 @@
+/**
+ * Licensed
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/253
JENA-1346: HttpOp: switch to a pooling HttpClient as the default
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena patch-1
Alternatively
When the site is republished. At latest, that happens with a release, but we can do it at other times. I don't know that we have a specific policy as to when
(other than a release) it happens, but maybe we do?
ajs6f
Chris Tomlinson wrote on 5/24/17 11:32 AM:
When do these sorts of changes
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/251#discussion_r117814042
--- Diff:
jena-arq/src/main/java/org/apache/jena/atlas/web/TypedInputStream.java ---
@@ -31,6 +31,7 @@
// May be different from the URI used to access
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/251#discussion_r117796673
--- Diff:
jena-arq/src/main/java/org/apache/jena/atlas/web/TypedInputStream.java ---
@@ -31,6 +31,7 @@
// May be different from the URI used to access
We are pleased to announce the release of Apache Jena 3.3.0.
The major feature of this release is in jena-text.
* jena-text: Upgrade to Lucene v6.4.1
Important: Data will need to be reloaded into text indexes.
* jena-text: Support for Elasticsearch: v5.2.2 contributed by Anuj Kumar
New
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/237#discussion_r116380794
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/NodeValueSortKey.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/237#discussion_r116378420
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/expr/nodevalue/NodeValueSortKey.java
---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache
I agree that Any23 could be a good home for it, and better than Commons RDF, which seems to be more focused on the basic RDF API, and I also agree that we
should keep an ongoing policy of trying to work with Commons RDF when possible. I don't think any development we have in the immediate future
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
Okay, cool! Just give a yell when you want more eyes on it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
Hey, @dick-twocows -- just checking in on this. Are you still adding more
commits or is it time to move on to in-dept review? Thanks again for this
contribution!
---
If your project is set up
I'm basically +1 to this. I wouldn't mind "setting a cron job" to do a similar
review every other or every three releases.
---
A. Soroka
Bruno P. Kinoshita wrote on 5/11/17 4:59 AM:
+1 to removing Fuseki1 now. And +1 for the legacy module definition and
expectations.
I'd be fine with
I had already closed this release with the right date and opened 3.4.0. Is that
what you mean?
---
A. Soroka
Andy Seaborne wrote on 5/10/17 4:23 AM:
JIRA?
On 09/05/17 14:45, aj...@apache.org wrote:
Okay, just catching up to this-- thanks very much Andy for stepping in!
I think all that is
Okay, just catching up to this-- thanks very much Andy for stepping in!
I think all that is left for me to do is apply the final git tag and send announcements (I'm not thinking to send an announcement to semantic-...@w3.org, or
should I?).
That was quite a ride. In California, Osma and I
Andy, was that just you reverting the several mis-aimed commits I made today?
---
A. Soroka
build...@apache.org wrote on 5/8/17 4:38 PM:
The Buildbot has detected a restored build on builder jena-site-staging while
building . Full details are available at:
Okay, at this point I am getting messages from buildbot I don't understand at
all:
https://ci.apache.org/builders/jena-site-staging/builds/201/steps/compile/logs/stdio
I'm really hesitant to publish the site under these circumstances, but is that
the best alternative?
---
A. Soroka
Andy
---
A. Soroka
sorok...@gmail.com wrote on 5/7/17 3:04 PM:
Okay, folks, we have 3 binding +1 votes and no binding -1 votes and 2
non-binding +1 votes. Thanks very much to everyone who tested!
I will be continuing the release process, so we will soon have Jena 3.3.0.
---
A. Soroka
Dick
+1 from builds on Mac OS X 10.10.5 using Java build 1.8.0_40-ea-b22.
---
A. Soroka
Dick Murray wrote on 5/4/17 6:10 AM:
+1
mvn install passed on Ubuntu 17.04 and CentOS 7 and Fedora 25.
I've merged this with my fork and deployed to some of our test servers
(Fedora 25) which are under load
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/237
It's hard for me to reason about what will happen if the first param is
allowed to vary along the bindings... do we care about weirdness like that or
is that just such a strange thing to do that we
It's not the worst thing ever, and as you say, it's not a frequent bother.
If it (it = the 0.0.1 suggested step) is coming from upstream (meaning the plugin) perhaps we can raise a ticket there for a Maven config parameter to adjust.
It's not going to be a super-priority for them, I wouldn't
time
and we can extend the vote period.
Thanks,
ajs6f
Checking needed:
+ does everything work on Linux?
+ does everything work on MS Windows?
+ does everything work on OS X?
+ are the GPG signatures fine?
+ are the checksums correct?
+ is there a source archive?
+ can the source archive
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/237#discussion_r114351493
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
---
@@ -954,7 +971,8 @@ public boolean isDayTimeDuration()
public boolean
I am starting the work now.
The release setup is offering to go to 3.3.1-SNAPSHOT, but didn't we decide to go directly to 3.4.0? I admit, I've gotten mixed around in the discussion and
doing this while physically cleaning out twenty years of accumulated stuff in my office is not clarifying my
I think this is indeed where we are getting to (that client and context need to be fully threaded through the whole API). That's kind of the price we pay to
avoid doing lots and lots of work to hide them.
I'm not as sure that context without client works as well... but it does seem
from the
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/133
NP, @CesarPantoja. If your work concerned Jena, please feel free to let the
list know about it. It's good to share good news.
---
If your project is set up for it, you can reply to this email and have
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/133
@CesarPantoja Have you had a chance to take the warnings mentioned above
into account?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/246
I second what @osma said and I would add that there is a possible further
learning challenge with this new functionality in that the two selections for
test indexing, Lucene and ElasticSearch, would
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
@rmorrise If you are satisfied with our work on JENA-1321, would you close
this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/241
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/243#discussion_r112275972
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/lang/ReaderRIOTRDFXML.java ---
@@ -172,10 +185,9 @@ private static Node convert(ALiteral lit
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
The tests pass fine, because as @afs prescribed, we aren't changing the
wrapping of exceptions, just adding useful information to "outer" ones.
---
If your project is set up for it, you
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
No, actually, I did not start with your code-- if you look at what I did, I
added fields and accessors and a constructor to `QueryExceptionHTTP` instead as
we discussed. You need do nothing further. I
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/241
@rmorrise, will this suit you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/241
JENA-1321: Exception rewrapping in HttpQuery masks error response from the
server
It's a bit odd-feeling to couple `HttpException` so tightly, but given that
it is an Atlas type, I don't feel terrible
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
`org.apache.jena.atlas.web.HttpException` only has `getResponseCode()`,
`getStatusLine()`, and `getResponse()`. Wouldn't it work to just add those
three to `QueryExceptionHTTP`?
---
If your project
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/240
If that understanding is correct (and I now share it) then I agree with
@afs's proposal, and I can make that change. @rmorrise ?
---
If your project is set up for it, you can reply to this email
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/237#discussion_r111237018
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java
---
@@ -784,10 +786,15 @@ private static int compare(NodeValue nv1, NodeValue
nv2
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110256573
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110256243
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110254192
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110254074
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110252024
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/DatasetGraphMosaic.java
---
@@ -0,0 +1,589 @@
+package
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
That seems reasonable to start with (blocking). That's what people would
get if they were addressing the mosaic pieces directly.
---
If your project is set up for it, you can reply to this email
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110245723
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
Ah, okay, cool. (Re: Javadocs)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
@dick-twocows , am I right in thinking that the assumption you are making
about the "mosaic pieces", the child-datasetgraphs, is that they are MR+SW? Or
are you somehow bein
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/233
There is a lot of cool functionality here, but I don't see any tests at
all. Are they coming in a separate PR?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110183160
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/thrift/IteratorCached.java
---
@@ -0,0 +1,21 @@
+package org.apache.jena.sparql.core.thrift
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110182274
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/TransactionalDistributed.java
---
@@ -0,0 +1,267 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110182062
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/TransactionalDistributed.java
---
@@ -0,0 +1,267 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110180946
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110180316
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/ThreadProxy.java ---
@@ -0,0 +1,100 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110179015
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/LockTry.java ---
@@ -0,0 +1,8 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/233#discussion_r110013073
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mosaic/Topology.java ---
@@ -0,0 +1,45 @@
+package org.apache.jena.sparql.core.mosaic
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
Fixed with
https://git-wip-us.apache.org/repos/asf?p=jena.git;a=commit;h=711e9be838efdb056bfa4bccc253c58799affea0
---
If your project is set up for it, you can reply to this email and have your
reply
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/223
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/232
fixing symlink behavior for Mac OS X
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1297
Alternatively you can review and apply
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
I was waiting to hear confirmation from the reporter that this is a fix,
but it's been quite a while. I have no prob with merging this as-is.
---
If your project is set up for it, you can reply
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
@osma I'm done mumbling over this PR. I think it looks okay. I did leave
some questions about the Maven stuff, but nothing in there makes me freak out.
The biggest question I have is why `log4j
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108439061
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/it/BaseESTest.java ---
@@ -0,0 +1,111 @@
+/**
+ * Licensed to the Apache Software
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108438170
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108438002
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108437929
--- Diff: jena-text/pom.xml ---
@@ -112,11 +138,72 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r108437539
--- Diff: jena-text/pom.xml ---
@@ -81,6 +81,32 @@
lucene-queryparser
+
+ org.elasticsearch
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I think that if we are confident that we have solid test coverage and that
it runs correctly, we can merge and clean up as time permits. I will take a
look at the Maven setup and see if anything worries
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I'm definitely cool with squashing a bit. I think that helps posterity a
lot. Two possible (plausible?) principles:
1. Each post-squash commit should move the codebase from a does-build state
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/227#discussion_r107435245
--- Diff: jena-text/pom.xml ---
@@ -112,11 +141,77 @@
org.apache.maven.plugins
maven-surefire-plugin
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I don't know enough to have a useful opinion about how thorough the tests
need to be-- I am very happy to defer to @osma about that.
As for the test framework-- my (small) knowledge of ES
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
No prob-- good to see you back, @kinow !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
@anujgandharv, the first place to look is at the actual
`jena-integration-tests` module. You will see there that the tests follow the
same form as in other Jena modules (explicitly linked together
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/227
I'm just catching up with this PR, so apologies if I turn out to have
missed part of the conversation!
If there is difficulty getting tests integrated into the Maven lifecycle
within one module
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/223
Yeah, `HttpOp` is usually my first stop for this kind of thing because my
understanding is that in theory, all ARQ routes all HTTP traffic through
`HttpOp`.
---
If your project is set up for it, you
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/223
JENA-1309: HttpOp should respect system properties for default client
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1309
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
Closing in favor of further more general discussion about points raised on
this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/50
Are commits showing up there a release, or a mirroring of the source code
repository like Github?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/209
Perhaps you could open an ordinary Jira issue with sample data and code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/37
Given that #38 is merged, is this still live?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/50
@stain @kinow Were we able to get testing of some kind done? I can see real
utility for a Docker image, because it would let a wider audience try out
Fuseki more easily, and for some people, would give
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
@kinow is this still live?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/215
A big +1 to the `return this;` idiom. It's very convenient in this kind of
work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/213
+1: this is clearer. But that's coming from someone w/o much familiarity
with this part of the code!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/213#discussion_r98915106
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/tokens/StringType.java ---
@@ -0,0 +1,22 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/212
My 2¢ are inline, but I echo @rvesse's questions as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/212#discussion_r98912284
--- Diff: jena-core/src/main/java/org/apache/jena/graph/GraphUtil.java ---
@@ -115,55 +117,44 @@ public static void add(Graph graph, Triple[] triples
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/212#discussion_r98912881
--- Diff: jena-core/src/main/java/org/apache/jena/graph/GraphUtil.java ---
@@ -115,55 +117,44 @@ public static void add(Graph graph, Triple[] triples
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/210
Fixing JENA-1283 by using Maven properties to control versions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena JENA-1283
Alternatively
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/209
I agree with @rvesse . One doesn't take control of the lifecycle of a
parameter like this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
I'm starting to wonder whether I should back up here and just go for the
more general 2-phase-locking design as [@afs discusses in the Jira
ticket](https://issues.apache.org/jira/browse/JENA-1274
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/204
Yeah, judging by the general silence in response to my question about "Does
anyone have other use cases for this kind of thing?" I'm not going to push on
that I'm happy for it to be helpful
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/205
Sure, so my claims are 1) this is a good PR :) and 2) if we want to offer
the kind of functionality that you are removing, that's cool, but we should do
it in some appropriate, public, maintainable way
401 - 500 of 1019 matches
Mail list logo
