[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-26 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/401 This, to my mind, is now well into the realm of 4.0-sized changes. ---

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 a quick note here about the prospect of further restructuring to support jpms. I have learned today that if a module (e.g. `org.apache.jena.arq`) does not contain a single top level

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 See PR #408 for updating the shaded Google guava. ---

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-25 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 PR merged and email sent to dev@jena to let everyone know this has an impact on ServiceLoader files. ---

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-24 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 `RemovalNotification` is used in the constructor for `CacheGuava`. ---

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-24 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 Indeed, these dependency questions are issues that I need to solve... I would prefer to simplify the über-jar `jena-osgi` dependency of `commons.rdf.jena` by creating lean modular jena

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-24 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 > Compilation in JPMS requires a module-info.java and is distinct from compiling in JDK 9+. The issue is for trellisldp to solve surely? The transitivity is an indirect jena-osgi dependency and

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-24 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 Compilation in JPMS requires a `module-info.java` and is distinct from compiling in JDK 9+. > What is the issue here? Does anything break? A quick background of the use

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 jdeps complains about oaj.dboe so having a common automatic-moulde-name seems not to work. Clearing that out and xerces, then /usr/lib/jvm/java-9-openjdk-amd64/bin/jdeps -R

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 I ran: /usr/lib/jvm/java-9-openjdk-amd64/bin/jdeps -cp 'lib/*' lib/jena-arq-3.8.0-SNAPSHOT.jar and the only split packages reported are for Xerces/xml-apis. Various packages under

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 What is the issue here? Does anything break? oaj = org.apache.jena > the module system does not allow two distinct modules (e.g. org.apache.jena.arq and org.apache.jena.base) to export

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 re: `org.apache.jena.atlas` dependents in `org.apache.jena.arq` (namely `org.apache.jena.riot`) I attach an excerpt from a `jdep`s output looking at `jena-arq-3.7.0.jar`, sorted

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 I've tried out the PR and it passes the build and Fuseki starts up. I renamed the ServiceLoader files as `org.apache.jena.sys.JenaSubsystemLifecycle` (I have a script for that now,I can do that after the

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 jena-arq does not need to export `org.apache.jena.atlas` - it needs to export `org.apache.jena.atlas.csv`, org.apache.jena.atlas.data` etc. `org.apache.jena.atlas` does not depend on `riot`, it

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 the module system does not allow two distinct modules (e.g. `org.apache.jena.arq` and `org.apache.jena.base`) to export the same package (e.g. `org.apache.jena.atlas`). There

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-23 Thread afs
Github user afs commented on the issue: https://github.com/apache/jena/pull/401 I don't see a split package in `org.apache.jena.atlas` - it has classes and sub-packages in `jena-base` and separate sub-packages in `jena-arq` but I don't see a package being split. That should not be a

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-21 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/401 That sounds like a set of changes (e.g. module renaming) much better suited for 4.0. ---

[GitHub] jena issue #401: [JENA-1524] org.apache.jena.system is split by org.apache.j...

2018-04-21 Thread christopher-johnson
Github user christopher-johnson commented on the issue: https://github.com/apache/jena/pull/401 In working with the automatic modules, I have also found a split with`org.apache.jena.atlas`. This is between `org.apache.jena.arq` and `org.apache.jena.base`. Would it make