Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/404
+1
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/403
+1
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/380
@FSchumacher , what do you think of
https://github.com/LatencyUtils/LatencyUtils/ ?
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
@pmouawad , please review https://github.com/apache/jmeter/pull/369
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
"Precise Throughput Timer" sounds goods.
PS. There's "Poisson Random Timer" in JMeter:
http://jmeter.apache.org/usermanual/component_reference.html#Poisson_Random_Timer
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
@pmouawad , thanks anyway for giving it a spin.
Do you think it requires changes?
If not, I think I can prepare a doc draft.
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
> Philippe: It is just that as per your confirmation, one of the aims of
this new component was:
> Vladimir: "The very basic requirement is to ensure you end up exactly 50
iterations
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>Is it really supposed to be exact ?
Let me ask another question: "is thread scheduler=120sec supposed to make
the test to last exactly 120 seconds"?
Note: **timers
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>Could you confirm your component implements the following features:
That's true.
---
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>I will commit this PR unless there is a NO GO within 2 days.
Philippe, thanks for looking into this. I'm afraid the documentation is
missing.
---
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122906273
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -127,19 +163,28 @@ public Date getExpires() {
* @param
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/298#discussion_r122906537
--- Diff:
src/protocol/http/org/apache/jmeter/protocol/http/control/CacheManager.java ---
@@ -180,65 +221,97 @@ private void setCache(String lastModified
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113696169
--- Diff: res/maven/ApacheJMeter_parent.pom ---
@@ -427,6 +428,11 @@ under the License.
hamcrest-core
${hamcrest-core.version
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113698496
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113695286
--- Diff: build.xml ---
@@ -400,6 +400,7 @@
+
--- End diff --
This line seems to be using tabs while file
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113697973
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113696083
--- Diff: licenses/bin/hamcrest-date-2.0.4.txt ---
@@ -0,0 +1 @@
+According to https://github.com/eXparity/hamcrest-date Hamcrest-date is
under BSD License
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113700339
--- Diff: test/src/org/apache/jmeter/functions/TestTimeShiftFunction.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113696389
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113696887
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113698701
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113697784
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113698846
--- Diff: src/functions/org/apache/jmeter/functions/TimeShift.java ---
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/291#discussion_r113700248
--- Diff: test/src/org/apache/jmeter/functions/TestTimeShiftFunction.java
---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/233
> I will test and consider a solution
The question is if that is feasible at all to support run-time variable
changes and keep the performance sane
---
If your project is set up for it,
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/233
Just in case, C and C1 has the following groovy post-processor:
`vars.put("x", String.valueOf(1+Integer.parseInt(vars.get("x"`
---
If your project is set up for it, you can
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/233
While being able to enable-disable and rename the children from WDC UI is
nice, I wonder how many worms are hidden in that "keep WDC and children tree"
consistent can.
Nested
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>In my test plan I have 3 http request and one Exponential Timer at the
same level
That does not work like this.
Please wrap "expenential timer" into some sampler (e.g.
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>I have some strange behavior in some test
What is the behavior?
Don't get me wrong, but I think the UI should be obvious. If the UI is
obscure and/or the tooltip does not h
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
@ra0077 , have you seen the tooltips for the input values of the timer?
I'm sure those should explain all the things.
---
If your project is set up for it, you can reply to this email and have
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
> Too much parameter
Well, UI is built by JMeter OOB:
https://github.com/apache/jmeter/pull/231/files#diff-fc396f633dbdaf0a98c5472613e9190dR25
Do you know if BeanInfoSupport can cre
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
> And if "test duration" parameter is not equal to expected test duration?
Nothing breaks. The idea is as follows: each "test duration" the timer
produces
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
>I don't understand how to use "Test duration" parameter
The timer is random. Suppose one wants to have "100 samples per hour".
Suppose the test
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/231
> Any reason for not using ThreadLocalRandom.current() instead of Random ?
TLR does not support setSeed. setSeed is required to get reproducible
workloads.
>
https://docs.orac
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/231
WIP: timer that produces poisson arrivals with given constant throughput
see
http://mail-archives.apache.org/mod_mbox/jmeter-dev/201609.mbox/%3CCAB%3DJe-EBhT-hD-oAorpnyfR%2By
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/230#discussion_r82242980
--- Diff: README.md ---
@@ -0,0 +1,190 @@
+
+# Apache JMeter
+
+## What
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/228
Looks good. Just one question: HOW did you find that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
> remove log to avoid performance problem
+1
Technically speaking, I would prefer set the language to "groovy" if it was
not specified.
That would make the U
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
>I don't know how to implement
For instance, a boolean flag that is cleared after the fist warning is
printed.
---
If your project is set up for it, you can reply to this email and have y
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73691076
--- Diff: src/core/org/apache/jmeter/util/ScriptingTestElement.java ---
@@ -36,6 +36,8 @@
private String script = ""; // script (if file no
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/223
-1 for logging a warning on each sampler execution.
Typical user would never open log files, and get bad performance results
(or even log overflow of some kind)
---
If your project is set up
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
> OSGI approach is a huge & complex piece of work, frankly I doubt we do it
knowing all the other more important things we have on roadmap and that do not
make any progress.
Alte
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
>if you want CLHM, why not propose a PR implementing PR-221 with it ? or do
you prefer to wait for decision on guava or not guava ?
I prefer to wait an agreement first, since the code is sim
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
> commons-math3 takes 2.2 MiB and is being used by exactly 4 classes in
JMeter. Should we write the statistics computation from scratch to save those
2MiBs? Hell no
That is a nice find
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
> Hashing is surely not the bottleneck in JMeter overall performances.
Why do you think synchronized CSS cache is the bottleneck then?
---
If your project is set up for it, you can re
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
> jloisel: Groovy alone takes 7.0MiB
Do you have better language for JSR232 in mind?
The thing is beanshell is outdated, and Nashorn JS is not yet very popular.
In other wo
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
>jloisel: Calcite is a database framework whose purpose is to be integrated
into java applications
JMeter's purpose is to be integrated with various plugins, so exposing
extra c
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
> like Webdriver, which also uses Guava 19.0
That basically means if newer Webdriver would use Guava 20, that might
render "newer webdriver incompatible with older JMeter". That i
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
>What I mean is create an LRU based on CHM
That is basically what CLHM does. So I would pull CLHM and save our
resources for something more valuable than "implementing yet another C
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
https://issues.apache.org/jira/browse/CALCITE-736
>Guava is involved in major dependency hells in Java, with Hadoop the most
affected ecosystem.
>Removing Guava types from visible
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
Regarding "fast cache with limited size", there's
https://github.com/ben-manes/concurrentlinkedhashmap
It is 120 KiB jar with very little possibility to break backward
compatib
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
Re guava: AFAIK, if guava is included into JMeter, then it might clash with
plugins that also want guava.
AFAIK, guava is known to break backward compatibility quite often, so it
might trigger &quo
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/221
>Ok thanks for feedback, I'll commit the PR after further review
+2MiB of dependencies :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on Git
Github user vlsi commented on the issue:
https://github.com/apache/jmeter/pull/215
Looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/198#issuecomment-211285422
Thanks for the change. It looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/187#issuecomment-207733923
@ra0077, thanks for the PRs, however could you please try reusing the PRs
next time?
Regarding "the right properties files", can you please clarify i
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/186#issuecomment-207628919
Are changes to `messages.properties` and `messages_fr.properties`
intentional?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/181#discussion_r58370745
--- Diff: src/core/org/apache/jmeter/util/JMeterUtils.java ---
@@ -311,20 +315,47 @@ public void initializeProperties(String file) {
* The output array
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/181#issuecomment-205280416
@undera , are those merge commits required in this PR?
Can you rebase "Separate thirdparty dirs" commit on top of trunk?
---
If your project is set up for i
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/181#discussion_r58365976
--- Diff: src/core/org/apache/jmeter/NewDriver.java ---
@@ -85,9 +86,22 @@
// Add standard jar locations to initial classpath
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/180
Log file contents in ant.batchtest failure case
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vlsi/jmeter debug_batchtest
Alternatively you can
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/176#issuecomment-204978579
> Sorry , I had some hallucination although I checked twice :-) , it is
package protected.
You are fine. I've just updated the PR as you suggested package-priv
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/179#issuecomment-204970518
> Memory estimation of SampleResult is too positive I think
Some heap dumps might help to get idea of the sampleresult.
---
If your project is set up for it,
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/179#discussion_r58309908
--- Diff: src/core/org/apache/jmeter/resources/messages.properties ---
@@ -1235,6 +1235,8 @@ view_results_in_table=View Results in Table
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/179#discussion_r58309855
--- Diff: src/components/org/apache/jmeter/visualizers/TableVisualizer.java
---
@@ -205,6 +226,26 @@ public void run
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/178
Refactor TestCacheManager: replace duplicated code with inheritance
Reduce timeouts from 5 to 1 seconds to speedup test execution
You can merge this pull request into a Git repository by running
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/177
Compress PNGs
`pngquant --force --ext .png *.png`
This reduces size of xdocs/images from 12MiB to 6.5MiB
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/176
Use explicit timeout for TestDNSCacheManager, so test is executed faster
`org.apache.jmeter.protocol.http.control.TestDNSCacheManager#testCloneWithCustomResolverAndInvalidNameserver`
took 30 seconds
GitHub user vlsi opened a pull request:
https://github.com/apache/jmeter/pull/175
Move checkstyle to a separate Travis job
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vlsi/jmeter travis_upd
Alternatively you can review
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/167#discussion_r56486961
--- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
@@ -428,7 +431,7 @@ private BufferedReader createBufferedReader(FileEntry
fileEntry) throws
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/171#issuecomment-198529464
@benbenw , thanks for bringing this up.
Can you please enable relevant checkstyle rule so it would capture
non-capital static finals violations in the future
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/167#discussion_r56465359
--- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
@@ -418,16 +418,20 @@ private BufferedReader getReader(String alias,
boolean recycle, boolean
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/167#discussion_r56164700
--- Diff: src/core/org/apache/jmeter/services/FileServer.java ---
@@ -428,6 +429,9 @@ private BufferedReader createBufferedReader(FileEntry
fileEntry) throws
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/162#issuecomment-196795299
>I have swap it and remove formating to be easy to read it
@ra0077, would you please update the PR then?
---
If your project is set up for it, you can re
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/162#issuecomment-196710977
>I don't have modify these lines.
@ra0077, can you please rework the PR without reformatting the whole method?
---
If your project is set up for it, you can re
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/162#discussion_r56126978
--- Diff: src/components/org/apache/jmeter/config/CSVDataSet.java ---
@@ -146,71 +146,76 @@ public void setProperty(JMeterProperty property
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/162#discussion_r56126557
--- Diff: src/components/org/apache/jmeter/config/CSVDataSet.java ---
@@ -146,71 +146,76 @@ public void setProperty(JMeterProperty property
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/162#discussion_r56126539
--- Diff: src/components/org/apache/jmeter/config/CSVDataSet.java ---
@@ -146,71 +146,76 @@ public void setProperty(JMeterProperty property
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/27#discussion_r38084911
--- Diff:
src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
---
@@ -18,34 +18,44 @@
package
Github user vlsi commented on the pull request:
https://github.com/apache/jmeter/pull/27#issuecomment-135393177
Looks good except from a glitch with imports moved around.
I'm not sure if additional tests are expected in this PR.
---
If your project is set up for it, you can reply
Github user vlsi commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/27#discussion_r37815468
--- Diff:
src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
---
@@ -338,6 +328,44 @@ private static final int countRows(ResultSet
81 matches
Mail list logo
