GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/64
Fixed Rescoring test
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua 7
Alternatively you can review
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/63
Fixed more tests in 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua 7_new
Alternatively you can review
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/62
Fixed NumTranslationOptions test and added deterministic output orderâ¦
⦠of feature vectors
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/61
Fixed NAry test for 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua 7
Alternatively you can review
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/59
Fixed NoGrammarTest for 7
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber/incubator-joshua 7
Alternatively you can review
Github user fhieber commented on the issue:
https://github.com/apache/incubator-joshua/pull/58
Depends whether we had any end-to-end tests like this already in 7. For the
existing unit tests I already made the necessary changes to pass in 7. Quote
from my commit for the featureFector
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/58
Moved new unit tests (former regression tests) to correct location.
The previous merge from master placed the new regression tests from Michael
into the wrong location. This moves them
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/50
fix basedir path for java.library.path
makes unit tests run with kenlm again
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fhieber
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/41
Major refactoring of features/rules/grammars in Joshua
Major refactoring of core decoder components (Rule.java, FeatureVector.java
and grammars). The core idea of this change
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3e2e053db9cafcdc5b4885a0f6fa5e54a63bc468#commitcomment-18672173
In src/test/java/org/apache/joshua/system/LmOovFeatureTest.java:
In src/test/java/org/apache/joshua/system
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/29
Added option to fire a dense language model oov indicator feature
from LanguageModelFF. By default it is turned off. To activate, specify
'-oov_feature' in the lm line in joshua.config
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/748cf32f956d3fd5772f62e023d0cc8d70a7dcad#commitcomment-17995315
No its totally fine. Thanks for the fix!
---
If your project is set up for it, you can reply to this email and have
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3fb809c444c7855255b51080c368071bc508be1f#commitcomment-17995297
I am fine with testng. Its equally easy to run in eclipse with the plugin
---
If your project is set up for it, you
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/748cf32f956d3fd5772f62e023d0cc8d70a7dcad#commitcomment-17994947
Ah, right! Thanks! Should have looked more closely.
---
If your project is set up for it, you can reply to this email
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/748cf32f956d3fd5772f62e023d0cc8d70a7dcad#commitcomment-17994753
Hi Matt,
Can you comment how this was a bug and what this change changes? Using the
Rule constructor without
Github user fhieber commented on the issue:
https://github.com/apache/incubator-joshua/pull/26
Alright, I can rebase this PR once the ClassLM PR is merged so that we have
a clean separation of those two commits on Github
---
If your project is set up for it, you can reply
Github user fhieber commented on the issue:
https://github.com/apache/incubator-joshua/pull/25
Great, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/26
Owner Ids are maintained in separate mapping now
Removed owner ids from Vocabulary. These are now maintained in their own
mapping. Fixes a bug with multiple packed grammars that would
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/25
ClassLMs: fixed a bug with class-based lms not mapping to class ids for
estimateCost()
Also refactored the code a little bit to have StateMinimizingLanguageModels
support classes as well
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17933645
In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
In src/main/java/org/apache/joshua/decoder
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/6d2213a20b74432fc7cb131c732f7507b74053e9#commitcomment-17928740
In src/main/java/org/apache/joshua/decoder/StructuredTranslation.java:
In src/main/java/org/apache/joshua/decoder
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/3fb809c444c7855255b51080c368071bc508be1f#commitcomment-17817018
I would vote for junit, since these tests were created much more recently
and the older testng tests have not been used
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/pull/20#issuecomment-222445352
Unit tests should all pass now except the MultithreadedTranslation test
because of the interface change to decodeAll()
---
If your project is set up
GitHub user fhieber opened a pull request:
https://github.com/apache/incubator-joshua/pull/20
Some changes to structured translation interface to provide kbest access.
Hi Matt,
I tried to fix all compile errors, but some of the tests still fail due to
the changed decodeAll
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620411
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 193:
where is the right side
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f2f82c38af9aebd28f9d27f685a2e99767a2e575#commitcomment-17620359
In src/joshua/decoder/Decoder.java:
In src/joshua/decoder/Decoder.java on line 39:
is this required
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f5adcdefd3e52c58b36713798c0830d1c42099e3#commitcomment-17618810
In src/joshua/tools/GrammarPacker.java:
In src/joshua/tools/GrammarPacker.java on line 295:
Completely agreed
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/868b340949f324b12d810d03c09c25fd5877d3dc#commitcomment-17618752
There is a Vocabulary unit test
(https://github.com/apache/incubator-joshua/blob/master/tst/joshua/corpus
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f5adcdefd3e52c58b36713798c0830d1c42099e3#commitcomment-17618502
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java:
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f5adcdefd3e52c58b36713798c0830d1c42099e3#commitcomment-17618536
In src/joshua/tools/GrammarPacker.java:
In src/joshua/tools/GrammarPacker.java on line 261:
should probably
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f5adcdefd3e52c58b36713798c0830d1c42099e3#commitcomment-17618628
I love this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/366f408672e2d29b69a78531b57056649629e978#commitcomment-17618694
In src/joshua/decoder/phrase/PhraseTable.java:
In src/joshua/decoder/phrase/PhraseTable.java on line 99:
&qu
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/f5adcdefd3e52c58b36713798c0830d1c42099e3#commitcomment-17618489
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java:
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618411
In src/joshua/decoder/ff/tm/hash_based/MemoryBasedBatchGrammar.java:
In src/joshua/decoder/ff/tm/hash_based
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618391
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java:
In src/joshua/decoder/ff/tm/format/MosesFormatReader.java
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618301
In src/joshua/decoder/ff/tm/format/HieroFormatReader.java:
In src/joshua/decoder/ff/tm/format/HieroFormatReader.java
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/76eb9587a9c321d45a9560481429e2dffd918e4e#commitcomment-17618246
In src/joshua/decoder/ff/tm/Rule.java:
In src/joshua/decoder/ff/tm/Rule.java on line 201:
Fantasic commit! Would
Github user fhieber commented on the pull request:
https://github.com/apache/incubator-joshua/commit/805b643187e07c1d4dcd5047c3ac2dfa0a84e256#commitcomment-17176979
I agree, this is kind of a big deal. Thanks for catching this! I have used
this code before, but did not see clear
38 matches
Mail list logo
