[jira] [Created] (KAFKA-13484) Tag Offline Partition Count by Topic Name

2021-11-25 Thread Mason Joseph Legere (Jira)
Mason Joseph Legere created KAFKA-13484: --- Summary: Tag Offline Partition Count by Topic Name Key: KAFKA-13484 URL: https://issues.apache.org/jira/browse/KAFKA-13484 Project: Kafka

[jira] [Created] (KAFKA-13483) Stale Missing ISR on a partition after a zookeeper timeout

2021-11-25 Thread Jira
F Méthot created KAFKA-13483: Summary: Stale Missing ISR on a partition after a zookeeper timeout Key: KAFKA-13483 URL: https://issues.apache.org/jira/browse/KAFKA-13483 Project: Kafka Issue

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.1 #23

2021-11-25 Thread Apache Jenkins Server
See Changes: -- [...truncated 499282 lines...] [2021-11-25T12:08:24.494Z] > Task :streams:testSrcJar [2021-11-25T12:08:24.494Z] > Task

[jira] [Created] (KAFKA-13482) JRE: Duplicate Key: Multiple bootstrap server URLs

2021-11-25 Thread Michael Anstis (Jira)
Michael Anstis created KAFKA-13482: -- Summary: JRE: Duplicate Key: Multiple bootstrap server URLs Key: KAFKA-13482 URL: https://issues.apache.org/jira/browse/KAFKA-13482 Project: Kafka Issue

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread David Jacot
Hi Tom, I do agree with you. For context, this is the current reason/message logged by the consumer when enforceRebalance is called so I just kept it as it is. I guess that we can revise it during the implementation. Thanks, David On Thu, Nov 25, 2021 at 3:52 PM Tom Bentley wrote: > > Thanks

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Tom Bentley
Thanks for the KIP David. It's a very trivial point, but I did wonder whether "caused" or "requested" might be a better word than "enforced" in the default messages. In any case, +1 (binding). Kind regards, Tom On Thu, Nov 25, 2021 at 2:36 PM David Jacot wrote: > Thanks, Mickael. I have

Re: Permission to contribute to Apache Kafka

2021-11-25 Thread David Jacot
Hi Brett, I've granted you the relevant permissions. Cheers, David On Thu, Nov 25, 2021 at 1:06 AM Brett Jordan wrote: > > Hi, > I would like to be able to contribute to Apache Kafka. > > Wiki ID: brett.jordan > Jira ID: brett.jordan > > Cheers, > [image: Airwallex] > Brett Jordan >

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread David Jacot
Thanks, Mickael. I have removed it. On Thu, Nov 25, 2021 at 3:22 PM Mickael Maison wrote: > > +1 (binding) > Thanks for the KIP > > Just a small suggestion: in other Options classes we don't seem to > prefix setters with "set", so I think we could use void reason(final > String reason). > > > On

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Mickael Maison
+1 (binding) Thanks for the KIP Just a small suggestion: in other Options classes we don't seem to prefix setters with "set", so I think we could use void reason(final String reason). On Thu, Nov 25, 2021 at 1:48 PM Luke Chen wrote: > > Hi David, > Thanks for the KIP! > It is good to have the

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread David Jacot
Hi Mickael, Yes, I briefly considered it. I was trying to stay inline with the `enforceRebalance` method. On second thought, it was likely the wrong way to look at it as we already have the optional members in `RemoveMembersFromConsumerGroupOptions` so adding another optional `reason` field there

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Mickael Maison
Hi David, Thanks for the KIP, it looks like a useful addition. You propose adding a new method removeMembersFromConsumerGroup(String, String, RemoveMembersFromConsumerGroupOptions) to Admin. Have you considered keeping the existing method and instead add the reason to

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Luke Chen
Hi David, Thanks for the update. Just voted! :) Thank you. Luke On Thu, Nov 25, 2021 at 8:42 PM David Jacot wrote: > Hi Luke, > > Good point. I have renamed the KIP. > > Thanks, > David > > On Thu, Nov 25, 2021 at 4:28 AM Luke Chen wrote: > > > > Hi David, > > Sorry for the late reply. > >

Re: [VOTE] KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread Luke Chen
Hi David, Thanks for the KIP! It is good to have the joinGroup/leaveGroup reason sent to brokers for better troubleshooting. +1 (non-binding) Thank you. Luke On Thu, Nov 25, 2021 at 8:14 AM Gwen Shapira wrote: > +1 > > Thanks for driving David. Super useful. > > On Wed, Nov 24, 2021 at 8:53

Re: KIP-800: Add reason to LeaveGroupRequest

2021-11-25 Thread David Jacot
Hi Luke, Good point. I have renamed the KIP. Thanks, David On Thu, Nov 25, 2021 at 4:28 AM Luke Chen wrote: > > Hi David, > Sorry for the late reply. > Thanks for the update. It looks good now. > I love the idea to add joinGroup request reason, as well as the > `enforceRebalance` API! > > One