Re: [DISCUSS] KIP-39 Pinning controller to a broker

2015-10-20 Thread Abhishek Nigam
here are also some minor things like listing it as > released in 0.8.3 that seem wrong. > > -Jay > > On Tue, Oct 20, 2015 at 12:18 PM, Abhishek Nigam < > ani...@linkedin.com.invalid> wrote: > > > Hi, > > Can we please discuss this KIP. The background for this is

[DISCUSS] KIP-39 Pinning controller to a broker

2015-10-20 Thread Abhishek Nigam
Hi, Can we please discuss this KIP. The background for this is that it allows us to pin controller to a broker. This is useful in a couple of scenarios: a) If we want to do a rolling bounce we can reduce the number of controller moves down to 1. b) Again pick a designated broker and reduce the numb

[jira] [Commented] (KAFKA-1599) Change preferred replica election admin command to handle large clusters

2015-09-21 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901279#comment-14901279 ] Abhishek Nigam commented on KAFKA-1599: --- Copying this content verbatim from a n

[jira] [Assigned] (KAFKA-1599) Change preferred replica election admin command to handle large clusters

2015-09-21 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam reassigned KAFKA-1599: - Assignee: Abhishek Nigam > Change preferred replica election admin command to han

[jira] [Commented] (KAFKA-2552) Certain admin commands such as partition assignment fail on large clusters

2015-09-17 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804560#comment-14804560 ] Abhishek Nigam commented on KAFKA-2552: --- Essentially a generic approach to

[jira] [Created] (KAFKA-2552) Certain admin commands such as partition assignment fail on large clusters

2015-09-16 Thread Abhishek Nigam (JIRA)
Abhishek Nigam created KAFKA-2552: - Summary: Certain admin commands such as partition assignment fail on large clusters Key: KAFKA-2552 URL: https://issues.apache.org/jira/browse/KAFKA-2552 Project

Can I get permission to create proposal

2015-08-25 Thread Abhishek Nigam
For pinning the controller to a broker KAFKA-1778 I want to create a proposal detailing the design. My user id is:anigam -Abhishek

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-08-14 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697427#comment-14697427 ] Abhishek Nigam commented on KAFKA-1387: --- Thanks a lot for digging into this.

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-08-11 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692628#comment-14692628 ] Abhishek Nigam commented on KAFKA-1778: --- Thanks Guozhang, I will write it up

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-08-11 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692370#comment-14692370 ] Abhishek Nigam commented on KAFKA-1778: --- Hi Guozhang, I agree 100% with you.

Re: Can someone review ticket 1778

2015-08-11 Thread Abhishek Nigam
, 2015 at 10:55 PM, Abhishek Nigam wrote: > Hi, > For pinning the controller to a broker I have proposed a design. Can > someone review the design and let me know if it looks ok. > I can then submit a patch for this ticket within the next couple of weeks. > > -Abhishek > >

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-05-29 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565837#comment-14565837 ] Abhishek Nigam commented on KAFKA-1778: --- I believe what you are suggesting is

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-05-27 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561833#comment-14561833 ] Abhishek Nigam commented on KAFKA-1778: --- Joel, What I was proposing was that

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-05-19 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550781#comment-14550781 ] Abhishek Nigam commented on KAFKA-1778: --- Jun, The way I see it pinning

Can someone review ticket 1778

2015-05-17 Thread Abhishek Nigam
Hi, For pinning the controller to a broker I have proposed a design. Can someone review the design and let me know if it looks ok. I can then submit a patch for this ticket within the next couple of weeks. -Abhishek

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

2015-05-17 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547566#comment-14547566 ] Abhishek Nigam commented on KAFKA-1888: --- Geoffrey, Thanks for the heads up. I s

[jira] [Updated] (KAFKA-1888) Add a "rolling upgrade" system test

2015-05-17 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1888: -- Assignee: (was: Abhishek Nigam) > Add a "rolling upgrade"

[jira] [Commented] (KAFKA-1387) Kafka getting stuck creating ephemeral node it has already created when two zookeeper sessions are established in a very short period of time

2015-05-07 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533402#comment-14533402 ] Abhishek Nigam commented on KAFKA-1387: --- I have seen the ephemeral node i

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

2015-04-02 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14393806#comment-14393806 ] Abhishek Nigam commented on KAFKA-1888: --- Hi Gwen/Ashish, I need to finis

Re: Review Request 30809: Patch for KAFKA-1888

2015-04-02 Thread Abhishek Nigam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review78630 ------- On March 23, 2015, 6:54 p.m., Abhishek Nigam wrote: > > -

Re: Review Request 30809: Patch for KAFKA-1888

2015-04-02 Thread Abhishek Nigam
I think > > it is a bit confusing to mix this with CVT. The continuous validation test will be useful outside of the system test framework. This was an attempt to leverage CVT in the system test setting. I think since strong objections have been raised against adopting this approach I

[jira] [Updated] (KAFKA-1888) Add a "rolling upgrade" system test

2015-03-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1888: -- Attachment: KAFKA-1888_2015-03-23_11:54:25.patch > Add a "rolling upgrade"

[jira] [Updated] (KAFKA-1888) Add a "rolling upgrade" system test

2015-03-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1888: -- Status: Patch Available (was: Open) > Add a "rolling upgrade"

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

2015-03-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376399#comment-14376399 ] Abhishek Nigam commented on KAFKA-1888: --- Updated reviewboard h

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-23 Thread Abhishek Nigam
rg/r/30809/diff/ Testing --- Scripted it to run 20 times without any failures. Command-line: broker-upgrade/bin/test.sh Thanks, Abhishek Nigam

[jira] [Work started] (KAFKA-1778) Create new re-elect controller admin function

2015-03-19 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on KAFKA-1778 started by Abhishek Nigam. - > Create new re-elect controller admin funct

[jira] [Commented] (KAFKA-1778) Create new re-elect controller admin function

2015-03-19 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370385#comment-14370385 ] Abhishek Nigam commented on KAFKA-1778: --- I have a design for pinning the contro

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-11 Thread Abhishek Nigam
h, can we use callback to do this? > > Abhishek Nigam wrote: > This is intentional. We want to make sure the event has successfully > reached the brokers. This enables us to form a reasonable expectation of what > the consumer should expect. > > Jiangjie Qin wrote: > The

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-11 Thread Abhishek Nigam
ould be pulled. Would you recommend adding it to the original script as an optional argument? - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76157 -

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-11 Thread Abhishek Nigam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review76173 --- On March 9, 2015, 11:55 p.m., Abhishek Nigam wrote: > > --

[jira] [Commented] (KAFKA-2003) Add upgrade tests

2015-03-11 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357325#comment-14357325 ] Abhishek Nigam commented on KAFKA-2003: --- Hi Gwen, I did not realize might patch

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

2015-03-10 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355921#comment-14355921 ] Abhishek Nigam commented on KAFKA-1888: --- Hi Gwen, I am not sure why the link is

[jira] [Commented] (KAFKA-2003) Add upgrade tests

2015-03-09 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14353922#comment-14353922 ] Abhishek Nigam commented on KAFKA-2003: --- Hi Ashish/Gwen, Can you review KAFKA-

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-09 Thread Abhishek Nigam
thing about comments so made the indenting consistent using the IDE. - Abhishek --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 ----

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-09 Thread Abhishek Nigam
<https://reviews.apache.org/r/30809/#comment119244> Flip is needed to reset the pointer to beginning of byte buffer. - Abhishek Nigam On March 9, 2015, 11:55 p.m., Abhishek Nigam wrote: > > --- > This is an automatically g

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-09 Thread Abhishek Nigam
------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review72786 --- On March 9, 2015, 11:55 p.m., Abhishek Nigam wrote: > > --

Re: Review Request 30809: Patch for KAFKA-1888

2015-03-09 Thread Abhishek Nigam
-CREATION system_test/broker_upgrade/configs/zookeeper_source.properties PRE-CREATION Diff: https://reviews.apache.org/r/30809/diff/ Testing --- Scripted it to run 20 times without any failures. Command-line: broker-upgrade/bin/test.sh Thanks, Abhishek Nigam

RE: Review Request 31385: Patch for KAFKA-1978

2015-02-25 Thread Abhishek Nigam
) 2015-02-25 00:53:17,882 - INFO - replicaIdx: 3 (kafka_system_test_utils) The code tries to index into the array using index 2 but since the size of the array is only 2 we get array out of bounds exception. -Abhishek From: Abhishek Nigam Sent: Wednesday, February

RE: Review Request 31385: Patch for KAFKA-1978

2015-02-25 Thread Abhishek Nigam
Guozhang Wang [nore...@reviews.apache.org] on behalf of Guozhang Wang [wangg...@gmail.com] Sent: Tuesday, February 24, 2015 6:36 PM To: Abhishek Nigam; Guozhang Wang; kafka Subject: Re: Review Request 31385: Patch for KAFKA-1978 This is an automatically generated e-mail. To reply, visit: https://

[jira] [Commented] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-24 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335663#comment-14335663 ] Abhishek Nigam commented on KAFKA-1978: --- Created reviewboard h

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-24 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Attachment: KAFKA-1978.patch > Replication test_0131 system test has been fail

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-24 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Status: Patch Available (was: Open) > Replication test_0131 system test has been fail

Review Request 31385: Patch for KAFKA-1978

2015-02-24 Thread Abhishek Nigam
--- Thanks, Abhishek Nigam

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Status: Open (was: Patch Available) > Replication test_0131 system test has been fail

[jira] [Updated] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam updated KAFKA-1978: -- Reviewer: Guozhang Wang Status: Patch Available (was: Open) > Replication test_0

[jira] [Created] (KAFKA-1978) Replication test_0131 system test has been failing.

2015-02-23 Thread Abhishek Nigam (JIRA)
Abhishek Nigam created KAFKA-1978: - Summary: Replication test_0131 system test has been failing. Key: KAFKA-1978 URL: https://issues.apache.org/jira/browse/KAFKA-1978 Project: Kafka Issue

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-18 Thread Abhishek Nigam
gt; > Why we need a flip? The flip is needed to reset the get pointer in byte buffer to beginning of the byte buffer else we will get underflow exception. - Abhishek --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-17 Thread Abhishek Nigam
/zookeeper_source.properties PRE-CREATION Diff: https://reviews.apache.org/r/30809/diff/ Testing --- Scripted it to run 20 times without any failures. Command-line: broker-upgrade/bin/test.sh Thanks, Abhishek Nigam

[jira] [Assigned] (KAFKA-1778) Create new re-elect controller admin function

2015-02-17 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam reassigned KAFKA-1778: - Assignee: Abhishek Nigam > Create new re-elect controller admin funct

Re: Review Request 30809: Patch for KAFKA-1888

2015-02-09 Thread Abhishek Nigam
without any failures. Command-line: broker-upgrade/bin/test.sh Thanks, Abhishek Nigam

Review Request 30809: Patch for KAFKA-1888

2015-02-09 Thread Abhishek Nigam
/configs/zookeeper_source.properties PRE-CREATION Diff: https://reviews.apache.org/r/30809/diff/ Testing --- Thanks, Abhishek Nigam

Request to be added to this mailing list

2015-01-28 Thread Abhishek Nigam

[jira] [Assigned] (KAFKA-1888) Add a "rolling upgrade" system test

2015-01-27 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abhishek Nigam reassigned KAFKA-1888: - Assignee: Abhishek Nigam > Add a "rolling upgrade"

[jira] [Commented] (KAFKA-1888) Add a "rolling upgrade" system test

2015-01-22 Thread Abhishek Nigam (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288206#comment-14288206 ] Abhishek Nigam commented on KAFKA-1888: --- Gwen, If you are not actively workin