[
https://issues.apache.org/jira/browse/KAFKA-1275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13922928#comment-13922928
]
Joel Koshy commented on KAFKA-1275:
---
Also, may want to make a note of the difference
[
https://issues.apache.org/jira/browse/KAFKA-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13923390#comment-13923390
]
Joel Koshy commented on KAFKA-1298:
---
I think the tool itself may be useful to have (say
---
On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18022
://reviews.apache.org/r/18022/diff/
Testing
---
Thanks,
Joel Koshy
[
https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13921669#comment-13921669
]
Joel Koshy commented on KAFKA-1012:
---
Just updated the RB with a new patch.
Implement
---
On March 5, 2014, 11:53 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18022
, visit:
https://reviews.apache.org/r/18022/#review34615
---
On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/18022/#review34673
---
On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18022
:
https://reviews.apache.org/r/18022/#review34677
---
On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18022/#review34803
---
On Feb. 12, 2014, 7:50 p.m., Joel Koshy wrote
kafka_system_test_utils.start_entity_in_background for how the
PPID is obtained for the broker/console consumer, etc.
- Joel Koshy
On Jan. 28, 2014, 5:26 p.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail
that Jason reported.
- Joel Koshy
On Feb. 13, 2014, 8:24 p.m., Joe Stein wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16718
/kafka_system_test_utils.py fb4a9c0
system_test/utils/testcase_env.py bee8716
Diff: https://reviews.apache.org/r/18022/diff/
Testing
---
Thanks,
Joel Koshy
[
https://issues.apache.org/jira/browse/KAFKA-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13899502#comment-13899502
]
Joel Koshy commented on KAFKA-1012:
---
I uploaded a patch (manually) to this RB:
https
I have not had a chance to review the new metrics code and its
features carefully (apart from your write-up), but here are my general
thoughts:
Implementing a metrics package correctly is difficult; more so for
people like me, because I'm not a statistician. However, if this new
package: {(i)
[
https://issues.apache.org/jira/browse/KAFKA-1254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13896824#comment-13896824
]
Joel Koshy commented on KAFKA-1254:
---
Jun can confirm, but I believe the remaining issues
[
https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13895058#comment-13895058
]
Joel Koshy commented on KAFKA-1171:
---
+1
Gradle build for Kafka
... i.e., we should eventually resume.
- and I prefer Ineligible to Halted because I think it is weird to have
replicas on dead brokers to come back up _have_ to go through a state called
ReplicaDeletion_Failed_ if there was in fact no attempt at deletion.
- Joel Koshy
On Feb. 6, 2014, 7
method that we call from the shutdown hook as well
as here.)
- Joel Koshy
On Feb. 4, 2014, 9:12 p.m., Neha Narkhede wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17649
Overall, +1 on sticking with key-values for configs.
Con: The IDE gives nice auto-completion for pojos.
Con: There are some advantages to javadoc as a documentation mechanism for
java people.
Optionally, both the above cons can be addressed (to some degree) by
wrapper config POJOs that
., the lock will in fact be released
while awaiting, so maybe you should just say that the lock should be acquired
before calling.
- Joel Koshy
On Feb. 1, 2014, 10:58 p.m., Neha Narkhede wrote:
---
This is an automatically generated e-mail
We are already using other libraries in various parts of our code
(e.g., metrics, zkclient, joptsimple, etc) some of which pull in these
other logging dependencies anyway. i.e., what do we gain by using jul?
There may be a good reason why people don't use jul so I think we
should fully understand
/#comment62934
Producers are not shut down cleanly.
- Joel Koshy
On Feb. 3, 2014, 1:02 a.m., Neha Narkhede wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17649
for their producer/consumer in addition to the configuration file for
the rest of their system.
Thanks,
Joel
On Mon, Feb 3, 2014 at 11:17 AM, Joel Koshy jjkosh...@gmail.com wrote:
We are already using other libraries in various parts of our code
(e.g., metrics, zkclient, joptsimple, etc) some
For (3) we could also do the following:
- On any retryable producer error, force a metadata refresh (in
handleProducerResponse).
- In handleMetadataResponse, the producer can (internally) close out
connections that are no longer valid. (i.e., connections to {old set
of leader brokers} - {new
.
In order to allow correctly choosing a partition the Producer interface
will include a new method:
ListPartitionInfo partitionsForTopic(String topic);
PartitionInfo will be changed to include the actual Node objects not just
the Node ids.
Why are the node id's alone insufficient?
That's a good point about 1A - does seem that we would need to have
some kind of TTL for each topic's metadata.
Also, WRT ZK dependency I don't think that decision (for the Java
client) affects other clients. i.e., other client implementations can
use whatever discovery mechanism it chooses. That
+ dev
(this thread has become a bit unwieldy)
On Thu, Jan 30, 2014 at 5:15 PM, Joel Koshy jjkosh...@gmail.com wrote:
Does it preclude those various implementations? i.e., it could become
a producer config:
default.partitioner.strategy=minimize-connections/roundrobin - and
so
On Jan. 28, 2014, 8:48 p.m., Joel Koshy wrote:
clients/src/main/java/kafka/clients/producer/KafkaProducer.java, line 182
https://reviews.apache.org/r/17263/diff/1/?file=436445#file436445line182
This could add a couple minutes startup for producers that send to
several
/java/kafka/common/network/Send.java
https://reviews.apache.org/r/17263/#comment62210
Not sure what the use-case for this would be.
clients/src/main/java/kafka/common/utils/CopyOnWriteMap.java
https://reviews.apache.org/r/17263/#comment62214
Unused class.
- Joel Koshy
On Jan. 23, 2014
Same here: +1 on checking in as is. I should be able to go through the
patch on Monday.
On Fri, Jan 24, 2014 at 01:48:14PM -0800, Neha Narkhede wrote:
I plan to review the code over the weekend and I think it is easier to
address the review comments async. +1 for checking it in as is for now.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17055/#review32772
---
Ship it!
- Joel Koshy
On Jan. 21, 2014, 9:29 p.m., Guozhang Wang
[
https://issues.apache.org/jira/browse/KAFKA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1055.
---
Resolution: Fixed
Committed to trunk.
BrokerTopicStats is updated before checking
[
https://issues.apache.org/jira/browse/KAFKA-1055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy closed KAFKA-1055.
-
BrokerTopicStats is updated before checking for MessageSizeTooLarge
[
https://issues.apache.org/jira/browse/KAFKA-1190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13864935#comment-13864935
]
Joel Koshy commented on KAFKA-1190:
---
This is useful but do we want to check-in very
://reviews.apache.org/r/16718/#comment59807
Thanks for patching this issue.
I'm not very clear on the cases here - i.e., is it exhaustive? Also, why is
this method named quoteJsonLiteral?
Finally, it may be a good idea to add more test cases in TopicFilterTest.
- joel koshy
On Jan. 8
There seem to be missing files - was able to copy those over from samza's
setup and was able to build but wasn't able to get the IDE filed generated.
Also, is there a javadoc/scaladoc plugin?
On Saturday, January 4, 2014, Jun Rao (JIRA) wrote:
[
+1
On Wed, Nov 27, 2013 at 10:22:24AM -0800, Jun Rao wrote:
+1. Verified quick start and unit tests.
Thanks,
Jun
On Tue, Nov 26, 2013 at 2:34 PM, Joe Stein joe.st...@stealth.ly wrote:
This is the fifth candidate for release of Apache Kafka 0.8.0. This
release candidate is now
[
https://issues.apache.org/jira/browse/KAFKA-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13834116#comment-13834116
]
Joel Koshy commented on KAFKA-1146:
---
We could just print something like %s kafka
Joel Koshy created KAFKA-1147:
-
Summary: Consumer socket timeout should be greater than fetch max
wait
Key: KAFKA-1147
URL: https://issues.apache.org/jira/browse/KAFKA-1147
Project: Kafka
Issue
Joel Koshy created KAFKA-1148:
-
Summary: Delayed fetch/producer requests should be satisfied on a
leader change
Key: KAFKA-1148
URL: https://issues.apache.org/jira/browse/KAFKA-1148
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1146:
--
Fix Version/s: 0.8.1
Yes this is due to KafkaStream being a scala iterable - toString on
an iterable
I'm getting this with console consumer in the binary package which
seems to be because it was built under Java 7. Can we stick to 6?
Exception in thread main java.lang.UnsupportedClassVersionError:
kafka/javaapi/consumer/ConsumerConnector : Unsupported major.minor version 51.0
at
[
https://issues.apache.org/jira/browse/KAFKA-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13833359#comment-13833359
]
Joel Koshy commented on KAFKA-1144:
---
I agree that this is a useful feature. It may
[
https://issues.apache.org/jira/browse/KAFKA-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1004:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
This was fixed in KAFKA-1103
[
https://issues.apache.org/jira/browse/KAFKA-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy closed KAFKA-1004.
-
Handle topic event for trivial whitelist topic filters
[
https://issues.apache.org/jira/browse/KAFKA-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830186#comment-13830186
]
Joel Koshy commented on KAFKA-1103:
---
I think the issue is that the patch-review tool
Joel Koshy created KAFKA-1142:
-
Summary: Patch review tool should take diff with origin from last
divergent point
Key: KAFKA-1142
URL: https://issues.apache.org/jira/browse/KAFKA-1142
Project: Kafka
/browse/KAFKA-1142
Repository: kafka
Description
---
Take diff from last divergent point
Diffs
-
kafka-patch-review.py 7fa6cb5165d0d497ec3004dc2c98b60fb8d0436d
Diff: https://reviews.apache.org/r/15793/diff/
Testing
---
Thanks,
joel koshy
[
https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830191#comment-13830191
]
Joel Koshy commented on KAFKA-1142:
---
Created reviewboard against branch origin/trunk
[
https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830193#comment-13830193
]
Joel Koshy commented on KAFKA-1142:
---
I got: rbtools.api.errors.APIError: HTTP 502
(from
[
https://issues.apache.org/jira/browse/KAFKA-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13830200#comment-13830200
]
Joel Koshy commented on KAFKA-1142:
---
Actually, it did post a diff:
https
[
https://issues.apache.org/jira/browse/KAFKA-1137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1137.
---
Resolution: Invalid
Closing - this behavior is documented here:
https://cwiki.apache.org/confluence
[
https://issues.apache.org/jira/browse/KAFKA-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1140:
--
Fix Version/s: 0.8.1
Move the decoding logic from ConsumerIterator.makeNext to next
[
https://issues.apache.org/jira/browse/KAFKA-1136?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1136:
--
Fix Version/s: 0.8.1
Add subAppend in Log4jAppender for generic usage
I can elaborate further on the wiki tomorrow. The term in-flight in my
edit is a bit incomplete. It refers to what's in-flight on the
broker-side for actual handling - that is what provides the ordering
guarantee. The client can continue to write requests to the socket
even while the broker is
into onPreferredReplicaElection (although if this
feature is turned on you wouldn't need to use the command-line tool anyway).
- Joel Koshy
On Nov. 20, 2013, 1:38 a.m., Sriram Subramanian wrote:
---
This is an automatically generated e-mail. To reply, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15659/#review29205
---
Ship it!
Looks good.
- Joel Koshy
On Nov. 20, 2013, 8:59 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15744/#review29206
---
Ship it!
- Joel Koshy
On Nov. 21, 2013, midnight, Joe Stein
/15659/#comment56263
Typo in message; however, I think we can just drop the entire else block.
- Joel Koshy
On Nov. 18, 2013, 11:30 p.m., Guozhang Wang wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
Based on
http://www.apache.org/dev/release.html#distribute-other-artifacts it
seems we should close KAFKA-1133 before releasing.
quote
For example, the Java artifact format is based on a compressed
directory structure and those projects wishing to distribute jars must
place LICENSE and NOTICE
Marek was referring to the zookeeper namespace - Marek, there are
jira(s)
https://issues.apache.org/jira/browse/KAFKA-294
https://issues.apache.org/jira/browse/KAFKA-404
Should be straightforward to finish that up - want to give that a go?
Thanks,
Joel
On Thu, Nov 14, 2013 at 03:48:01AM +0400,
and the isTopicAllowed API
that it provides?
- Joel Koshy
On Nov. 12, 2013, 4:34 p.m., Jun Rao wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15201
+1
Thanks Joe.
The following are very minor issues that I think don't matter at all,
but we can keep in mind for future releases:
- won't fix issues still show up in the release notes (the go client
jiras for e.g.,)
- In
for configsToBeDeleted right? - i.e., validation
could fail for deleted configs which have no associated value.
- joel koshy
On Nov. 7, 2013, 6:17 p.m., Neha Narkhede wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
://reviews.apache.org/r/15274/#comment55226
Also, if we are adding the deleteConfig option we need not use the same
regex and split. i.e., we expect only one argument.
- joel koshy
On Nov. 7, 2013, 6:17 p.m., Neha Narkhede wrote
Joe, thanks for doing this. Couple of questions before I can vote
because I'm not sure if any of these would block voting:
From below:
http://svn.apache.org/repos/asf/incubator/kafka/trunk/KEYS in addition to
This link is out of date - should be
http://svn.apache.org/repos/asf/kafka/KEYS
In
On Nov. 7, 2013, 6:31 p.m., joel koshy wrote:
core/src/main/scala/kafka/admin/TopicCommand.scala, line 153
https://reviews.apache.org/r/15274/diff/4/?file=380482#file380482line153
Also, if we are adding the deleteConfig option we need not use the same
regex and split. i.e., we
On Nov. 7, 2013, 6:29 p.m., joel koshy wrote:
core/src/main/scala/kafka/admin/AdminUtils.scala, line 224
https://reviews.apache.org/r/15274/diff/4/?file=380481#file380481line224
Not sure if this is required any more if we're doing validation earlier
- since a validation failure
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15274/#review28481
---
Ship it!
- joel koshy
On Nov. 8, 2013, 1:07 a.m., Neha Narkhede
Joel Koshy created KAFKA-1103:
-
Summary: Consumer uses two zkclients
Key: KAFKA-1103
URL: https://issues.apache.org/jira/browse/KAFKA-1103
Project: Kafka
Issue Type: Bug
Reporter
Joel Koshy created KAFKA-1104:
-
Summary: Consumer uses two zkclients
Key: KAFKA-1104
URL: https://issues.apache.org/jira/browse/KAFKA-1104
Project: Kafka
Issue Type: Bug
Reporter
Joel Koshy created KAFKA-1105:
-
Summary: Consumer uses two zkclient instances
Key: KAFKA-1105
URL: https://issues.apache.org/jira/browse/KAFKA-1105
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1104.
---
Resolution: Duplicate
Apologies for the spam - my browser was just hanging when i tried to create
[
https://issues.apache.org/jira/browse/KAFKA-1105?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy resolved KAFKA-1105.
---
Resolution: Duplicate
Apologies for the spam - my browser was just hanging when i tried to create
[
https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802335#comment-13802335
]
Joel Koshy commented on KAFKA-1097:
---
[~guozhang] Neha's comment wrt not getting any more
[
https://issues.apache.org/jira/browse/KAFKA-1097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802344#comment-13802344
]
Joel Koshy commented on KAFKA-1097:
---
nm.. i think the previous comment addressed
[
https://issues.apache.org/jira/browse/KAFKA-1098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802477#comment-13802477
]
Joel Koshy commented on KAFKA-1098:
---
Thanks for the patch - this is interesting/weird
Joel Koshy created KAFKA-1089:
-
Summary: Migration tool system tests soft-fail on 0.8 and trunk
Key: KAFKA-1089
URL: https://issues.apache.org/jira/browse/KAFKA-1089
Project: Kafka
Issue Type
[
https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1089:
--
Attachment: KAFKA-1089-v1.patch
Migration tool system tests soft-fail on 0.8 and trunk
[
https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1089:
--
Status: Patch Available (was: Open)
Migration tool system tests soft-fail on 0.8 and trunk
[
https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797000#comment-13797000
]
Joel Koshy commented on KAFKA-1089:
---
Thanks for the review - committed to 0.8. I'll
[
https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1089:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Committed to both 0.8 and trunk
[
https://issues.apache.org/jira/browse/KAFKA-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy closed KAFKA-1089.
-
Migration tool system tests soft-fail on 0.8 and trunk
https://reviews.apache.org/r/14675/#comment52743
Should probably wrap this with an Assert.assertTrue(...)
- joel koshy
On Oct. 16, 2013, 5 p.m., Jun Rao wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
this with InetAddress.getLocalHost.getHostName
core/src/main/scala/kafka/tools/GetOffsetShell.scala
https://reviews.apache.org/r/14638/#comment52658
Should this be partitionList.split(,)...
- Joel Koshy
On Oct. 14, 2013, 10:50 p.m., Neha Narkhede wrote
On Oct. 15, 2013, 8:03 p.m., Joel Koshy wrote:
core/src/main/scala/kafka/tools/GetOffsetShell.scala, line 71
https://reviews.apache.org/r/14638/diff/1/?file=364653#file364653line71
Nice use of clientId. We should do this in every tool. I would suggest
we also prepend
node loss. Did the Kafka consumer not respond to rebalance events or did
the server not respond to state change events ? Also, ephemeral nodes are
lost only when sessions are expired on the zookeeper server or if clients
close the session actively, how does losing connection lead to ephemeral
://www.stealth.ly
Twitter: @allthingshadoop
/
On Sep 14, 2013, at 8:17 AM, Joel Koshy jjkosh...@gmail.com wrote:
Thanks for bringing this up - it is definitely an important point to
discuss. The underlying issue of KAFKA-1017
020e73c72a310e874ba07cf0691517a61c1fc35f
core/src/main/scala/kafka/utils/Utils.scala
e0a5a27c72abf3560f68fc6c2dbfc67d90cc5cd9
core/src/main/scala/kafka/utils/VerifiableProperties.scala
d694ba98522a0aa2fc9cac84ebcfc4bd51505300
Diff: https://reviews.apache.org/r/14184/diff/
Testing
---
Thanks,
joel
020e73c72a310e874ba07cf0691517a61c1fc35f
core/src/main/scala/kafka/utils/Utils.scala
e0a5a27c72abf3560f68fc6c2dbfc67d90cc5cd9
core/src/main/scala/kafka/utils/VerifiableProperties.scala
d694ba98522a0aa2fc9cac84ebcfc4bd51505300
Diff: https://reviews.apache.org/r/14188/diff/
Testing
---
Thanks,
joel
[
https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-1049:
--
Attachment: KAFKA-1049.patch
Encoder implementations are required to provide an undocumented
[
https://issues.apache.org/jira/browse/KAFKA-1049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770182#comment-13770182
]
Joel Koshy commented on KAFKA-1049:
---
Created reviewboard https://reviews.apache.org/r
core/src/main/scala/kafka/utils/Utils.scala
https://reviews.apache.org/r/14188/#comment51186
The following getConstructor call fails in this diff - e.g., try running
AsyncProducerTest.
- joel koshy
On Sept. 17, 2013, 11:52 p.m., joel koshy wrote
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13770270#comment-13770270
]
Joel Koshy commented on KAFKA-1053:
---
Nice - I tried this on KAFKA-1049 (as a test
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13765763#comment-13765763
]
Joel Koshy commented on KAFKA-1053:
---
I'll take a look today - would like to try it out
+1 binding
On Fri, Sep 13, 2013 at 10:00 AM, Joe Stein crypt...@gmail.com wrote:
+1 binding
/***
Joe Stein
Founder, Principal Consultant
Big Data Open Source Security LLC
http://www.stealth.ly
Twitter: @allthingshadoop
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767216#comment-13767216
]
Joel Koshy commented on KAFKA-1053:
---
Ran into this while following the instructions. May
[
https://issues.apache.org/jira/browse/KAFKA-1053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13767225#comment-13767225
]
Joel Koshy commented on KAFKA-1053:
---
Probably because I did both yum install python
to implement selective rebalance - that
way the overhead of going to ZK for partition information (for the affected
topics alone) should be acceptable. It will also give us the added benefit of
reducing the overall time for rebalance on a topic event.
- Joel Koshy
On Sept. 10, 2013, 6:29 p.m., Guozhang
1201 - 1300 of 1401 matches
Mail list logo
