Re: Review Request 26373: Patch for KAFKA-1647

<https://reviews.apache.org/r/26373/#comment13> Sorry - this is fine. I missed the parantheses - Joel Koshy On Oct. 28, 2014, 12:20 a.m., Jiangjie Qin wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 26755: Patch for KAFKA-1706

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26755/#review58831 --- Can we add a unit test as well? - Joel Koshy On Oct. 28, 2014, 1

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187118#comment-14187118 ] Joel Koshy commented on KAFKA-1583: --- Thanks for the updated patch. I will do this t

Re: Review Request 26373: Patch for KAFKA-1647

reference the jira in comments since people can just git annotate. - Joel Koshy On Oct. 28, 2014, 12:20 a.m., Jiangjie Qin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 26755: Patch for KAFKA-1706

ttle need to return from the middle. Can you restructure it to something like: if (...) false else { ... success } core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala <https://reviews.apache.org/r/26755/#comment99866> Same here -

Re: Review Request 26755: Patch for KAFKA-1706

> On Oct. 25, 2014, 7:52 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala, line 109 > > <https://reviews.apache.org/r/26755/diff/3/?file=722245#file722245line109> > > > > getAndDecrement(sizeFunction.get(e)) >

Re: Review Request 26755: Patch for KAFKA-1706

main/scala/kafka/utils/ByteBoundedBlockingQueue.scala <https://reviews.apache.org/r/26755/#comment99575> addAndDecrement core/src/main/scala/kafka/utils/ByteBoundedBlockingQueue.scala <https://reviews.apache.org/r/26755/#comment99576> Synchronization comment above - Joel Koshy On Oct. 15,

Re: Review Request 26994: Patch for KAFKA-1719

.scala <https://reviews.apache.org/r/26994/#comment99540> Braces are actually unnecessary for the case block - Joel Koshy On Oct. 24, 2014, 7:56 a.m., Jiangjie Qin wrote: > > --- > This is an automatically generated e-

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183304#comment-14183304 ] Joel Koshy commented on KAFKA-1555: --- Looks good - I just have a few minor edits to

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183086#comment-14183086 ] Joel Koshy commented on KAFKA-1555: --- Jun, you can just diff configuration.

Re: 082 docs

an sign up on one of the sub tasks. > > Joel Koshy, > > Do you want to update the doc for offset management? > > Thanks, > > Jun

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182276#comment-14182276 ] Joel Koshy commented on KAFKA-391: -- Yeah I see your point. That's intere

Re: Review Request 26994: Patch for KAFKA-1719

the minor comments? core/src/main/scala/kafka/tools/MirrorMaker.scala <https://reviews.apache.org/r/26994/#comment99129> exited - Joel Koshy On Oct. 23, 2014, 11:20 p.m., Jiangjie Qin wrote: > > --- > This is a

[jira] [Commented] (KAFKA-391) Producer request and response classes should use maps

[ https://issues.apache.org/jira/browse/KAFKA-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14182240#comment-14182240 ] Joel Koshy commented on KAFKA-391: -- You mean two responses to the caller of send? I d

[jira] [Updated] (KAFKA-1641) Log cleaner exits if last cleaned offset is lower than earliest offset

[ https://issues.apache.org/jira/browse/KAFKA-1641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1641: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch. Pushed to

Re: Review Request 26390: Fix KAFKA-1641

tps://reviews.apache.org/r/26390/#comment99062> Actually, because of the + the format specifiers are unmatched. I will fix this on check-in. - Joel Koshy On Oct. 9, 2014, 8:04 p.m., Guozhang Wang wrote: > > ---

Re: Review Request 26390: Fix KAFKA-1641

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26390/#review58117 --- Ship it! - Joel Koshy On Oct. 9, 2014, 8:04 p.m., Guozhang Wang

Re: Review Request 26994: Patch for KAFKA-1719

maker. So, can you rename these fields in the DataChannel? i.e., numConsumers -> numOutputs and numProducers -> numInputs? - Joel Koshy On Oct. 22, 2014, 10:04 p.m., Jiangjie Qin wrote: > > --- > Thi

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we c

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180328#comment-14180328 ] Joel Koshy commented on KAFKA-1647: --- [~becket_qin] here are some steps to repro

Re: Review Request 26373: Patch for KAFKA-1647

tps://reviews.apache.org/r/26373/#comment98711> This and the following change can be reverted. I will post some steps to reproduce locally on the ticket. - Joel Koshy On Oct. 22, 2014, 6:08 a.m., Jiangjie Qin wrote: > > ---

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14179460#comment-14179460 ] Joel Koshy commented on KAFKA-1583: --- I posted review comments, mostly minor. Did

Re: Review Request 24676: Rebase KAFKA-1583

< numPartitions errors in local append. core/src/main/scala/kafka/utils/DelayedItem.scala <https://reviews.apache.org/r/24676/#comment98553> We don't really need this class anymore and it can be folded into DelayedRequest right? core/src/test/scala/integration/kafka/a

[jira] [Reopened] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-1555: --- I'm reopening this so we won't forget about the documentation patch. If you prefer, we

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1555: -- Reviewer: Joel Koshy (was: Jun Rao) > provide strong consistency with reasonable availabil

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

h). If we can get a patch ready, we can > > include it in 0.8.2 final. > > > > Thanks, > > > > Jun > > > > On Tue, Oct 21, 2014 at 8:00 AM, Joel Koshy wrote: > > > >> KAFKA-1634 is orthogonal to 1583 right? (BTW sorry about the delay in >

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

de any other fixes (e.g., KAFKA-1481) in the 0.8.2 final > release. > > Thanks, > > Jun > > On Thu, Oct 16, 2014 at 3:53 PM, Joel Koshy wrote: > > > +1 on the beta. I think KAFKA-1583 should only be on trunk, not 0.8.2 > > so that will only go out with 0.8

Re: Kafka Command Line & Shell

+1 It would definitely be useful to have a CLI. We had a cursory discussion on this in the past [1] but it would be useful to have a full proposal describing everything the CLI should provide. [1] http://grokbase.com/t/kafka/dev/1435tr3pfc/command-line-tools On Fri, Oct 17, 2014 at 05:12:16PM -

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175763#comment-14175763 ] Joel Koshy commented on KAFKA-1583: --- Reviewing is taking a bit longer than expe

Re: [DISCUSS] Release 0.8.2-beta before 0.8.2?

+1 on the beta. I think KAFKA-1583 should only be on trunk, not 0.8.2 so that will only go out with 0.8.3. Joel On Thu, Oct 16, 2014 at 03:25:39PM -0700, Guozhang Wang wrote: > Agree. > On Oct 16, 2014 3:16 PM, "Jun Rao" wrote: > > > +1 on doing an 0.8.2 beta. > > > > Guozhang, > > > > kafka-15

Re: [DISCUSSION] Message Metadata

e producer created the message > >> > > - The time the leader received the message > >> > > - The time the current broker received the message > >> > > The producer timestamps won't be at all increasing. The leader > >> timestamp > >> > >

[jira] [Updated] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1583: -- Reviewer: Joel Koshy (was: Jun Rao) > Kafka API Refactor

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14173215#comment-14173215 ] Joel Koshy commented on KAFKA-1583: --- Yes please. I will be able to do this on Fr

Re: Review Request 26710: Patch for KAFKA-1637

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26710/#review56827 --- Ship it! Ship It! - Joel Koshy On Oct. 15, 2014, 9:47 p.m

Re: Review Request 26710: Patch for KAFKA-1637

-in. core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/26710/#comment97223> How about val (unknownTopicPartitions, knownTopicPartitions) core/src/main/scala/kafka/server/KafkaApis.scala <https://reviews.apache.org/r/26710/#comment97224> Same he

Re: Review Request 26663: Patch for KAFKA-979

> On Oct. 15, 2014, 4:19 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 515 > > <https://reviews.apache.org/r/26663/diff/2/?file=721126#file721126line515> > > > > Thinking about this a bit more: do you think it would be safer to &g

[jira] [Reopened] (KAFKA-1637) SimpleConsumer.fetchOffset returns wrong error code when no offset exists for topic/partition/consumer group

[ https://issues.apache.org/jira/browse/KAFKA-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-1637: --- > SimpleConsumer.fetchOffset returns wrong error code when no offset exists for > topic/par

[jira] [Commented] (KAFKA-1637) SimpleConsumer.fetchOffset returns wrong error code when no offset exists for topic/partition/consumer group

[ https://issues.apache.org/jira/browse/KAFKA-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172020#comment-14172020 ] Joel Koshy commented on KAFKA-1637: --- -1 on this patch per the comment in th

Re: Review Request 26710: Patch for KAFKA-1637

hat are not assigned to this broker. The offset manager though will still contain offsets for those partitions. - Joel Koshy On Oct. 14, 2014, 10:04 p.m., Ewen Cheslack-Postava wrote: > > --- > This is an automatically generated e-m

[jira] [Commented] (KAFKA-979) Add jitter for time based rolling

[ https://issues.apache.org/jira/browse/KAFKA-979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171962#comment-14171962 ] Joel Koshy commented on KAFKA-979: -- Just had one more comment in the RB on how to use

Re: Review Request 26663: Patch for KAFKA-979

s as a jitter window. i.e., the actual age for rolling will be config.segmentMs + segment.rollJitterMs; and limit segment.rollJitterMs to an interval of [-config.segmentMs / 2, config.segmentMs / 2] Thoughts? - Joel Koshy On Oct. 14, 2014, 10:33 p.m., Ewen Cheslack-Postava

Re: Review Request 26663: Patch for KAFKA-979

> On Oct. 14, 2014, 6:27 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/log/Log.scala, line 515 > > <https://reviews.apache.org/r/26663/diff/1/?file=719793#file719793line515> > > > > Although this should work I'm wondering if it would be better

Re: Review Request 26663: Patch for KAFKA-979

uld use Utils.abs before returning or it could return a large negative result. - Joel Koshy On Oct. 13, 2014, 11:16 p.m., Ewen Cheslack-Postava wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https

Re: Review Request 26373: Patch for KAFKA-1647

ica is already following a leader, it is unnecessary to stop the fetcher, truncate to HW and restart the fetcher. So I think we should still skip such partitions. (The associated replica will already be in the checkpoint array so its checkpoint won't get lost) - Joel Koshy On Oct. 6,

[jira] [Commented] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169648#comment-14169648 ] Joel Koshy commented on KAFKA-1634: --- [~junrao] yes you are right.

Re: [DISCUSSION] Message Metadata

Thanks Guozhang! This is an excellent write-up and the approach nicely consolidates a number of long-standing issues. It would be great if everyone can review this carefully and give feedback. Also, wrt discussion in the past we have used a mix of wiki comments and the mailing list. Personally, I

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1634: -- Summary: Improve semantics of timestamp in OffsetCommitRequests (was: Update protocol wiki to reflect

[jira] [Updated] (KAFKA-1634) Improve semantics of timestamp in OffsetCommitRequests and update documentation

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1634: -- Summary: Improve semantics of timestamp in OffsetCommitRequests and update documentation (was: Improve

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167700#comment-14167700 ] Joel Koshy commented on KAFKA-1634: --- (BTW, I'm looking for a +1 or -1 on

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167696#comment-14167696 ] Joel Koshy commented on KAFKA-1634: --- Actually, one more potential source of confu

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14167600#comment-14167600 ] Joel Koshy commented on KAFKA-1499: --- [~omkreddy] will review your other patch, bu

[jira] [Assigned] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1634: - Assignee: Joel Koshy (was: Jun Rao) > Update protocol wiki to reflect the new offset managem

Re: including KAFKA-1555 in 0.8.2?

+1 On Fri, Oct 10, 2014 at 04:53:45PM +, Sriram Subramanian wrote: > +1 > > On 10/10/14 9:39 AM, "Gwen Shapira" wrote: > > >+1 :) > > > >On Fri, Oct 10, 2014 at 9:34 AM, Joe Stein wrote: > >> +1 > >> On Oct 10, 2014 12:08 PM, "Neha Narkhede" > >>wrote: > >> > >>> +1. > >>> > >>> On Thu,

[jira] [Updated] (KAFKA-1648) Round robin consumer balance throws an NPE when there are no topics

[ https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1648: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk > Round ro

Re: Review Request 26291: Patch for KAFKA-1648

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26291/#review56040 --- Ship it! Ship It! - Joel Koshy On Oct. 9, 2014, 6:56 p.m

Re: Review Request 26291: Patch for KAFKA-1648

g/r/26291/#comment96384> This needs to be moved out of the if block (or it won't compile). - Joel Koshy On Oct. 9, 2014, 12:46 a.m., Mayuresh Gharat wrote: > > --- > This is an automatically generated e-mail

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162942#comment-14162942 ] Joel Koshy commented on KAFKA-1555: --- +1 (took a quick look at it) We could improve

Re: Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

oes move a portion of the log config validation outside. - Joel Koshy On Oct. 8, 2014, 1:46 a.m., Gwen Shapira wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Re: Review Request 26291: Patch for KAFKA-1648

/kafka/consumer/ZookeeperConsumerConnector.scala <https://reviews.apache.org/r/26291/#comment96089> I don't think this is required. (Or if it is can you explain?) - Joel Koshy On Oct. 5, 2014, 12:40 a.m., Mayuresh Gharat wrote: > >

Re: Review Request 26390: Fix KAFKA-1641

rtOffset) { error("...") logStartOffset } else offset } ``` core/src/main/scala/kafka/log/LogCleanerManager.scala <https://reviews.apache.org/r/26390/#comment96075> It seems this should be `LogToClean(l._1, l._2, firstDirtyOffset)

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162336#comment-14162336 ] Joel Koshy commented on KAFKA-1499: --- Talked to Jay offline and here is a summar

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158111#comment-14158111 ] Joel Koshy commented on KAFKA-1499: --- Yes that is correct. However, in practice I t

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158097#comment-14158097 ] Joel Koshy commented on KAFKA-1499: --- [~guozhang] I do believe we can avoid the nee

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158091#comment-14158091 ] Joel Koshy commented on KAFKA-1499: --- [~jkreps] Regarding the two approaches, both

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Assignee: Jiangjie Qin > Replication offset checkpoints (high water marks) can be lost on hard ki

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154209#comment-14154209 ] Joel Koshy commented on KAFKA-1499: --- If we provide a broker-compression-enabled co

Re: Review Request 25136: Patch for KAFKA-1610

tatus => status.responseStatus) we can just do: val responseStatusView = partitionStatus.mapValues(status => status.responseStatus) - Joel Koshy On Sept. 16, 2014, 10:23 p.m., Mayuresh Gharat wrote: > > --- > This is an automatically genera

[jira] [Updated] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1577: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk > Exception

[jira] [Commented] (KAFKA-1634) Update protocol wiki to reflect the new offset management feature

[ https://issues.apache.org/jira/browse/KAFKA-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152466#comment-14152466 ] Joel Koshy commented on KAFKA-1634: --- [~nehanarkhede] I agree that timestamp in

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151955#comment-14151955 ] Joel Koshy commented on KAFKA-1647: --- Yes that is exactly why it happens and the fi

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151947#comment-14151947 ] Joel Koshy commented on KAFKA-1499: --- Yes I understand that the LogConfig is at

Re: Review Request 26107: Patch for KAFKA-1577

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26107/#review54764 --- Ship it! Ship It! - Joel Koshy On Sept. 27, 2014, 2:13 a.m

Re: Review Request 26107: Patch for KAFKA-1577

calling closeAll. - Joel Koshy On Sept. 26, 2014, 10:41 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150181#comment-14150181 ] Joel Koshy commented on KAFKA-1499: --- That sounds reasonable. Another option would b

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149888#comment-14149888 ] Joel Koshy commented on KAFKA-1577: --- Hmm.. that is really weird - since the swa

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149803#comment-14149803 ] Joel Koshy commented on KAFKA-1577: --- I think selectNow is a good option. > Ex

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14149798#comment-14149798 ] Joel Koshy commented on KAFKA-1577: --- Oh now I remember this - the root cause i

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148802#comment-14148802 ] Joel Koshy commented on KAFKA-1647: --- Yes that is one possibility but not the only

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148795#comment-14148795 ] Joel Koshy commented on KAFKA-1555: --- This is an implementation detail but wrt

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148598#comment-14148598 ] Joel Koshy commented on KAFKA-1499: --- Thanks - it works now. Sorry I had forgotte

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54636 --- Ship it! Ship It! - Joel Koshy On Sept. 25, 2014, 5:38 a.m

[jira] [Updated] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1647: -- Labels: newbie++ (was: ) > Replication offset checkpoints (high water marks) can be lost on hard ki

[jira] [Commented] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

[ https://issues.apache.org/jira/browse/KAFKA-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148336#comment-14148336 ] Joel Koshy commented on KAFKA-1647: --- If b1 aborts the follower transition the

[jira] [Commented] (KAFKA-1652) NoSuchElementException on server shutdown

[ https://issues.apache.org/jira/browse/KAFKA-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14148263#comment-14148263 ] Joel Koshy commented on KAFKA-1652: --- Are you sure you have the fix in KAFKA-1577

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147943#comment-14147943 ] Joel Koshy commented on KAFKA-1555: --- I'm +1 on the concept of min.isr and acks

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14147187#comment-14147187 ] Joel Koshy commented on KAFKA-1499: --- [~omkreddy] I thought I would try this locally

Re: Review Request 25944: Patch for KAFKA-1013

will also need to provide a variant of this method that takes javaapi.OffsetCommitRequest Also, better to call this commitOffsets Also, see comment above on config - Joel Koshy On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote: > >

Re: Review Request 24704: Patch for KAFKA-1499

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/#review54423 --- Ship it! Ship It! - Joel Koshy On Sept. 24, 2014, 8:57 a.m

Re: Review Request 24704: Patch for KAFKA-1499

<https://reviews.apache.org/r/24704/#comment94551> There are still some whitespace inconsistencies here. I will take care of it on check-in. - Joel Koshy On Sept. 24, 2014, 8:57 a.m., Manikumar Reddy O wrote: > > ---

[jira] [Updated] (KAFKA-1013) Modify existing tools as per the changes in KAFKA-1000

[ https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1013: -- Reviewer: Joel Koshy > Modify existing tools as per the changes in KAFKA-1

Re: Review Request 24704: Patch for KAFKA-1499

dentation on scala - however, there are a bunch of places in this patch where there is a mix of two-space/four-space indent. - Joel Koshy On Sept. 23, 2014, 9:17 a.m., Manikumar Reddy O wrote: > > --- > This is an automati

[jira] [Created] (KAFKA-1647) Replication offset checkpoints (high water marks) can be lost on hard kills and restarts

Joel Koshy created KAFKA-1647: - Summary: Replication offset checkpoints (high water marks) can be lost on hard kills and restarts Key: KAFKA-1647 URL: https://issues.apache.org/jira/browse/KAFKA-1647

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144434#comment-14144434 ] Joel Koshy commented on KAFKA-1367: --- I definitely agree with [~edenhill] that if su

Re: Review Request 24704: Patch for KAFKA-1499

second parameter to targetCodec and the new parameter to sourceCodec? So the condition would be (if (sourceCodec == NoCompressionCodec && targetCodec == NoCompressionCodec) // do in-place conversion) - Joel Koshy On Sept. 21, 2014, 10:30 a.m., Manikumar

[jira] [Updated] (KAFKA-1469) Util.abs function does not return correct absolute values for negative values

[ https://issues.apache.org/jira/browse/KAFKA-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1469: -- Description: Reported by Russell Melick. [edit1: I don't think this affects correctness of the p

Offset manager movement (due to change in KAFKA-1469)

I just wanted to send this out as an FYI but it does not affect any released versions. This only affects those who release off trunk and use Kafka-based consumer offset management. KAFKA-1469 fixes an issue in our Utils.abs code. Since we use this method in determining the offset manager for a co

[jira] [Commented] (KAFKA-1583) Kafka API Refactoring

[ https://issues.apache.org/jira/browse/KAFKA-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14141318#comment-14141318 ] Joel Koshy commented on KAFKA-1583: --- Yes I intend to review this within the next co

Re: Review Request 24704: Patch for KAFKA-1499

<https://reviews.apache.org/r/24704/#comment93887> Should this just be part of LogTest instead? - Joel Koshy On Aug. 21, 2014, 4:17 p.m., Manikumar Reddy O wrote: > > --- > This is an automatically generated e-mail. To

[jira] [Created] (KAFKA-1641) Log cleaner exits if last cleaned offset is lower than earliest offset

Joel Koshy created KAFKA-1641: - Summary: Log cleaner exits if last cleaned offset is lower than earliest offset Key: KAFKA-1641 URL: https://issues.apache.org/jira/browse/KAFKA-1641 Project: Kafka

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135957#comment-14135957 ] Joel Koshy commented on KAFKA-1499: --- Sorry you are right - I mixed up the two. For

<    4   5   6   7   8   9   10   11   12   13   >