Re: Review Request 24676: WIP for KAFKA-1583

2014-08-18 Thread Joel Koshy
patch. - Joel Koshy On Aug. 13, 2014, 11:16 p.m., Guozhang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24676

Re: Review Request 24704: Patch for KAFKA-1499

2014-08-16 Thread Joel Koshy
property is applicable to all non-compressed messages received on the broker. Yes, we should explicitly specify this in documentation. Joel Koshy wrote: Manikumar/Neha - would it be less confusing if we add another config as well. Something like broker.compression.enabled. If that is true

Re: Review Request 24510: Patch for KAFKA-1582

2014-08-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24510/#review50745 --- Ship it! Ship It! - Joel Koshy On Aug. 11, 2014, 4:23 a.m

[jira] [Resolved] (KAFKA-1582) System Test should wait for producer to finish

2014-08-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1582. --- Resolution: Fixed Committed to trunk System Test should wait for producer to finish

Re: Review Request 24704: Patch for KAFKA-1499

2014-08-15 Thread Joel Koshy
On Aug. 15, 2014, 12:52 a.m., Joel Koshy wrote: core/src/main/scala/kafka/log/Log.scala, line 263 https://reviews.apache.org/r/24704/diff/1/?file=660643#file660643line263 As summarized in the ticket description we should have per-topic overrides as well. If the topic's config has

Re: Review Request 24704: Patch for KAFKA-1499

2014-08-15 Thread Joel Koshy
On Aug. 14, 2014, 9:52 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, line 323 https://reviews.apache.org/r/24704/diff/1/?file=660645#file660645line323 Can we just call the config compression.type? Also, the default value of NoCompressionCodec is a

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-15 Thread Joel Koshy
and KAFKA-1583 should significantly improve the overall structure. - Joel Koshy On Aug. 15, 2014, 1:21 a.m., Jonathan Natkins wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620

Re: Review Request 24620: Patch for KAFKA-1580

2014-08-15 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24620/#review50786 --- Ship it! Ship It! - Joel Koshy On Aug. 15, 2014, 10:05 p.m

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-08-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14099304#comment-14099304 ] Joel Koshy commented on KAFKA-687: -- [~junrao] I was thinking over this a little more and I

[jira] [Updated] (KAFKA-1580) Reject producer requests to internal topics

2014-08-15 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1580: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk. Reject

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-14 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097674#comment-14097674 ] Joel Koshy commented on KAFKA-1577: --- [~sriharsha] I tried reproducing this again

[jira] [Created] (KAFKA-1596) Exception in KafkaScheduler while shutting down

2014-08-14 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1596: - Summary: Exception in KafkaScheduler while shutting down Key: KAFKA-1596 URL: https://issues.apache.org/jira/browse/KAFKA-1596 Project: Kafka Issue Type: Bug

Re: Review Request 23567: Patch for KAFKA-1522

2014-08-14 Thread Joel Koshy
https://reviews.apache.org/r/23567/#comment88514 It would help to have comments here describing each type's role. - Joel Koshy On Aug. 9, 2014, 4:21 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 24704: Patch for KAFKA-1499

2014-08-14 Thread Joel Koshy
/24704/#comment88539 Can you also add a test to LogTest - i.e., that the feature actually works? - Joel Koshy On Aug. 14, 2014, 5:01 p.m., Manikumar Reddy O wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 24411: Patch for KAFKA-1524

2014-08-13 Thread Joel Koshy
/earlier version? - Joel Koshy On Aug. 6, 2014, 7:51 p.m., Raul Castro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24411

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14095940#comment-14095940 ] Joel Koshy commented on KAFKA-1510: --- After some discussion with [~guozhang] and [~junrao

[jira] [Commented] (KAFKA-1567) Metric memory leaking after closing the clients

2014-08-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096159#comment-14096159 ] Joel Koshy commented on KAFKA-1567: --- Although this is in the old consumer

[jira] [Commented] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-13 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096408#comment-14096408 ] Joel Koshy commented on KAFKA-1577: --- Unfortunately I don't have reliable steps

Re: Review Request 24480: Fix KAFKA-1578

2014-08-08 Thread Joel Koshy
to deregister the broker change listener as well? - Joel Koshy On Aug. 8, 2014, 5:28 p.m., Guozhang Wang wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24480

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091100#comment-14091100 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] I realized later there is actually

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091103#comment-14091103 ] Joel Koshy commented on KAFKA-1510: --- Would you be able to update your patch to take

[jira] [Created] (KAFKA-1580) Reject producer requests to internal topics

2014-08-08 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1580: - Summary: Reject producer requests to internal topics Key: KAFKA-1580 URL: https://issues.apache.org/jira/browse/KAFKA-1580 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-1581) Log cleaner should have an option to ignore messages without keys

2014-08-08 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1581: - Summary: Log cleaner should have an option to ignore messages without keys Key: KAFKA-1581 URL: https://issues.apache.org/jira/browse/KAFKA-1581 Project: Kafka

Re: Review Request 23567: Patch for KAFKA-1522

2014-08-08 Thread Joel Koshy
the order - can we just do a simple groupBy? core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/23567/#comment87617 Same as above - thought this was no longer required (see comments from previous review) - Joel Koshy On Aug. 6, 2014, 4:28 a.m., Dong Lin wrote

[jira] [Commented] (KAFKA-1524) Implement transactional producer

2014-08-08 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14091410#comment-14091410 ] Joel Koshy commented on KAFKA-1524: --- [~raulcf] will take a look at the updated patch

[jira] [Created] (KAFKA-1577) Exception in ConnectionQuotas while shutting down

2014-08-07 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1577: - Summary: Exception in ConnectionQuotas while shutting down Key: KAFKA-1577 URL: https://issues.apache.org/jira/browse/KAFKA-1577 Project: Kafka Issue Type: Bug

Re: Review Request 23906: Patch for KAFKA-1527

2014-08-05 Thread Joel Koshy
/SimpleConsumer.scala https://reviews.apache.org/r/23906/#comment86684 Why do this after the above statement? - Joel Koshy On July 24, 2014, 11:23 p.m., Raul Castro Fernandez wrote: --- This is an automatically generated e-mail. To reply, visit

[jira] [Resolved] (KAFKA-1550) Patch review tool should use git format-patch to generate patch

2014-08-05 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1550. --- Resolution: Fixed Committed to trunk. Patch review tool should use git format-patch to generate

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-08-01 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083237#comment-14083237 ] Joel Koshy commented on KAFKA-1510: --- I see - my thinking was since we retry indefinitely

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081781#comment-14081781 ] Joel Koshy commented on KAFKA-1510: --- Re: isAutoCommit: Yes you are right. Can you fix

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-30 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080164#comment-14080164 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoi] - sure thing. Will get back to you

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14077480#comment-14077480 ] Joel Koshy commented on KAFKA-687: -- Short update on this: After the initial review

[jira] [Updated] (KAFKA-1557) ISR reported by TopicMetadataResponse most of the time doesn't match the Zookeeper information (and the truth)

2014-07-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1557: -- Component/s: (was: consumer) Labels: newbie++ (was: ) ISR reported

[jira] [Commented] (KAFKA-1557) ISR reported by TopicMetadataResponse most of the time doesn't match the Zookeeper information (and the truth)

2014-07-25 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074766#comment-14074766 ] Joel Koshy commented on KAFKA-1557: --- For the first question: I don't think cluster

[jira] [Updated] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1510: -- Summary: Force offset commits when migrating consumer offsets from zookeeper to kafka (was: Force

[jira] [Commented] (KAFKA-1510) Force offset commits when migrating consumer offsets from zookeeper to kafka

2014-07-23 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14072437#comment-14072437 ] Joel Koshy commented on KAFKA-1510: --- [~nmarasoiu] do you think you will be able to take

Re: Review Request 23655: Patch for KAFKA-687

2014-07-23 Thread Joel Koshy
partitions are distributed across all your consumers. core/src/test/scala/unit/kafka/consumer/PartitionAllocatorTest.scala https://reviews.apache.org/r/23655/#comment85272 Will add it. - Joel Koshy On July 18, 2014, 10:57 p.m., Joel Koshy wrote

Re: question about message sets and produce requests/responses

2014-07-23 Thread Joel Koshy
Not sure if I followed the question correctly, but S1 and S2 would be message-sets to different partitions of T - the producer request object contains a map of topic-partition - messageset). So each partition would get its own ack. The response object is just a map of partition - response status

Re: question about message sets and produce requests/responses

2014-07-23 Thread Joel Koshy
Also, to be clear, by ack I mean an error code as described here: https://cwiki.apache.org/confluence/display/KAFKA/A+Guide+To+The+Kafka+Protocol#AGuideToTheKafkaProtocol-ProduceResponse On Wed, Jul 23, 2014 at 04:33:29PM -0700, Joel Koshy wrote: Not sure if I followed the question correctly

Re: Review Request 23648: Patch for KAFKA-1524

2014-07-22 Thread Joel Koshy
/TransactionCoordinatorNotAvailableException.java https://reviews.apache.org/r/23648/#comment84898 Incorrect comment. clients/src/main/java/org/apache/kafka/common/errors/TransactionFailedException.java https://reviews.apache.org/r/23648/#comment84899 Same - Joel Koshy On July 17, 2014, 5:37 p.m., Raul

Re: Review Request 23569: Patch for KAFKA-1525

2014-07-22 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23569/#review48416 --- Ship it! Ship It! - Joel Koshy On July 16, 2014, 9:30 p.m

Re: Review Request 23567: Patch for KAFKA-1522

2014-07-21 Thread Joel Koshy
txGroupId core/src/main/scala/kafka/common/ErrorMapping.scala https://reviews.apache.org/r/23567/#comment84636 TxCoordinatorNotAvailableCode - Joel Koshy On July 18, 2014, 3:12 a.m., Dong Lin wrote

Re: Review Request 23568: Patch for KAFKA-1523

2014-07-21 Thread Joel Koshy
should not be the key. - Joel Koshy On July 18, 2014, 3:12 a.m., Dong Lin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23568

[jira] [Commented] (KAFKA-1510) Force offset commits at a minimum interval when migrating consumer offsets from zookeeper to kafka

2014-07-18 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14066792#comment-14066792 ] Joel Koshy commented on KAFKA-1510: --- I think it should be sufficient to force commit

Re: Review Request 23655: Patch for KAFKA-687

2014-07-18 Thread Joel Koshy
-CREATION Diff: https://reviews.apache.org/r/23655/diff/ Testing --- * I did the unit tests (including the new one) as well as mirror maker system test suite with roundrobin. While this is being reviewed I will run the system tests with symmetric Thanks, Joel Koshy

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-18 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067051#comment-14067051 ] Joel Koshy commented on KAFKA-687: -- Updated reviewboard https://reviews.apache.org/r/23655

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-18 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687_2014-07-18_15:55:15.patch Rebalance algorithm should consider partitions from all

Re: Review Request 23655: Patch for KAFKA-687

2014-07-18 Thread Joel Koshy
://reviews.apache.org/r/23655/diff/ Testing --- * I did the unit tests (including the new one) as well as mirror maker system test suite with roundrobin. While this is being reviewed I will run the system tests with symmetric Thanks, Joel Koshy

Review Request 23655: Provide alternate (round-robin-style) rebalance algorithms.

2014-07-17 Thread Joel Koshy
/unit/kafka/consumer/PartitionAllocatorTest.scala PRE-CREATION Diff: https://reviews.apache.org/r/23655/diff/ Testing --- Thanks, Joel Koshy

[jira] [Updated] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-687: - Attachment: KAFKA-687.patch Rebalance algorithm should consider partitions from all topics

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065446#comment-14065446 ] Joel Koshy commented on KAFKA-687: -- Created reviewboard https://reviews.apache.org/r/23655

Re: Review Request 23655: Provide alternate (round-robin-style) rebalance algorithms.

2014-07-17 Thread Joel Koshy
one) as well as mirror maker system test suite with roundrobin. While this is being reviewed I will run the system tests with symmetric Thanks, Joel Koshy

Re: Review Request 23655: Provide alternate (round-robin-style) rebalance algorithms.

2014-07-17 Thread Joel Koshy
/ZookeeperConsumerConnector.scala https://reviews.apache.org/r/23655/#comment84294 (FYI: while this is being reviewed I will look into adding some mbeans to report topic-level and total owner counts for the consumer.) - Joel Koshy On July 17, 2014, 7:50 p.m., Joel Koshy wrote

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14065457#comment-14065457 ] Joel Koshy commented on KAFKA-687: -- I ended up abandoning the earlier approach I

[jira] [Assigned] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-07-17 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-687: Assignee: Joel Koshy (was: Sriharsha Chintalapani) Rebalance algorithm should consider partitions

[jira] [Created] (KAFKA-1541) Add transactional request definitions to clients package

2014-07-16 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1541: - Summary: Add transactional request definitions to clients package Key: KAFKA-1541 URL: https://issues.apache.org/jira/browse/KAFKA-1541 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-1524) Implement transactional producer

2014-07-16 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14063763#comment-14063763 ] Joel Koshy commented on KAFKA-1524: --- Can you use the patch review tool to submit? https

Re: Review Request 16718: Patch for KAFKA-1180

2014-07-08 Thread Joel Koshy
On Feb. 13, 2014, 10:54 p.m., Joel Koshy wrote: core/src/main/scala/kafka/utils/Utils.scala, line 545 https://reviews.apache.org/r/16718/diff/6/?file=484571#file484571line545 Thanks for the comment. However, I still don't get it. Why are JSON strings relevant here? i.e., we

Re: Review Request 16718: Patch for KAFKA-1180

2014-07-08 Thread Joel Koshy
on the tests. - Joel Koshy On Feb. 13, 2014, 8:24 p.m., Joe Stein wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16718/ --- (Updated

[jira] [Created] (KAFKA-1522) Transactional messaging request/response definitions

2014-07-04 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1522: - Summary: Transactional messaging request/response definitions Key: KAFKA-1522 URL: https://issues.apache.org/jira/browse/KAFKA-1522 Project: Kafka Issue Type: New

[jira] [Created] (KAFKA-1523) Implement transaction manager module

2014-07-04 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1523: - Summary: Implement transaction manager module Key: KAFKA-1523 URL: https://issues.apache.org/jira/browse/KAFKA-1523 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-1524) Implement transactional producer

2014-07-04 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1524: - Summary: Implement transactional producer Key: KAFKA-1524 URL: https://issues.apache.org/jira/browse/KAFKA-1524 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-1525) DumpLogSegments should print transaction IDs

2014-07-04 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1525: - Summary: DumpLogSegments should print transaction IDs Key: KAFKA-1525 URL: https://issues.apache.org/jira/browse/KAFKA-1525 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-1526) Producer performance tool should have an option to enable transactions

2014-07-04 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1526: - Summary: Producer performance tool should have an option to enable transactions Key: KAFKA-1526 URL: https://issues.apache.org/jira/browse/KAFKA-1526 Project: Kafka

[jira] [Assigned] (KAFKA-1527) SimpleConsumer should be transaction-aware

2014-07-04 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reassigned KAFKA-1527: - Assignee: Raul Castro Fernandez (was: Joel Koshy) SimpleConsumer should be transaction-aware

Transactional messaging in Kafka

2014-07-02 Thread Joel Koshy
A couple of folks have been thinking through adding transactional support to Kafka - close to, but much more general than the idempotent producer. Rather than put too many details in this email I thought I would send out a wiki link to the write-up and proposal:

[jira] [Resolved] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1491. --- Resolution: Fixed Committed (changed the log level to debug - Neha's review comment

[jira] [Created] (KAFKA-1510) Force offset commits at a minimum interval when migrating consumer offsets from zookeeper to kafka

2014-06-27 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1510: - Summary: Force offset commits at a minimum interval when migrating consumer offsets from zookeeper to kafka Key: KAFKA-1510 URL: https://issues.apache.org/jira/browse/KAFKA-1510

Re: Review Request 22905: Patch for KAFKA-1477

2014-06-26 Thread Joel Koshy
On June 26, 2014, 12:51 a.m., Joel Koshy wrote: core/src/main/scala/kafka/api/RequestKeys.scala, line 36 https://reviews.apache.org/r/22905/diff/1/?file=615398#file615398line36 Just wondering if TransactionMetadata is misleading - since we are actually inquiring about

Re: Review Request 22905: Patch for KAFKA-1477

2014-06-25 Thread Joel Koshy
this to anything other than -1 core/src/main/scala/kafka/api/TransactionRequest.scala https://reviews.apache.org/r/22905/#comment82253 Should probably append this only if details is true. - Joel Koshy On June 24, 2014, 2:02 a.m., Dong Lin wrote

[jira] [Resolved] (KAFKA-564) Wildcard-based topic consumption should assign partitions to threads uniformly

2014-06-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-564. -- Resolution: Duplicate KAFKA-687 is a little more general than this. Wildcard-based topic consumption

[jira] [Commented] (KAFKA-687) Rebalance algorithm should consider partitions from all topics

2014-06-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037620#comment-14037620 ] Joel Koshy commented on KAFKA-687: -- Although we are working on the new consumer, some

[jira] [Commented] (KAFKA-1374) LogCleaner (compaction) does not support compressed topics

2014-06-19 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14037669#comment-14037669 ] Joel Koshy commented on KAFKA-1374: --- I had started on this a while ago, but did

[jira] [Closed] (KAFKA-179) Log files always touched when broker is bounced

2014-06-12 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-179. Assignee: Raul Castro Fernandez Log files always touched when broker is bounced

[jira] [Resolved] (KAFKA-179) Log files always touched when broker is bounced

2014-06-12 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-179. -- Resolution: Implemented Cool - thanks for checking. Log files always touched when broker is bounced

[jira] [Commented] (KAFKA-179) Log files always touched when broker is bounced

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028313#comment-14028313 ] Joel Koshy commented on KAFKA-179: -- It might have been fixed in KAFKA-615. Maybe you can

[jira] [Created] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1491: - Summary: ConsumerMetadataResponse is not read completely Key: KAFKA-1491 URL: https://issues.apache.org/jira/browse/KAFKA-1491 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028556#comment-14028556 ] Joel Koshy commented on KAFKA-1491: --- So it turns out this is not as bad as I thought

[jira] [Updated] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1491: -- Attachment: KAFKA-1491.patch ConsumerMetadataResponse is not read completely

[jira] [Updated] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1491: -- Attachment: KAFKA-1491.patch ConsumerMetadataResponse is not read completely

[jira] [Commented] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028571#comment-14028571 ] Joel Koshy commented on KAFKA-1491: --- Created reviewboard https://reviews.apache.org/r

Review Request 22482: Patch for KAFKA-1491

2014-06-11 Thread Joel Koshy
ba5fbdcd9e60f953575e529325caf4c41e22f22d Diff: https://reviews.apache.org/r/22482/diff/ Testing --- Thanks, Joel Koshy

[jira] [Commented] (KAFKA-1491) ConsumerMetadataResponse is not read completely

2014-06-11 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14028570#comment-14028570 ] Joel Koshy commented on KAFKA-1491: --- Created reviewboard against branch origin/trunk

[jira] [Commented] (KAFKA-1486) Move all request/responses to use schema-utils

2014-06-10 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14027084#comment-14027084 ] Joel Koshy commented on KAFKA-1486: --- Jun mentioned that some of the work in KAFKA-1462

Re: Review Request 22446: Patch for KAFKA-1488

2014-06-10 Thread Joel Koshy
just measure the time for the original (full) await() no? - Joel Koshy On June 10, 2014, 11:15 p.m., Jun Rao wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22446

[jira] [Updated] (KAFKA-1472) Add the compression ratio metrics in the new producer

2014-05-29 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1472: -- Assignee: Dong Lin Add the compression ratio metrics in the new producer

[jira] [Closed] (KAFKA-1311) Add a flag to turn off delete topic until it is stable

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1311. - Add a flag to turn off delete topic until it is stable

[jira] [Closed] (KAFKA-1317) KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager or MetricsMeter state

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1317. - KafkaServer 0.8.1 not responding to .shutdown() cleanly, possibly related to TopicDeletionManager

[jira] [Closed] (KAFKA-1323) log.dirs server property no longer supports relative directories

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1323. - log.dirs server property no longer supports relative directories

[jira] [Closed] (KAFKA-1315) log.dirs property in KafkaServer intolerant of trailing slash

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1315. - log.dirs property in KafkaServer intolerant of trailing slash

[jira] [Closed] (KAFKA-1380) 0.8.1.1 release candidate

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1380. - 0.8.1.1 release candidate - Key: KAFKA-1380 URL

[jira] [Closed] (KAFKA-1362) Publish sources and javadoc jars

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1362. - Publish sources and javadoc jars Key: KAFKA-1362

[jira] [Closed] (KAFKA-1365) Second Manual preferred replica leader election command always fails

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1365. - Second Manual preferred replica leader election command always fails

[jira] [Closed] (KAFKA-1358) Broker throws exception when reconnecting to zookeeper

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1358. - Broker throws exception when reconnecting to zookeeper

[jira] [Closed] (KAFKA-1398) Topic config changes can be lost and cause fatal exceptions on broker restarts

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1398. - Topic config changes can be lost and cause fatal exceptions on broker restarts

[jira] [Closed] (KAFKA-1289) Misc. nitpicks in log cleaner

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1289. - Misc. nitpicks in log cleaner - Key: KAFKA-1289

[jira] [Closed] (KAFKA-1319) kafka jar doesn't depend on metrics-annotation any more

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1319. - kafka jar doesn't depend on metrics-annotation any more

[jira] [Resolved] (KAFKA-1380) 0.8.1.1 release candidate

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-1380. --- Resolution: Fixed 0.8.1.1 release candidate - Key: KAFKA

[jira] [Closed] (KAFKA-1288) add enclosing dir in release tar gz

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1288. - add enclosing dir in release tar gz --- Key: KAFKA-1288

[jira] [Closed] (KAFKA-1355) Reduce/optimize update metadata requests sent during leader election

2014-05-27 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy closed KAFKA-1355. - Reduce/optimize update metadata requests sent during leader election

<    5   6   7   8   9   10   11   12   13   14   >