Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-04 Thread Mason Legere
Hi All, Thanks for all the comments and suggestions! Addressing them in order: - Have you considered enabling the new metrics by default? > - If you prefer keeping a configuration to enable them, what about > renaming it to "client.quota.value.metric.enable" or even > "quota.value.metric.enable

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-04 Thread Bob Barrett
+1 to Tom's point. Having a metric is a lot more convenient than needing to periodically call an API, and anyone who isn't interested in the metric should be able to just not collect it. Thanks for the KIP, Mason! I think this will be very useful. Under the rejected alternatives, you say the foll

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-04 Thread Tom Bentley
This is a good point Luke. Unrelatedly, I've considered the value of exposing gauges for the expiry time of SSL certificates, which similarly change rarely. The metrics collected are used to build dashboards, create alerts etc. Thus to have, for example, an alert on approaching certificate expiry,

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-04 Thread Luke Chen
Hi Mason, Thanks for the KIP. But I think since the quota value won't change from time to time unless admin alter it, it might be waste of resources to record it on each produce/fetch API. It can alternatively be achieved by using the kafka-configs.sh to describe ALL users/clients/default to have a

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-11-03 Thread Mickael Maison
Hi Mason, Thanks for the KIP. I think it's a good idea to also emit quota limits as metrics. It certainly simplifies monitoring/graphing if all the data come from the same source. The KIP looks good overall, just a couple of questions: - Have you considered enabling the new metrics by default? -

Re: [DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-10-27 Thread Mason Legere
Hi All, Haven't received any feedback on this yet but as it was a small change have made a PR showing the functional components: pull request Will update the related documentation outlining the new metric attributes in a bit. Best, Mason Legere On Sat

[DISCUSS] KIP-786: Emit Metric Client Quota Values

2021-10-23 Thread Mason Legere
Hi All, I would like to start a discussion for my proposed KIP-786 which aims to allow client quota values to be emitted as a standard jmx MBean attribute - if enabl