RE: [VOTE] KIP-21 Dynamic Configuration

2015-06-01 Thread Aditya Auradkar
Thanks Jay. Since we have enough votes now, I'll mark this as adopted. Aditya From: Jay Kreps [jay.kr...@gmail.com] Sent: Monday, June 01, 2015 8:42 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration Awesome. +1 On Sunday

Re: [VOTE] KIP-21 Dynamic Configuration

2015-06-01 Thread Jay Kreps
uration-Migrationplanfornotifications > > Thanks, > Aditya > > From: Jay Kreps [jay.kr...@gmail.com ] > Sent: Saturday, May 30, 2015 9:51 AM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-21 Dynamic Configuration > > 1. G

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-31 Thread Aditya Auradkar
Jay Kreps [jay.kr...@gmail.com] Sent: Saturday, May 30, 2015 9:51 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration 1. Great. 2. I don't have a preference as to the casing, but I really appreciate consistency. Is everything using underscores today? If so let's stick

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-30 Thread Jay Kreps
ounced. So we do need to handle notifications in the old format. Should we > simply ignore older changes since they are only valid for a short period of > time? > > Thanks, > Aditya > > From: Jay Kreps [jay.kr...@gmail.com] > Sent: Thursday, May 28

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Aditya Auradkar
Auradkar Sent: Thursday, May 28, 2015 11:22 PM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-21 Dynamic Configuration Yeah, the same cleaning mechanism will be carried over. > 1. Are we introducing a new Java API for the config change protocol and if > so where will that appear? Is that going

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Aditya Auradkar
nce they are only valid for a short period of time? Thanks, Aditya From: Jay Kreps [jay.kr...@gmail.com] Sent: Thursday, May 28, 2015 5:25 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration That is handled now so I am assuming the same mechanism carries over? -Jay

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Jay Kreps
nkedin.com.invalid> wrote: > > > > > bump > > > > > > ____________ > > > From: Aditya Auradkar > > > Sent: Tuesday, May 26, 2015 1:16 PM > > > To: dev@kafka.apache.org > > > Subject: RE: [VOTE] KIP-21 Dyn

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Guozhang Wang
, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > > > bump > > > > > > From: Aditya Auradkar > > Sent: Tuesday, May 26, 2015 1:16 PM > > To: dev@kafka.apache.org > > Subject: RE: [VOTE] KIP-21

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Jay Kreps
5 at 11:41 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > bump > > > From: Aditya Auradkar > Sent: Tuesday, May 26, 2015 1:16 PM > To: dev@kafka.apache.org > Subject: RE: [VOTE] KIP-21 Dynamic Configuration > &

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Jay Kreps
5 at 11:41 AM, Aditya Auradkar < aaurad...@linkedin.com.invalid> wrote: > bump > > > From: Aditya Auradkar > Sent: Tuesday, May 26, 2015 1:16 PM > To: dev@kafka.apache.org > Subject: RE: [VOTE] KIP-21 Dynamic Configuration > &

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Jun Rao
___ > From: Aditya Auradkar > Sent: Thursday, May 21, 2015 11:26 AM > To: dev@kafka.apache.org > Subject: RE: [VOTE] KIP-21 Dynamic Configuration > > I think we should remove the config part in TopicMetadataResponse. It's > probably cleaner if

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Todd Palino
+1 (non binding) > On May 28, 2015, at 11:41 AM, Aditya Auradkar > wrote: > > bump > > > From: Aditya Auradkar > Sent: Tuesday, May 26, 2015 1:16 PM > To: dev@kafka.apache.org > Subject: RE: [VOTE] KIP-21 Dynamic C

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-28 Thread Aditya Auradkar
bump From: Aditya Auradkar Sent: Tuesday, May 26, 2015 1:16 PM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-21 Dynamic Configuration Hey everyone, Completed the changes to KIP-4. After today's hangout, there doesn't appear to be anything

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-26 Thread Aditya Auradkar
1, 2015 11:26 AM To: dev@kafka.apache.org Subject: RE: [VOTE] KIP-21 Dynamic Configuration I think we should remove the config part in TopicMetadataResponse. It's probably cleaner if Alter and Describe are the only way to view and modify configs but I don't feel very strongly about it.

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-22 Thread Jiangjie Qin
ed AlterConfig. If no-one objects, I can make some changes to >>KIP-4 >> to reflect this. >> >> Aditya >> >> >> From: Jay Kreps [jay.kr...@gmail.com] >> Sent: Tuesday, May 19, 2015 10:51 AM >> To: dev@kafk

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-21 Thread Aditya Auradkar
Configuration" error code to "InvalidEntityConfig" as proposed in KIP-21. Aditya From: Jun Rao [j...@confluent.io] Sent: Thursday, May 21, 2015 10:50 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration What about To

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-21 Thread Jun Rao
ange "InvalidTopicConfiguration" error code to "InvalidEntityConfig" > as proposed in KIP-21. > > > Thanks, > Aditya > > > From: Jun Rao [j...@confluent.io] > Sent: Thursday, May 21, 2015 8:41 AM > To

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-21 Thread Aditya Auradkar
, May 21, 2015 8:41 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration Aditya, For completeness, could you list the set of error codes in the wiki? Also, could you summarize the changes that are needed for the requests listed in KIP-4 and update the wiki accordingly? Thanks, Jun On

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-21 Thread Jun Rao
__ > From: Andrii Biletskyi [andrii.bilets...@stealth.ly] > Sent: Tuesday, May 19, 2015 2:26 PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-21 Dynamic Configuration > > Hi, > > Sorry I wasn't able to participate. I don't have objections abou

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-20 Thread Joel Koshy
Configuration > > Aditya > > From: Andrii Biletskyi [andrii.bilets...@stealth.ly] > Sent: Tuesday, May 19, 2015 2:26 PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-21 Dynamic Configuration > > Hi, > > Sorry I wasn

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-19 Thread Aditya Auradkar
rii.bilets...@stealth.ly] Sent: Tuesday, May 19, 2015 2:26 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration Hi, Sorry I wasn't able to participate. I don't have objections about removing config changes from AlterTopic (as I understand both AddedConfig and DeletedConfi

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-19 Thread Andrii Biletskyi
tedConfig => string > > > > The downside of this approach is that we will have 2 separate ways of > > changing topic configs (AlterTopic and AlterConfig). While a general > > AlterConfig only makes sense if we plan to have more than two types of > > entity configs.. it'

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-19 Thread Aditya Auradkar
If no-one objects, I can make some changes to KIP-4 to reflect this. Aditya From: Jay Kreps [jay.kr...@gmail.com] Sent: Tuesday, May 19, 2015 10:51 AM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration Hey Aditya, Two comments: 1. Yeah

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-19 Thread Jay Kreps
types of > entity configs.. it's definitely more future proof. Thoughts? > > Aditya > > > From: Todd Palino [tpal...@gmail.com] > Sent: Monday, May 18, 2015 12:39 PM > To: dev@kafka.apache.org > Subject: Re: [VOTE] KIP-21 Dynamic Configuration > > Agree with Jun

RE: [VOTE] KIP-21 Dynamic Configuration

2015-05-18 Thread Aditya Auradkar
ure proof. Thoughts? Aditya From: Todd Palino [tpal...@gmail.com] Sent: Monday, May 18, 2015 12:39 PM To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-21 Dynamic Configuration Agree with Jun here on the JSON format. I think your intention was likely to have actual JSON here and it was just a typo

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-18 Thread Todd Palino
Agree with Jun here on the JSON format. I think your intention was likely to have actual JSON here and it was just a typo in the wiki? -Todd On Mon, May 18, 2015 at 12:07 PM, Jun Rao wrote: > Aditya, > > Another thing to consider. In KIP-4, we are adding a new RPC request to > change and retrie

Re: [VOTE] KIP-21 Dynamic Configuration

2015-05-18 Thread Jun Rao
Aditya, Another thing to consider. In KIP-4, we are adding a new RPC request to change and retrieve topic configs. Do we want to add a similar RPC request to change configs per client id? If so, do we want to introduce a separate new request or have a combined new request for both topic and client

[VOTE] KIP-21 Dynamic Configuration

2015-05-18 Thread Aditya Auradkar
https://cwiki.apache.org/confluence/display/KAFKA/KIP-21+-+Dynamic+Configuration Aditya