Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-28 Thread David Jacot
Hi Colin, I agree that we try hard to avoid breaking compatibility. I am not questioning this at all. I also agree with your concern. My point was about requiring users to opt-in for a feature vs having it enabled by default during the EA and the Preview phases. With KIP-1022, the only way to

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-27 Thread Chia-Ping Tsai
On Wed, Jun 26, 2024, at 13:16, Jun Rao wrote: > > Hi, Colin, > > > > Thanks for the reply. > > > > 1. > https://kafka.apache.org/protocol.html#The_Messages_ConsumerGroupDescribe > > lists ConsumerGroupDescribeRequest, whose latest version is unstable. > > > > Hi Jun, > > I think that is a bug. >

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-27 Thread Colin McCabe
Hi David, Do most people feel that it's OK to break compatibility when transitioning a feature from EA to GA? I always had the impression we tried hard to avoid doing this. But I'm curious if this is documented somewhere. My concern about making this configuration externally useable is that

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-27 Thread David Jacot
Hi all, I think that it would be nice to have an official way to enable non-production-ready features in order to have a way to test them in development/soak clusters. For instance, I would like the new consumer protocol to be disabled by default but users should be able to enable it if they want

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Colin McCabe
Hi Jun, KIP-1014 is explicitly NOT for EA features, since EA features need to be usable by non-developers. I think it's important to be clear about this. Maybe "unreleased" would be a better name than "unstable" since people seem to have lots of different ideas about what "unstable" means,

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Jun Rao
Hi, Colin, Thanks for the reply. 4. "A developer could modify the code to allow unstable features outside of JUnit, and then run whatever they want." Hmm, it's inconvenient for a developer to make some temporary change just to test an unstable feature outside of junit, right? Also, how does a

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Colin McCabe
On Wed, Jun 26, 2024, at 13:16, Jun Rao wrote: > Hi, Colin, > > Thanks for the reply. > > 1. https://kafka.apache.org/protocol.html#The_Messages_ConsumerGroupDescribe > lists ConsumerGroupDescribeRequest, whose latest version is unstable. > Hi Jun, I think that is a bug. > > 4. "As devlopers,

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Jun Rao
Hi, Colin, Thanks for the reply. 1. https://kafka.apache.org/protocol.html#The_Messages_ConsumerGroupDescribe lists ConsumerGroupDescribeRequest, whose latest version is unstable. 4. "As devlopers, they can change the code to do this if they want." Just to be clear. A developer could be able to

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Colin McCabe
On Wed, Jun 26, 2024, at 12:09, Jun Rao wrote: > Hi, Colin, > > Thanks for restarting the discussion. A few comments. > > 1. "An unstable RPC version can be changed at any time, until it becomes > stable." > > What's our recommendation to non-java developers? Should they start > building a new

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Colin McCabe
Hi Justine, Since these configurations are (and have always been) internal, changing or removing them should be no problem. best, Colin On Tue, Jun 25, 2024, at 16:51, Justine Olshan wrote: > Hey Colin, > > I made a single configuration as part of KIP-1022 called >

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-26 Thread Jun Rao
Hi, Colin, Thanks for restarting the discussion. A few comments. 1. "An unstable RPC version can be changed at any time, until it becomes stable." What's our recommendation to non-java developers? Should they start building a new version of an RPC until it is stable? Should we explicitly mark

Re: [DISCUSS] KIP-1014: Managing Unstable Features in Apache Kafka

2024-06-25 Thread Justine Olshan
Hey Colin, I made a single configuration as part of KIP-1022 called unstableFeatureVersionsEnabled. Would we want to deprecate that and use the more generic name? Unfortunately, the config as defined in KIP-1022 is already in 3.8. Thanks for taking a look at this again. This will help with a lot