Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58495 --- Ship it! Just two minor comments that we can touch up on check-in.

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- (Updated Oct. 24, 2014, 7:56 a.m.) Review request for kafka. Bugs: KAFKA-1719

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58185 --- Ship it! Looks good - can you upload an updated RB incorporating th

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58171 --- Ship it! Besides the minor stylistic comment, rest looks good. co

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58168 --- Ship it! LGTM, one minor thing upon check in. core/src/main/scala

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- (Updated Oct. 23, 2014, 11:20 p.m.) Review request for kafka. Bugs: KAFKA-171

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we c

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 22, 2014, 9:32 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 271 > > > > > > Is there any value in setting this to true? It seems that just checking > > if it is fals

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review58049 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? > > Jiangjie Qin wrote: > Yes, it is intended, so that we c

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 22, 2014, 9:32 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 271 > > > > > > Is there any value in setting this to true? It seems that just checking > > if it is fals

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 22, 2014, 9:32 p.m., Neha Narkhede wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 271 > > > > > > Is there any value in setting this to true? It seems that just checking > > if it is fals

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- (Updated Oct. 22, 2014, 10:04 p.m.) Review request for kafka. Bugs: KAFKA-171

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review57907 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Re: Review Request 26994: Patch for KAFKA-1719

> On Oct. 21, 2014, 10:21 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/tools/MirrorMaker.scala, line 323 > > > > > > Is this change intended? Yes, it is intended, so that we can make sure each data channel

Re: Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/#review57680 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

Review Request 26994: Patch for KAFKA-1719

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26994/ --- Review request for kafka. Bugs: KAFKA-1719 https://issues.apache.org/jira/b