Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 18, 2015, 10:16 p.m., Jun Rao wrote: > > Thanks for the patch. A couple of comments. > > > > 1. We already measure the total produce/fetch request rate in > > RequestMetrics. Now, we are duplicating that in BrokerTopics. Is there a > > way to avoid the duplication? > > 2. The followi

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 18, 2015, 10:16 p.m., Jun Rao wrote: > > Thanks for the patch. A couple of comments. > > > > 1. We already measure the total produce/fetch request rate in > > RequestMetrics. Now, we are duplicating that in BrokerTopics. Is there a > > way to avoid the duplication? > > 2. The followi

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review73020 --- Thanks for the patch. A couple of comments. 1. We already measure t

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 18, 2015, 12:41 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/KafkaRequestHandler.scala, line 108 > > > > > > I think the aggregate rates here are redundant to what's already there > > in Requ

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72845 --- Ship it! core/src/main/scala/kafka/server/KafkaRequestHandler.scal

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72836 --- Ship it! Ship It! - Guozhang Wang On Feb. 17, 2015, 11:46 p.m.,

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 17, 2015, 11:02 p.m., Guozhang Wang wrote: > > core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala, line 137 > > > > > > Should this be BrokerTopicStats.getBrokerAllTopicsStats()? Good catch. Fixed

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/ --- (Updated Feb. 17, 2015, 11:46 p.m.) Review request for kafka and Joel Koshy.

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review72817 --- core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 9, 2015, 6:29 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > I agree with Guozhang that the offset commits need to be disambiguated. > > > >

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review71660 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 9, 2015, 5:47 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > appendToLocalLog can be called for both produce and commit-offset > > requests. A

Re: Review Request 30570: Patch for KAFKA-1914

> On Feb. 9, 2015, 5:47 p.m., Guozhang Wang wrote: > > core/src/main/scala/kafka/server/ReplicaManager.scala, lines 296-303 > > > > > > appendToLocalLog can be called for both produce and commit-offset > > requests. A

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/#review71646 --- core/src/main/scala/kafka/server/ReplicaManager.scala

Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/ --- Review request for kafka. Bugs: KAFKA-1914 https://issues.apache.org/jira/b

Re: Review Request 30570: Patch for KAFKA-1914

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30570/ --- (Updated Feb. 3, 2015, 6:50 p.m.) Review request for kafka. Bugs: KAFKA-1914