Re: Review Request 39842: Ability to load different instances of same driver class

2015-11-19 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39842/#review107323 --- I see some instances where both the drivers are using same initiali

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15015182#comment-15015182 ] Amareshwari Sriramadasu commented on LENS-868: -- Nice to know. Please go ahead w

[jira] [Updated] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amareshwari Sriramadasu updated LENS-868: - Fix Version/s: (was: 2.4) 2.5 > Should not bundle node & node

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014889#comment-15014889 ] Raju Bairishetti commented on LENS-868: --- Thanks [~sriksun], source release tar does no

RE: [VOTE] Release of Apache Lens 2.4.0-beta

2015-11-19 Thread Srikanth Sundarrajan
Hi Raju, I have updated https://issues.apache.org/jira/browse/LENS-868?focusedCommentId=15014148&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15014148 with more details. Rat check came out clean after the node & node_modules have been removed. Binary tar ball

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Srikanth Sundarrajan (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014148#comment-15014148 ] Srikanth Sundarrajan commented on LENS-868: --- A clean checkout and build seems to c

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013649#comment-15013649 ] Ajay Yadava commented on LENS-868: -- Not only the build will take more time but a bigger pro

[jira] [Comment Edited] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013636#comment-15013636 ] Ajay Yadava edited comment on LENS-868 at 11/19/15 2:54 PM: Sorr

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013636#comment-15013636 ] Ajay Yadava commented on LENS-868: -- Sorry I copied the wrong tab URL. We also exclude it du

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013592#comment-15013592 ] Ankeet Maini commented on LENS-868: --- We can certainly put node folder inside target, but t

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013590#comment-15013590 ] Ankeet Maini commented on LENS-868: --- I can see the files excluded in the rat check, we als

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013572#comment-15013572 ] Ajay Yadava commented on LENS-868: -- For the alternative, if you do want to keep the node_mo

Re: Hangout Today - Thursday 7 PM IST

2015-11-19 Thread Yash Sharma
Hangout is On. Feel free to join in !! On Thu, Nov 19, 2015 at 10:42 AM, amareshwarisr . wrote: > +1 Will join today. > > On Thu, Nov 19, 2015 at 10:35 AM, Yash Sharma wrote: > >> Hi All, >> We will be having the Lens weekly Hangout today @ 7 PM IST. >> Feel free to join in to share your though

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ajay Yadava (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013538#comment-15013538 ] Ajay Yadava commented on LENS-868: -- Although I am not an expert on node, I think node doesn

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Amareshwari Sriramadasu (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013519#comment-15013519 ] Amareshwari Sriramadasu commented on LENS-868: -- If we want to do this, that has

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013509#comment-15013509 ] Ankeet Maini commented on LENS-868: --- Also, we we were to exclude these folders, the person

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013475#comment-15013475 ] Ankeet Maini commented on LENS-868: --- We can pass an excludes argument in the maven-assembl

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013469#comment-15013469 ] Rajat Khandelwal commented on LENS-868: --- +1 > Should not bundle node & node_modules (

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Ankeet Maini (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013452#comment-15013452 ] Ankeet Maini commented on LENS-868: --- The location of node_modules can't be changed, else a

[jira] [Comment Edited] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013422#comment-15013422 ] Raju Bairishetti edited comment on LENS-868 at 11/19/15 12:21 PM:

[jira] [Comment Edited] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013422#comment-15013422 ] Raju Bairishetti edited comment on LENS-868 at 11/19/15 12:15 PM:

[jira] [Commented] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Raju Bairishetti (JIRA)
[ https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013422#comment-15013422 ] Raju Bairishetti commented on LENS-868: --- {noformat} io.wcm.maven.plugins

[jira] [Created] (LENS-868) Should not bundle node & node_modules (generated files) in source-release archive file

2015-11-19 Thread Raju Bairishetti (JIRA)
Raju Bairishetti created LENS-868: - Summary: Should not bundle node & node_modules (generated files) in source-release archive file Key: LENS-868 URL: https://issues.apache.org/jira/browse/LENS-868 Pr

[CANCEL][VOTE] Release of Apache Lens 2.4.0-beta Release candidate-0

2015-11-19 Thread Raju Bairishetti
Cancelling release candidate-0 of Lens 2.4.0-beta as issues with licenses.

Re: [VOTE] Release of Apache Lens 2.4.0-beta

2015-11-19 Thread Raju Bairishetti
Cancelling this release vote as there are licensing issues with this release On Thu, Nov 19, 2015 at 1:35 PM, Raju Bairishetti wrote: > @Srikanth, Please let me know if you find any license issues? I feel like > licenses of all dependencies in lens-ui module are compatible with Apache > License.

Re: Review Request 40475: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Amareshwari Sriramadasu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40475/#review107155 --- Ship it! Hope tests are passing on both java7 and java8. - Amares

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013244#comment-15013244 ] Rajat Khandelwal commented on LENS-851: --- Created https://reviews.apache.org/r/40475/

Review Request 40475: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40475/ --- Review request for lens. Bugs: LENS-851 https://issues.apache.org/jira/brow

Re: Review Request 39895: LENS-851: queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39895/ --- (Updated Nov. 19, 2015, 3:05 p.m.) Review request for lens. Bugs: LENS-851

[jira] [Work started] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on LENS-851 started by Rajat Khandelwal. - > queries where results of two storage tables of same fact are unioned, the > ro

[jira] [Commented] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15013133#comment-15013133 ] Rajat Khandelwal commented on LENS-851: --- Created LENS-867 for long term fix. > queri

[jira] [Created] (LENS-867) Do Query Comparison through individual ASTs

2015-11-19 Thread Rajat Khandelwal (JIRA)
Rajat Khandelwal created LENS-867: - Summary: Do Query Comparison through individual ASTs Key: LENS-867 URL: https://issues.apache.org/jira/browse/LENS-867 Project: Apache Lens Issue Type: Imp

[jira] [Reopened] (LENS-851) queries where results of two storage tables of same fact are unioned, the rows should be aggregated

2015-11-19 Thread Rajat Khandelwal (JIRA)
[ https://issues.apache.org/jira/browse/LENS-851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal reopened LENS-851: --- One failure is because for union queries, order is getting changed. There are other failures too bu