Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/ --- Review request for lens. Bugs: LENS-1168 https://issues.apache.org/jira/bro

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review140896 --- lens-server-api/src/test/java/org/apache/lens/server/api/query/co

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review140934 --- lens-server-api/src/main/java/org/apache/lens/server/api/LensConf

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 6, 2016, 4:20 a.m., Raju Bairishetti wrote: > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java, > > line 48 > > > > > > Can we change

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 6, 2016, 5:29 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java, > > line 939 > > > > > > Should we increase number this since we are using a Syn

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/ --- (Updated July 6, 2016, 8:47 a.m.) Review request for lens. Changes --- I

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 6, 2016, 5:29 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > lines 773-780 > > > > > > Do we need to hanlde InterrupedException sep

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review141266 --- lens-server-api/src/main/java/org/apache/lens/server/api/query/co

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 6, 2016, 5:29 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > lines 773-780 > > > > > > Do we need to hanlde InterrupedException sep

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 8, 2016, 10:45 a.m., Puneet Gupta wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java, > > line 49 > > > > > > shoudl we use driv

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review141638 --- lens-server-api/src/main/java/org/apache/lens/server/api/query/Qu

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 11, 2016, 6:12 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 205 > > > > > > I feel adding a new state would be better than ad

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/ --- (Updated July 12, 2016, 5:41 a.m.) Review request for lens. Changes ---

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review142912 --- lens-server/src/main/java/org/apache/lens/server/query/QueryExecu

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review142915 --- lens-server/src/main/java/org/apache/lens/server/query/QueryExecu

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 20, 2016, 8:36 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 773 > > > > > > We might need to hanlde InterruptedException fro

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 8, 2016, 10:45 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > lines 787-793 > > > > > > Do we need to synchronize the entire run me

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 11, 2016, 6:12 a.m., Rajat Khandelwal wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 205 > > > > > > I feel adding a new state would be better than ad

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 20, 2016, 8:36 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 767 > > > > > > Cancel code may require some synchronization. N

Re: Review Request 49371: LENS-1168 : Add query launcher pool

> On July 20, 2016, 8:53 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 1339 > > > > > > Do we need to await termination of this pool ?

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/ --- (Updated July 21, 2016, 11:56 a.m.) Review request for lens. Changes ---

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/ --- (Updated July 22, 2016, 4:05 a.m.) Review request for lens. Changes ---

Re: Review Request 49371: LENS-1168 : Add query launcher pool

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49371/#review143343 --- Ship it! Ship It! - Puneet Gupta On July 22, 2016, 4:05 a.m.