Re: Feature proposal for a new Filter result: Throw

2024-10-10 Thread Piotr P. Karwasz
Hi Gary, On Wed, 9 Oct 2024 at 16:34, Gary D. Gregory wrote: > My proposal is to allow a user to _not_ define any custom filters by reusing > a new Result enum value called “Throw”. When a filter returns “Throw”, then > Log4j throws a new LoggingException subclass called FilterLoggingException.

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 9 Oct 2024 at 16:46, Volkan Yazıcı wrote: > > Piotr, note that the build must be reproducible > for > CI-based signing. If this is not the case for Log4cxx, could you also > address that in your PR, pleas

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
Hi Stephen, On Wed, 9 Oct 2024 at 09:09, Piotr P. Karwasz wrote: > [1] > https://github.com/apache/logging-parent/blob/428d9ede494f54358c6f004b07f7e40f8f33d3ab/.github/workflows/merge-dependabot-reusable.yaml#L70-L79 The `deploy-release-reusable` workflow[1] should be a better example

Re: Adding to Logging KEYS file

2024-10-09 Thread Piotr P. Karwasz
On Wed, 9 Oct 2024 at 08:36, Stephen Webb wrote: > > That would be much simpler. I was not aware that option was available. Is > there an example I can copy? We use `actions/setup-java` in our workflows[1], which can also install a GPG key on the Github runner (and clears it when the action ends/

Re: Adding to Logging KEYS file

2024-10-08 Thread Piotr P. Karwasz
Hi Stephen, On Wed, 9 Oct 2024 at 07:12, Stephen Webb wrote: > > I have sent the public key D4305EBC16B4A78D to hkps://keys.openpgp.org > > Is this the correct way to get the KEYS file updated? You also need to append it to the KEYS file in the Subversion release repository: https://dist.apache.

Bridges in 2.x and 3.x

2024-10-08 Thread Piotr P. Karwasz
Hi all, I have finished the PRs for all X-to-Log4j API and Log4j API-to-X bridges in `2.x` and `3.x`, but the PRs are still waiting for a review, before I merge them and release `3.0.0-beta3`. Sorry for the long e-mail. Summarizing the situation would be: == JUL The Log4j API-to-JUL bridge (`lo

Re: [VOTE] Move Flume to dormant

2024-10-03 Thread Piotr P. Karwasz
Hi Christian, On Wed, 2 Oct 2024 at 21:30, Christian Grobmeier wrote: > Please vote: > > [] +1, label Flume as dormant > [] -1, don't label Flume as dormant because... +1, label Flume as dormant Honestly I have a lot of work on Log4j and I can not spare time to even release Flume. I did try to

[ANNOUNCE] Apache Log4j `2.24.1`released

2024-09-30 Thread Piotr P. Karwasz
The Apache Log4j team is pleased to announce the `2.24.1` release. Apache Log4j is a versatile, industrial-strength Java logging framework composed of an API, its implementation, and components to assist the deployment for various use cases. For further information (support, download, etc.) see th

[DISCUSS] Release Apache Log4j `2.24.1` (RC1)

2024-09-30 Thread Piotr P. Karwasz
Hi Axel, On Mon, 30 Sept 2024 at 08:51, Axel Howind wrote: > I know I'm late, but maybe it would be a good idea to mention that the Jigsaw > problems with 2.24.0 are also fixed in this release as some dependent > projects (POI being an example) have not updated because of this. There is > the

[RESULT][VOTE] Release Apache Log4j `2.24.1` (RC1)

2024-09-29 Thread Piotr P. Karwasz
Hi all, On Wed, 25 Sept 2024 at 20:36, Gary Gregory wrote: > > +1 passes on macOS, fails on Windows as usual (see GH issues). > > I tested the src zip file. > - ASC file OK > - SHA-512 file OK > - `mvn clean verify` OK Adding my +1 the vote passes with 3 +1 from Gary Gregory, Jan Friedrich and m

[VOTE] Release Apache Log4j `2.24.1` (RC1)

2024-09-24 Thread Piotr P. Karwasz
This is a vote to release the Apache Log4j `2.24.1`. Website: https://logging.staged.apache.org/log4j/2.24.1/index.html GitHub: https://github.com/apache/logging-log4j2 Commit: 8ee9387d9ec2063ab11f27eaa43e44a13f4c9935 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j/2.24.1 Nexus:

[ANNOUNCE] Apache Logging Parent `11.3.0` released

2024-09-21 Thread Piotr P. Karwasz
Apache Logging Parent team is pleased to announce the `11.3.0` release. This project contains the parent POM for other Maven-based Apache Logging Services projects. For further information (support, download, etc.) see the project website[1]. [1] https://logging.apache.org/logging-parent/index.htm

[RESULT][VOTE][LAZY] Release Apache Logging Parent `11.3.0` (RC1)

2024-09-21 Thread Piotr P. Karwasz
Hi all, On Tue, 17 Sept 2024 at 17:52, Piotr P. Karwasz wrote: > > This is a lazy-vote to release the Apache Logging Parent `11.3.0`. > > Website: https://logging.staged.apache.org/logging-parent-11.3.0 > GitHub: https://github.com/apache/logging-

Re: Use RTC in Log4j and Log4Net

2024-09-18 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 18 Sept 2024 at 09:46, Volkan Yazıcı wrote: > Changes can be exempt from this policy if and only if they suffice *only > one* of the following conditions: > >1. Grammatical corrections to the documentation (incl. Javadoc and >release notes) >2. Code typo fixes¹ less

Re: Use RTC in Log4j and Log4Net

2024-09-17 Thread Piotr P. Karwasz
Hi Matt, On Tue, 17 Sept 2024 at 20:06, Matt Sicker wrote: > > I’m -1 on switching to RTC. Same reason as always. Losing momentum from > waiting for an unnecessary code review will simply lead to much longer gaps > between time I spend on the project. Honestly, momentum is not always a good th

[VOTE][LAZY] Release Apache Logging Parent `11.3.0` (RC1)

2024-09-17 Thread Piotr P. Karwasz
This is a lazy-vote to release the Apache Logging Parent `11.3.0`. Website: https://logging.staged.apache.org/logging-parent-11.3.0 GitHub: https://github.com/apache/logging-parent Commit: 47c5a7a1073ac75ebb8aee58277a6b574862a990 Distribution: https://dist.apache.org/repos/dist/dev/logging/loggin

Re: Use RTC in Log4j and Log4Net

2024-09-17 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 17 Sept 2024 at 15:47, Ralph Goers wrote: > > Why? i.e. - what currently isn’t working? I merely wish to formalize what is already happening and set up a branch protection rule to enforce it. Note that I have never seen a PR in Log4Net being merged without a review. On the ot

Re: Can't build log4j main branch

2024-09-17 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 16 Sept 2024 at 20:19, Volkan Yazıcı wrote: > Gary has a failure on L361, that is, it retries every 100ms to succeed with > `logger.info()` for at most 2mins. I doubt if more waiting will solve the > problem. I tried to improve that test several times (see its history), but > W

Use RTC in Log4j and Log4Net

2024-09-17 Thread Piotr P. Karwasz
Hi all, Inspired by the way the Log4Net team works, I would like to propose a switch from our CTR policy to RTC: * every change to the main branches should go through a pull request, * pull requests can be merged if they have 1 positive review and no requested changes. To allow everyone to look a

Re: Can't build log4j main branch

2024-09-16 Thread Piotr P. Karwasz
Hi Gary, On Mon, 16 Sept 2024 at 16:50, Gary D. Gregory wrote: > > I just pulled main since we've had changes there, now I get: > > [ERROR] Tests run: 3, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.31 > s <<< FAILURE! -- in > org.apache.logging.log4j.core.appender.SocketAppenderReconne

Re: [VOTE] Release Apache Log4net 3.0.0

2024-09-12 Thread Piotr P. Karwasz
Hi Jan, On Thu, 12 Sept 2024 at 20:54, Jan Friedrich wrote: > How to run the unit tests? > - install docker (if you haven't already) > - https://docs.docker.com/engine/install/ > - in logging/log4net run > - `docker build -t log4net-builder .` > - `docker run -it log4net-builder` > - th

[DISCUSS] [VOTE] Release Apache Log4net 3.0.0

2024-09-12 Thread Piotr P. Karwasz
Hi Jan, On Thu, 12 Sept 2024 at 20:54, Jan Friedrich wrote: > > This is a vote to release the Apache Log4net 3.0.0. > > Website: https://logging.staged.apache.org/log4net/release/release-notes.html > GitHub: https://github.com/apache/logging-log4net > GitHub release (pre-release): > https://gith

Re: Can't build log4j main branch

2024-09-11 Thread Piotr P. Karwasz
Hi Gary, On Wed, 11 Sept 2024 at 22:13, Gary D. Gregory wrote: > Running 'mvn clean install' on git main [1] gives me: > > [ERROR] Failures: > [ERROR] AsyncLoggerConfigTest.testSingleFilterInvocation:114 > Wanted but not invoked: > appender.append(); > -> at > org.apache.logging.log4j.async.lo

Re: [ANNOUNCE] Apache Log4j `2.24.0` released

2024-09-06 Thread Piotr P. Karwasz
Hi Ralph, On Sat, 7 Sept 2024 at 07:00, Ralph Goers wrote: > > As I said previously, you should expect this will NOT get moderated through > the ASF announce list. The e-mail has the same format as the one I sent for 2.23.0[1] and is very similar to the one for 3.0.0-alpha1[2]. Looking at othe

[ANNOUNCE] Apache Log4j `2.24.0` released

2024-09-06 Thread Piotr P. Karwasz
Apache Log4j team is pleased to announce the `2.24.0` release. Apache Log4j is a versatile, industrial-strength Java logging framework composed of an API, its implementation, and components to assist the deployment for various use cases. For further information (support, download, etc.) see the pr

Re: [VOTE] Release Apache Log4j `2.24.0`

2024-09-05 Thread Piotr P. Karwasz
Hi Ralph, On Fri, 6 Sept 2024 at 01:46, Ralph Goers wrote: > Features: > > The GitHub actions workflows list several yaml files. This confuses me. Yaml > files don’t contain executable code so how do they accomplish any of the > features they list? Are these to configure specific GitHub Actions

[DISCUSS][VOTE] Release Apache Log4j `2.24.0`

2024-09-03 Thread Piotr P. Karwasz
Hi Volkan, On Tue, 3 Sept 2024 at 20:54, Volkan Yazıcı wrote: > My point is, 3 people verified the release and CI runs passed on all 3 > platforms – there is definitely something unexpected in your setup. As you > know better, issuing an RC is a time and energy consuming task. Besides RM, > other

Re: (logging-parent) branch main updated: Modify review kit

2024-09-03 Thread Piotr P. Karwasz
Hi Gary, On Tue, 3 Sept 2024 at 18:25, Gary Gregory wrote: > > Why doesn't the maven build in the review kit (below) invoke clean goal? > > > +sh mvnw -Prelease clean verify artifact:compare > > -Dreference.repo=$NEXUS_REPO > > + > > +# Run tests only (Windows) > > +sh mvnw -Prelease clean verify

[VOTE] Release Apache Log4j `2.24.0` (RC2)

2024-09-03 Thread Piotr P. Karwasz
This is a vote to release the Apache Log4j `2.24.0`. Website: https://logging.staged.apache.org/log4j/2.24.0/index.html GitHub: https://github.com/apache/logging-log4j2 Commit: c79ae325f6a21af45526c202f121bfced188613e Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j/2.24.0/ Nexus

Re: [VOTE] Release Apache Log4j `2.24.0`

2024-09-03 Thread Piotr P. Karwasz
Hi all, On Sat, 31 Aug 2024 at 21:30, Piotr P. Karwasz wrote: > > This is a vote to release the Apache Log4j `2.24.0`. > > Website: https://logging.staged.apache.org/log4j/2.24.0/index.html > GitHub: https://github.com/apache/logging-log4j2 > Commit: 08053687456f6be61ee820

Re: [log4net] INFRA-managed NuGet account

2024-09-02 Thread Piotr P. Karwasz
Hi, FYI, I also notified the Apache ActiveMQ developers about the `asf` organisation. They will migrate to it too: https://issues.apache.org/jira/browse/AMQNET-843 Do you know any other ASF projects that use NuGet? Piotr

Re: [VOTE] Release Apache Log4j `2.24.0`

2024-09-01 Thread Piotr P. Karwasz
Hi Gary, On Sun, 1 Sept 2024 at 23:34, Gary Gregory wrote: > Now I get: > > [INFO] Results: > [INFO] > [ERROR] Failures: > [ERROR] NetUtilsTest.testCanonicalHostName:78 > Expecting actual: > "localhost" > to contain: > "." > [INFO] > [ERROR] Tests run: 2253, Failures: 1, Errors: 0, Skipped:

Re: [VOTE] Release Apache Log4j `2.24.0`

2024-09-01 Thread Piotr P. Karwasz
Hi Gary, On Sun, 1 Sept 2024 at 23:00, Piotr P. Karwasz wrote: > On Sun, 1 Sept 2024 at 22:44, Gary Gregory wrote: > > [ERROR] sha512 mismatch log4j-bom-2.24.0-cyclonedx.xml: investigate > > with diffoscope > > target/reference/org.apache.logging.log4j/log4j-bom-2.24.0-cyc

Re: [VOTE] Release Apache Log4j `2.24.0`

2024-09-01 Thread Piotr P. Karwasz
Hi Gary, On Sun, 1 Sept 2024 at 22:44, Gary Gregory wrote: > [ERROR] sha512 mismatch log4j-bom-2.24.0-cyclonedx.xml: investigate > with diffoscope > target/reference/org.apache.logging.log4j/log4j-bom-2.24.0-cyclonedx.xml > target/bom.xml Could you investigate with `diff target/reference/org.apa

Re: [Discuss][VOTE] Release Apache Log4j `2.24.0`

2024-09-01 Thread Piotr P. Karwasz
Hi Ralph, On Sat, 31 Aug 2024 at 22:56, Ralph Goers wrote: > I looked at the download page and it does NOT meet the requirements for a > release announcement: > ... > Note that the web site is NOT officially part of the release so I am NOT > going to vote -1 due to any web site issues. Just be

[VOTE] Release Apache Log4j `2.24.0`

2024-08-31 Thread Piotr P. Karwasz
This is a vote to release the Apache Log4j `2.24.0`. Website: https://logging.staged.apache.org/log4j/2.24.0/index.html GitHub: https://github.com/apache/logging-log4j2 Commit: 08053687456f6be61ee8206da782a3d051928a57 Distribution: https://dist.apache.org/repos/dist/dev/logging/log4j Nexus: https:

Re: Delaying publication of `log4j-flume-ng` in 3.x

2024-08-30 Thread Piotr P. Karwasz
Hi Ralph, On Fri, 30 Aug 2024 at 08:44, Piotr P. Karwasz wrote: > On Thu, 29 Aug 2024 at 23:32, Ralph Goers wrote: > > So I will say I am fine with moving it to its own module. Can it be moved > > while keeping the 2.x and main branches? > > Sure, I created a `logging-lo

[ANNOUNCE] Apache Logging Parent `11.2.0` released

2024-08-30 Thread Piotr P. Karwasz
Apache Logging Parent team is pleased to announce the `11.2.0` release. This project contains the parent POM for other Maven-based Apache Logging Services projects. For further information (support, download, etc.) see the project website[1]. [1] https://logging.apache.org/logging-parent == Relea

[RESULT][VOTE][LAZY] Release Apache Logging Parent `11.2.0` (RC1)

2024-08-30 Thread Piotr P. Karwasz
On Tue, 27 Aug 2024 at 11:30, Piotr P. Karwasz wrote: > > This is a lazy-vote to release the Apache Logging Parent `11.2.0`. > > Website: https://logging.staged.apache.org/logging-parent-11.2.0 > GitHub: https://github.com/apache/logging-parent > Commit: b001c784d2a53c5f046758

Re: Delaying publication of `log4j-flume-ng` in 3.x

2024-08-29 Thread Piotr P. Karwasz
Hi Ralph, On Thu, 29 Aug 2024 at 23:32, Ralph Goers wrote: > So I will say I am fine with moving it to its own module. Can it be moved > while keeping the 2.x and main branches? Sure, I created a `logging-log4j-flume` repository and I'll move both branches there preserving the commit history.

Delaying publication of `log4j-flume-ng` in 3.x

2024-08-29 Thread Piotr P. Karwasz
Hi all, The `log4j-flume-ng` module _de facto_ contains 3 different appenders: * an Avro appender, that only depends on Avro and Avro IPC. Since it only communicates with Flume via network, it doesn't need to even depend on Flume, it just needs to use the same protocol. * a Persistent appender, w

[VOTE][LAZY] Release Apache Logging Parent `11.2.0` (RC1)

2024-08-27 Thread Piotr P. Karwasz
This is a lazy-vote to release the Apache Logging Parent `11.2.0`. Website: https://logging.staged.apache.org/logging-parent-11.2.0 GitHub: https://github.com/apache/logging-parent Commit: b001c784d2a53c5f046758bfaea2550eb8dcb299 Distribution: https://dist.apache.org/repos/dist/dev/logging/loggin

Preparation for 2.24.0 release

2024-08-17 Thread Piotr P. Karwasz
Hi all, I plan to release 2.24.0 in the week of August 26th. For that purpose I have cleaned up the 2.24.0 Milestone[1] on Github, which now contains only 6 issues that all have a PR ready. Could you look at those PRs and review them? I also submitted a PR that simplifies the logic of Properties

Re: Release timeline for log4j 2.24.0?

2024-08-16 Thread Piotr P. Karwasz
Hi John, On Thu, 15 Aug 2024 at 17:33, John Engebretson wrote: > Thanks Ralph! Unfortunately the test you attached doesn't attempt any > log statements against thread thread context. The only test performed on > this implementation loops through the keys that are present, and provides > ident

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Piotr P. Karwasz
Hi Gary, On Wed, 14 Aug 2024 at 12:34, Gary Gregory wrote: > I think that to "deactivate" the mailing lists you refer to would be very > bad and might not even be allowed by Apache. > > You cannot/shouldn't force people to create a GitHub (Microsoft) account > just to talk to us. Yes, that is an

Re: Unable to locate plugin type for Custom log4j2 Appender

2024-08-14 Thread Piotr P. Karwasz
Hi Volkan, [I am dropping `log4j-user@logging` from the recipients] On Wed, 14 Aug 2024 at 10:24, Volkan Yazıcı wrote: > On Tue, Aug 13, 2024 at 8:52 PM Piotr P. Karwasz > wrote: > > There is no special reason why `JsonTemplateLayout` does not support > > pretty print. I

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Piotr P. Karwasz
Hi Gary, On Fri, 9 Aug 2024 at 12:15, Gary Gregory wrote: > While it is a different community, I have received negative feedback in > Commons against the trend to spread information all over the place, and we > don't use GitHub. > > The TLDR is that in the past it was easier to find information b

Re: Release timeline for log4j 2.24.0?

2024-08-13 Thread Piotr P. Karwasz
Hi Ralph, On Wed, 14 Aug 2024 at 00:00, Ralph Goers wrote: > > Piotr, I am still concerned that you never looked into the issues I had with > StringArrayThreadContextMap. My performance tests were showing that it was > fast because it wasn’t actually setting values. It's on my TODO list. Note

Re: Release timeline for log4j 2.24.0?

2024-08-13 Thread Piotr P. Karwasz
Hi John, On Tue, 13 Aug 2024 at 21:10, John Engebretson wrote: > HI - just curious when the updated ThreadContextMap will be available? > The latest release is 2.23.1, over five months ago. We just finished a long series of documentation tasks that kept us occupied for the past since May[1].

Re: Unable to locate plugin type for Custom log4j2 Appender

2024-08-13 Thread Piotr P. Karwasz
Hi Amanda, I am crossposting this to dev@logging.apache.org. Please answer to that mailing list. On Tue, 6 Aug 2024 at 01:05, Amanda Liu wrote: > The reason I want a custom appender is to pretty print the JSON log objects > produced by JsonTemplateLayout, to make it more readable. I see in the

Re: Website footer copyright

2024-08-13 Thread Piotr P. Karwasz
Hi Robert, On Tue, 13 Aug 2024 at 00:11, Robert Middleton wrote: > > Stephen has gone and made an update to the log4cxx footer: > https://github.com/apache/logging-log4cxx/pull/406/files > This mentions dormant projects(e.g. chainsaw, log4php) and also > mentions Oracle. Should there be a common

Happy work anniversary Matt!

2024-08-12 Thread Piotr P. Karwasz
Hi all, According to the records, Matt joined the PMC exactly 10 years ago. Since then (and before) he has been continuously contributing to the Log4j, Log4j Scala and Log4j Kotlin projects. Happy work anniversary Matt! Piotr

Re: Should Log4j API bridges have a 3.x release?

2024-08-09 Thread Piotr P. Karwasz
Hi Matt, On Fri, 9 Aug 2024 at 22:54, Matt Sicker wrote: > > A 3.x version of `log4j-jul` isn’t strictly necessary as long as we have a > META-INF/versions/9/module-info.class file in the jar. Sure, but `log4j-jul` has some classes that use Log4j Core (to modify the configuration using JUL). Si

Re: Should Log4j API bridges have a 3.x release?

2024-08-09 Thread Piotr P. Karwasz
Hi Matt, On Fri, 9 Aug 2024 at 20:29, Matt Sicker wrote: > > Well, one thing that changed in JUL is that it requires the java.logging > module. Otherwise, the Java 8+ stuff is for the System.Logger API. Right, maybe a 3.x version of `log4j-jul` would be useful. Besides the artifact has an optio

Re: Integration tests

2024-08-09 Thread Piotr P. Karwasz
Hi Matt, On Fri, 9 Aug 2024 at 20:28, Matt Sicker wrote: > > Commons libraries are generally self-contained to the point where modularity > isn’t a problem. Things get complicated once you start involving split up > modules like APIs, SPIs, alternate implementations, and reflection-heavy > des

Re: Integration tests

2024-08-09 Thread Piotr P. Karwasz
Hi Gary, On Fri, 9 Aug 2024 at 15:24, Gary Gregory wrote: > I've had many requests to support JPMS in Commons and none that I recall > since I've been releasing jars using Moditect, so I can only assume it > works well enough. My impression is that people only care to get rid of > warnings or err

Re: Integration tests

2024-08-09 Thread Piotr P. Karwasz
Hi Gary, On Fri, 9 Aug 2024 at 13:18, Gary Gregory wrote: > I use Eclipse to create PRs for projects like Jetty 12 which has 200+ Maven > modules. How is this not a problem there? I don't see any `module-info.java` file in Jetty tests. Are they even running tests on the module path? > In Common

Re: Integration tests

2024-08-09 Thread Piotr P. Karwasz
Hi Gary, On Fri, 9 Aug 2024 at 12:00, Gary Gregory wrote: > > I hope you mean a new maven module and not a whole new git repo... Unfortunately I mean repo. The problem is that IDEs (even commercial ones like IntelliJ IDEA) barely handle JPMS and have big problems with the way we generate JPMS mo

Open GitHub discussions for Log4j Scala and Kotlin

2024-08-09 Thread Piotr P. Karwasz
Hi all, As specified in the `.asf.yaml` documentation, I am opening this thread to test the consensus on enabling Github discussions for `logging-log4j-kotlin` and `logging-log4j-scala`. Do you have anything against enabling this feature? Piotr BTW: an INFRA ticket is already open[2]. [1] htt

Staging site

2024-08-09 Thread Piotr P. Karwasz
Hi all, We finished revamping the documentation of Log4j 2. The result is available on the staging site: https://logging.staged.apache.org/log4j/2.x/ The new version should be: * visually more appealing. * takes advantage of AsciiDoc admonition blocks and tabbed code blocks to help users find i

Integration tests

2024-08-08 Thread Piotr P. Karwasz
Hi all, Unless I am mistaken, adding tests that run under JPMS is problematic in the `apache/logging-log4j2` repository. Even if I create a new Maven module for these tests: * IntelliJ IDEA still complains that it doesn't know a `org.apache.logging.log4j.core` module. * These tests might be flaky

Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-06 Thread Piotr P. Karwasz
Hi Volkan, On Sat, 3 Aug 2024 at 19:23, Volkan Yazıcı wrote: > Please download, test, and cast your votes on this mailing list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... I have tested: * that the hashes of the source and binary archives are correct, * that the signat

Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-04 Thread Piotr P. Karwasz
Hi Gary, On Sun, 4 Aug 2024 at 02:09, Gary Gregory wrote: > > Could the "review kit" instructions be incorrect then? I'm pretty sure I > just followed the steps. Can you double-check that you downloaded the sources for version 1.5.0 and not version 1.4.0? Both source archives are in the subversi

Re: [VOTE] Release Apache Log4j Kotlin API `1.5.0` RC1

2024-08-03 Thread Piotr P. Karwasz
Hi Gary, On Sat, 3 Aug 2024 at 23:47, Gary Gregory wrote: > > Using the review kit, running: > > sh mvnw -Prelease verify artifact:compare -Dreference.repo=$NEXUS_REPO > > I get: > > [INFO] --- artifact:3.5.0:compare (default-cli) @ log4j-api-kotlin-parent --- > Downloading from reference: > http

Re: Updating the Logging Services Logo

2024-07-23 Thread Piotr P. Karwasz
Hi Gary, On Tue, 23 Jul 2024 at 13:41, Gary Gregory wrote: > > Don't create and use a new Apache logo without Apache marketing involved > (or whichever part of Aapche is doing this). Sorry, I meant Apache Logging Services logo. Piotr

Re: Updating the Logging Services Logo

2024-07-23 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 23 Jul 2024 at 08:25, Ralph Goers wrote: > > What am I missing here? In looking at all the project sites none of our > logos have a feather in them. Once the ASF provides a replacement logo we can > simply replace it. The "Logging Services" image has a feather: https://loggi

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-21 Thread Piotr P. Karwasz
Hi Ralph, On Thu, 18 Jul 2024 at 01:34, Ralph Goers wrote: > > Although `$${date:...}` and `%d{...}` are not equivalent for > > `filePattern`, I don't see a reason for users to use the former. > > A file pattern like `$${date:-MM}/%d{-MM-dd}.log` that I often > > see in user questions, si

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Piotr P. Karwasz
Hi Matt, On Wed, 17 Jul 2024 at 19:03, Matt Sicker wrote: > I’ll note one design constraint behind property sources and lookups. Property > sources are defined in the API while lookups are defined in Core. Since Log4j Core 3 has a different properties system, property sources are technically de

Re: Redundant abstractions: property sources, lookups and pattern converters

2024-07-17 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 16 Jul 2024 at 15:17, Ralph Goers wrote: > > * we have a `SpringLookup` and a `SpringPropertySource`. > > SpringLookup returns the value of a key. A property source locates a set of > keys. So comparing them is apples to oranges. Or rather - an apple to a > bushel of apples. P

Redundant abstractions: property sources, lookups and pattern converters

2024-07-15 Thread Piotr P. Karwasz
Since the creation of Log4j 2, the concepts of `PropertySource` and `StrLookup` and the concepts of `StrLookup` and `LogEventPatternConverter` have strongly converged to each other. We might consider removing some of them in Log4j Core 4. ## Problem Log4j Core uses multiple map-like abstractions

Re: Release timeline for 2.24.0

2024-06-20 Thread Piotr P. Karwasz
Hi Gary, On Thu, 20 Jun 2024 at 13:55, Gary Gregory wrote: > I'll give you all my -1 POV here: I share some of your concerns. My main motivation for this experiment with Develocity is not to save up CI time, but to improve its responsiveness. >From my contributions to other projects I learned t

Re: (logging-log4j2) branch 2.x updated: Disable PTS on a per-module basis

2024-06-20 Thread Piotr P. Karwasz
Hi Gary, On Thu, 20 Jun 2024 at 14:15, Gary D. Gregory wrote: > I am -1 on changing our PRODUCTION 2.x build. If you want to experiment with > some company's product, please do so in a non-production branch. The cynic in > me sees this as a company wanting free advertising to say Apache uses th

Re: Release timeline for 2.24.0

2024-06-20 Thread Piotr P. Karwasz
Hi Gary, On Thu, 20 Jun 2024 at 13:15, Gary Gregory wrote: > I lost track of where we are after our video discussion regarding all the > scoped classes and 2.24.0. Where are we on those? >From my part I didn't advance much, since we are working hard on reviewing and improving the documentation.

Re: [Log4j] Potential support/dev policy for plugins

2024-06-17 Thread Piotr P. Karwasz
Hi Matt, On Tue, 11 Jun 2024 at 22:15, Matt Sicker wrote: > While I think we can adapt the Airflow guidance to Log4j, we will likely have > some different requirements. I think this would help a lot in determining > when and for how long to support plugins that involve third party > dependenci

Re: (logging-log4j2) branch 2.x updated: Disable PTS on a per-module basis

2024-06-14 Thread Piotr P. Karwasz
Hi Gary, On Fri, 14 Jun 2024 at 18:12, Gary Gregory wrote: > I sure hope that all tests are ALWAYS run by default in the 2.x branch, > otherwise it will be a -1 from me. Currently Predictive Test Selection is enabled on all CI builds, except the `release/*` branches, since I am trying to evaluat

Re: Release timeline for 2.24.0

2024-05-24 Thread Piotr P. Karwasz
Hi Ralph, On Fri, 24 May 2024 at 22:50, Ralph Goers wrote: > Thanks! Is there any chance you could provide some sample code we could use > to perform performance testing? Based on your description I have a suspicion > that ScopedContext would perform even better but at this point that is just

Re: Release timeline for 2.24.0

2024-05-24 Thread Piotr P. Karwasz
Hi John, On Fri, 24 May 2024 at 17:17, John Engebretson wrote: > The long-debated ScopedContext is not significant to us. Can > we set a target date for 2.24.0? Perhaps by punting ScopedContext to a > later date? +1, the release of 2.24.0 is a blocker for: * the release of a performance-optimi

Author lines in documentation

2024-05-14 Thread Piotr P. Karwasz
Can we remove author lines in documentation pages? These lines are becoming crowded and somehow IntelliJ IDEA formats author lines badly (i.e. inserts a blank line before them and they end up in the text. Of course this doesn't need to be a PMC decision: when I reformat a page I'll remove the nam

Re: [VOTE] Release Apache Log4j Tools `0.9.0` RC2

2024-05-10 Thread Piotr P. Karwasz
On Thu, 9 May 2024 at 14:40, Volkan Yazıcı wrote: > > This is a vote to release the Apache Log4j Tools `0.9.0` RC2. > > Website: https://logging.staged.apache.org/log4j/tools-0.9.0 > GitHub: https://github.com/apache/logging-log4j-tools > Commit: 485e1823cd6f8ae581071e938608db21126a7af5 > Distribu

Re: Canonicalization of URLs on our website

2024-05-08 Thread Piotr P. Karwasz
Hi Volkan, On Wed, 8 May 2024 at 14:57, Volkan Yazıcı wrote: > In my opinion, > >- Being able to view `target/site` with just using my browser and >nothing else is super convenient. The development experience is much >smoother. If we use a non-default `html_extension_style`, you can

Re: Canonicalization of URLs on our website

2024-05-08 Thread Piotr P. Karwasz
Hi all, On Sun, 21 Apr 2024 at 20:19, Volkan Yazıcı wrote: >1. Could you show us the Antora configuration option you mentioned >and how we can use it to achieve what you propose? I found the perfect Antora setting: `html_extension_style`[1]. The option I am proposing corresponds to the

Integration between `log4j-jpl` and `log4j-jul`

2024-05-07 Thread Piotr P. Karwasz
Hi, I just discovered that JBoss LogManager implemented a very nifty feature[1] that integrates Java 9 System.Logger with `java.util.logging`. Since: * `System.Logger` is loaded using `ServiceLoader` * JUL's `LogManager` requires a `java.util.logging.manager` system property to be set on the comm

Closing inactive issues

2024-04-24 Thread Piotr P. Karwasz
Hi all, We have currently almost 1000 issues for the Log4j project alone. Let us be honest, most of these issues will **never** be solved, we barely have time for the issues reported against the current Log4j version. What do you think about automatically closing as "Won't Fix" or "Abandoned" th

Re: Canonicalization of URLs on our website

2024-04-22 Thread Piotr P. Karwasz
Hi Volkan, On Sun, 21 Apr 2024 at 20:19, Volkan Yazıcı wrote: > > I have a couple of questions Piotr: > >1. Could you show us the Antora configuration option you mentioned >and how we can use it to achieve what you propose? There are `:relfileprefix:` and `:relfilesuffix:` attributes[1]

Re: End-of-life date for `log4j-1.2-api`

2024-04-21 Thread Piotr P. Karwasz
Hi Ralph, On Mon, 22 Apr 2024 at 03:35, Ralph Goers wrote: > > Did we make a decision on this? Since apparently there is consensus in the PMC, I opened an issue[1] and I am going to remove `log4j-1.2-api` from the `main` branch. Piotr [1] https://github.com/apache/logging-log4j2/issues/2461

Re: Canonicalization of URLs on our website

2024-04-20 Thread Piotr P. Karwasz
Hi Gary, On Sun, 21 Apr 2024 at 00:02, Gary Gregory wrote: > > I agree with Piotr. I prefer the simplest solution, pointing to > `index.html`, no guessing required. Personally I prefer the shortest one: * no www, * no `index.html`, * no `.html`. Piotr

Canonicalization of URLs on our website

2024-04-20 Thread Piotr P. Karwasz
Hi, I scanned our https://logging.apache.org/ website and found out that the internal hyperlinks between our pages are not consistent. For example links to: https://logging.apache.org/log4j/2.x/ might appear in hyperlinks with an URI path of: * `/log4j/2.x` (which causes a 301 HTTP redirect), *

Re: [Log4j] In 2.x, drop log4j-mongodb3 and add log4j-mongodb5

2024-04-17 Thread Piotr P. Karwasz
Hi Gary, On Wed, 17 Apr 2024 at 21:23, Gary Gregory wrote: > But then your config has to say AND depend on the mongodb5 > module! Still confusing 😕 There is actually a rarely used feature of our plugin system, where a plugin named `Foo` can actually create an object of type `Bar`. See for examp

Re: [Log4j] In 2.x, drop log4j-mongodb3 and add log4j-mongodb5

2024-04-17 Thread Piotr P. Karwasz
Hi Gary, On Wed, 17 Apr 2024 at 18:45, Gary Gregory wrote: > Maybe if want to only use the latest driver for main, we should rename the > module and classes and drop the "4". That or go with what I initially > suggested. Your initial proposal of having a separate `log4j-mongodb4` and `log4j-mong

Re: [Log4j] In 2.x, drop log4j-mongodb3 and add log4j-mongodb5

2024-04-17 Thread Piotr P. Karwasz
Hi Gary, On Wed, 17 Apr 2024 at 16:36, Gary D. Gregory wrote: > > Hello All, > > In In 2.x, I would like to: > > - drop log4j-mongodb3 and > - add log4j-mongodb5 > - then do the same in 3.x > > Any objections? It is fine with me. Regarding log4j-mongodb5: MongoDB driver has already been upgrade

Re: Context data propagation and logger-bound context data

2024-04-15 Thread Piotr P. Karwasz
Hi, On Mon, 15 Apr 2024 at 18:44, Matt Sicker wrote: > Context Propagation support :: Micrometer Context Propagation > > docs.micrometer.io > > [image: favicon.ico] >

Re: Monitoring discards from async logging

2024-04-12 Thread Piotr P. Karwasz
Hi Adam, On Fri, 12 Apr 2024 at 21:42, Thomas, Adam wrote: > That sounds appealing, but do you have to have this hook registered by the > time the disruptor is set up? That's my fundamental concern with a lot of > these interception strategies - if your library/framework is called (which > our

Re: Monitoring discards from async logging

2024-04-12 Thread Piotr P. Karwasz
Hi Volkan, On Thu, 11 Apr 2024 at 21:26, Volkan Yazıcı wrote: > *Slightly longer answer:* Log4j has never had a holistic observability view > to its internals. We need something new (if not, from scratch), and > preferably, applicable to not only async. logging, but all components > wherever this

Re: Monitoring discards from async logging

2024-04-10 Thread Piotr P. Karwasz
Hi Adam, On Wed, 10 Apr 2024 at 19:03, Thomas, Adam wrote: > I would do this if I had control of the end user's logging setup. > Unfortunately, I vend an internal library that is used by a lot of different > teams. By the time my code is invoked, AsyncLoggerDisruptor has already read > the sys

Re: Monitoring discards from async logging

2024-04-09 Thread Piotr P. Karwasz
Hi Adam, On Wed, 10 Apr 2024 at 00:11, Thomas, Adam wrote: > I created a pull request[1] late last year for this, and was encouraged to > start a discussion on the dev list at the time. Be reassured that we didn't forget about your PR, we just have a lot of changes going on to publish Log4j Cor

Re: Should Log4j API bridges have a 3.x release?

2024-04-09 Thread Piotr P. Karwasz
Hi Ralph, On Tue, 9 Apr 2024 at 23:46, Ralph Goers wrote: > You are forgetting one small thing. Plugins in 3.x use ServiceLoader while > 2.x uses the Log4j2Plugins.dat file. While 3.x supports the old format it > will be much better for users to not have to use the transformer when > building

Re: Should Log4j API bridges have a 3.x release?

2024-04-09 Thread Piotr P. Karwasz
Hi, On Tue, 9 Apr 2024 at 21:34, Piotr P. Karwasz wrote: > * `log4j-iostreams`, > * `log4j-jpl`, > * `log4j-jul`, > * `log4j-slf4j-impl`, > * `log4j-slf4j2-impl`, > * `log4j-to-jul`, > * `log4j-to-slf4j`. Don't get me wrong: these are very good artifacts, but I really

Should Log4j API bridges have a 3.x release?

2024-04-09 Thread Piotr P. Karwasz
Hi all, Since Log4j Core 3.x moved to `log4j-api` 2.24.0, many artifacts that only depend on `log4j-api` became redundant in the 3.x branch: * `log4j-iostreams`, * `log4j-jpl`, * `log4j-jul`, * `log4j-slf4j-impl`, * `log4j-slf4j2-impl`, * `log4j-to-jul`, * `log4j-to-slf4j`. Right now the `3.x` v

End-of-life date for `log4j-1.2-api`

2024-04-08 Thread Piotr P. Karwasz
Hi all, As you are probably aware, `log4j-1.2-api` is the second largest artifact we maintain. Yes, it is slightly larger than `log4j-api` and twice the size of JTL. This library is mainly used: 1. By some older frameworks/libraries that want to "help" users in their logging configuration. The a

Logger context specific configuration and properties in 3.x

2024-03-26 Thread Piotr P. Karwasz
Hi all, I have some concerns at the naming strategy of per-context properties files documented in: https://logging.apache.org/log4j/3.x/manual/systemproperties The naming of the properties files seems dangerously close to that of configuration files: * configuration files are named `log4j2.json

  1   2   3   4   5   6   >