Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Ignacio Vera
I have spoken to Adrien offline and I have included LUCENE-90555 which includes a fix where shape line queries would fail detecting crossing through edge points. Thanks Adrien. On Thu, Dec 19, 2019 at 6:24 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Since there was a re-spin,

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Ishan Chattopadhyaya
Since there was a re-spin, I added SOLR-14108 to the release branch. It is a very minor fix (null check), but solves an important annoyance that Erik Hatcher reported while trying to use the package manager. On Thu, Dec 19, 2019 at 3:31 AM Noble Paul wrote: > > I'v ported the commit >

Re: Paying attention to deprecation warnings

2019-12-18 Thread Kevin Risden
There is some "prior work" in this area [1] and [2]. Not specifically about deprecations, but the idea is the same. Use the tools we have like the java compiler to prevent future issues. Yes its going to be work to get to fewer warnings, but we need to make sure that new ones get added. [1]

OK, my first attempt at a SIP. Safe indexing operations without re-indexing

2019-12-18 Thread Erick Erickson
https://cwiki.apache.org/confluence/display/SOLR/SIP-2+Support+safe+index+transformations+without+reindexing JIRA: https://issues.apache.org/jira/browse/SOLR-14116 - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For

Re: Disturbing and steady decrease in boosting by date performance (and maybe others).

2019-12-18 Thread Joel Bernstein
One of the things that would be interesting would be to analyze the QTimes for individual queries from the logs for these runs. If you ship me the log files I can take a look. I'll also be posting a branch with new command line tool for posting logs to be indexed in Solr tomorrow and you can take

Disturbing and steady decrease in boosting by date performance (and maybe others).

2019-12-18 Thread Erick Erickson
The very short form is that from Solr 6.6.1 to Solr 8.3.1, the throughput for date boosting in my tests dropped by 40+% I’ve been hearing about slowdowns in successive Solr releases with boost functions, so I dug into it a bit. The test setup is just a boost-by-date with an additional big OR

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
I'v ported the commit https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=221d4ed On Thu, Dec 19, 2019 at 8:59 AM Noble Paul wrote: > > Thanks Adrien. > My apologies for the inconvenience . > > --Noble > > On Thu, Dec 19, 2019 at 8:04 AM Adrien Grand wrote: > > > > Thanks Cassandra for

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
Thanks Adrien. My apologies for the inconvenience . --Noble On Thu, Dec 19, 2019 at 8:04 AM Adrien Grand wrote: > > Thanks Cassandra for finding this missing commit. I'll start a new RC > tomorrow morning EU time. > > On Wed, Dec 18, 2019 at 9:21 PM Alexandre Rafalovitch > wrote: >> >> If

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Adrien Grand
Thanks Cassandra for finding this missing commit. I'll start a new RC tomorrow morning EU time. On Wed, Dec 18, 2019 at 9:21 PM Alexandre Rafalovitch wrote: > If there is a respin, maybe the Changenotes (for Solr) can be fixed too: > 1) First entry under Upgrade Notes is missing JIRA and

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Alexandre Rafalovitch
If there is a respin, maybe the Changenotes (for Solr) can be fixed too: 1) First entry under Upgrade Notes is missing JIRA and probably does not need to include the full class path 2) Optimization section can probably be skipped as it just has "no changes" entry 3) Couple of JIRAs are missing

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
I'm so sorry to come at this moment and tell you that one of the critical bug fixes I made to master was not ported to 8x and 8.4. This breaks a critical functionality of package loading feature. Is it possible to do a respin?

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Adrien Grand
Hi Gus, If the test is flaky, would you mind annotating it with "@BadApple"? It will make sure this test doesn't get in the way of building or voting on a release until the test is fixed. On Wed, Dec 18, 2019 at 3:52 PM Gus Heck wrote: > Hi Mkhail, This is a known flakey test (mine, it's on my

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Cassandra Targett
A little late for some votes, but the Draft version of the 8.4 Solr Ref Guide is up now: https://lucene.apache.org/solr/guide/8_4/ (I need to get on automating it soon.) On Dec 18, 2019, 8:52 AM -0600, Gus Heck , wrote: > Hi Mkhail, This is a known flakey test (mine, it's on my to do list).

Re: Paying attention to deprecation warnings

2019-12-18 Thread Erick Erickson
This’ll be a bit tricky as long as we have Java required 11 on master and Java 8 on 8x, we’ll have to sort out the deprecations due to the JDK .vs. everything else. That said, +1 to fixing this up, it’s been on my TODO list for, oh, 2 years or so, but keeps sliding. A hackathon would be a

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Atri Sharma
+1 SUCCESS! [1:26:38.49393] On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: >

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Gus Heck
Hi Mkhail, This is a known flakey test (mine, it's on my to do list). Seems to have got slightly more flakey recently possibly because other tests have got better at using up CPU?. The flake here is that the code in the test didn't manage to wait long enough before running the assertion. This

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Tommaso Teofili
+1 SUCCESS! [1:33:40.587556] On Wed, 18 Dec 2019 at 11:37, Shalin Shekhar Mangar wrote: > +1 > > SUCCESS! [0:50:00.981792] > > On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > >> Please vote for release candidate 1 for Lucene/Solr 8.4.0 >> >> The artifacts can be downloaded from: >> >>

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Shalin Shekhar Mangar
+1 SUCCESS! [0:50:00.981792] On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: > >

Paying attention to deprecation warnings

2019-12-18 Thread Jan Høydahl
Hi Our project compiles and runs with tons of deprecation warnings. Recently when working on SOLR-14106 and SOLR-14105 we found that there has been jetty deprecation warnings in the logs ever

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Munendra S N
+1 SUCCESS! [1:30:13.695296] On Wed, Dec 18, 2019 at 2:01 PM Andrzej Białecki wrote: > +1 > > SUCCESS! [1:34:39.788377] > > On 17 Dec 2019, at 21:13, Anshum Gupta wrote: > > +1 > > SUCCESS! [1:21:44.176149] > > On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand wrote: > >> Please vote for

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Andrzej Białecki
+1 SUCCESS! [1:34:39.788377] > On 17 Dec 2019, at 21:13, Anshum Gupta wrote: > > +1 > > SUCCESS! [1:21:44.176149] > > On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand > wrote: > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be