[jira] [Updated] (SOLR-12070) TestJMXIntegration.testJMXOnCoreReload always fails

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-12070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-12070: - Priority: Blocker (was: Major) > TestJMXIntegration.testJMXOnCoreReload always fails > --

[jira] [Commented] (SOLR-11591) AutoAddReplicasIntegrationTest failures on jenkins

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396880#comment-16396880 ] Alan Woodward commented on SOLR-11591: -- Thanks [~shalinmangar] > AutoAddReplicasInte

[jira] [Updated] (SOLR-11591) AutoAddReplicasIntegrationTest failures on jenkins

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated SOLR-11591: - Priority: Blocker (was: Major) > AutoAddReplicasIntegrationTest failures on jenkins > ---

[jira] [Commented] (SOLR-11591) AutoAddReplicasIntegrationTest failures on jenkins

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396878#comment-16396878 ] Alan Woodward commented on SOLR-11591: -- This is also failing all of the time on the 7

[jira] [Commented] (LUCENE-8038) Decouple payload decoding from Similarity

2018-03-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16396781#comment-16396781 ] Alan Woodward commented on LUCENE-8038: --- Hi [~xabbu42], this is because the Delimit

[jira] [Updated] (LUCENE-8202) Add a FixedShingleFilter

2018-03-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8202: -- Attachment: LUCENE-8202.patch > Add a FixedShingleFilter > > >

[jira] [Created] (LUCENE-8202) Add a FixedShingleFilter

2018-03-12 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8202: - Summary: Add a FixedShingleFilter Key: LUCENE-8202 URL: https://issues.apache.org/jira/browse/LUCENE-8202 Project: Lucene - Core Issue Type: New Feature

[jira] [Commented] (LUCENE-3475) ShingleFilter should handle positionIncrement of zero, e.g. synonyms

2018-03-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395140#comment-16395140 ] Alan Woodward commented on LUCENE-3475: --- Updated patch: * trailing terms that woul

[jira] [Updated] (LUCENE-3475) ShingleFilter should handle positionIncrement of zero, e.g. synonyms

2018-03-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-3475: -- Attachment: LUCENE-3475.patch > ShingleFilter should handle positionIncrement of zero, e.g. syn

[jira] [Commented] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394980#comment-16394980 ] Alan Woodward commented on LUCENE-8196: --- This patch makes IntervalIterator extend D

[jira] [Updated] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8196: -- Attachment: LUCENE-8196.patch > Add IntervalQuery and IntervalsSource to expose minimum interva

[jira] [Commented] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393182#comment-16393182 ] Alan Woodward commented on LUCENE-8196: --- I discussed scoring with [~jim.ferenczi] a

[jira] [Commented] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392834#comment-16392834 ] Alan Woodward commented on LUCENE-8196: --- I opened a pull request at [https://github

[jira] [Commented] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391580#comment-16391580 ] Alan Woodward commented on LUCENE-8196: --- {quote}Do we need {{IntervalIterator.score

[jira] [Created] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-08 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8196: - Summary: Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields Key: LUCENE-8196 URL: https://issues.apache.org/jira/browse/LUCENE-8196

[jira] [Updated] (LUCENE-8196) Add IntervalQuery and IntervalsSource to expose minimum interval semantics across term fields

2018-03-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8196: -- Attachment: LUCENE-8196.patch > Add IntervalQuery and IntervalsSource to expose minimum interva

[jira] [Resolved] (LUCENE-8121) UnifiedHighlighter can highlight terms within SpanNear clauses at unmatched positions

2018-02-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8121. --- Resolution: Fixed Think this can be resolved now. > UnifiedHighlighter can highlight terms w

[jira] [Commented] (LUCENE-8182) BoostingQuery applies the wrong boost to the query score

2018-02-21 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371217#comment-16371217 ] Alan Woodward commented on LUCENE-8182: --- +1 > BoostingQuery applies the wrong boos

[jira] [Resolved] (LUCENE-8179) StandardTokenizer doesn't tokenize the word "system" but it works for the plural "systems"

2018-02-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8179. --- Resolution: Not A Problem > StandardTokenizer doesn't tokenize the word "system" but it works

[jira] [Commented] (LUCENE-8179) StandardTokenizer doesn't tokenize the word "system" but it works for the plural "systems"

2018-02-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16370277#comment-16370277 ] Alan Woodward commented on LUCENE-8179: --- >From a quick look, it seems that all the

[jira] [Commented] (LUCENE-8179) StandardTokenizer doesn't tokenize the word "system" but it works for the plural "systems"

2018-02-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16369847#comment-16369847 ] Alan Woodward commented on LUCENE-8179: --- When I run your test program, it produces

[jira] [Commented] (LUCENE-3475) ShingleFilter should handle positionIncrement of zero, e.g. synonyms

2018-02-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358207#comment-16358207 ] Alan Woodward commented on LUCENE-3475: --- {quote}but won't generate a graph unless t

[jira] [Resolved] (LUCENE-8163) BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names

2018-02-09 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8163. --- Resolution: Fixed Fix Version/s: 7.3 master (8.0) > BaseDirectoryTe

[jira] [Commented] (LUCENE-8163) BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names

2018-02-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357017#comment-16357017 ] Alan Woodward commented on LUCENE-8163: --- Patch adopting the fix from LUCENE-7333 >

[jira] [Updated] (LUCENE-8163) BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names

2018-02-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8163: -- Attachment: LUCENE-8163.patch > BaseDirectoryTestCase.testListAllIsSorted() can create Windows-

[jira] [Assigned] (LUCENE-3475) ShingleFilter should handle positionIncrement of zero, e.g. synonyms

2018-02-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reassigned LUCENE-3475: - Assignee: Alan Woodward Affects Version/s: (was: 3.4) Here's a patch wi

[jira] [Updated] (LUCENE-3475) ShingleFilter should handle positionIncrement of zero, e.g. synonyms

2018-02-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-3475: -- Attachment: LUCENE-3475.patch > ShingleFilter should handle positionIncrement of zero, e.g. syn

[jira] [Commented] (LUCENE-8163) BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names

2018-02-07 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355600#comment-16355600 ] Alan Woodward commented on LUCENE-8163: --- The restricted filenames are all 4 chars l

[jira] [Created] (LUCENE-8163) BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names

2018-02-07 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8163: - Summary: BaseDirectoryTestCase.testListAllIsSorted() can create Windows-incompatible names Key: LUCENE-8163 URL: https://issues.apache.org/jira/browse/LUCENE-8163 P

[jira] [Commented] (LUCENE-8158) Expose OffsetsEnum directly from UnifiedHighlighter

2018-02-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352423#comment-16352423 ] Alan Woodward commented on LUCENE-8158: --- Here's an alternative, considerably more i

[jira] [Updated] (LUCENE-8158) Expose OffsetsEnum directly from UnifiedHighlighter

2018-02-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8158: -- Attachment: LUCENE-8158-alt.patch > Expose OffsetsEnum directly from UnifiedHighlighter > -

[jira] [Commented] (LUCENE-8158) Expose OffsetsEnum directly from UnifiedHighlighter

2018-02-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352268#comment-16352268 ] Alan Woodward commented on LUCENE-8158: --- This patch adds an OffsetProducer abstract

[jira] [Updated] (LUCENE-8158) Expose OffsetsEnum directly from UnifiedHighlighter

2018-02-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8158: -- Attachment: LUCENE-8158.patch > Expose OffsetsEnum directly from UnifiedHighlighter > -

[jira] [Created] (LUCENE-8158) Expose OffsetsEnum directly from UnifiedHighlighter

2018-02-05 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8158: - Summary: Expose OffsetsEnum directly from UnifiedHighlighter Key: LUCENE-8158 URL: https://issues.apache.org/jira/browse/LUCENE-8158 Project: Lucene - Core

[jira] [Resolved] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-02-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8145. --- Resolution: Fixed Fix Version/s: 7.3 Thanks for the comments and reviews everyone! >

[jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-02-01 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16348629#comment-16348629 ] Alan Woodward commented on LUCENE-8145: --- I've opened a pull request on github: [ht

[jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-01-31 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347602#comment-16347602 ] Alan Woodward commented on LUCENE-8145: --- Thanks for the review David!  I'll put up

[jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-01-31 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347062#comment-16347062 ] Alan Woodward commented on LUCENE-8145: --- I should add that this is just a refactori

[jira] [Commented] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-01-31 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16347059#comment-16347059 ] Alan Woodward commented on LUCENE-8145: --- This patch renames `FieldOffsetStrategy#ge

[jira] [Updated] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-01-31 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8145: -- Attachment: LUCENE-8145.patch > UnifiedHighlighter should use single OffsetEnum rather than Lis

[jira] [Created] (LUCENE-8145) UnifiedHighlighter should use single OffsetEnum rather than List

2018-01-31 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8145: - Summary: UnifiedHighlighter should use single OffsetEnum rather than List Key: LUCENE-8145 URL: https://issues.apache.org/jira/browse/LUCENE-8145 Project: Lucene -

[jira] [Commented] (LUCENE-8140) Checks for coplanarity when creating polygons shows numerical issues

2018-01-31 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346832#comment-16346832 ] Alan Woodward commented on LUCENE-8140: --- The commit messages had the wrong issue nu

[jira] [Commented] (LUCENE-8141) Inconsistent org.apache.lucene.codecs.PostingsFormat service definition?

2018-01-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16344935#comment-16344935 ] Alan Woodward commented on LUCENE-8141: --- Hi Matthias, You can have as many differe

[jira] [Commented] (LUCENE-8130) NullPointerException from TermStates.toString()

2018-01-15 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326253#comment-16326253 ] Alan Woodward commented on LUCENE-8130: --- +1 > NullPointerException from TermStates

[jira] [Commented] (LUCENE-8121) UnifiedHighlighter can highlight terms within SpanNear clauses at unmatched positions

2018-01-11 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322017#comment-16322017 ] Alan Woodward commented on LUCENE-8121: --- Changing the expected score in testSubPhra

[jira] [Reopened] (LUCENE-8121) UnifiedHighlighter can highlight terms within SpanNear clauses at unmatched positions

2018-01-11 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward reopened LUCENE-8121: --- Seeing lots of test failures due to this, specifically in TestUnifiedHighlighterStrictPhrases >

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2018-01-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316017#comment-16316017 ] Alan Woodward commented on LUCENE-8099: --- I removed BoostQParserPlugin.boostQuery().

[jira] [Commented] (LUCENE-8121) UnifiedHighlighter can highlight terms within SpanNear clauses at unmatched positions

2018-01-08 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315946#comment-16315946 ] Alan Woodward commented on LUCENE-8121: --- bq. can I incorporate this into Lucene wit

[jira] [Resolved] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8113. --- Resolution: Fixed Assignee: Alan Woodward Fix Version/s: master (8.0) Committ

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16313328#comment-16313328 ] Alan Woodward commented on LUCENE-8099: --- What pushed me over the line on the static

[jira] [Updated] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8113: -- Attachment: LUCENE-8113-rename.patch Thanks for the review Mike. Here's a patch with your sugg

[jira] [Updated] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8113: -- Attachment: LUCENE-8113-rename.patch OK, here's the patch again, this time including the rename

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312867#comment-16312867 ] Alan Woodward commented on LUCENE-8099: --- I committed those extra static methods, an

[jira] [Updated] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-05 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8113: -- Attachment: LUCENE-8113.patch Patch updated against master to take into account SimScorer API c

[jira] [Commented] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309810#comment-16309810 ] Alan Woodward commented on LUCENE-8113: --- Making the constructor private and adding

[jira] [Updated] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2018-01-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8099: -- Attachment: LUCENE-8099-2.patch Here's a patch demonstrating the static methods idea (against m

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2018-01-03 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16309384#comment-16309384 ] Alan Woodward commented on LUCENE-8099: --- Hi [~hossman] I had a few reasons for wan

[jira] [Updated] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8113: -- Attachment: LUCENE-8113.patch This patch folds LazyTermContext back into TermContext itself. T

[jira] [Resolved] (LUCENE-8012) Improve Explanation class

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8012. --- Resolution: Fixed Fix Version/s: master (8.0) Thanks for the review [~jpountz] > Impr

[jira] [Commented] (LUCENE-8114) Grouping module should not depend on queries module

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16307872#comment-16307872 ] Alan Woodward commented on LUCENE-8114: --- [~martijn.v.groningen] said: bq. I think

[jira] [Resolved] (LUCENE-8104) Facet module should no longer depend on Queries module (ValueSource)

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8104. --- Resolution: Fixed Fix Version/s: 7.3 I opened LUCENE-8114 to deal with grouping > Fac

[jira] [Created] (LUCENE-8114) Grouping module should not depend on queries module

2018-01-02 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8114: - Summary: Grouping module should not depend on queries module Key: LUCENE-8114 URL: https://issues.apache.org/jira/browse/LUCENE-8114 Project: Lucene - Core

[jira] [Updated] (LUCENE-8114) Grouping module should not depend on queries module

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8114: -- Description: Spin-off of LUCENE-8104 > Grouping module should not depend on queries module > --

[jira] [Updated] (LUCENE-8104) Facet module should no longer depend on Queries module (ValueSource)

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8104: -- Summary: Facet module should no longer depend on Queries module (ValueSource) (was: Grouping m

[jira] [Updated] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-02 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8113: -- Attachment: LUCENE-8113.patch Here's a patch that introduces a LazyTermContext object. TermCon

[jira] [Created] (LUCENE-8113) Allow terms dictionary lookups to be lazy when scores are not needed

2018-01-02 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8113: - Summary: Allow terms dictionary lookups to be lazy when scores are not needed Key: LUCENE-8113 URL: https://issues.apache.org/jira/browse/LUCENE-8113 Project: Lucen

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298514#comment-16298514 ] Alan Woodward commented on LUCENE-8104: --- I've committed the patch, shall I change t

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296661#comment-16296661 ] Alan Woodward commented on LUCENE-8104: --- FunctionScoreQuery is also in the queries

[jira] [Updated] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8104: -- Attachment: LUCENE-8104.patch Here's a patch changing the facet dependency on queries to be tes

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296505#comment-16296505 ] Alan Woodward commented on LUCENE-8104: --- The facets module also uses a FunctionQuer

[jira] [Commented] (LUCENE-8104) Grouping module should no longer depend on Queries module (ValueSource)

2017-12-19 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16296426#comment-16296426 ] Alan Woodward commented on LUCENE-8104: --- LUCENE-7889 is a start at implementing thi

[jira] [Resolved] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8099. --- Resolution: Fixed Fix Version/s: 7.3 Thanks David! > Deprecate CustomScoreQuery, Boos

[jira] [Commented] (LUCENE-7722) Remove BoostedQuery

2017-12-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295097#comment-16295097 ] Alan Woodward commented on LUCENE-7722: --- Think this can be resolved as a duplicate

[jira] [Updated] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8099: -- Attachment: LUCENE-8099.patch Patch adding support to MultiTermHighlighting and javadocs to Boo

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-18 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16295070#comment-16295070 ] Alan Woodward commented on LUCENE-8099: --- bq. RE DoubleValueSource helper: which iss

[jira] [Commented] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293837#comment-16293837 ] Alan Woodward commented on LUCENE-8099: --- Thanks for reviewing David bq. Here you'v

[jira] [Commented] (LUCENE-8092) TestRandomChains failure

2017-12-15 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292560#comment-16292560 ] Alan Woodward commented on LUCENE-8092: --- {code} SF:ShingleFilter@2d06f345 term=ᇻᆑᅌ,

[jira] [Commented] (LUCENE-8092) TestRandomChains failure

2017-12-15 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16292539#comment-16292539 ] Alan Woodward commented on LUCENE-8092: --- This is due to a combination of ShingleFil

[jira] [Resolved] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8093. --- Resolution: Fixed Fix Version/s: 7.3 > TrimFilterFactory should implement MultiTermAwa

[jira] [Resolved] (LUCENE-8098) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8098. --- Resolution: Duplicate > Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery >

[jira] [Updated] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-14 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8099: -- Attachment: LUCENE-8099.patch Patch deprecating these three queries and adding explanatory java

[jira] [Created] (LUCENE-8099) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-14 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8099: - Summary: Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery Key: LUCENE-8099 URL: https://issues.apache.org/jira/browse/LUCENE-8099 Project: Lucene - Core

[jira] [Created] (LUCENE-8098) Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery

2017-12-14 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8098: - Summary: Deprecate CustomScoreQuery, BoostedQuery and BoostingQuery Key: LUCENE-8098 URL: https://issues.apache.org/jira/browse/LUCENE-8098 Project: Lucene - Core

[jira] [Updated] (LUCENE-8012) Improve Explanation class

2017-12-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8012: -- Attachment: LUCENE-8012.patch Updated patch: - added a null check to the Explanation constructo

[jira] [Commented] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289821#comment-16289821 ] Alan Woodward commented on LUCENE-8093: --- Will commit this tomorrow if nobody object

[jira] [Updated] (LUCENE-8012) Improve Explanation class

2017-12-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8012: -- Attachment: LUCENE-8012.patch Here's a patch cutting everything over from float to Number, incl

[jira] [Commented] (LUCENE-8012) Improve Explanation class

2017-12-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16288985#comment-16288985 ] Alan Woodward commented on LUCENE-8012: --- There are a couple of options here. Just

[jira] [Updated] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-13 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-8093: -- Attachment: LUCENE-8093.patch Adrien also pointed me to MappingCharFilter, which behaves simila

[jira] [Commented] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287789#comment-16287789 ] Alan Woodward commented on LUCENE-8093: --- TrimFilter would I think normally be used

[jira] [Commented] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-12 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16287592#comment-16287592 ] Alan Woodward commented on LUCENE-8093: --- Ah, ok. Maybe I should add some javadoc t

[jira] [Created] (LUCENE-8093) TrimFilterFactory should implement MultiTermAwareComponent

2017-12-12 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8093: - Summary: TrimFilterFactory should implement MultiTermAwareComponent Key: LUCENE-8093 URL: https://issues.apache.org/jira/browse/LUCENE-8093 Project: Lucene - Core

[jira] [Created] (LUCENE-8092) TestRandomChains failure

2017-12-12 Thread Alan Woodward (JIRA)
Alan Woodward created LUCENE-8092: - Summary: TestRandomChains failure Key: LUCENE-8092 URL: https://issues.apache.org/jira/browse/LUCENE-8092 Project: Lucene - Core Issue Type: Bug

[jira] [Commented] (LUCENE-7996) Should we require positive scores?

2017-11-30 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272506#comment-16272506 ] Alan Woodward commented on LUCENE-7996: --- Rather than throwing errors from BoostingQ

[jira] [Updated] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-22 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6228: -- Attachment: LUCENE-6228.patch Here's an updated patch: * getChildren() is now on Scorable * Sco

[jira] [Commented] (LUCENE-8055) MemoryIndex.MemoryDocValuesIterator returns 2 document instead of 1

2017-11-21 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-8055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16260580#comment-16260580 ] Alan Woodward commented on LUCENE-8055: --- +1. Oops > MemoryIndex.MemoryDocValuesIt

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-20 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16259721#comment-16259721 ] Alan Woodward commented on LUCENE-6228: --- bq. Can we access the Query from this new

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255640#comment-16255640 ] Alan Woodward commented on LUCENE-6228: --- bq. What we need to prevent is someone cal

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255460#comment-16255460 ] Alan Woodward commented on LUCENE-6228: --- The issue with getChildren() is that you c

[jira] [Commented] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255332#comment-16255332 ] Alan Woodward commented on LUCENE-6228: --- bq. Can we try something like moving getCh

[jira] [Updated] (LUCENE-6228) Do not expose full-fledged scorers in LeafCollector.setScorer

2017-11-16 Thread Alan Woodward (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward updated LUCENE-6228: -- Attachment: LUCENE-6228.patch Here's a patch implementing [~rcmuir]'s idea of a Scorable interf

<    3   4   5   6   7   8   9   10   11   12   >