jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r319030989
##
File path: lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526152703
Ran precommit on the latest iteration -- came in clean.
@jimczi Looks good to be committed?
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526122213
> > Also, I believe having the abstraction will let future implementations
customize the threshold logic
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526120397
> Also, I believe having the abstraction will let future implementations
customize the threshold logic
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526113533
> > So, essentially, we make implicit CollectorManager implementations owned
by IndexSearcher instead of
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526110754
> So, essentially, we make implicit CollectorManager implementations owned
by IndexSearcher instead of
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526102145
> > That would require a CollectorManager implementation
>
> Not necessarily, you could create a
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526078472
> That would require a CollectorManager implementation
Not necessarily, you could create a
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-526075360
> I wonder if the shared count should be used automatically in
`IndexSearcher#searchAfter` if the executor is
shalinmangar merged pull request #805: SOLR-13649 change the default behavior
of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805
This is an automated message from the Apache Git Service.
shalinmangar commented on issue #805: SOLR-13649 change the default behavior of
the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-526028139
+1 LGTM. I'm going to do a squash merge to master.
noblepaul merged pull request #847: SOLR-13723 JettySolrRunner should support
/api/* (the v2 end point)
URL: https://github.com/apache/lucene-solr/pull/847
This is an automated message from the Apache Git Service.
To
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525982234
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525952277
@janhoy I need to make a few changes for precommit to pass. making now.
MarcusSorealheis removed a comment on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525944739
Ok. Will do. Thank you.
On Wed, Aug 28, 2019 at 3:20 PM Jan Høydahl
wrote:
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525944739
Ok. Will do. Thank you.
On Wed, Aug 28, 2019 at 3:20 PM Jan Høydahl
wrote:
>
janhoy commented on issue #805: SOLR-13649 change the default behavior of the
basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525944463
@MarcusSorealheis Can you try to address this precommit error:
> [java] ERROR: Orphan page:
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318801263
##
File path:
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525929484
very big help @janhoy. That was awesome. L-ingGTM?
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318798645
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318767322
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318763377
##
File path:
erikhatcher commented on issue #805: SOLR-13649 change the default behavior of
the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525892861
Looks great, Marcus! I've run the tests and they are passing.
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318667994
##
File path:
chatman commented on issue #768: SOLR-13472: Defer authorization to be done on
forwarded nodes
URL: https://github.com/apache/lucene-solr/pull/768#issuecomment-525813230
@anshumg, apologies for the confusion. This is already merged, but I forgot
to close the PR after merging.
chatman closed pull request #768: SOLR-13472: Defer authorization to be done on
forwarded nodes
URL: https://github.com/apache/lucene-solr/pull/768
This is an automated message from the Apache Git Service.
To respond to the
anshumg commented on issue #768: SOLR-13472: Defer authorization to be done on
forwarded nodes
URL: https://github.com/apache/lucene-solr/pull/768#issuecomment-525812178
Should've checked the code, this is already merged directly. Let's close
this one out @chatman ?
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318664696
##
File path:
anshumg merged pull request #849: SOLR-13257: Cleanup code and make the
AffinityReplicaTransformer constructors private (#848)
URL: https://github.com/apache/lucene-solr/pull/849
This is an automated message from the Apache
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318611751
##
File path:
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525754830
@jimczi Thanks, I updated per your comments. Please let me know if it seems
fine.
RE: benchmarks, the
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318559088
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318562876
##
File path:
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318563308
##
File path:
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318562576
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318559370
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318562103
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
jimczi commented on a change in pull request #823: LUCENE-8939: Introduce
Shared Count Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#discussion_r318561896
##
File path: lucene/core/src/java/org/apache/lucene/search/TopFieldCollector.java
atris edited a comment on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525720523
@jimczi Updated the PR with implementation for `TopScoreDocsCollector`.
Haven't added the corresponding
atris edited a comment on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525720523
@jimczi Updated the PR with implementation for `TopScoreDocsCollector`.
Haven't added the corresponding
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525720523
@jimczi Updated the PR with implementation for `TopScoreDocsCollector'.
Haven't added the corresponding
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525703089
> Should we commit this then, and then follow up on the other JIRA that I
opened?
Let's benchmark
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525695991
> > Looks like the performance is consistent and we see no degradation. WDYT?
>
> I don't think that
jimczi edited a comment on issue #823: LUCENE-8939: Introduce Shared Count
Early Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525687970
> Looks like the performance is consistent and we see no degradation. WDYT?
I don't think that
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525687970
> Looks like the performance is consistent and we see no degradation. WDYT?
I don't think that these
iverase commented on a change in pull request #844: LUCENE-8860: Make more
decision on inner nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844#discussion_r318499448
##
File path:
iverase commented on a change in pull request #844: LUCENE-8860: Make more
decision on inner nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844#discussion_r318499931
##
File path: lucene/sandbox/src/java/org/apache/lucene/geo/Rectangle2D.java
iverase commented on a change in pull request #844: LUCENE-8860: Make more
decision on inner nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844#discussion_r318499581
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318452959
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318451600
##
File path:
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525634541
I opened a JIRA for the follow up :
https://issues.apache.org/jira/browse/LUCENE-8958
Will post a patch
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318426085
##
File path:
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318425825
##
File path:
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318420753
##
File path:
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318419252
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318417151
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318414048
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318416829
##
File path:
janhoy commented on a change in pull request #805: SOLR-13649 change the
default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318417661
##
File path: solr/solr-ref-guide/src/basic-authentication-plugin.adoc
##
MarcusSorealheis commented on a change in pull request #805: SOLR-13649 change
the default behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#discussion_r318374760
##
File path:
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525563889
@shalinmangar if you run the tests now they all work
anshumg opened a new pull request #849: SOLR-13257: Cleanup code and make the
AffinityReplicaTransformer constructors private (#848)
URL: https://github.com/apache/lucene-solr/pull/849
SOLR-13257: Cleanup code and make the constructors private as the
constructor is supposed to be called
anshumg merged pull request #848: SOLR-13257: Cleanup code and make the
AffinityReplicaTransformer constructors private
URL: https://github.com/apache/lucene-solr/pull/848
This is an automated message from the Apache Git
anshumg commented on issue #768: SOLR-13472: Defer authorization to be done on
forwarded nodes
URL: https://github.com/apache/lucene-solr/pull/768#issuecomment-525520683
@chatman - is there something stopping you from merging this in?
anshumg commented on a change in pull request #768: SOLR-13472: Defer
authorization to be done on forwarded nodes
URL: https://github.com/apache/lucene-solr/pull/768#discussion_r318335441
##
File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
##
@@
anshumg opened a new pull request #848: SOLR-13257: Cleanup code and make the
AffinityReplicaTransformer constructors private
URL: https://github.com/apache/lucene-solr/pull/848
# Description
Cleanup code and make the AffinityReplicaTransformer constructors private
as the
tflobbe merged pull request #717: SOLR-13542: Code cleanup - Avoid using stream
filter count where possible
URL: https://github.com/apache/lucene-solr/pull/717
This is an automated message from the Apache Git Service.
To
atris edited a comment on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525287168
@jimczi Thanks for reviewing the PR.
I will follow up with a JIRA and a PR for
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-525287168
@jimczi Thanks for reviewing the PR.
I will follow up with a JIRA and a PR for `TopScoreDocCollector`
noblepaul opened a new pull request #847: SOLR-13723 JettySolrRunner should
support /api/* (the v2 end point)
URL: https://github.com/apache/lucene-solr/pull/847
This is just a PoC , NOT TO BE MERGED
This is an automated
MarcusSorealheis commented on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525172840
> org.apache.solr.cloud.TestConfigSetsAPI.testUploadWithScriptUpdateProcessor
Will check
shalinmangar commented on issue #805: SOLR-13649 change the default behavior of
the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525149948
@MarcusSorealheis There are a bunch of test failures still.
```
Test Result (10 failures /
noblepaul merged pull request #846: SOLR-13710: Persist package jars locally &
expose them over http
URL: https://github.com/apache/lucene-solr/pull/846
This is an automated message from the Apache Git Service.
To respond
MarcusSorealheis edited a comment on issue #805: SOLR-13649 change the default
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-522845003
Feel free to take a look when you can @janhoy I think it looks pretty good
and accounts
KoenDG commented on issue #717: SOLR-13542: Code cleanup - Avoid using stream
filter count where possible
URL: https://github.com/apache/lucene-solr/pull/717#issuecomment-525014070
@tflobbe Update and rebase done, all tests passed locally on openjdk11,
should be good now.
danmuzi merged pull request #839: LUCENE-8954: refactor Nori analyzer
URL: https://github.com/apache/lucene-solr/pull/839
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
danmuzi commented on issue #839: LUCENE-8954: refactor Nori analyzer
URL: https://github.com/apache/lucene-solr/pull/839#issuecomment-524966134
Thank you for your review! @jimczi
I'll merge this PR and close.
This is an
noblepaul opened a new pull request #846: SOLR-13710: Persist package jars
locally & expose them over http
URL: https://github.com/apache/lucene-solr/pull/846
This is an automated message from the Apache Git Service.
To
iverase merged pull request #842: LUCENE-8955: Move compare logic to
IntersectVisitor in NearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/842
This is an automated message from the Apache Git Service.
To
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524725795
@jimczi Looks like I partially misunderstood your earlier comments -- sorry
about that. I have raised a
noblepaul merged pull request #845: SOLR-13699 - maxChars no longer working on
CopyField with Javabin
URL: https://github.com/apache/lucene-solr/pull/845
This is an automated message from the Apache Git Service.
To respond
ctroullis opened a new pull request #845: SOLR-13699 - maxChars no longer
working on CopyField with Javabin
URL: https://github.com/apache/lucene-solr/pull/845
# Description
A regression was introduced as part of the optimizations made in
[SOLR-12992](SOLR-12992), which
shalinmangar commented on issue #805: SOLR-13649 change the default behavior of
the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-524591740
The current state looks good to me. It seems that all suggestions have been
incorporated and tests
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet
to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524513296
Thanks @tflobbe !
This is an automated message
tflobbe commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet
to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524470040
Thanks @atris! squashed/merged
This is an
tflobbe merged pull request #817: SOLR-13655:Upgrade
Collections.unModifiableSet to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817
This is an automated message from the Apache Git Service.
To
imotov opened a new pull request #844: LUCENE-8860: Make more decision on inner
nodes in ShapeBoundingBoxQuery
URL: https://github.com/apache/lucene-solr/pull/844
Relaxes the bounding box intersection check in bounding box queries on
the inner node level. For the intersection it is not
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524385885
> The reason for that is since `AtomicInteger.get()` is not guaranteed to be
thread safe, so that was a hack
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524382441
> I don't see what the modification is. The early termination logic is the
same, the only diff is that the
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524350989
> Yes, that is correct, but adding it to TopFieldCollector would mean that
it is a part of
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524335774
> Sorry I don't follow. The logic for early termination should be the same
in `TopFieldCollector` than the one
jimczi commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524333717
Sorry I don't follow. The logic for early termination should be the same in
`TopFieldCollector` than the one
magibney opened a new pull request #843: SOLR-13714: Correct refguide regarding
shardHandlerFactory solrconfig…
URL: https://github.com/apache/lucene-solr/pull/843
This is an automated message from the Apache Git Service.
atris commented on issue #823: LUCENE-8939: Introduce Shared Count Early
Termination In Parallel Search
URL: https://github.com/apache/lucene-solr/pull/823#issuecomment-524332090
@jimczi I did consider doing that, but went down this route to explicitly
decouple the early termination code
janhoy merged pull request #834: SOLR-13702: Some components register twice
their metric names
URL: https://github.com/apache/lucene-solr/pull/834
This is an automated message from the Apache Git Service.
To respond to the
KoenDG commented on issue #717: SOLR-13542: Code cleanup - Avoid using stream
filter count where possible
URL: https://github.com/apache/lucene-solr/pull/717#issuecomment-524281371
Woops, I forgot about this one.
I'll have a look at it later.
iverase commented on issue #832: LUCENE-8952: Use a sort key instead of true
distance in NearestNeighbor.
URL: https://github.com/apache/lucene-solr/pull/832#issuecomment-524241231
Thank you @jtibshirani!
This is an
iverase merged pull request #832: LUCENE-8952: Use a sort key instead of true
distance in NearestNeighbor.
URL: https://github.com/apache/lucene-solr/pull/832
This is an automated message from the Apache Git Service.
To
atris commented on issue #817: SOLR-13655:Upgrade Collections.unModifiableSet
to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#issuecomment-524185726
@tflobbe Thanks. I was slightly unsure about whether these sections actually
need an immutable copy of the
tflobbe commented on a change in pull request #817: SOLR-13655:Upgrade
Collections.unModifiableSet to Set.of and Set.copyOf
URL: https://github.com/apache/lucene-solr/pull/817#discussion_r316982695
##
File path: solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
401 - 500 of 3240 matches
Mail list logo
