atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of
Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513171204
> I think you forgot to remove `createElementNameSet`?
Oops, sorry. Updated
jpountz commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of
Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513166742
I think you forgot to remove `createElementNameSet`?
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of
Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513165474
@jpountz Thanks, updated the PR
This is an
jpountz commented on a change in pull request #796: LUCENE-8927: Set.copyOf and
Set.of instead of Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#discussion_r305266078
##
File path: lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
jpountz commented on a change in pull request #796: LUCENE-8927: Set.copyOf and
Set.of instead of Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#discussion_r305265986
##
File path:
jpountz commented on a change in pull request #796: LUCENE-8927: Set.copyOf and
Set.of instead of Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#discussion_r305266781
##
File path:
atris commented on issue #796: LUCENE-8927: Set.copyOf and Set.of instead of
Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796#issuecomment-513139699
cc @jpountz
This is an automated message from
atris opened a new pull request #796: LUCENE-8927: Set.copyOf and Set.of
instead of Collections.unmodifiabl…
URL: https://github.com/apache/lucene-solr/pull/796
This is an automated message from the Apache Git Service.
To
magibney commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r305150693
##
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
tflobbe commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r305147811
##
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
munendrasn commented on issue #538: LUCENE-8640: added changes for the
validation of valid dateString
URL: https://github.com/apache/lucene-solr/pull/538#issuecomment-512839513
Closing this as LUCENE-8640 is resolved
This is
munendrasn closed pull request #538: LUCENE-8640: added changes for the
validation of valid dateString
URL: https://github.com/apache/lucene-solr/pull/538
This is an automated message from the Apache Git Service.
To respond
cpoerschke commented on a change in pull request #300: SOLR-11831: Skip second
grouping step if group.limit is 1 (aka Las Vegas Patch)
URL: https://github.com/apache/lucene-solr/pull/300#discussion_r304929695
##
File path:
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With
Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512816491
@iverase I was hesitant to do that since MultiRangeQuery will take multiple
points as inputs, so if we were to build the
atris commented on issue #789: LUCENE-8915 : Improve Javadocs for RateLimiter
and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789#issuecomment-512808284
@sigram does this look commit right now, please? Happy to iterate further
romseygeek commented on issue #785: LUCENE-8918: Disallow null terms in
PhraseQuery
URL: https://github.com/apache/lucene-solr/pull/785#issuecomment-512798128
Merged
This is an automated message from the Apache Git Service.
romseygeek closed pull request #785: LUCENE-8918: Disallow null terms in
PhraseQuery
URL: https://github.com/apache/lucene-solr/pull/785
This is an automated message from the Apache Git Service.
To respond to the message,
romseygeek commented on issue #786: LUCENE-8916: GraphTokenStreamFiniteStrings
preserves all incoming attributes
URL: https://github.com/apache/lucene-solr/pull/786#issuecomment-512741272
I decided to try and keep the API changes minimal, so I've preserved the old
`getTerms()` method on
iverase commented on issue #794: LUCENE-8769: Introduce Range Query Type With
Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512740625
Ok, that is fine.
I think we should follow the structure hat we have for other queries, e.g.
Add in {X}Point
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With
Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512723236
> This approach is ok when the number of ranges is low but I wonder if it
would be worthy to order the ranges on an
nealsid opened a new pull request #795: SOLR-13643: Create accessors/setters in
ResponseBuilder with unit tests
URL: https://github.com/apache/lucene-solr/pull/795
Also migrate analytics rqeuest handling to use them.
# Description
Please provide a short
iverase commented on issue #794: LUCENE-8769: Introduce Range Query Type With
Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512699160
This approach is ok when the number of ranges is low but I wonder if it
would be worthy to order the ranges on an
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With
Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512674354
cc @jpountz @iverase
This is an automated message from
atris opened a new pull request #794: LUCENE-8769: Introduce Range Query Type
With Multiple Ranges
URL: https://github.com/apache/lucene-solr/pull/794
Currently, multiple ranges need to be specified in different
PointRangeQueries, thus leading to performance implications when
the BKD
atris closed pull request #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779
This is an automated message from the Apache Git Service.
To respond to the
MarcusSorealheis closed pull request #793: testing the PR template
URL: https://github.com/apache/lucene-solr/pull/793
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
MarcusSorealheis commented on issue #793: testing the PR template
URL: https://github.com/apache/lucene-solr/pull/793#issuecomment-512356262
https://user-images.githubusercontent.com/2353608/61393288-85be6c00-a875-11e9-9d1f-1e7b56ca63d8.png;>
MarcusSorealheis opened a new pull request #793: testing the PR template
URL: https://github.com/apache/lucene-solr/pull/793
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a
MarcusSorealheis commented on issue #793: testing the PR template
URL: https://github.com/apache/lucene-solr/pull/793#issuecomment-512355940
works
This is an automated message from the Apache Git Service.
To respond to
erikhatcher merged pull request #781: updated the pull request template to make
checkboxes work
URL: https://github.com/apache/lucene-solr/pull/781
This is an automated message from the Apache Git Service.
To respond to the
erikhatcher closed pull request #778: SOLR-10288 remove non minified js
URL: https://github.com/apache/lucene-solr/pull/778
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cbuescher opened a new pull request #792: Update Wordnet file format
description link
URL: https://github.com/apache/lucene-solr/pull/792
The link to the description of the Wordnet prolog database files seems
outdated.
This change replaces it with a working link.
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512228939
> I ran luceneutil on this patch on my machine too and I'm getting similar
results. It's a bit disappointing, I was expecting
iverase merged pull request #783: LUCENE-8914: Move compare logic to
IntersectVisitor in FloatPointNearestNeighbor
URL: https://github.com/apache/lucene-solr/pull/783
This is an automated message from the Apache Git
jpountz commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512227693
I ran luceneutil on this patch on my machine too and I'm getting similar
results. It's a bit disappointing, I was expecting
atris commented on issue #789: LUCENE-8915 : Improve Javadocs for RateLimiter
and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789#issuecomment-51469
@sigram Thanks, updated the same
This is an
sigram commented on a change in pull request #789: LUCENE-8915 : Improve
Javadocs for RateLimiter and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789#discussion_r304360145
##
File path: lucene/core/src/java/org/apache/lucene/store/RateLimiter.java
##
jpountz commented on a change in pull request #779: LUCENE-8762: Introduce
Specialized Impacts For Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#discussion_r304360904
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java
sigram commented on a change in pull request #789: LUCENE-8915 : Improve
Javadocs for RateLimiter and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789#discussion_r304356013
##
File path: lucene/core/src/java/org/apache/lucene/store/RateLimiter.java
##
sigram commented on a change in pull request #789: LUCENE-8915 : Improve
Javadocs for RateLimiter and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789#discussion_r304356220
##
File path: lucene/core/src/java/org/apache/lucene/store/RateLimiter.java
##
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512220733
luceneutil run:
https://gist.github.com/atris/1b2c25021ca11138338aa73efde2aa38
wikimedium2m
jpountz opened a new pull request #791: LUCENE-8922: Better impacts for
DisjunctionMaxQuery.
URL: https://github.com/apache/lucene-solr/pull/791
Note that we already have tests that cover impacts for DisjunctionMaxQuery.
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512198512
@jpountz Updated the PR with lazy loading. Please let me know if it looks
fine
thomaswoeckinger commented on issue #755: SOLR-13592: Introduce
EmbeddedSolrTestBase for better integration tests
URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-512197991
@gerlowskija Are you still working on this?
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-512198034
@gerlowskija Are you still working on this?
This is an automated message from the Apache
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal
Arguments
URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-512156642
@jpountz Updated the PR. With the current version, all tests for both Lucene
and Solo pass (yay!).
atris edited a comment on issue #769: LUCENE-8905: Better Error Handling For
Illegal Arguments
URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-512156642
@jpountz Updated the PR. With the current version, all tests for both Lucene
and Solr pass (yay!).
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-51216
Ah, yes, that makes sense. I did a couple of more runs with 10m docs and saw
similar results.
Will update the PR
jpountz commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512154379
I don't expect your last commit to help since impacts should always be
requested with frequencies. What I had in mind when
princemanohar opened a new pull request #790: SOLR-13640 : Fix page linking to
build project on IDE
URL: https://github.com/apache/lucene-solr/pull/790
# Description
Please provide a short description of the changes you're making with this
pull request.
#
munendrasn commented on a change in pull request #597: [SOLR-13272]
feat(facet/interval): support json facet requests for interval facet
URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303986476
##
File path:
munendrasn commented on a change in pull request #597: [SOLR-13272]
feat(facet/interval): support json facet requests for interval facet
URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303988029
##
File path:
munendrasn commented on a change in pull request #597: [SOLR-13272]
feat(facet/interval): support json facet requests for interval facet
URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303986989
##
File path:
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511874550
@jpountz Three Luceneutil runs with wikimedium2m:
https://gist.github.com/atris/5057e3372b287873a4e840c5f4e65a0d
munendrasn commented on a change in pull request #597: [SOLR-13272]
feat(facet/interval): support json facet requests for interval facet
URL: https://github.com/apache/lucene-solr/pull/597#discussion_r303986476
##
File path:
atris commented on issue #769: LUCENE-8905: Better Error Handling For Illegal
Arguments
URL: https://github.com/apache/lucene-solr/pull/769#issuecomment-511831246
> @atris I think the check you introduced always fails a query when there
are no hits?
@jpountz Thanks for highlighting
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303909793
##
File path:
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303910866
##
File path:
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303909793
##
File path:
magibney commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r303906601
##
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511813095
@jpountz I have fixed your comments, please let me know if they look fine.
luceneutil is running right now with 10k
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303890649
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303891904
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303891477
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303893047
##
File path: solr/solr-ref-guide/src/the-query-elevation-component.adoc
##
jpountz commented on a change in pull request #769: LUCENE-8905: Better Error
Handling For Illegal Arguments
URL: https://github.com/apache/lucene-solr/pull/769#discussion_r303890610
##
File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java
##
@@
jpountz commented on a change in pull request #779: LUCENE-8762: Introduce
Specialized Impacts For Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#discussion_r303852373
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java
jpountz commented on a change in pull request #779: LUCENE-8762: Introduce
Specialized Impacts For Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#discussion_r303851882
##
File path:
lucene/core/src/java/org/apache/lucene/codecs/lucene50/Lucene50PostingsReader.java
jpountz commented on a change in pull request #786: LUCENE-8916:
GraphTokenStreamFiniteStrings preserves all incoming attributes
URL: https://github.com/apache/lucene-solr/pull/786#discussion_r303849314
##
File path:
jpountz commented on a change in pull request #786: LUCENE-8916:
GraphTokenStreamFiniteStrings preserves all incoming attributes
URL: https://github.com/apache/lucene-solr/pull/786#discussion_r303849314
##
File path:
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303824411
##
File path:
romseygeek commented on a change in pull request #786: LUCENE-8916:
GraphTokenStreamFiniteStrings preserves all incoming attributes
URL: https://github.com/apache/lucene-solr/pull/786#discussion_r303822204
##
File path:
jpountz commented on a change in pull request #786: LUCENE-8916:
GraphTokenStreamFiniteStrings preserves all incoming attributes
URL: https://github.com/apache/lucene-solr/pull/786#discussion_r303816286
##
File path:
jpountz commented on issue #788: LUCENE-8920: disable FST direct-addressing
pending size reduction
URL: https://github.com/apache/lucene-solr/pull/788#issuecomment-511739179
You might need to move CHANGES entries as well?
mocobeta merged pull request #782: LUCENE-8911: Backport LUCENE-8778 (improved
analysis SPI name handling) to 8.x
URL: https://github.com/apache/lucene-solr/pull/782
This is an automated message from the Apache Git Service.
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303794163
##
File path:
atris opened a new pull request #789: LUCENE-8915 : Improve Javadocs for
RateLimiter and SimpleRateLimiter
URL: https://github.com/apache/lucene-solr/pull/789
This is an automated message from the Apache Git Service.
To
bruno-roustant commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303786550
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303657585
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303721826
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303720194
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303722666
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303724939
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303658212
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303721929
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303611139
##
File path:
dsmiley commented on a change in pull request #780: SOLR-11866: Support
efficient subset matching in query elevation rules
URL: https://github.com/apache/lucene-solr/pull/780#discussion_r303651927
##
File path:
tflobbe commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r303695087
##
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
tflobbe commented on a change in pull request #677: SOLR-13257: support for
stable replica routing preferences
URL: https://github.com/apache/lucene-solr/pull/677#discussion_r303693271
##
File path:
solr/core/src/java/org/apache/solr/handler/component/HttpShardHandlerFactory.java
chatman closed pull request #773: SOLR-13619: Kerberos 403 when node doesn't
host collection
URL: https://github.com/apache/lucene-solr/pull/773
This is an automated message from the Apache Git Service.
To respond to the
magibney commented on issue #772: Payload-stored position length intervals
URL: https://github.com/apache/lucene-solr/pull/772#issuecomment-511527663
Agreed, @romseygeek; just to clarify, re-ordering may _raise_ the problem,
but doesn't _introduce_ it. This is indeed a variant of the issue
msokolov opened a new pull request #788: LUCENE-8920: disable FST
direct-addressing pending size reduction
URL: https://github.com/apache/lucene-solr/pull/788
Minimal change to disable FST direct addressing
This is an
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For
Doc + Freq
URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511408229
Any thoughts on this one? I am hoping this will bring gains to our nightly
benchmarks :)
atris commented on issue #787: LUCENE-8810: Honor MaxClausesCount in
BooleanQuery
URL: https://github.com/apache/lucene-solr/pull/787#issuecomment-511405603
Thanks for merging @jpountz !
This is an automated message from the
jpountz merged pull request #787: LUCENE-8810: Honor MaxClausesCount in
BooleanQuery
URL: https://github.com/apache/lucene-solr/pull/787
This is an automated message from the Apache Git Service.
To respond to the message,
atris commented on issue #784: LUCENE-8810: Honor MaxClausesCount in
BooleanQuery During Flattening
URL: https://github.com/apache/lucene-solr/pull/784#issuecomment-511400026
@jpountz Thanks for your comments. I have opened #787 which fixes your
comments and is against 8x
atris closed pull request #784: LUCENE-8810: Honor MaxClausesCount in
BooleanQuery During Flattening
URL: https://github.com/apache/lucene-solr/pull/784
This is an automated message from the Apache Git Service.
To respond
atris opened a new pull request #787: LUCENE-8810: Honor MaxClausesCount in
BooleanQuery
URL: https://github.com/apache/lucene-solr/pull/787
During Flattening, BooleanQuery will always try to flatten
nested clauses during rewrite. However, this can cause the
maximum number of clauses
thomaswoeckinger commented on issue #665: Fixes SOLR-13539
URL: https://github.com/apache/lucene-solr/pull/665#issuecomment-511391449
Still nothing?
This is an automated message from the Apache Git Service.
To respond to the
thomaswoeckinger commented on issue #755: SOLR-13592: Introduce
EmbeddedSolrTestBase for better integration tests
URL: https://github.com/apache/lucene-solr/pull/755#issuecomment-511391348
Still nothing?
This is an automated
801 - 900 of 3240 matches
Mail list logo
