[
https://issues.apache.org/jira/browse/LUCENE-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131561#comment-14131561
]
Shai Erera commented on LUCENE-5941:
I added {{dir.setEnableVirusScanner(false
[
https://issues.apache.org/jira/browse/LUCENE-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14131561#comment-14131561
]
Shai Erera edited comment on LUCENE-5941 at 9/12/14 2:04 PM
[
https://issues.apache.org/jira/browse/LUCENE-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14132554#comment-14132554
]
Shai Erera commented on LUCENE-5941:
bq. Well i think its related to windows
I dug some more into this, and e.g. compared how does PhraseQuery behave on
these cases ('a' and 'b' are indexed at the same position):
a b - NO MATCH (expected)
a b~1+ (1+ - any slop = 1) - MATCH
Because of the mathematics behind PQ, the slop determines the edit distance
to match 'a' and 'b'.
[
https://issues.apache.org/jira/browse/LUCENE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14129786#comment-14129786
]
Shai Erera commented on LUCENE-5933:
Spans is not plural, it's the name of the class
[
https://issues.apache.org/jira/browse/LUCENE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5933.
Resolution: Fixed
Fix Version/s: 5.0
4.11
Committed to trunk and 4x
Shai Erera created LUCENE-5941:
--
Summary: IndexWriter.forceMerge documentation error
Key: LUCENE-5941
URL: https://issues.apache.org/jira/browse/LUCENE-5941
Project: Lucene - Core
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14130293#comment-14130293
]
Shai Erera commented on LUCENE-5941:
Correction about the largest merge. That's true
Shai Erera created LUCENE-5933:
--
Summary: Add FilterSpans to allow easily wrapping a Spans impl
Key: LUCENE-5933
URL: https://issues.apache.org/jira/browse/LUCENE-5933
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5933:
---
Attachment: LUCNE-5933.patch
Trivial patch. I couldn't decide between FilterSpans and SpansWrapper
[
https://issues.apache.org/jira/browse/LUCENE-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122990#comment-14122990
]
Shai Erera commented on LUCENE-5925:
What would be the fallback logic in case
[
https://issues.apache.org/jira/browse/LUCENE-5925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123001#comment-14123001
]
Shai Erera commented on LUCENE-5925:
bq. You would get an exception. So it needs
Hi
I am playing with searching over annotated text - that is some stream of
text is indexed under one field, and I have annotations indexed under
another field. The annotations are indexed with custom positions that I
inject, based on the original position of the text.
So for example I might
Thanks Hoss, this is very useful information, especially
FieldMaskingSpanQuery :).
So according to those issues, it seems others also think that end1 = end2
is also a correct behavior of SNQ (in case ordered=true, and
start1==start2). Was there a reason these issues were not resolved (e.g.
[
https://issues.apache.org/jira/browse/LUCENE-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14105671#comment-14105671
]
Shai Erera commented on LUCENE-5672:
+1. Now that we can set the MP dynamically
I don't understand something -- you add a ReaderClosedListener to get a
notification when IR.close() is called (actually, when it's actually being
closed). Why removing the listener after the reader has been closed? Don't
apps usually nullify their IR member after it's been closed?
Shai
On Wed,
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
*From:* Shai Erera [mailto:ser...@gmail.com]
*Sent:* Wednesday, August 20, 2014 5:10 PM
*To:* dev@lucene.apache.org
*Subject:* Re: IndexReader.removeReaderClosedListener
I
Hmm, I think we have the same problem with MergeScheduler. It is no longer
wired to an IW instance, yet IW calls ms.close() when it's closed. This is
wrong ... maybe we should add ref-counting to MergeScheduler?
Shai
On Thu, Aug 14, 2014 at 8:38 AM, Shai Erera ser...@gmail.com wrote:
OK I
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096780#comment-14096780
]
Shai Erera commented on LUCENE-5883:
If it wasn't clear, I think this is ready
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096796#comment-14096796
]
Shai Erera commented on LUCENE-5883:
Indeed. With this patch it would mean to pass
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5883.
Resolution: Fixed
Fix Version/s: 4.10
5.0
Committed to trunk and 4x
[
https://issues.apache.org/jira/browse/LUCENE-5526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096888#comment-14096888
]
Shai Erera commented on LUCENE-5526:
On LUCENE-5883 I moved MergePolicy
Shai Erera created LUCENE-5885:
--
Summary: MergeScheduler should not implement Closeable
Key: LUCENE-5885
URL: https://issues.apache.org/jira/browse/LUCENE-5885
Project: Lucene - Core
Issue Type
[
https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096931#comment-14096931
]
Shai Erera commented on LUCENE-5885:
Oh, that simplifies things a lot. I started
[
https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096936#comment-14096936
]
Shai Erera commented on LUCENE-5885:
I had a chat w/ Mike about this - we think
[
https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5885:
---
Attachment: LUCENE-5885.patch
Patch removes CMS.sync() and Closeable from MergeScheduler. Note
[
https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14097149#comment-14097149
]
Shai Erera commented on LUCENE-5885:
I ran tests after the fix on LUCENE-5871, but I
[
https://issues.apache.org/jira/browse/LUCENE-5885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5885:
---
Attachment: LUCENE-5885.patch
Patch fixes the bug - finishMerges(false) is more robust now
, 2014 at 9:00 AM, Shai Erera ser...@gmail.com wrote:
Hi
While working on LUCENE-5883, I noticed that IndexWriter calls
mergePolicy.close(). But since LUCENE-5711, where we no longer wire an
MP to
a single IndexWriter instance, I don't think IW should call MP.close(),
e.g.
in case
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5883:
---
Attachment: LUCENE-5883.patch
Thanks Mike, I improved the jdocs. This patch also removes Closeable
, Shai Erera ser...@gmail.com wrote:
OK I will remove it under LUCENE-5883.
And I like the idea of adding ref-counting semantics, but we should do it
separately and only when there's a real reason too. Then, we can make
sure
IW inc/decRef appropriately.
Shai
On Thu, Aug 14, 2014
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14096603#comment-14096603
]
Shai Erera commented on LUCENE-5883:
BTW, the way I implemented it is that top-level
Shai Erera created LUCENE-5883:
--
Summary: Move MergePolicy to LiveIndexWriterConfig
Key: LUCENE-5883
URL: https://issues.apache.org/jira/browse/LUCENE-5883
Project: Lucene - Core
Issue Type
Hi
While working on LUCENE-5883, I noticed that IndexWriter calls
mergePolicy.close(). But since LUCENE-5711, where we no longer wire an MP
to a single IndexWriter instance, I don't think IW should call MP.close(),
e.g. in case the app shares this MP across several IWs?
But then, in the common
[
https://issues.apache.org/jira/browse/LUCENE-5883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5883:
---
Attachment: LUCENE-5883.patch
Patch moves MergePolicy to LiveIndexWriterConfig. Note though
OK, I agree I didn't have XML APIs in mind when I wrote that. So if we
change that API such that users *must* migrate (because e.g. we add a new
mandatory parameter), then that's fine not to keep old code. But if users'
apps silently use other settings just because they didn't upgrade their XML
Thanks Hoss for the detailed reply!
About useCompoundFile, I understand the simplification this brings to
regular users, but I also think we should protect such users from making
silly mistakes, ONLY because they don't have deep understanding of the
underlying stuff. Packing 20GB segments in a
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14088894#comment-14088894
]
Shai Erera commented on SOLR-6315:
--
{quote}
One option for the stated purpose
[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087307#comment-14087307
]
Shai Erera commented on SOLR-912:
-
Hi Shawn. See SOLR-6315 which I opened to do exactly
[
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087317#comment-14087317
]
Shai Erera commented on LUCENE-5871:
I don't think this patch is correct. IndexWriter
[
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087778#comment-14087778
]
Shai Erera commented on LUCENE-5871:
We could change the semantics, but I pointed out
[
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14087780#comment-14087780
]
Shai Erera commented on LUCENE-5871:
I guess what I'm trying to say is, if we make
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086079#comment-14086079
]
Shai Erera commented on LUCENE-5859:
I think we can apply the same approach here
[
https://issues.apache.org/jira/browse/LUCENE-5871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14086435#comment-14086435
]
Shai Erera commented on LUCENE-5871:
Version is currently used to decide whether
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084374#comment-14084374
]
Shai Erera commented on SOLR-6315:
--
OK, so I think if the jdocs said exactly (and only
returning an instance, the instances wouldn't be modifiable.
My 2 cents. :)
Steve
--
*From:* Shai Erera [ser...@gmail.com]
*Sent:* August 3, 2014 8:51 AM
*To:* dev@lucene.apache.org
*Subject:* Re: Lucene versioning logic
OK I see, it's the Tokenizers and Filters
[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884
]
Shai Erera commented on SOLR-912:
-
Resurrecting that issue, I reviewed NamedList and I don't
[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884
]
Shai Erera edited comment on SOLR-912 at 8/3/14 6:21 AM
[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083884#comment-14083884
]
Shai Erera edited comment on SOLR-912 at 8/3/14 6:22 AM
[
https://issues.apache.org/jira/browse/SOLR-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083888#comment-14083888
]
Shai Erera commented on SOLR-912:
-
One other thing, how important is it to be able to store
Shai Erera created SOLR-6315:
Summary: Remove SimpleOrderedMap
Key: SOLR-6315
URL: https://issues.apache.org/jira/browse/SOLR-6315
Project: Solr
Issue Type: Improvement
Components
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated SOLR-6315:
-
Attachment: SOLR-6315.patch
Simple patch. It's huge because it's a rote search-and-replace, but nothing
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083936#comment-14083936
]
Shai Erera edited comment on SOLR-6315 at 8/3/14 10:34 AM
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083954#comment-14083954
]
Shai Erera commented on SOLR-6315:
--
I thought about it, I think it's odd that whoever
Version.java.
Shai
On Sun, Aug 3, 2014 at 2:43 PM, Robert Muir rcm...@gmail.com wrote:
On Sat, Aug 2, 2014 at 12:41 PM, Shai Erera ser...@gmail.com wrote:
Another proposal that I made on LUCENE-5859 is to get rid of Version (for
Analyzers) and follow the solution we have with Codecs
that you want.
Shai
On Sun, Aug 3, 2014 at 3:02 PM, Robert Muir rcm...@gmail.com wrote:
You don't read what i wrote.
Read it again.
On Sun, Aug 3, 2014 at 7:49 AM, Shai Erera ser...@gmail.com wrote:
Yes, I agree that Foo49Analyzer is an odd name. Better if it was named
proposal, so please look for more elaboration there.
I am -1 to putting Versions in the name of Analyzers.
On Sun, Aug 3, 2014 at 8:21 AM, Shai Erera ser...@gmail.com wrote:
Oh, I misread this part I do think its ok to name ... -- replaced do
with don't :).
So you say that if we have
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083970#comment-14083970
]
Shai Erera commented on SOLR-6315:
--
First, this class is entirely bogus the way I see
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084077#comment-14084077
]
Shai Erera commented on SOLR-6315:
--
[~yo...@apache.org], please excuse me if I used
[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084111#comment-14084111
]
Shai Erera commented on SOLR-6315:
--
Thanks Yonik for explaining this. I realized as I
Another proposal that I made on LUCENE-5859 is to get rid of Version (for
Analyzers) and follow the solution we have with Codecs. If an Analyzer
changes its runtime behavior, and e.g not marked @experimental, it can
create a Foo49Analyzer with the new behavior. That way, apps are still safe
when
[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14083636#comment-14083636
]
Shai Erera commented on LUCENE-5850:
Thanks Uwe for adding the docs, they are crystal
...@fucit.org
wrote:
: OK thanks. I subscribed with the user 'shaie' (name: Shai Erera).
I've added your edit permissions.
: I will fix trivial typos and wording stuff directly there, and if
there's a
: bigger change I'll open JIRA issues.
For edits to existing pages, feel free to make them
Hi
I reviewed the index configuration section in the ref guide and then
SolrIndexConfig and I'm not sure if that's intentional, or again a relic
from older days when configuration was simpler. But I think that the
parameter useCompoundFiles needs some clarification:
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080762#comment-14080762
]
Shai Erera commented on LUCENE-5859:
I don't think that we need to add any get
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080799#comment-14080799
]
Shai Erera commented on LUCENE-5859:
You don't build an index for a specific version
Welcome Tomas!
On Jul 31, 2014 7:55 PM, Shawn Heisey s...@elyograg.org wrote:
On 7/31/2014 9:50 AM, Yonik Seeley wrote:
I'm pleased to announce that Tomás has accepted the PMC's invitation
to become a Lucene/Solr committer.
Congrats and welcome!
[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14081294#comment-14081294
]
Shai Erera commented on LUCENE-5850:
Thanks for fixing this bug Rob ... sorry
I agree with the general statement that users may want to set such settings
without caring much about the actual MergePolicy that's used. But then I
think that we currently don't do a very good job to allow that:
- I think mergeFactor is less clear than segmentsPerTier, as a parameter
name
OK thanks. I subscribed with the user 'shaie' (name: Shai Erera).
I will fix trivial typos and wording stuff directly there, and if there's a
bigger change I'll open JIRA issues.
Shai
On Tue, Jul 29, 2014 at 6:34 PM, Steve Rowe sar...@gmail.com wrote:
On Jul 29, 2014, at 10:45 AM, Steve
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079237#comment-14079237
]
Shai Erera commented on LUCENE-5859:
What about the proposal that at some point
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079265#comment-14079265
]
Shai Erera commented on LUCENE-5859:
The thing that worries me is that if you upgrade
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14079282#comment-14079282
]
Shai Erera commented on LUCENE-5859:
bq. I tried to be reasonable here and open
[
https://issues.apache.org/jira/browse/LUCENE-5859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14080517#comment-14080517
]
Shai Erera commented on LUCENE-5859:
The way I see it, Rob's commit is exactly what
[
https://issues.apache.org/jira/browse/LUCENE-5852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5852.
Resolution: Fixed
Fix Version/s: 4.10
5.0
Assignee: Shai Erera
Hi
I was reading some sections in the Solr ref guide and found few typos,
errors etc. How can I edit it? Do I need a user/pass for the confluence
website? I tried to login w/ my ASF credentials but it says my username is
not recognized.
Is it better to handle all these through JIRA. And if so,
Hi
While reading the IndexConfig section in the Solr ref guide, I noticed that
mergeFactor is exposed as its own mergeFactor element, and not a merge
policy parameter, e.g. int name=mergeFactor10/int. I think that's
wrong because:
1) The merge factor only applies to our existing merge policies.
don't even have to wonder why they see these messages in the log.
Shai
On Tue, Jul 29, 2014 at 1:41 PM, Shai Erera ser...@gmail.com wrote:
Hi
While reading the IndexConfig section in the Solr ref guide, I noticed
that mergeFactor is exposed as its own mergeFactor element, and not a
merge
[
https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074546#comment-14074546
]
Shai Erera commented on LUCENE-5843:
{quote}
I added public static final int
[
https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074554#comment-14074554
]
Shai Erera commented on LUCENE-5843:
Yes, I think we shouldn't try to be too smart
[
https://issues.apache.org/jira/browse/LUCENE-5843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14074575#comment-14074575
]
Shai Erera commented on LUCENE-5843:
oh good, I didn't read the patch before, but I
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14068279#comment-14068279
]
Shai Erera commented on LUCENE-5801:
Committed the fix.
Resurrect
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5801:
---
Attachment: LUCENE-5801.patch
Patch fixes the problem. We need to take the source FacetsConfig
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067905#comment-14067905
]
Shai Erera commented on LUCENE-5801:
Committed this fix. Please report if you still
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14067946#comment-14067946
]
Shai Erera commented on LUCENE-5801:
Actually, this isn't the correct fix. I modified
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5801:
---
Attachment: LUCENE-5801.patch
Patch fixes the problem, but I still want to review the test, make
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera reassigned LUCENE-5801:
--
Assignee: Shai Erera
Resurrect org.apache.lucene.facet.util.OrdinalMappingAtomicReader
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-5801:
---
Attachment: LUCENE-5801.patch
Thanks Nicola. I updated the patch with a CHANGES entry. Also, I
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera resolved LUCENE-5801.
Resolution: Fixed
Fix Version/s: 4.10
5.0
Lucene Fields: New,Patch
It reproduces ... something's fishy with IW.changeCount -- seems that after
you open an IW on an existing Directory, changeCount = 0. I will try to
reproduce this in a standalone test to verify if it's a general IW bug or
not.
Shai
On Thu, Jul 3, 2014 at 2:54 PM, Policeman Jenkins Server
I'll handle - will make it an abstract class.
Shai
On Thu, Jul 3, 2014 at 7:01 PM, Policeman Jenkins Server
jenk...@thetaphi.de wrote:
Build: http://jenkins.thetaphi.de/job/Lucene-Solr-4.x-Linux/10593/
Java: 64bit/jdk1.7.0_60 -XX:+UseCompressedOops -XX:+UseSerialGC
All tests passed
that randomForceMerge, the test passes.
I will review it again later and commit, perhaps someone can take a second
look.
Shai
On Thu, Jul 3, 2014 at 6:50 PM, Shai Erera sh...@apache.org wrote:
It reproduces ... something's fishy with IW.changeCount -- seems that
after you open an IW on an existing
Committed a fix.
On Thu, Jul 3, 2014 at 7:56 PM, Michael McCandless
luc...@mikemccandless.com wrote:
+1 to add the commit in RIW if it does an operation like forceMerge in
close.
Mike McCandless
http://blog.mikemccandless.com
On Thu, Jul 3, 2014 at 12:23 PM, Shai Erera sh
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049928#comment-14049928
]
Shai Erera commented on LUCENE-5801:
I will review the patch later, but a static
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049928#comment-14049928
]
Shai Erera edited comment on LUCENE-5801 at 7/2/14 1:54 PM:
I
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14049952#comment-14049952
]
Shai Erera commented on LUCENE-5801:
FacetsConfig.dedupAndEncode is the encode
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14050529#comment-14050529
]
Shai Erera commented on LUCENE-5801:
Hmm, I thought about it, maybe we don't need
This is definitely a mistake - this class should not have been removed in
the recent API changes, as the Taxonomy API (and concept) hasn't changed. I
guess if it was under the o.a.l.facet.taxonomy package, it would stay.
Would you mind opening an issue? If you also want to try and resurrect it,
[
https://issues.apache.org/jira/browse/LUCENE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shai Erera updated LUCENE-4258:
---
Fix Version/s: (was: 4.9)
(was: 5.0)
Incremental Field Updates through
[
https://issues.apache.org/jira/browse/LUCENE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14048831#comment-14048831
]
Shai Erera commented on LUCENE-5801:
Thanks for opening this, we definitely need
501 - 600 of 4461 matches
Mail list logo
