Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-19 Thread Adrien Grand
It's taking some time because the first build of RC2 found a test failure in TestWandScorer that looks like a real bug. I'm digging it. On Thu, Dec 19, 2019 at 8:52 AM Ignacio Vera wrote: > I have spoken to Adrien offline and I have included LUCENE-90555 which > includes a fix where shape line q

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Ignacio Vera
I have spoken to Adrien offline and I have included LUCENE-90555 which includes a fix where shape line queries would fail detecting crossing through edge points. Thanks Adrien. On Thu, Dec 19, 2019 at 6:24 AM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > Since there was a re-spin, I

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Ishan Chattopadhyaya
Since there was a re-spin, I added SOLR-14108 to the release branch. It is a very minor fix (null check), but solves an important annoyance that Erik Hatcher reported while trying to use the package manager. On Thu, Dec 19, 2019 at 3:31 AM Noble Paul wrote: > > I'v ported the commit > https://git

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
I'v ported the commit https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=221d4ed On Thu, Dec 19, 2019 at 8:59 AM Noble Paul wrote: > > Thanks Adrien. > My apologies for the inconvenience . > > --Noble > > On Thu, Dec 19, 2019 at 8:04 AM Adrien Grand wrote: > > > > Thanks Cassandra for findi

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
Thanks Adrien. My apologies for the inconvenience . --Noble On Thu, Dec 19, 2019 at 8:04 AM Adrien Grand wrote: > > Thanks Cassandra for finding this missing commit. I'll start a new RC > tomorrow morning EU time. > > On Wed, Dec 18, 2019 at 9:21 PM Alexandre Rafalovitch > wrote: >> >> If the

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Adrien Grand
Thanks Cassandra for finding this missing commit. I'll start a new RC tomorrow morning EU time. On Wed, Dec 18, 2019 at 9:21 PM Alexandre Rafalovitch wrote: > If there is a respin, maybe the Changenotes (for Solr) can be fixed too: > 1) First entry under Upgrade Notes is missing JIRA and probabl

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Alexandre Rafalovitch
If there is a respin, maybe the Changenotes (for Solr) can be fixed too: 1) First entry under Upgrade Notes is missing JIRA and probably does not need to include the full class path 2) Optimization section can probably be skipped as it just has "no changes" entry 3) Couple of JIRAs are missing cont

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Noble Paul
I'm so sorry to come at this moment and tell you that one of the critical bug fixes I made to master was not ported to 8x and 8.4. This breaks a critical functionality of package loading feature. Is it possible to do a respin? https://github.com/apache/lucene-solr/commit/f98555854cbdb9d396c34a93fd

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Adrien Grand
Hi Gus, If the test is flaky, would you mind annotating it with "@BadApple"? It will make sure this test doesn't get in the way of building or voting on a release until the test is fixed. On Wed, Dec 18, 2019 at 3:52 PM Gus Heck wrote: > Hi Mkhail, This is a known flakey test (mine, it's on my

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Cassandra Targett
A little late for some votes, but the Draft version of the 8.4 Solr Ref Guide is up now: https://lucene.apache.org/solr/guide/8_4/ (I need to get on automating it soon.) On Dec 18, 2019, 8:52 AM -0600, Gus Heck , wrote: > Hi Mkhail, This is a known flakey test (mine, it's on my to do list). Seems

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Atri Sharma
+1 SUCCESS! [1:26:38.49393] On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b207018

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Gus Heck
Hi Mkhail, This is a known flakey test (mine, it's on my to do list). Seems to have got slightly more flakey recently possibly because other tests have got better at using up CPU?. The flake here is that the code in the test didn't manage to wait long enough before running the assertion. This failu

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Tommaso Teofili
+1 SUCCESS! [1:33:40.587556] On Wed, 18 Dec 2019 at 11:37, Shalin Shekhar Mangar wrote: > +1 > > SUCCESS! [0:50:00.981792] > > On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > >> Please vote for release candidate 1 for Lucene/Solr 8.4.0 >> >> The artifacts can be downloaded from: >> >>

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Shalin Shekhar Mangar
+1 SUCCESS! [0:50:00.981792] On Tue, Dec 17, 2019 at 11:53 PM Adrien Grand wrote: > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: > > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b20701

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Munendra S N
+1 SUCCESS! [1:30:13.695296] On Wed, Dec 18, 2019 at 2:01 PM Andrzej Białecki wrote: > +1 > > SUCCESS! [1:34:39.788377] > > On 17 Dec 2019, at 21:13, Anshum Gupta wrote: > > +1 > > SUCCESS! [1:21:44.176149] > > On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand wrote: > >> Please vote for releas

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-18 Thread Andrzej Białecki
+1 SUCCESS! [1:34:39.788377] > On 17 Dec 2019, at 21:13, Anshum Gupta wrote: > > +1 > > SUCCESS! [1:21:44.176149] > > On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand > wrote: > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloa

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-17 Thread Ignacio Vera
+1 SUCCESS! [1:23:10.623120] On Wed, Dec 18, 2019 at 7:06 AM Mikhail Khludnev wrote: > I've got > > 2> NOTE: reproduce with: ant test > -Dtestcase=DimensionalRoutedAliasUpdateProcessorTest > -Dtests.method=testTimeCat -Dtests.seed=D05700662AF3B95B > -Dtests.locale=en-GB -Dtests.timezone=Aus

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-17 Thread Mikhail Khludnev
I've got 2> NOTE: reproduce with: ant test -Dtestcase=DimensionalRoutedAliasUpdateProcessorTest -Dtests.method=testTimeCat -Dtests.seed=D05700662AF3B95B -Dtests.locale=en-GB -Dtests.timezone=Australia/North -Dt ests.asserts=true -Dtests.file.encoding=ISO-8859-1 [00:42:59.083] FAILURE 29.4s J1

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-17 Thread Nhat Nguyen
+1 SUCCESS! [0:58:08.302838] On Tue, Dec 17, 2019 at 3:14 PM Anshum Gupta wrote: > +1 > > SUCCESS! [1:21:44.176149] > > On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand wrote: > >> Please vote for release candidate 1 for Lucene/Solr 8.4.0 >> >> The artifacts can be downloaded from: >> >> https://d

Re: [VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-17 Thread Anshum Gupta
+1 SUCCESS! [1:21:44.176149] On Tue, Dec 17, 2019 at 10:23 AM Adrien Grand wrote: > Please vote for release candidate 1 for Lucene/Solr 8.4.0 > > The artifacts can be downloaded from: > > https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b20701

[VOTE] Release Lucene/Solr 8.4.0 RC1

2019-12-17 Thread Adrien Grand
Please vote for release candidate 1 for Lucene/Solr 8.4.0 The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-8.4.0-RC1-revc91d36f50efb62e55bcc3a1adc0442b207018670 You can run the smoke tester directly with this command: python3 -u dev-tools/scripts/sm