Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-30 Thread Greg Miller
-> >> >> org.apache.lucene.analysis.phonetic >> >> lucene-analysis-smartcn-10.0.0-SNAPSHOT.jar -> >> >> org.apache.lucene.analysis.smartcn >> >> lucene-analysis-stempel-10.0.0-SNAPSHOT.jar-> >> >> org.apache.lucene.an

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-30 Thread Adrien Grand
larized). In later Lucene > 9.x versions we will add full module support and only expose APIs for > external consumption and hide all internal lucene packages. > >> > >> The 9.0 relese should make sure that the module names are at least > "defined", so we can use them la

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-30 Thread Greg Miller
Lucene 9.x >> versions we will add full module support and only expose APIs for external >> consumption and hide all internal lucene packages. >> >> The 9.0 relese should make sure that the module names are at least >> "defined", so we can use

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Adrien Grand
de all internal lucene packages. > > The 9.0 relese should make sure that the module names are at least > "defined", so we can use them later in module-info.java, > > Should I send a vote thread about this to the mailing list separately? > > Uwe > > - > Uwe Schi

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Uwe Schindler
dler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -----Original Message----- > From: Dawid Weiss > Sent: Monday, November 29, 2021 7:36 PM > To: Lucene Dev > Subject: Re: [VOTE] Release Lucene 9.0.0 RC3 > > Here is the change add

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Uwe Schindler
> > In every build.gradle file define the module name explicit using an ext > property for the "Automatic Module Name" JAR manifest, don't use regex > replace on the filesystem path of the gradle build. > > I disagree with you - convention over configuration. If you derive the > module name from

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Dawid Weiss
Here is the change adding the 'org.apache.*' prefix, Uwe: https://github.com/apache/lucene/pull/487 I verified that Luke starts in the rebuilt distribution and that module names show org.apache.* prefixes. Dashes are not allowed in modules so Lucene artifacts using them (spatial-extras,

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Dawid Weiss
Dear Uwe, > I did not notice this because it was somehow hidden. It was not hidden, Uwe. It was right there in the issue that introduced it, along with a comment that it was a deliberate decision (mine). > In every build.gradle file define the module name explicit using an ext > property for

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Uwe Schindler
hterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Adrien Grand > Sent: Friday, November 26, 2021 3:31 PM > To: Lucene Dev > Subject: [VOTE] Release Lucene 9.0.0 RC3 > > Please vote for release can

[RESULT][VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Adrien Grand
nauthorized artifacts created >> accidentally). If somebody wants to release a custom Lucene with patches, >> one can pass -Dversion.suffix="Ubuntu20.04-foobar" to make a customized >> release. >> >> >> >> Uwe >> >> >> >> -

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Gus Heck
; >> Achterdiek 19, D-28357 Bremen > >> https://www.thetaphi.de > >> eMail: u...@thetaphi.de > >> > >> > -Original Message- > >> > From: Dawid Weiss > >> > Sent: Monday, November 29, 2021 1:33 PM > >> > To:

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Dawid Weiss
tomized >> release. >> >> Uwe >> >> - >> Uwe Schindler >> Achterdiek 19, D-28357 Bremen >> https://www.thetaphi.de >> eMail: u...@thetaphi.de >> >> > -Original Message- >> > From: Dawid Weiss >> > S

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Gus Heck
w.thetaphi.de > eMail: u...@thetaphi.de > > > -Original Message- > > From: Dawid Weiss > > Sent: Monday, November 29, 2021 1:33 PM > > To: Lucene Dev > > Subject: Re: [VOTE] Release Lucene 9.0.0 RC3 > > > > I don't think it's a showstopper. This a

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Uwe Schindler
thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Dawid Weiss > Sent: Monday, November 29, 2021 1:33 PM > To: Lucene Dev > Subject: Re: [VOTE] Release Lucene 9.0.0 RC3 > > I don't think it's a showstopper. This applies to any 9x branch - > perhaps starting fro

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Dawid Weiss
I don't think it's a showstopper. This applies to any 9x branch - perhaps starting from main. We can extract these instructions into a separate document. On the other hand, it wouldn't be shown up there on github front-page then... and times have changed - this is where most folks would probably

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Gus Heck
Seems to me the details for how to turn a src tarball into something that can be compiled should go in a BUILDING.txt file? On Mon, Nov 29, 2021 at 3:00 AM Dawid Weiss wrote: > SUCCESS! [0:17:23.949074] > > +1. > > D. > > On Fri, Nov 26, 2021 at 3:31 PM Adrien Grand wrote: > > > > Please vote

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-29 Thread Dawid Weiss
SUCCESS! [0:17:23.949074] +1. D. On Fri, Nov 26, 2021 at 3:31 PM Adrien Grand wrote: > > Please vote for release candidate 3 for Lucene 9.0.0. > > The artifacts can be downloaded from: > https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC3-rev-1ddce848cf3d5067efcafc6569d5f8203e56af0b

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Atri Sharma
+1 SUCCESS! [0:22:43.58483] On Sat, Nov 27, 2021 at 8:30 PM Robert Muir wrote: > > +1 > > (with --test-java17) > SUCCESS! [0:26:01.193203] > > On Sat, Nov 27, 2021 at 8:40 AM Michael McCandless > wrote: > > > > +1 > > > > SUCCESS! [0:06:46.020662] > > > > What a crazy speedup to smoke tester!!

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> Also fine with some note that, if you want to fork lucene and make your > own source release, you can use our packaging build infrastructure, but you > need to git clone. We are giving you a source release, not a git clone > (shallow or deep). If you want to fork and make your own customized

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 6:24 PM Uwe Schindler wrote: > FYI, > > looks like this: > > > > I also tried to compile, test and assemble. All works. Only the src.tgz > can’t be built from itsself, because the extracted folder is no git > repository : > > > > > Task :checkWorkingCopyClean > >

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
Uwe - Uwe Schindler Achterdiek 19, D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de From: Uwe Schindler Sent: Sunday, November 28, 2021 10:51 PM To: Robert Muir Cc: dev@lucene.apache.org Subject: Re: [VOTE] Release Lucene 9.0.0 RC3 The pax file is only in the root of the ta

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
The pax file is only in the root of the tar file next to the folder named "lucene-9.0.0/". This is why I have seen it. You open the tar file and it shows up next to the root folder, so it was impossible to ignore. Same after extraction. Am 28. November 2021 20:58:52 UTC schrieb Robert Muir :

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 11:12 AM Uwe Schindler wrote: > > Thanks Robert! > > This is of course not a problem, but 7zip is the defacto unzipper used on > windows nowadays, so we should be prepared because of questions. > > It's not an issue at all, the hidden file contains useful information

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
Thanks Robert! This is of course not a problem, but 7zip is the defacto unzipper used on windows nowadays, so we should be prepared because of questions. It's not an issue at all, the hidden file contains useful information (commit hash), so I don't care. I was more wondering why it was

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
https://sourceforge.net/p/sevenzip/bugs/2116/ Basically, it seems to me this 7zip doesn't support the posix pax extensions used by lots of software (read the comments on the bug report for an idea). So it treats them as ordinary tar files and that's why Uwe sees these files. On Sun, Nov 28, 2021

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Robert Muir
On Sun, Nov 28, 2021 at 5:15 AM Dawid Weiss wrote: >> >> >> Wasn't the src.tgz not created by Gradle? Was it done by using the git >> command line inside the release wizard? > > > No - we use external git because it simplifies excludes/ includes (git will > only compress versioned files). >

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> > > Wasn't the src.tgz not created by Gradle? Was it done by using the git > command line inside the release wizard? > No - we use external git because it simplifies excludes/ includes (git will only compress versioned files).

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Uwe Schindler
I found that out, too. Wasn't the src.tgz not created by Gradle? Was it done by using the git command line inside the release wizard? I used 7zip on Windows to review file contents. Uwe Am 28. November 2021 08:29:55 UTC schrieb Dawid Weiss : >> >> I checked the src.tgz file, I was only a bit

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-28 Thread Dawid Weiss
> > I checked the src.tgz file, I was only a bit confused about the > "pax_global_header" file, looks as if it contains the commit hash. What's > this? > Seems like a file created by git export - Kernel tar-archives created by git contain an extended header with the git commit ID that was used

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Uwe Schindler
ginal Message----- > > From: Adrien Grand > > Sent: Friday, November 26, 2021 3:31 PM > > To: Lucene Dev > > Subject: [VOTE] Release Lucene 9.0.0 RC3 > > > > Please vote for release candidate 3 for Lucene 9.0.0. > > > > The artifacts can

RE: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Uwe Schindler
D-28357 Bremen https://www.thetaphi.de eMail: u...@thetaphi.de > -Original Message- > From: Adrien Grand > Sent: Friday, November 26, 2021 3:31 PM > To: Lucene Dev > Subject: [VOTE] Release Lucene 9.0.0 RC3 > > Please vote for release candidate 3 for Lucene 9.0.0. > >

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Gus Heck
+1 SUCCESS! [0:08:46.711289] (Java 11 JAVA_HOME=/home/gus/../zulu11.48.21-ca-jdk11.0.11-linux_x64/) Smoketester only On Sat, Nov 27, 2021 at 10:57 AM Tomoko Uchida wrote: > Luke app starts on both of Linux and Windows (with or without spaces > in the path) and works well for me. > Thanks

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Tomoko Uchida
Luke app starts on both of Linux and Windows (with or without spaces in the path) and works well for me. Thanks everyone who took the time for it. Tomoko 2021年11月27日(土) 23:57 Robert Muir : > > +1 > > (with --test-java17) > SUCCESS! [0:26:01.193203] > > On Sat, Nov 27, 2021 at 8:40 AM Michael

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Robert Muir
+1 (with --test-java17) SUCCESS! [0:26:01.193203] On Sat, Nov 27, 2021 at 8:40 AM Michael McCandless wrote: > > +1 > > SUCCESS! [0:06:46.020662] > > What a crazy speedup to smoke tester!! > > > > Mike McCandless > > http://blog.mikemccandless.com > > > On Sat, Nov 27, 2021 at 3:42 AM Ignacio

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Michael McCandless
+1 SUCCESS! [0:06:46.020662] What a crazy speedup to smoke tester!! Mike McCandless http://blog.mikemccandless.com On Sat, Nov 27, 2021 at 3:42 AM Ignacio Vera wrote: > +1 > > SUCCESS! [0:17:28.435474] > > On Sat, Nov 27, 2021 at 1:27 AM Jan Høydahl wrote: > >> +1 SUCCESS!

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-27 Thread Ignacio Vera
+1 SUCCESS! [0:17:28.435474] On Sat, Nov 27, 2021 at 1:27 AM Jan Høydahl wrote: > +1 SUCCESS! [0:23:41.775448] > > Only ran smoketester this time. > > Jan > > > 26. nov. 2021 kl. 15:31 skrev Adrien Grand : > > > > Please vote for release candidate 3 for Lucene 9.0.0. > > > > The artifacts can

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-26 Thread Jan Høydahl
+1 SUCCESS! [0:23:41.775448] Only ran smoketester this time. Jan > 26. nov. 2021 kl. 15:31 skrev Adrien Grand : > > Please vote for release candidate 3 for Lucene 9.0.0. > > The artifacts can be downloaded from: >

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-26 Thread Nhat Nguyen
+1 (binding). SUCCESS! [0:14:24.593226] On Fri, Nov 26, 2021 at 11:23 AM Michael Sokolov wrote: > SUCCESS! [0:10:10.031522] > > +1 from me > > On Fri, Nov 26, 2021 at 9:31 AM Adrien Grand wrote: > > > > Please vote for release candidate 3 for Lucene 9.0.0. > > > > The artifacts can be

Re: [VOTE] Release Lucene 9.0.0 RC3

2021-11-26 Thread Michael Sokolov
SUCCESS! [0:10:10.031522] +1 from me On Fri, Nov 26, 2021 at 9:31 AM Adrien Grand wrote: > > Please vote for release candidate 3 for Lucene 9.0.0. > > The artifacts can be downloaded from: >

[VOTE] Release Lucene 9.0.0 RC3

2021-11-26 Thread Adrien Grand
Please vote for release candidate 3 for Lucene 9.0.0. The artifacts can be downloaded from: https://dist.apache.org/repos/dist/dev/lucene/lucene-9.0.0-RC3-rev-1ddce848cf3d5067efcafc6569d5f8203e56af0b You can run the smoke tester directly with this command: python3 -u