[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166241#comment-13166241 ] Simon Willnauer commented on LUCENE-3622: - robert, while you are on it I think we

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166289#comment-13166289 ] Mark Miller commented on LUCENE-3622: - Does that really remove the confusion? Not

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166290#comment-13166290 ] Robert Muir commented on LUCENE-3622: - I think it does: we need to use the simplest

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Uwe Schindler (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166296#comment-13166296 ] Uwe Schindler commented on LUCENE-3622: --- I agree with Robert and Simon, we should

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166303#comment-13166303 ] Mark Miller commented on LUCENE-3622: - Its two different points: 1. Does it remove

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Jason Rutherglen (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166305#comment-13166305 ] Jason Rutherglen commented on LUCENE-3622: -- +! To the function naming being

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166306#comment-13166306 ] Mark Miller commented on LUCENE-3622: - And as I said, calling it IndexDocValues

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166310#comment-13166310 ] Mark Miller commented on LUCENE-3622: - bq. I think it does: we need to use the

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166311#comment-13166311 ] Simon Willnauer commented on LUCENE-3622: - bq. And as I said, calling it

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166312#comment-13166312 ] Robert Muir commented on LUCENE-3622: - For now in the branch

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166315#comment-13166315 ] Mark Miller commented on LUCENE-3622: - bq. we had some arguments when merging from

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Robert Muir (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166319#comment-13166319 ] Robert Muir commented on LUCENE-3622: - {quote} I'd also have argued that in 4 we

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Ryan McKinley (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166327#comment-13166327 ] Ryan McKinley commented on LUCENE-3622: --- +1 for FunctionValues

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-09 Thread Mark Miller (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13166328#comment-13166328 ] Mark Miller commented on LUCENE-3622: - +1 separate IndexDocValues

[jira] [Commented] (LUCENE-3622) separate IndexDocValues interface from implementation

2011-12-06 Thread Simon Willnauer (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-3622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13164220#comment-13164220 ] Simon Willnauer commented on LUCENE-3622: - +1 go for it