[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-29 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13617286#comment-13617286 ] Erick Erickson commented on SOLR-4196: -- Changed my mind, rather than fold it into

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-28 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616427#comment-13616427 ] Mark Miller commented on SOLR-4196: --- what im talking about is this: {code} // We are

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-28 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13616627#comment-13616627 ] Erick Erickson commented on SOLR-4196: -- Good catch! Actually, I think clearing the

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-19 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606489#comment-13606489 ] Erick Erickson commented on SOLR-4196: -- bq: ...there are a variety of non thread safe

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-19 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13606497#comment-13606497 ] Mark Miller commented on SOLR-4196: --- I'm going to do a full review soon and I'll report

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-15 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603341#comment-13603341 ] Commit Tag Bot commented on SOLR-4196: -- [trunk commit] Erick Erickson

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-15 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13603356#comment-13603356 ] Commit Tag Bot commented on SOLR-4196: -- [branch_4x commit] Erick Erickson

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-15 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13604111#comment-13604111 ] Mark Miller commented on SOLR-4196: --- I'll try and be more specific over the weekend when

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-08 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13597316#comment-13597316 ] Commit Tag Bot commented on SOLR-4196: -- [branch_4x commit] Erick Erickson

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-01 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591172#comment-13591172 ] Erick Erickson commented on SOLR-4196: -- Checked in, trunk r: 1451797 I want this to

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-03-01 Thread Commit Tag Bot (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13591174#comment-13591174 ] Commit Tag Bot commented on SOLR-4196: -- [trunk commit] Erick Erickson

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-21 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13583182#comment-13583182 ] Erick Erickson commented on SOLR-4196: -- got it, thanks. Untangle

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582305#comment-13582305 ] Mark Miller commented on SOLR-4196: --- bq. with the problem that seems to come up

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-20 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582316#comment-13582316 ] Erick Erickson commented on SOLR-4196: -- bq: Are you seeing this on your machine? If

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582324#comment-13582324 ] Mark Miller commented on SOLR-4196: --- Unless you see something fail locally without your

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-20 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582373#comment-13582373 ] Erick Erickson commented on SOLR-4196: -- I'm not communicating. There aren't any test

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-20 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13582385#comment-13582385 ] Mark Miller commented on SOLR-4196: --- I'm just letting you know for the future - I know

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-17 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13580285#comment-13580285 ] Erick Erickson commented on SOLR-4196: -- I'm still having the same problem with updates

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-04 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13570915#comment-13570915 ] Mark Miller commented on SOLR-4196: --- I'll try some test runs with the latest patch soon.

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-03 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569790#comment-13569790 ] Erick Erickson commented on SOLR-4196: -- Hmmm, I have no idea why Eclipse didn't like

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-03 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569811#comment-13569811 ] Mark Miller commented on SOLR-4196: --- bq. Hmmm, I have no idea why Eclipse didn't like the

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569686#comment-13569686 ] Mark Miller commented on SOLR-4196: --- Looking pretty good! Another clean up comment -

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569688#comment-13569688 ] Mark Miller commented on SOLR-4196: --- Also, fyi, for some reason eclipse doesn't like your

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-02-02 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13569693#comment-13569693 ] Mark Miller commented on SOLR-4196: --- The first deadlock I've seen is with -x and involves

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-01-27 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13564021#comment-13564021 ] Mark Miller commented on SOLR-4196: --- I'm going to take a closer look at the latest patch.

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2013-01-22 Thread Andy Fowler (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13560418#comment-13560418 ] Andy Fowler commented on SOLR-4196: --- I noticed a bug(?) in Solr-4.1 release that if there

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-20 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13537049#comment-13537049 ] Erick Erickson commented on SOLR-4196: -- Mark: I think this approach is close enough

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-19 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535910#comment-13535910 ] Erick Erickson commented on SOLR-4196: -- @Ryan I have a ConfigSolr object that I'm

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-19 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13536651#comment-13536651 ] Mark Miller commented on SOLR-4196: --- Yeah, but since the xml is not very complex, most of

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-18 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535509#comment-13535509 ] Erick Erickson commented on SOLR-4196: -- I'm starting by trying to pull all XML

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-18 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535524#comment-13535524 ] Ryan McKinley commented on SOLR-4196: - bq. Does anyone have some grand scheme in mind

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-18 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13535545#comment-13535545 ] Mark Miller commented on SOLR-4196: --- Yeah, eventually we want to get rid of all that.

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-15 Thread Jack Krupansky (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533051#comment-13533051 ] Jack Krupansky commented on SOLR-4196: -- I notice this has fix version of 4.1... there

[jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes

2012-12-15 Thread Erick Erickson (JIRA)
[ https://issues.apache.org/jira/browse/SOLR-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13533121#comment-13533121 ] Erick Erickson commented on SOLR-4196: -- Don't worry about it, the other one probaby