[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2011-01-29 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988492#action_12988492 ] Yonik Seeley commented on LUCENE-2671: -- bq. Does this mean we should now deprecate: o

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2011-01-29 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988496#action_12988496 ] Ryan McKinley commented on LUCENE-2671: --- in r1065093, i deprecated the sortable* fie

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-09-26 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12915083#action_12915083 ] Yonik Seeley commented on LUCENE-2671: -- Ah - I was just about to report "hmmm, doesn'

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-09-28 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916009#action_12916009 ] Ryan McKinley commented on LUCENE-2671: --- Note, this solution does not (yet) address

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-01 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917023#action_12917023 ] Uwe Schindler commented on LUCENE-2671: --- Additionally, the source code formatting is

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921686#action_12921686 ] Robert Muir commented on LUCENE-2671: - I am concerned about the @SuppressWarnings here

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921725#action_12921725 ] Ryan McKinley commented on LUCENE-2671: --- bq. I don't think we should leave the API

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921732#action_12921732 ] Yonik Seeley commented on LUCENE-2671: -- Hopefully if/when this cache moves to IndexRe

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921759#action_12921759 ] Ryan McKinley commented on LUCENE-2671: --- bq. Hopefully if/when this cache moves to I

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921760#action_12921760 ] Robert Muir commented on LUCENE-2671: - bq. What part of the API is broken? DocTermsC

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921763#action_12921763 ] Ryan McKinley commented on LUCENE-2671: --- bq. This is not true, it returns DocTermCre

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-10-16 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921768#action_12921768 ] Robert Muir commented on LUCENE-2671: - {quote} in #1023379 I changed DocTermsCreator a

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-12-08 Thread Yonik Seeley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969386#action_12969386 ] Yonik Seeley commented on LUCENE-2671: -- (carried over from LUCENE-2649... I guess my

[jira] Commented: (LUCENE-2671) Add sort missing first/last ability to SortField and ValueComparator

2010-12-10 Thread Ryan McKinley (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970235#action_12970235 ] Ryan McKinley commented on LUCENE-2671: --- Looks good -- should we also get rid of the