Hi,
If I can I want show to you some advantages/disadvantages as I see as
collaborator to external project. Maybe some of them you will like.
I've analyzed some commits what I did to maven-invoker-plugin project.
I used: git log --graph --show-signature --format=full
*1. commit made manually
Checkstyle builds will fail of there is more than one commit in a PR.
Not saying I like it, but it's an option.
On Sat, 21 Mar 2020, 16:17 Elliotte Rusty Harold,
wrote:
> So it appears that if I do all squashing and merging locally and then
> push directly to master, I get listed as
So it appears that if I do all squashing and merging locally and then
push directly to master, I get listed as committer and author:
https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git=commit=4264899a152a6205b0f34a32e9c947edcd9cb1e8
Github is no longer listed as the committer. This is
On Sat, Mar 14, 2020 at 6:22 AM Robert Scholte wrote:
>
> Yes, once confirmed that the branch builds fine on our Jenkins, we should do
> the "squash and merge". (we should already be happy with a proper PR)
> My experience so far was like you describe, but it doesn't explain why
> Elliotte
Several Apache project have a script to perform this stuff
I really love this kind of scripts
You can find an example here (1)
Such scripts:
- squash all commits into one
- keep original author
- ask for a meaningful commit message
- interact with JIRA
- set Resolved status and fixVersion
- all
Yes, once confirmed that the branch builds fine on our Jenkins, we should do
the "squash and merge". (we should already be happy with a proper PR)
My experience so far was like you describe, but it doesn't explain why Elliotte
causes "github" to become the committer.
One possible difference I
I agree we must make it mandatory for the committer (us) to squash it.
But not really mandatory to ask contributor to squash but just only use the
"Squash and merge" option and you will get proper commit on merge:
see this commit
Hi,
On 13.03.20 15:58, Michael Osipov wrote:
Am 2020-03-12 um 19:46 schrieb Robert Scholte:
This week I was very surprised to see commits from the user call
"github" in Jenkins:
https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
IMO we shouldn't want these
Am 2020-03-12 um 19:46 schrieb Robert Scholte:
This week I was very surprised to see commits from the user call "github" in
Jenkins:
https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
IMO we shouldn't want these kind of commits.
Based on the most recent
On Thu, Mar 12, 2020 at 2:46 PM Robert Scholte wrote:
>
> This week I was very surprised to see commits from the user call "github" in
> Jenkins:
> https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
>
>
> IMO we shouldn't want these kind of commits.
> Based on the
This week I was very surprised to see commits from the user call "github" in
Jenkins:
https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
IMO we shouldn't want these kind of commits.
Based on the most recent activities I had a chat with Sylwester en Elliotte.
The
11 matches
Mail list logo
