Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-02 Thread Romain Manni-Bucau
Le lun. 2 août 2021 à 17:23, Robert Scholte a écrit : > Thinks to keep in mind when trying to log for a specific execution of a > plugin: > - loggers use the classname as identifier, so you need to know when to the > execution starts and ends. > - plugins can call Maven Core code, most likely you

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-02 Thread Robert Scholte
Thinks to keep in mind when trying to log for a specific execution of a plugin: - loggers use the classname as identifier, so you need to know when to the execution starts and ends. - plugins can call Maven Core code, most likely you want this to be logged as part of the plugin execution. - multi

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-02 Thread Romain Manni-Bucau
Le lun. 2 août 2021 à 16:02, Michael Osipov a écrit : > Am 2021-08-02 um 09:39 schrieb Romain Manni-Bucau: > > Le dim. 1 août 2021 à 22:37, Michael Osipov a > écrit : > > > >> A prerequisite PR is ready: https://github.com/apache/maven/pull/519 > > > > > > Maybe I'm a bit "off" on this one but s

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-02 Thread Michael Osipov
Am 2021-08-02 um 09:39 schrieb Romain Manni-Bucau: Le dim. 1 août 2021 à 22:37, Michael Osipov a écrit : A prerequisite PR is ready: https://github.com/apache/maven/pull/519 Maybe I'm a bit "off" on this one but shouldn't we just enable to configure slf4j from the command line with "shortcu

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-02 Thread Romain Manni-Bucau
Le dim. 1 août 2021 à 22:37, Michael Osipov a écrit : > A prerequisite PR is ready: https://github.com/apache/maven/pull/519 Maybe I'm a bit "off" on this one but shouldn't we just enable to configure slf4j from the command line with "shortcuts"? ie --info --debug --org.apache.wagon-debug Once

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-01 Thread Michael Osipov
A prerequisite PR is ready: https://github.com/apache/maven/pull/519 - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-01 Thread Michael Osipov
Am 2021-08-01 um 13:03 schrieb Michael Osipov: Am 2021-08-01 um 11:04 schrieb Romain Manni-Bucau: Le dim. 1 août 2021 à 01:22, Stephen Connolly < stephen.alan.conno...@gmail.com> a écrit : I’m fine with a breaking change. I also think batch mode debugging is a special case, we could go with

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-01 Thread Michael Osipov
Am 2021-08-01 um 11:04 schrieb Romain Manni-Bucau: Le dim. 1 août 2021 à 01:22, Stephen Connolly < stephen.alan.conno...@gmail.com> a écrit : I’m fine with a breaking change. I also think batch mode debugging is a special case, we could go with —batch-debug Both options are transversal IMH

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-08-01 Thread Romain Manni-Bucau
Le dim. 1 août 2021 à 01:22, Stephen Connolly < stephen.alan.conno...@gmail.com> a écrit : > I’m fine with a breaking change. > > I also think batch mode debugging is a special case, we could go with > > —batch-debug > Both options are transversal IMHO so let it be. If you run in debug without cu

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Stephen Connolly
I’m fine with a breaking change. I also think batch mode debugging is a special case, we could go with —batch-debug If you really want to debug batch mode and that way —debug can be incompatible with —batch and then we don’t worry about it On Sat 31 Jul 2021 at 16:06, Michael Osipov wrote: >

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Michael Osipov
Well, I have just tried. Not providing a timeout is just like providing timeout=0. The socket will wait forever. If your provide a timeout and don't connect after a timeout, this will happen: Listening for transport dt_socket at address: 8000 ERROR: transport error 203: timed out waiting for c

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Romain Manni-Bucau
Le sam. 31 juil. 2021 à 16:48, Michael Osipov a écrit : > Am 2021-07-31 um 16:40 schrieb Romain Manni-Bucau: > > Open question: if mvnDebug stays (i am all for it), why deprecating it? > It > > is very useful for all dev using embed plugins (most of them) like jetty, > > tomee, tomcat, meecrowave

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Michael Osipov
Am 2021-07-31 um 16:40 schrieb Romain Manni-Bucau: Open question: if mvnDebug stays (i am all for it), why deprecating it? It is very useful for all dev using embed plugins (most of them) like jetty, tomee, tomcat, meecrowave, renders, etc What is the problem you see? It add unnecessary mainten

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Romain Manni-Bucau
Open question: if mvnDebug stays (i am all for it), why deprecating it? It is very useful for all dev using embed plugins (most of them) like jetty, tomee, tomcat, meecrowave, renders, etc Le sam. 31 juil. 2021 à 16:32, Robert Scholte a écrit : > CI can have multiple Maven versions. > Mistakes w

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Robert Scholte
CI can have multiple Maven versions.  Mistakes will happen: users might add --debug assuming verbose logging. With an Environment Variable the CI server can globally suppress the option to debug. I'm also fine with a NO_DEBUG option, but I'd like to have a global way to suppress the impact. Robe

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Michael Osipov
Am 2021-07-31 um 11:22 schrieb Robert Scholte: Right, it is suspend, I misinterpreted the description of server. Can we introduce an environment variable for it, so CI servers can set it to 0? Let me summarize: If --debug is passed everything will work as before: wait forever If --debug --batc

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Clemens Quoss
Thx for the clarification. Regards Clemens Am 31. Juli 2021 10:58:07 MESZ schrieb Robert Scholte : >The discussion is about using --debug -B (combination of these 2 flags). With >Maven 3 this meant batch-mode + debug level logging. >The proposal for Maven 4 is to change debug level logging to

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Robert Scholte
Right, it is suspend, I misinterpreted the description of server. Can we introduce an environment variable for it, so CI servers can set it to 0? Robert On 30-7-2021 21:46:46, Michael Osipov wrote: I guess you mean suspend and not server. Your idea may work, but still is problematic. If the brea

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-31 Thread Robert Scholte
The discussion is about using --debug -B (combination of these 2 flags). With Maven 3 this meant batch-mode + debug level logging. The proposal for Maven 4 is to change debug level logging to --verbose/-X and redefine --debug for debugging instead of mvnDebug. So if you're only using -B there's n

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-30 Thread Clemens Quoss
Hello! I may not understand much of this discussion going on here. But we use the -B option for having the default behaviour of maven-release in literally thousands of our Jenkins build jobs. Even only having to wait on a debug timeout would not be acceptable and would force us to remove this i

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-30 Thread Michael Osipov
I guess you mean suspend and not server. Your idea may work, but still is problematic. If the breakpoint is quite early you will miss in your IDE and then you need to start over. I think -B and --debug are special cases and I believe that a timeout is acceptible since the build is halted, but mo

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-30 Thread Robert Scholte
I wonder if this is a realistic issue. In the cases I know with the batch-mode the interactive part is skipped and code falls back to defaults. If there are issues, they're more much  likely to happen in the interactive mode. Maybe a more reasonable solution is to use server="n" (default) for bat

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-30 Thread Michael Osipov
Am 2021-07-30 um 14:31 schrieb Stephen Connolly: So now I cannot debug Maven issues that happen when running in batch mode? We should document that specific case uses MAVEN_OPTS Not now, nothing has been committed/merged yet. This is just a PoC. Robert and me thought about this. We could add a

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-30 Thread Stephen Connolly
So now I cannot debug Maven issues that happen when running in batch mode? We should document that specific case uses MAVEN_OPTS On Tue 27 Jul 2021 at 16:01, Michael Osipov wrote: > So you say that -B will implicitly disable --debug without any further > notice? > > I logically agree that batch

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-29 Thread Michael Osipov
I have now updated the PR with batch mode in mind. Please have a look. Note: the PR is of course in complete because it needs modification in the Java side. - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additi

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-27 Thread Michael Osipov
So you say that -B will implicitly disable --debug without any further notice? I logically agree that batch contradicts debug which requires interaction with the suspended VM. Both does not make sense. Note: Colors are easier now. They now work just like people are used with grep --color...

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-27 Thread Robert Scholte
batch mode means no interaction, but the debug-flag is an interaction (java process is waiting for input). So it doesn't make sense to have both activated. This will prevent CI jobs to hang when using --debug (if they assume this means logging at debug level) batch implies disabling colours, but

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-27 Thread Michael Osipov
OK, let me sum up what you are proposing: Am 2021-07-27 um 12:39 schrieb Robert Scholte: I actually like the idea of renaming --debug/-X to --verbose/-X and we're actually lucky. When renaming we can add a message that --debug for logging at debug level has been renamed to --verbose. A prece

Re: [Maven 4] Collapsing mvnDebug into mvn

2021-07-27 Thread Robert Scholte
I actually like the idea of renaming --debug/-X to --verbose/-X and we're actually lucky. When renaming we can add a message that --debug for logging at debug level has been renamed to --verbose. Due to the nature of debugging (waiting until remote debugger is attached) the message will be visib

[Maven 4] Collapsing mvnDebug into mvn

2021-07-26 Thread Michael Osipov
Hi folks, I was recently working on MNG-7075 and while the solution is straight forward [1], it just feels awkward. For a long time I had the idea that the mvnDebug script can be completely collapsed into mvn with a single switch. Therefore, I have created a draft PR [2] which works in the Win