Re: Review Request 17342: Updated Log::Reader and Log::Writer to be asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17342/#review32781 --- Ship it! src/log/log.hpp

Re: Review Request 17341: move process::http namespace into http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17341/#review32780 --- Ship it! Thank you for the cleanup! You'll gonna need to rebase sin

[jira] [Commented] (MESOS-947) Slave should properly handle a killTask() that arrives between runTask() and _runTask()

[ https://issues.apache.org/jira/browse/MESOS-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881660#comment-13881660 ] Jonathan Boulle commented on MESOS-947: --- e.g. {code} I0124 21:49:33.939821 42915 slav

[jira] [Created] (MESOS-947) Slave should properly handle a killTask() that arrives between runTask() and _runTask()

Vinod Kone created MESOS-947: Summary: Slave should properly handle a killTask() that arrives between runTask() and _runTask() Key: MESOS-947 URL: https://issues.apache.org/jira/browse/MESOS-947 Project:

Re: Review Request 17221: Added a function that captures the stack trace when "a pure virtual method" is called.

> On Jan. 23, 2014, 10:27 a.m., Jie Yu wrote: > > src/logging/logging.cpp, line 44 > > > > > > Is this standard? What if other library also defines this function? It's done in a similar way in other projects. e.g. htt

Re: Review Request 14669: launchTasks on list of offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/ --- (Updated Jan. 24, 2014, 6:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 14669: launchTasks on list of offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/#review32773 --- Ship it! Lets get this committed. src/sched/sched.cpp

Re: Review Request 14669: launchTasks on list of offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/ --- (Updated Jan. 24, 2014, 6:01 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 17339: Made proposal number optional in log::catchup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17339/ --- (Updated Jan. 25, 2014, 12:56 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 17286: Allowed log::catchup to retry to tolerate network blips.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17286/ --- (Updated Jan. 25, 2014, 12:57 a.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

> On Jan. 24, 2014, 7:47 a.m., Benjamin Hindman wrote: > > src/launcher/executor.cpp, line 298 > > > > > > I think it makes sense to have a "global" reaper just like we do with > > statistics. Having multiple libproce

Re: Review Request 17340: Use Failure instead of Future::failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17340/#review32769 --- Ship it! Ship It! - Jie Yu On Jan. 25, 2014, 12:42 a.m., Benjami

Re: Review Request 17339: Made proposal number optional in log::catchup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17339/#review32767 --- Ship it! src/log/catchup.cpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32751 --- 3rdparty/libprocess/src/reaper.cpp

Review Request 17345: Replaced Log::Writer constructor with explicit Log::Writer::start.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17345/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Review Request 17346: Exposed coordinator demotion in Log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17346/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 8:15 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/reaper.cpp, lines 70-98 > > > > > > Any reason why these two loops cannot be merged now? Definitely! Thanks for pointing this out :) - Ben

Review Request 17342: Updated Log::Reader and Log::Writer to be asynchronous.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17342/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Review Request 17344: Simplified coordinator election semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17344/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Review Request 17343: Exposed coordinator demotion.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17343/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Review Request 17340: Use Failure instead of Future::failed.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17340/ --- Review request for mesos and Jie Yu. Repository: mesos-git Description --

Re: Review Request 17338: Fixed a bug that causes incorrect log output when there is no master detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17338/#review32766 --- Ship it! Ship It! - Vinod Kone On Jan. 24, 2014, 11:40 p.m., Jia

Re: Review Request 17341: move process::http namespace into http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17341/ --- (Updated Jan. 25, 2014, 12:24 a.m.) Review request for mesos, Benjamin Hindman

Review Request 17341: move process::http namespace into http.cpp

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17341/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: https://issues.apa

Re: Review Request 14669: launchTasks on list of offers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14669/#review32750 --- Ship it! Looks great! Thanks for the patience. Let me know what yo

Re: Review Request 17286: Allowed log::catchup to retry to tolerate network blips.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17286/ --- (Updated Jan. 25, 2014, 12:19 a.m.) Review request for mesos and Benjamin Hindm

Review Request 17339: Made proposal number optional in log::catchup.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17339/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-git Descript

Re: Review Request 17286: Allowed log::catchup to retry to tolerate network blips.

> On Jan. 24, 2014, 1:59 a.m., Benjamin Hindman wrote: > > src/log/catchup.hpp, line 52 > > > > > > If the caller can use an arbitrary proposal number than this should be > > an Option rather that assume semantics of p

Re: Review Request 17338: Fixed a bug that causes incorrect log output when there is no master detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17338/#review32762 --- Ship it! src/master/master.cpp

Review Request 17338: Fixed a bug that causes incorrect log output when there is no master detected.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17338/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, and Vinod Kone.

Re: Review Request 17210: Added 'hostname' flag to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17210/#review32761 --- Ship it! Looks great! Thanks for taking this on. - Brenden Matthew

Re: Review Request 17210: Added 'hostname' flag to the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17210/#review32760 --- Ship it! Expose 'hostname' through http.cpp? - Jiang Yan Xu On J

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review32758 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 17089: Refactored implicit conversions of Some, None, and Error.

> On Jan. 20, 2014, 10:55 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/some.hpp, line 30 > > > > > > Ditto Jie's comment, looks like a leftover from your intermediate > > attempt? > >

Re: Review Request 17089: Refactored implicit conversions of Some, None, and Error.

> On Jan. 19, 2014, 7:03 p.m., Jie Yu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/some.hpp, line 30 > > > > > > Ditto here. Why we need a type _Some? We need the _Some intermediate type so that you don'

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 5:46 p.m., Ian Downes wrote: > > 3rdparty/libprocess/src/reaper.cpp, line 101 > > > > > > Out of curiosity, why was 1 second originally chosen? It was likely an arbitrary decision based on a compro

[jira] [Commented] (MESOS-943) Provide an abstraction for asynchronous launching of subprocesses.

[ https://issues.apache.org/jira/browse/MESOS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881436#comment-13881436 ] Benjamin Mahler commented on MESOS-943: --- Thanks for bringing this up Nikita! For (3)

Re: Review Request 14669: launchTasks on list of offers

> On Jan. 16, 2014, 10:34 a.m., Niklas Nielsen wrote: > > src/master/master.cpp, lines 1427-1445 > > > > > > Unfortunately, the offer visitors won't be invoked if offerIds is empty. > > > > Also, the visitor

[jira] [Created] (MESOS-946) setup.py should be able to create publishable sdist

Kevin Sweeney created MESOS-946: --- Summary: setup.py should be able to create publishable sdist Key: MESOS-946 URL: https://issues.apache.org/jira/browse/MESOS-946 Project: Mesos Issue Type: Bug

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32744 --- 3rdparty/libprocess/src/reaper.cpp

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review32740 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 17304: Added a child Reaper utility in libprocess.

> On Jan. 24, 2014, 7:40 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/src/reaper.cpp, lines 31-34 > > > > > > Not your bug, but any reason we can't reuse an existing promise if it's > > already in the map? It

[jira] [Created] (MESOS-945) Show framework host name in the WebUI

Vinod Kone created MESOS-945: Summary: Show framework host name in the WebUI Key: MESOS-945 URL: https://issues.apache.org/jira/browse/MESOS-945 Project: Mesos Issue Type: Improvement C

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/ --- (Updated Jan. 24, 2014, 11:31 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 16147: Containerizer (part 1)

> On Jan. 24, 2014, 1:59 a.m., Adam B wrote: > > src/slave/container/containerizer.cpp, line 58 > > > > > > Do you need to use "process::" since you're "using namespace process" > > above? This code disappeared when I

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review32735 --- Ship it! Ship It! - Jie Yu On Jan. 24, 2014, 7:05 a.m., Ben Mahl

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32734 --- Ship it! Ship It! - Jie Yu On Jan. 24, 2014, 7:05 a.m., Ben Mahl

Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs: M

Re: Review Request 16147: Containerizer (part 1)

> On Jan. 22, 2014, 3:25 a.m., Adam B wrote: > > src/local/local.cpp, line 83 > > > > > > I wonder if we should we be mapping ContainerID -> Slave* instead? This map is storing Containerizers that have been created on

Re: Review Request 16147: Containerizer (part 1)

> On Jan. 22, 2014, 12:01 a.m., Niklas Nielsen wrote: > > src/slave/container/mesos_containerizer.cpp, line 169 > > > > > > Is this async signal safe? No, turns out it isn't so I'll reimplement this functionality with

Re: Review Request 16147: Containerizer (part 1)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16147/ --- (Updated Jan. 24, 2014, 6:25 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 16147: Containerizer (part 1)

> On Jan. 21, 2014, 11:39 p.m., Benjamin Hindman wrote: > > src/slave/slave.cpp, line 2041 > > > > > > What are the ramifications of the overcommit with respect to other > > containers? Should we be moving this close

Re: Review Request 16147: Containerizer (part 1)

> On Jan. 14, 2014, 4:29 p.m., Jason Dusek wrote: > > src/slave/container/containerizer.hpp, line 84 > > > > > > If Containerizer::launch() had the resources, it could simplify working > > with many external containeri

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review32726 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 17305: Update the slave to use the libprocess Reaper.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17305/#review32725 --- Ship it! Ship It! - Ian Downes On Jan. 24, 2014, 7:05 a.m., Ben

[jira] [Created] (MESOS-944) SlaveRecoveryTest/0.MultipleFrameworks hangs forever

Benjamin Hindman created MESOS-944: -- Summary: SlaveRecoveryTest/0.MultipleFrameworks hangs forever Key: MESOS-944 URL: https://issues.apache.org/jira/browse/MESOS-944 Project: Mesos Issue Ty

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32724 --- Ship it! Ship It! - Ian Downes On Jan. 24, 2014, 7:05 a.m., Ben

Re: Review Request 17304: Added a child Reaper utility in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17304/#review32723 --- 3rdparty/libprocess/include/process/reaper.hpp

[jira] [Commented] (MESOS-895) Removal of libev patch

[ https://issues.apache.org/jira/browse/MESOS-895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13881150#comment-13881150 ] Timothy St. Clair commented on MESOS-895: - So the resolution that we are thinking a

[jira] [Commented] (MESOS-943) Provide an abstraction for asynchronous launching of subprocesses.

[ https://issues.apache.org/jira/browse/MESOS-943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880879#comment-13880879 ] Nikita Vetoshkin commented on MESOS-943: I think it could a good thing to mention i

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review32707 --- This looks good Ben! One high-level thought, I wonder if we want to