Re: Review Request 17636: Added valgrind memcheck runnables.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17636/ --- (Updated Feb. 4, 2014, 6:40 a.m.) Review request for mesos, Benjamin Hindman, B

[jira] [Resolved] (MESOS-966) symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier

[ https://issues.apache.org/jira/browse/MESOS-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Hindman resolved MESOS-966. Resolution: Won't Fix This is an issue with glog itself and apparently only an issue on with

[jira] [Commented] (MESOS-960) Un-reaped executor during test teardown.

[ https://issues.apache.org/jira/browse/MESOS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890302#comment-13890302 ] Benjamin Mahler commented on MESOS-960: --- {noformat} commit 129ad594b51bf916d055bdcbab

Re: Review Request 17673: Fixed a test that leaked a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17673/ --- (Updated Feb. 4, 2014, 2:33 a.m.) Review request for mesos, Benjamin Hindman an

[jira] [Created] (MESOS-966) symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier

Vinson Lee created MESOS-966: Summary: symbolize.cc:235:58: error: invalid suffix on literal; C++11 requires a space between literal and identifier Key: MESOS-966 URL: https://issues.apache.org/jira/browse/MESOS-966

[jira] [Closed] (MESOS-591) GroupTest.GroupWatchWithSessionExpiration is flaky.

[ https://issues.apache.org/jira/browse/MESOS-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu closed MESOS-591. Resolution: Cannot Reproduce We haven't seen this (this [line|https://github.com/apache/mesos/blob/0047bd40d97fc076

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

> On Feb. 4, 2014, 12:10 a.m., Benjamin Hindman wrote: > > One high level comment, I think we need to decide if we want to "reserve" > > these names in libprocess. It might make sense to name these things > > __system__ and __profiler__ similar to how __processes__ and __gc__ was > > done. SG

Re: Review Request 17686: Updated Mesos to use new libprocess discard semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17686/ --- (Updated Feb. 4, 2014, 1:07 a.m.) Review request for mesos, Adam B, Ben Mahler,

Review Request 17685: Revisited Future::discard semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17685/ --- Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas Nielsen

Review Request 17686: Updated Mesos to use new libprocess discard semantics.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17686/ --- Review request for mesos, Adam B, Ben Mahler, Ian Downes, Jie Yu, Niklas Nielsen

[jira] [Commented] (MESOS-922) Containerizer to support launching tasks by TaskInfo

[ https://issues.apache.org/jira/browse/MESOS-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890222#comment-13890222 ] Ian Downes commented on MESOS-922: -- I could see the following initial changes to address t

[jira] [Updated] (MESOS-814) Retry retryable authentication failures

[ https://issues.apache.org/jira/browse/MESOS-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu updated MESOS-814: - Fix Version/s: 0.16.0 > Retry retryable authentication failures > --- > >

[jira] [Commented] (MESOS-922) Containerizer to support launching tasks by TaskInfo

[ https://issues.apache.org/jira/browse/MESOS-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13890196#comment-13890196 ] Niklas Quarfot Nielsen commented on MESOS-922: -- We should be able to start wor

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1868

See

Re: Review Request 17673: Fixed a test that leaked a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17673/#review33539 --- Ship it! src/tests/slave_recovery_tests.cpp

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33535 --- One high level comment, I think we need to decide if we want to "res

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

> On Feb. 3, 2014, 3:34 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/system.hpp, lines 54-66 > > > > > > This might get bitten by the same bug that is referenced in > > constants.hpp, statistics.hpp,

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33529 --- 3rdparty/libprocess/include/process/system.hpp

Re: Review Request 17663: Initialized local in cgroups and process isolator.

> On Feb. 3, 2014, 10:01 a.m., Ian Downes wrote: > > Cool, I will go ahead and commit this. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/#review33444 ---

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

> On Feb. 3, 2014, 11:51 a.m., Ben Mahler wrote: > > Thanks for the reviews Ben! I will go ahead and commit this. - Niklas --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33456 -

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/ --- (Updated Feb. 3, 2014, 2:10 p.m.) Review request for mesos, Benjamin Hindman, B

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1867

I have a fix out for this, see MESOS-960. On Mon, Feb 3, 2014 at 1:08 PM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/1867/ > > > >

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1867

See -- [...truncated 21279 lines...] I0203 21:08:49.143712 29347 hierarchical_allocator_process.hpp:688] Performed allocation for 0 slaves i

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 7:10 p.m., Jason Dusek wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 149 > > > > > > This order of arguments is not likely to work consistently across > > platforms. > > >

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 7:10 p.m., Jason Dusek wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 149 > > > > > > This order of arguments is not likely to work consistently across > > platforms. > > >

[jira] [Assigned] (MESOS-960) Un-reaped executor during test teardown.

[ https://issues.apache.org/jira/browse/MESOS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Mahler reassigned MESOS-960: - Assignee: Benjamin Mahler > Un-reaped executor during test teardown. > ---

[jira] [Commented] (MESOS-960) Un-reaped executor during test teardown.

[ https://issues.apache.org/jira/browse/MESOS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889914#comment-13889914 ] Benjamin Mahler commented on MESOS-960: --- Here is a fix for the one bad test I've foun

Review Request 17673: Fixed a test that leaked a child process.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17673/ --- Review request for mesos, Benjamin Hindman and Vinod Kone. Bugs: MESOS-960

[jira] [Reopened] (MESOS-965) GroupTest.GroupWatchWithSessionExpiration is flaky

[ https://issues.apache.org/jira/browse/MESOS-965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu reopened MESOS-965: -- Not a duplicate of MESOS-591. > GroupTest.GroupWatchWithSessionExpiration is flaky > --

[jira] [Resolved] (MESOS-965) GroupTest.GroupWatchWithSessionExpiration is flaky

[ https://issues.apache.org/jira/browse/MESOS-965?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu resolved MESOS-965. -- Resolution: Fixed Fix Version/s: (was: 0.18.0) > GroupTest.GroupWatchWithSessionExpiration is flaky >

[jira] [Created] (MESOS-965) GroupTest.GroupWatchWithSessionExpiration is flaky

Yan Xu created MESOS-965: Summary: GroupTest.GroupWatchWithSessionExpiration is flaky Key: MESOS-965 URL: https://issues.apache.org/jira/browse/MESOS-965 Project: Mesos Issue Type: Bug Comp

Jenkins build is back to normal : Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1866

See

[jira] [Updated] (MESOS-496) Refactor the MasterDetector (with 'bool contend' option) into new MasterDetector and MasterContender.

[ https://issues.apache.org/jira/browse/MESOS-496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yan Xu updated MESOS-496: - Description: The MasterDetector code still uses old Zookeeper abstractions and it's error-prone for maintenance a

Re: Review Request 17582: Fixed 'maven-install' make target.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17582/#review33487 --- src/Makefile.am

Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create MasterInfo from UPID.

> On Feb. 3, 2014, 11:01 a.m., Jiang Yan Xu wrote: > > src/common/protobuf_utils.hpp, line 105 > > > > > > I'd like some randomness (here and in master.cpp) too, if a UUID is too > > long given that we already have th

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17325/#review33456 --- Ship it! 3rdparty/libprocess/include/process/system.hpp

Re: Review Request 17325: Added new /system HTTP handler and /system/stats.json end-point.

> On Feb. 3, 2014, 7:51 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/include/process/system.hpp, line 35 > > > > > > Consider a static function as used in Duration to move the help string > > to the header file. (S

Re: Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1865

Commented on MESOS-960. On Mon, Feb 3, 2014 at 11:00 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See < > https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/1865/changes > > > > Changes: > > [dlester] Adds Medidata Solut

[jira] [Commented] (MESOS-960) Un-reaped executor during test teardown.

[ https://issues.apache.org/jira/browse/MESOS-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13889822#comment-13889822 ] Benjamin Mahler commented on MESOS-960: --- I found one test that produces zombies so fa

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 7:10 p.m., Jason Dusek wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 149 > > > > > > This order of arguments is not likely to work consistently across > > platforms. > > >

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 7:10 p.m., Jason Dusek wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, line 149 > > > > > > This order of arguments is not likely to work consistently across > > platforms. > > >

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review33469 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 9:10 a.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17574: Updated detector to return MasterInfo instead of PID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17574/#review33457 --- src/master/master.cpp

Re: Review Request 17572: Added 'protobuf::createMasterInfo()' to create MasterInfo from UPID.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17572/#review33466 --- src/common/protobuf_utils.hpp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #1865

See Changes: [dlester] Adds Medidata Solutions to 'Powered by Mesos' list. -- [...truncated 21316 lines...] I0203 19:00:55.817615 27

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 5:10 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 9:10 a.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 5:10 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17569: Added free and total memory to /system/stats.json.

> On Feb. 3, 2014, 10:30 a.m., Ben Mahler wrote: > > Ship It! Cool - thanks for reviewing! Mind taking a 2nd look at r17325 so we can land this? :) - Niklas --- This is an automatically generated e-mail. To reply, visit: https://review

Re: Review Request 17569: Added free and total memory to /system/stats.json.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17569/#review33451 --- Ship it! Ship It! - Ben Mahler On Jan. 31, 2014, 12:42 a.m., Nik

Re: Review Request 17663: Initialized local in cgroups and process isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/#review33449 --- Ship it! Ship It! - Adam B On Feb. 3, 2014, 9:50 a.m., Niklas Ni

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 9:10 a.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17663: Initialized local in cgroups and process isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/#review33444 --- Ship it! - Ian Downes On Feb. 3, 2014, 5:50 p.m., Niklas Nielsen

Re: Review Request 17306: Added an asynchronous subprocess utility.

> On Feb. 3, 2014, 5:10 p.m., Niklas Nielsen wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 157-159 > > > > > > Hey Ben, > > > > These lines fail to compile on GCC 4.8.1: > > error: i

Re: Review Request 17663: Initialized local in cgroups and process isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/#review33442 --- Ship it! Ship It! - Jie Yu On Feb. 3, 2014, 5:50 p.m., Niklas Ni

Review Request 17663: Initialized local in cgroups and process isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17663/ --- Review request for mesos, Adam B, Benjamin Hindman, and Ben Mahler. Repository:

Re: Review Request 17306: Added an asynchronous subprocess utility.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17306/#review33437 --- 3rdparty/libprocess/include/process/subprocess.hpp