On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, lines 839-840
https://reviews.apache.org/r/23771/diff/3/?file=643413#file643413line839
Hum, this looks problematic to me. These two static variables will be
initialized even before 'main' is called, at
On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, lines 839-840
https://reviews.apache.org/r/23771/diff/3/?file=643413#file643413line839
Hum, this looks problematic to me. These two static variables will be
initialized even before 'main' is called, at
:23.326675 24105 master.cpp:1208] Authorizing framework principal
'test-principal' to receive offers for role '*'
I0729 06:37:23.326784 24105 master.cpp:1307] Registering framework
20140729-063723-453759884-35851-24074- at
scheduler-54e926a9-6b9d-4672-81f0-5a8c181fac09@140.211.11.27:35851
I0729 06:37
On July 28, 2014, 9:33 p.m., Jie Yu wrote:
src/slave/containerizer/docker.cpp, lines 839-840
https://reviews.apache.org/r/23771/diff/3/?file=643413#file643413line839
Hum, this looks problematic to me. These two static variables will be
initialized even before 'main' is called, at
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/#review48974
---
Bad patch!
Reviews applied: [23224]
Failed command: ./bootstrap
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2016/changes
Changes:
[yujie.jay] Fixed a bug in port mapping test cleanup function.
--
[...truncated 60519 lines...]
I0729 07:07:11.393757 2566 recover.cpp:451] Replica is
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/#review48982
---
Bad patch!
Reviews applied: [20493, 20494]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/
---
(Updated July 29, 2014, 2:33 p.m.)
Review request for mesos, Adam B and Ben
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/
---
Review request for mesos, Adam B and Ben Mahler.
Repository: mesos-git
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20494/
---
(Updated July 29, 2014, 9:01 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 29, 2014, 9:12 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/
---
(Updated July 29, 2014, 9:12 a.m.)
Review request for mesos, Benjamin Hindman
On July 28, 2014, 7:35 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp, line 49
https://reviews.apache.org/r/20499/diff/4/?file=643983#file643983line49
For all of these calls to os::ls, why not call the result 'entries',
then each loop can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review48999
---
A few questions around my understanding that I'd like to clarify
On July 29, 2014, 2:35 a.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/setns.hpp, line 49
https://reviews.apache.org/r/20499/diff/4/?file=643983#file643983line49
For all of these calls to os::ls, why not call the result 'entries',
then each loop can
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/#review49001
---
src/slave/containerizer/isolators/network/port_mapping.cpp
On July 29, 2014, 6:25 p.m., Chi Zhang wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, line 1193
https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1193
Maybe add a comment here: that we only look at vethX for port ranges
during recovery,
On July 28, 2014, 11:26 p.m., Ben Mahler wrote:
3rdparty/libprocess/3rdparty/stout/include/stout/os/ls.hpp, lines 70-72
https://reviews.apache.org/r/20499/diff/3/?file=643960#file643960line70
It looks like readdir_r returns an error number that can be assigned to
errno. We could
On July 28, 2014, 4:05 p.m., Dominic Hamon wrote:
support/timed_tests.sh, line 9
https://reviews.apache.org/r/23700/diff/2/?file=643965#file643965line9
this might be simplified:
MAKE='make' GTEST_FILTER='Master*' timed_tests.sh 3600
ie - we assume we're
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:39 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/
---
(Updated July 29, 2014, 11:42 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/
---
(Updated July 29, 2014, 11:42 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23700/
---
(Updated July 29, 2014, 11:46 a.m.)
Review request for mesos, Ben Mahler,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:47 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:47 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23224/
---
(Updated July 29, 2014, 6:48 p.m.)
Review request for mesos.
Bugs: MESOS-857
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22796/#review49018
---
Patch looks great!
Reviews applied: [22796]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/#review49020
---
Ship it!
Ship It!
- Ben Mahler
On July 29, 2014, 2:33 p.m., Ken
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated July 29, 2014, 8:17 p.m.)
Review request for mesos, Ian Downes and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22313/
---
(Updated July 29, 2014, 9:05 p.m.)
Review request for mesos, Ian Downes and
' to receive offers for role '*'
I0729 21:46:09.062582 18035 master.cpp:1307] Registering framework
20140729-214608-453759884-33282-17989- at
scheduler-1915e2c2-07df-4bf0-8217-157ba48640b1@140.211.11.27:33282
I0729 21:46:09.062659 18035 sched.cpp:409] Framework registered with
20140729-214608
at
slave(195)@140.211.11.27:60822 (hemera.apache.org) with id
20140729-214936-453759884-60822-23165-0
I0729 21:49:36.834776 23418 registrar.cpp:422] Attempting to update the
'registry'
I0729 21:49:36.836351 23418 log.cpp:680] Attempting to append 332 bytes to the
log
I0729 21:49:36.836395 23418
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/#review49029
---
Thanks for the cleanup!
src/master/flags.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23997/#review49033
---
src/master/contender.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22796/#review49026
---
Looks great now, I had a few notes to clean up the tests a bit. Let
On July 29, 2014, 10:06 p.m., Jiang Yan Xu wrote:
src/master/contender.cpp, line 79
https://reviews.apache.org/r/23997/diff/3/?file=644484#file644484line79
Master detector and contender already support --zk=file://, in the
else if (strings::startsWith(zk, file://)) branch below.
On July 29, 2014, 3:06 p.m., Jiang Yan Xu wrote:
src/master/contender.cpp, line 79
https://reviews.apache.org/r/23997/diff/3/?file=644484#file644484line79
Master detector and contender already support --zk=file://, in the
else if (strings::startsWith(zk, file://)) branch below.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/#review49040
---
Bad patch!
Reviews applied: [23771]
Failed command: git apply
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/
---
(Updated July 29, 2014, 10:53 p.m.)
Review request for mesos, Adam B and Ben
)@140.211.11.27:60822 (hemera.apache.org) with id
20140729-214936-453759884-60822-23165-0
I0729 21:49:36.834776 23418 registrar.cpp:422] Attempting to update the
'registry'
I0729 21:49:36.836351 23418 log.cpp:680] Attempting to append 332 bytes to
the log
I0729 21:49:36.836395 23418 coordinator.cpp
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2273/changes
Changes:
[yan] Fixed a bug that caused 'make dist' unable to patch leveldb.
[bmahler] Fixed the master to accept a file:// based zk flag.
--
[...truncated
See https://builds.apache.org/job/Mesos-Ubuntu-distcheck/239/changes
framework
20140729-214608-453759884-33282-17989- at
scheduler-1915e2c2-07df-4bf0-8217-157ba48640b1@140.211.11.27:33282
I0729 21:46:09.062659 18035 sched.cpp:409] Framework registered with
20140729-214608-453759884-33282-17989-
I0729 21:46:09.062680 18035 sched.cpp:423] Scheduler::registered
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20499/#review49055
---
Ship it!
Looks great!
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20500/#review49056
---
Ship it!
src/files/files.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24057/#review49061
---
Ship it!
Ship It!
- Ben Mahler
On July 29, 2014, 10:53 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23598/#review49065
---
Ship it!
Ship It!
- Adam B
On July 19, 2014, 1:51 a.m., Timothy
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23596/#review49068
---
Ship it!
Yes!
src/common/type_utils.hpp
On July 29, 2014, 6:10 p.m., Ian Downes wrote:
src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1918-1920
https://reviews.apache.org/r/24020/diff/1-2/?file=643992#file643992line1918
Why not have deallocate() just return if passed an empty interval?
Jie Yu wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24020/
---
(Updated July 30, 2014, 1:23 a.m.)
Review request for mesos, Chi Zhang and Ian
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME/2018/changes
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui/2283/changes
Changes:
[dhamon] Converted bool returns to TryNothing in stout/os.hpp.
[dhamon] Mesos converted to use TryNothing returns from stout/os.hpp.
[bmahler] Cleaned up TODO
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23698/
---
(Updated July 30, 2014, 1:46 a.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23698/
---
(Updated July 30, 2014, 1:51 a.m.)
Review request for mesos and Adam B.
See https://builds.apache.org/job/mesos-reviewbot/1248/changes
Changes:
[bmahler] Cleaned up TODO comments for ZK file:// URL support.
[niklas] Task health status change notifications
[bmahler] Fixed a flaky slave recovery test.
[bmahler] Cleaned up the flag help documentation.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23698/#review49077
---
Ship it!
Ship It!
- Adam B
On July 29, 2014, 6:51 p.m., Craig
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23698/
---
(Updated July 30, 2014, 2:27 a.m.)
Review request for mesos and Adam B.
See
https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2274/changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23771/
---
(Updated July 30, 2014, 5:08 a.m.)
Review request for mesos, Benjamin Hindman,
On July 30, 2014, 1:47 a.m., Jie Yu wrote:
Have you updated the diff? I don't see any difference between r3 and r4.
Hi Jie, you're right for some reason my patch didn't have my changes! Please
take a look now.
- Timothy
---
This is
60 matches
Mail list logo
